Re: [Github-comments] [geany/geany-plugins] codenav: switch to header/implementation switches to wrong file (#594)

2017-08-16 Thread elextr
@b4n erm, the intention of the quote and the paragraph after was to say "thats good because it can't work that way", sorry if the message was not clear. As I said, the "same directory first, then anything open since we have no idea where else to look" is a good heuristic for C. But since __not

Re: [Github-comments] [geany/geany-plugins] codenav: switch to header/implementation switches to wrong file (#594)

2017-08-16 Thread Colomban Wendling
@elextr he wrote *is **not** that I expect […]* ;) Anyway, if the plugin does both there might be a very good reason; however it also seems reasonable to try and first check if there is a matching file in the same directory (as the OP is asking for) and expect that one to be The One when

Re: [Github-comments] [geany/geany-plugins] codenav: switch to header/implementation switches to wrong file (#594)

2017-08-12 Thread elextr
> the point isn't that I expect the plugin to be looking for the compile-time > include directories, As I said above, the compile time include directories (the -I options to the C compiler) are not known by Geany or the plugin, so it can't work like that. In fact the plugin doesn't even

Re: [Github-comments] [geany/geany-plugins] codenav: switch to header/implementation switches to wrong file (#594)

2017-08-12 Thread Mike Blumenkrantz
Perhaps my example was too simplistic; the point isn't that I expect the plugin to be looking for the compile-time include directories, it's that there are some cases where the current behavior is 99% guaranteed to be wrong. If I am working on some project in a directory such as

Re: [Github-comments] [geany/geany-plugins] codenav: switch to header/implementation switches to wrong file (#594)

2017-08-11 Thread elextr
There is no reason that the `.h` is in the same directory as the `.c`. There is a common idiom where the `.h` files are in a directory called `include`, not in the source directory called `src`. Enforcing the same directory would not find the `.h` files in this case. Geany does not

[Github-comments] [geany/geany-plugins] codenav: switch to header/implementation switches to wrong file (#594)

2017-08-11 Thread Mike Blumenkrantz
1. create `test.c`, `test.h`, `directory/test.h` 2. open `test.c` and `directory/test.h` 3. from `test.c`, try switching to header 4. `directory/test.h` is switched to it seems like this is using simple base filename checks and does not in any way check the path, so if there is a "matching"