It's pointless for plugins to check for GIO since GTK+ and Geany both use and
require the library.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/720#issuecomment-372011816
> FWIW, this check was more or less always obsolete, GIO is in GLib, and if GTK
> exposes API using its types it ought to be present…
But `libgio` is a separate library, maybe that was really what should have been
tested? Sure on Linux its in the glib package so it will allways be there, but
Merged #720.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/720#event-1514502527
b4n approved this pull request.
LGBI
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/720#pullrequestreview-102834917
b4n commented on this pull request.
> @@ -208,7 +206,7 @@ utils_pixbuf_from_stock(const gchar *stock_id)
static GdkPixbuf *
utils_pixbuf_from_path(gchar *path)
{
-#if defined(HAVE_GIO) && GTK_CHECK_VERSION(2, 14, 0)
+#if GTK_CHECK_VERSION(2, 14, 0)
The GTK check is also mostly irrelevant
Removed obsolete GIO check.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/720
-- Commit Summary --
* treebrowser: removed HAVE_GIO checks
-- File Changes --
M build/treebrowser.m4 (6)
M treebrowser/src/treebrowser.c (6)
