Re: [Github-comments] [geany-plugins] Macro plugin compatibility for both gtk2 and gtk3 [Needs Testing] (#352)

2016-02-18 Thread Colomban Wendling
Indentation has some problems, and some code should be dropped rather than commented out. Also, did you check how the widgets expand? `gtk_conatiner_add()` changed behavior to that regard in GTK3, where it doesn't expand by default. --- Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany-plugins] Macro plugin compatibility for both gtk2 and gtk3 [Needs Testing] (#352)

2016-02-18 Thread Colomban Wendling
> @@ -1733,9 +1736,12 @@ static void EditMacroElements(Macro *m) > > /* create dialog box */ > cTitle=g_strdup_printf(_("Edit: %s"),m->name); > - > dialog=gtk_dialog_new_with_buttons(cTitle,GTK_WINDOW(geany->main_widgets->window), > -

Re: [Github-comments] [geany-plugins] Macro plugin compatibility for both gtk2 and gtk3 [Needs Testing] (#352)

2016-02-18 Thread Colomban Wendling
> @@ -1387,21 +1386,26 @@ static void EditSearchOptions(GtkTreeModel > *model,GtkTreeIter *iter) > /* create dialog box */ > dialog=gtk_dialog_new_with_buttons(_("Search Options:"), > > GTK_WINDOW(geany->main_widgets->window), > -

Re: [Github-comments] [geany-plugins] Macro plugin compatibility for both gtk2 and gtk3 [Needs Testing] (#352)

2016-02-18 Thread Colomban Wendling
> @@ -1387,21 +1386,26 @@ static void EditSearchOptions(GtkTreeModel > *model,GtkTreeIter *iter) > /* create dialog box */ > dialog=gtk_dialog_new_with_buttons(_("Search Options:"), > > GTK_WINDOW(geany->main_widgets->window), > -

[Github-comments] [geany-plugins] Macro plugin compatibility for both gtk2 and gtk3 [Needs Testing] (#352)

2016-02-18 Thread Sagar Chalise
This is based on a patch. It builds on gtk3 as well as gtk2 but not thoroughly tested. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/352 -- Commit Summary -- * Macro plugin for both gtk2 and gtk3 [Needs Testing] -- File Changes