Didn't you like the second commit's message? :D
Done and thanks for review.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3594#issuecomment-1760362118
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3594 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3594#event-10636857656
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n approved this pull request.
LGTM, but you could squash the second commit into the first :wink:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3594#pullrequestreview-1675065827
You are receiving this because you are subscribed to this thread.
@eht16 commented on this pull request.
> - if [ -z "${PATCH}" ] || [ "${PATCH}" = "0" ]; then
- MINOR="$((MINOR-1))"
- PATCH="90"
+ if [[ "${MINOR}" = "0" && (-z "${PATCH}" || "${PATCH}" = "0")
]]; then
+
@eht16 pushed 1 commit.
15ef1d536971a3c3be9eb0d6b4cd2363ab21fb08 Use b4n's simpler version
--
View it on GitHub:
https://github.com/geany/geany/pull/3594/files/2fa22afbb8e80683afa2ae8b5f35dcd8e8c1299e..15ef1d536971a3c3be9eb0d6b4cd2363ab21fb08
You are receiving this because you are subscribed
@b4n commented on this pull request.
> - if [ -z "${PATCH}" ] || [ "${PATCH}" = "0" ]; then
- MINOR="$((MINOR-1))"
- PATCH="90"
+ if [[ "${MINOR}" = "0" && (-z "${PATCH}" || "${PATCH}" = "0")
]]; then
+
JFYI, it's even tested this time (left is the result, right is the input
version):
```
1.38.0 - 1.38.1_git_2023103518_173744b2b
1.37.99 - 1.38_git_2023103518_173744b2b
2.0.0 - 2.0.1
1.99.99 - 2.0_git_2023103518_173744b2b
2.1.89 - 2.1.90
2.0.99 - 2.1
2.2.0 - 2.2.1
2.89.99 - 2.90
```
