[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

Merged #3759 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3759#event-12773542349 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

@eht16 @b4n This is squashed and ready to go. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3759#issuecomment-2104724781 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

@b4n approved this pull request. Looks good and works fine. Could you please just squash the commits together? (or I can do it if you prefer) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3759#pullrequestreview-2015703603 You are receiving this

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

@andy5995 pushed 1 commit. aab90a0d052ced3c6e2775688c2dcaaa153ffd83 Start off with strings -- View it on GitHub: https://github.com/geany/geany/pull/3759/files/ad3e7753f9de9956e706aed00b784ee58e6bdff5..aab90a0d052ced3c6e2775688c2dcaaa153ffd83 You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

@eli-schwartz commented on this pull request. > runner = find_program('ctags/runner.sh') foreach t : ctags_tests - test('@0@'.format(t), runner, + test(join_paths(fs.parent(t), fs.name(t)), runner, You could start off with strings. :) -- Reply to this email directly or view it

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

@andy5995 commented on this pull request. > runner = find_program('ctags/runner.sh') foreach t : ctags_tests - test('@0@'.format(t), runner, + test(join_paths(fs.parent(t), fs.name(t)), runner, @eli-schwartz Isn't there a proper way to convert a file object to a string in

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

@andy5995 commented on this pull request. > runner = find_program('ctags/runner.sh') foreach t : ctags_tests - test('@0@'.format(t), runner, + test(join_paths(fs.parent(t), fs.name(t)), runner, One other potentially noteworthy feature of 0.59 is that when using 'ninja

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

@andy5995 commented on this pull request. > runner = find_program('ctags/runner.sh') foreach t : ctags_tests - test('@0@'.format(t), runner, + test(join_paths(fs.parent(t), fs.name(t)), runner, The required meson version is 0.53 and this feature is not available until 0.59 Looks

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

@andy5995 pushed 1 commit. ad3e7753f9de9956e706aed00b784ee58e6bdff5 Fix deprecation warning about str.format() during meson setup -- View it on GitHub: https://github.com/geany/geany/pull/3759/files/bfce17935451f8e2d95b0e8c02839351c4214375..ad3e7753f9de9956e706aed00b784ee58e6bdff5 You are

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

@andy5995 commented on this pull request. > @@ -355,7 +355,7 @@ ctags_tests = files([ runner = find_program('ctags/runner.sh') foreach t : ctags_tests - test('@0@'.format(t), runner, + test('@0@'.format(f[0][0]), runner, Oops, that's not right. Let me have a closer look at how