I've tried this patch on Fedora 38 with Adwaita-dark theme, and all icons are
dark on dark:
--
Reply to this email directly or view it on GitHub:
> But then it's really a problem of the icon theme I think.
Yeah, so we need to get an idea that major distros provide something sane for
`-symbolic`.
On this Mint (not the latest but still supported) `find /usr/share/icons -name
"edit-clear-symbolic*" -print ` only finds anything in
> @techee yeah, but here just using the icon name won't solve it, you also need
> to use the symbolic version for the problematic icons.
Ah, OK, I missed that. But then it's really a problem of the icon theme I think.
--
Reply to this email directly or view it on GitHub:
@techee yeah, but here just using the icon name won't solve it, you also need
to use the symbolic version for the problematic icons.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3614#issuecomment-1770418473
You are receiving this because you are
> although @techee has a point that as the icons that please Adwaita are used
> by GTK itself, it's likely not to cause much trouble.
I was looking for this page (which I couldn't find yesterday) for stock icons
and their replacements:
> Let's just cross fingers and hope Debian does something about it, and nobody
> else is shipping a broken Adwaita icon theme… or that none of our user
> actually use the broken ones.
No chance unless Murphy goes on holidays :smiling_imp:
--
Reply to this email directly or view it on GitHub:
Agreed, it grew way too out of hand to be merged less than 24 hours before the
deadline.
And I agree with @elextr that it likely requires more testing than just hoping
every other distro is shipping a well-behaving theme (better behaving than
Debian's Adwaita 43) by default, although @techee
> on all thinkable distributions
No, just Ubuntu, Mint, Arch probably. The point is that the change is relying
on icon themes, and distros are the thing that provides them, and possibly
differing sets on each desktop, as far as we can tell all but Debian Adwaita
provide sensible `gtk-clear`
> This needs to be tested on a wide range of distros, not just Debian, and not
> just Gnome, Cinnamon, XFCE, etc and Windows.
I don't think it needs to be tested on all thinkable distributions (just tried
briefly on macOS and it seems to work), it should work the same way everywhere.
On the
This needs to be tested on a wide range of distros, not just Debian, and not
just Gnome, Cinnamon, XFCE, etc and Windows.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3614#issuecomment-1769312752
You are receiving this because you are subscribed to
10 matches
Mail list logo
