[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-22 Thread Thomas Martitz via Github-comments
IMO meson is still experimental and we don't need to support Ubuntu 20.04. Pick whatever meson makes the least problems for us. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2068841524 You are receiving this because you are

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-22 Thread Colomban Wendling via Github-comments
We already have deprecation warnings in 0.56, so if we want to support earlier jus use the older option I mentioned -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2068837991 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-21 Thread elextr via Github-comments
Well, Ubuntu LTS 20.04 has a year of support left (April 2025) and it has Meson 0.54, maybe it has to be `#ifdef`ed (or whatever the meson equivalent is) to change what it uses at 0.56 to get rid of the message. Kind of annoying that a Windows only feature causes a message on Linux, maybe

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-21 Thread Colomban Wendling via Github-comments
@b4n requested changes on this pull request. ```console ../meson.build:887: WARNING: Project targets '>= 0.53' but uses feature introduced in '0.56.0': win_subsystem arg in executable. […] WARNING: Project specifies a minimum meson_version '>= 0.53' but uses features which were added in newer

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-21 Thread Colomban Wendling via Github-comments
@eht16 This doesn't seem to have any impact on Linux, so looks fine on that end. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2068186588 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-14 Thread Enrico Tröger via Github-comments
Well, the CI just builds the code and runs some simple tests. This is already a good indicator, yes. Still, it is different from executing the full application with full loading of GTK and such. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-14 Thread Biswapriyo Nath via Github-comments
Did not CI already do that in "CI Build / Linux Meson Build (pull_request)" ? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2054065400 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-14 Thread Enrico Tröger via Github-comments
Could anyone who uses Meson on Linux check if this is fine and properly ignored? @b4n or @kugel- maybe? I tested it on Windows and it does what it should. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2054064747 You are receiving

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-14 Thread Enrico Tröger via Github-comments
> > I would suggest to provide Windows installer. Most of the users will still > > use official installer who are not familiar with msys2 and its packaging > > system. > > But as I said above, none of the major contributors use Geany on Windows, > even the nice guy who makes the build (and yes

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-03 Thread elextr via Github-comments
> I would suggest to provide Windows installer. Most of the users will still > use official installer who are not familiar with msys2 and its packaging > system. But as I said above, none of the major contributors use Geany on Windows, even the nice guy who makes the build (and yes with

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-03 Thread Biswapriyo Nath via Github-comments
> Maybe we can stop making a build for Windows (hopeful). I would suggest to provide Windows installer. Most of the users will still use official installer who are not familiar with msys2 and its packaging system. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-03 Thread elextr via Github-comments
> geany 2.0 is built with meson in msys2 project Maybe we can stop making a build for Windows (hopeful). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2036200273 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-03 Thread Biswapriyo Nath via Github-comments
> Is that harmless on Linux builds? The `win_subsystem` option is valid for Windows target only. geany 2.0 is built with meson in msys2 project, see https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-geany/PKGBUILD -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-03 Thread elextr via Github-comments
Is that harmless on Linux builds? If not it needs to be conditioned appropriately the same as `win_src` and `vte_src` are, probably best if its done anyway, even if harmless at this point, since Meson has a habit of increasing strictness and creating errors of previously acceptable things. I

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

2024-04-03 Thread Biswapriyo Nath via Github-comments
This would be similar as `-mwindows` flag in src/Makefile.am https://github.com/geany/geany/blob/3a92129d61d4d8e96136e29d4709bb638527be40/src/Makefile.am#L157 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2034823993 You are receiving