[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-21 Thread Jiří Techet via Github-comments
> I will not do a code review but I intend to use the plugin with my work > project which has a huge Python code base and I'm very curious how it will > work and maybe I'm going to switch to the LSP approach completely but no > promises yet :). I'm _really_ interested in your feedback - some th

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-21 Thread Enrico Tröger via Github-comments
I will *not* do a code review but I intend to use the plugin with my work project which has a huge Python code base and I'm very curious how it will work and maybe I'm going to switch to the LSP approach completely but no promises yet :). Though this might take a few weeks to complete as I need

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-17 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 55232c5c44a2a5d1e43b82eb0ee1a9fe8467aa0b Backport fixes from the geany-lsp project -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/831c3ac506888d2ff7485bd3eae4022f622b901f..55232c5c44a2a5d1e43b82eb0ee1a9fe8467aa0b You are receiving this bec

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-11 Thread elextr via Github-comments
> Please let me know what needs to be done to get the plugin merged to > geany-plugins. Good question, plugins maintainer was @frlan but he hasn't been around much so I'm not sure if he doesn't have time any more. So somebody else maybe, @b4n, @eht16 ? -- Reply to this email directly or view

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-11 Thread Jiří Techet via Github-comments
Alright, I've pushed the latest version here with squashed commits. Apart from bugfixes (if some bugs appear), I don't plan anything more for this release. Please let me know what needs to be done to get the plugin merged to geany-plugins. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-11 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 831c3ac506888d2ff7485bd3eae4022f622b901f Add LSP plugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/5fba42b151a2385651095887864cb18176fa406f..831c3ac506888d2ff7485bd3eae4022f622b901f You are receiving this because you are subscribed to t

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-10 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 5fba42b151a2385651095887864cb18176fa406f Add LSP plugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/ad82d3c9c3a0604082cf208379b53c620791127c..5fba42b151a2385651095887864cb18176fa406f You are receiving this because you are subscribed to t

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-09-10 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. ad82d3c9c3a0604082cf208379b53c620791127c Add LSP plugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/78a2cd6b62643d53deb876b1e8bf6a9d60128d30..ad82d3c9c3a0604082cf208379b53c620791127c You are receiving this because you are subscribed to t

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-06-22 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. d50c6c64b39cdb86ceb53fed1af717689fb5792e Reduce the number of lsp_utils_doc_ft_has_tags() calls in on_editor_notify() 78a2cd6b62643d53deb876b1e8bf6a9d60128d30 Make progress reporting configurable -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-06-10 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 99e86a3d6d28371f0a573e83e541bc1151112f6c Switch to the newly proposed plugin extension API -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/d25253a1df3a961b910ef5877b2a4964137137de..99e86a3d6d28371f0a573e83e541bc1151112f6c You are receiving

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-06-07 Thread Jiří Techet via Github-comments
@b4n I added this feature to the plugin that other LSP clients implement as well (not tested much yet): https://github.com/techee/geany-lsp/blob/c56de66cecf4dff2c1b1a98ea37b22bd2af73f03/plugins/lsp/data/lsp.conf#L56-L68 This should essentially allow automatic opening/closing of multiple projects

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-06-07 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. d25253a1df3a961b910ef5877b2a4964137137de Fix memory leak -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/c98a1496ecf4433bad7f1cd5b86492bf3d3ae218..d25253a1df3a961b910ef5877b2a4964137137de You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-06-07 Thread Jiří Techet via Github-comments
@techee pushed 3 commits. 6b02c53465e890620b03a0c6a7a040cb42b477fb Use DOC_VALID() instead of its custom version 0bfd21fd5139b3e252fdf7a1e019ce9154046154 Fix initialize request for workspace folders when no project open c98a1496ecf4433bad7f1cd5b86492bf3d3ae218 Support multiple workspace folde

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-06-05 Thread Jiří Techet via Github-comments
@techee pushed 14 commits. c3968b012f697a65312e9871c3fbdca12c31374d Add phpactor configuration bad4fab3e37d2f3d852879f02601af5d268175db Always update last context menu click position f533b19136b99ea527b2712d60547e1ba1af Rename "Rename in File" to "Rename Highlighted" which is more descrip

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-06-02 Thread Jiří Techet via Github-comments
@techee pushed 4 commits. 206318f00881bd8487a2045913c3a5194f721101 Don't show snippets in autocompletion list as they are not supported 57e39f1ebf1b80dcaacaca8bc560b96fb0d1cddc Support direct CompletionItem array in addition to CompletionList 757d342e359fd83a0aae2860f201283d57e41f88 Fix incor

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-06-02 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. f0ae1e3b1e52acf676ff6061762b4dc66497aa30 Update menu sensitivity after creating menu items 90cbe4e6b5ab669e36d011dbd66679f12920e6f1 Add Swift language server configuration -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/84641c76323eb2800

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-06-02 Thread Jiří Techet via Github-comments
@techee pushed 8 commits. de56e6fca884cc822a8d5a25b94f942de8666557 Move formatting options to the [all] section so there are some defaults 7a9cda00abcbdfc21599ebab01ed0a6e13320cf3 Add haskell server specific hack 20a158c662d453d7f64fea4f67f6100225dfb2b7 tmp 73811aa92846cc6a24bb2dd8277198af9688

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-06-01 Thread Jiří Techet via Github-comments
@techee pushed 6 commits. aa11c417ed4d6a3b440916b8d87e50ad6192a9dd Add includeDeclaration parameter to textDocument/references 1733e8aee7e0422e8b74f874186f289e78738bc3 Semantic tokens: don't require resultId 4820b29b7728aaef1c2226873c2e0262c9d784dc Fix calltip code when the string starts wit

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-06-01 Thread Jiří Techet via Github-comments
@techee pushed 6 commits. b4427b4b27d26024168d23aa224fa39bc6a805e3 Sort autocomplete list so that the symbols whose prefix was typed are first fa0eb50cae7cc35cfae42212ac2e06425b78027b Fix some runtime warnings when empty unsaved file is shown b28567712e2a3fd90f3ffceb80b95f8cce700eaa Add basic

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-31 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 514e8d61a4a141f0ddc1c6fa2de15f28cac8cbc7 Remove invalid settings for gopls -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/752bad781fad87598b74b0b4ae83c8e07eeeb91f..514e8d61a4a141f0ddc1c6fa2de15f28cac8cbc7 You are receiving this because you

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-31 Thread Jiří Techet via Github-comments
@techee pushed 15 commits. 353ef56e28d473377ebdde8dd3fad2eccdcb4776 Support CodeAction structs when performing commands and related fixes 5d7193fe0affe39d813093dca4a7432722216634 Support automatic code formatting on save ad09e3f8f027b65fcd9dab15f7a071155b110749 Workaround semantic token bug i

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-27 Thread Jiří Techet via Github-comments
> Does it include #3865? No, it doesn't, but you don't need to disable the ctags parser for geany-lsp as it contains the proper LSP interface. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1331#issuecomment-2133689595 You are receiving this be

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-27 Thread Jiří Techet via Github-comments
@techee pushed 3 commits. 9437ee8d606c63b54aa3997d9392949e27283cc0 Fix semantic tokens not highlighted when LSP enabled for the first time 178d7fd616d5771b68654c7aa5154bb161823da5 Properly initialize project configuration 5315ffd94a780ed05f57c3f51aab3f84fef02830 Fix some warnings when using g

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-26 Thread elextr via Github-comments
Does it include #3865? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1331#issuecomment-2132441626 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-26 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. a808e99dd4459a3aba72f3a19933bbb26089c111 Update config options for pylsp -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/da98abcd538db01d0740e326ab0b2a0367e3a7d9..a808e99dd4459a3aba72f3a19933bbb26089c111 You are receiving this because you ar

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-26 Thread Jiří Techet via Github-comments
> Just to confirm geany-lsp is Geany with #3849 and this plugin, all previous > versions removed? If so I think I'll just get a new clone [end lazy git user] > :-) It's: 1. Geany 2. This PR 3. [#3850](https://github.com/geany/geany/pull/3850), i.e. including the symbol tree patches. But you can

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-26 Thread elextr via Github-comments
> I don't think clangd will ever work without a project - it really just > compiles it behind the scenes - so testing it on individual files won't work > and better to use TM for those. Well, although in theory it is possible to not have `compile_commands.json` but really clangd is a pain witho

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-26 Thread Jiří Techet via Github-comments
@b4n Ping :-) I think I'm pretty much done with the plugin and I'd like some feedback. I tried to address most of the complaints you had in https://github.com/geany/geany/pull/3571#issuecomment-1817205646: The config file now contains these settings with these default values: ```ini # Defines w

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-25 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. da98abcd538db01d0740e326ab0b2a0367e3a7d9 Some clarifications in the config file -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/98329cc3f9f49c70cb63938625f5581f9cc44a2c..da98abcd538db01d0740e326ab0b2a0367e3a7d9 You are receiving this because

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-25 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 98329cc3f9f49c70cb63938625f5581f9cc44a2c Improve initial experience when using the plugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/95f44a488774170baaa3d40ab41092d52c8edfd9..98329cc3f9f49c70cb63938625f5581f9cc44a2c You are receiving t

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-24 Thread Jiří Techet via Github-comments
@techee pushed 4 commits. 0e2b0bd8d8008fc4a89b04c9d2e0720636e2de22 Fix runtime warning 86bfa0668fca887f6f277d0a5217a2bb78c84f50 Allow specifying JSON for initialization and formatting directly in the config file 19a425916a20c4ea150216bc91d6ed899d62 Add config option enabling/disabling pro

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-21 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 7794a3f9a6f2e18293ddc78993a00e54b2afdafc Fix compilation with the combined geany-lsp repo -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/fe72e17aa9cf198a15df0208e6d8dff0da718a16..7794a3f9a6f2e18293ddc78993a00e54b2afdafc You are receiving t

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-21 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. fe72e17aa9cf198a15df0208e6d8dff0da718a16 Implement non-standard clangd LSP extension textDocument/switchSourceHeader -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/d9668e7a8fee51bf99109e740b102328467ba299..fe72e17aa9cf198a15df0208e6d8dff0d

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-21 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. 4e6be72aa9980fac5e51d7456e5177de3e7fc22f Add some sanity checks d9668e7a8fee51bf99109e740b102328467ba299 Fix some more leaks -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/cf1c68e80508f5f4fe1eb33c4e932ce49e7d8144..d9668e7a8fee51bf99109e74

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-21 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. cf1c68e80508f5f4fe1eb33c4e932ce49e7d8144 Fix memory leak -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/2a9118b60c64283701a641764284b32915f1fd40..cf1c68e80508f5f4fe1eb33c4e932ce49e7d8144 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-20 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 2a9118b60c64283701a641764284b32915f1fd40 Allow disabling diagnostic messages only for some files -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/eb5a7491b713105d6eb211f90f4d745cc14cc1ae..2a9118b60c64283701a641764284b32915f1fd40 You are rece

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-20 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. aa62690507cbbc5d194d739097c02d0ad4305be0 Force-kill LSP server if normal shutdown unsuccessful eb5a7491b713105d6eb211f90f4d745cc14cc1ae Unref should close the stream so remove the todo comment -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/fi

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-18 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. df2a325fd0d0aeaff1bde339a1bf36c1ac6d4053 Prefer autocomplete when both autocomplete and calltips are available -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/731a0f3060837a26afc183e57da1897dff366795..df2a325fd0d0aeaff1bde339a1bf36c1ac6d405

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-11 Thread Jiří Techet via Github-comments
@techee pushed 2 commits. eaa76c7e6eef919509857b9776e5338fa53c11ce Create lsp_utils_doc_is_valid() helper function 731a0f3060837a26afc183e57da1897dff366795 Perform expensive operations in idle callback after some timeout -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-11 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 884c520b0781945d67603a036215e62f7c3d3c21 Fix cppcheck warnings -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/a0e0fded5093e77d9b73cce0f304e91b2fc30f34..884c520b0781945d67603a036215e62f7c3d3c21 You are receiving this because you are subscrib

[Github-comments] Re: [geany/geany-plugins] Add LSP plugin (PR #1331)

2024-05-11 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. a0e0fded5093e77d9b73cce0f304e91b2fc30f34 Drop the usage of session-opening signal -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1331/files/749ac83c76459735f6d75efb3da53472f0e28c7c..a0e0fded5093e77d9b73cce0f304e91b2fc30f34 You are receiving this beca