Merged #1330 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#event-12635626337
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#pullrequestreview-2027099072
You are receiving this because you are subscribed to this thread.
Message ID:
In the end it's a little matter of taste, but compare it to HTML's
```html
...
```
and
```html
…
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#issuecomment-2081475695
You are receiving this because you are subscribed to this thread.
Looks good now.
As said before, I cannot judge whether the result of the snippets is as
desired. To me it feels a little confusing that the element in the "itemize"
environment is indented while for the other ones the cursor position is not
indented.
Maybe it's ok.
--
Reply to this email
@frlan pushed 1 commit.
5fb3c82fa0c7024cfa78586afa4da0f3b279f019 Propper NULL-terminate strings and
fix an trailing space inside a template
--
View it on GitHub:
> > For "table" and "itemize" there is a trailing space after the cursor
> > marker. Is this intended?
> > "block" uses no indentation at all, "itemize" uses a tab resp. spaces and
> > "table" uses a single space only.
>
> This is fixed. I tried to re-sync the indentions
I cannot verify as I
@eht16 commented on this pull request.
> - tmp = g_strdup_printf("\n\\end{%s}", environment);
- glatex_insert_string(tmp, FALSE);
- g_free(tmp);
-
- indention_prefs = editor_get_indent_prefs(doc->editor);
-
> Looks good.
>
> As you know I'm not LaTeX expert and so I'm wondering if it is on purpose
> that different environments produce quite different stylings:
>
> ```
> \begin{block}{}
> _
> \end{block}
>
> \begin{itemize}
> \item _
> \end{itemize}
>
> \begin{table}
> _
> \end{table}
>
@frlan pushed 1 commit.
6728529322b028c0e0791ba8ecec968042ac8c6d LaTeX: Switch handling of insert
(list) environments over to snippets workflow
--
View it on GitHub:
@frlan commented on this pull request.
> if (utils_str_equal(environment, "block") == TRUE)
{
- g_string_append(tmpstring, "}{}");
+ tmpstring =
@eht16 commented on this pull request.
> if (utils_str_equal(environment, "block") == TRUE)
{
- g_string_append(tmpstring, "}{}");
+ tmpstring =
@eht16 commented on this pull request.
Looks good.
As you know I'm not LaTeX expert and so I'm wondering if it is on purpose that
different environments produce quite different stylings:
```
\begin{block}{}
_
\end{block}
\begin{itemize}
\item _
\end{itemize}
\begin{table}
_
12 matches
Mail list logo
