OK, I just create #1349 for SCN_MARGINCLICK part.
Thanks
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1326#issuecomment-2124751106
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #1326.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1326#event-12885969899
You are receiving this because you are subscribed to this thread.
Message ID:
Closing this PR as #1338 was merged. Having SCN_MARGINCLICK handled would
however be worth adding as a separate PR.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1326#issuecomment-2123515548
You are receiving this because you are subscribed to
@techee commented on this pull request.
> @@ -306,6 +306,14 @@ gboolean vi_notify_sci(SCNotification *nt)
}
}
+ if (nt->nmhdr.code == SCN_MARGINCLICK) {
I've just merged #1338 which functionality-wise covers most of this PR but
doesn't contain the
@techee commented on this pull request.
> return;
- /* see cmd_goto_up() for explanation */
- one_above = p->line + num - 1;
- one_above = one_above < last_line ? one_above : last_line - 1;
- pos = SSM(p->sci, SCI_GETLINEENDPOSITION, one_above, 0);
-
@techee commented on this pull request.
> /* Calling SCI_LINEUP/SCI_LINEDOWN in a loop for num lines leads to
> visible
* slow scrolling. On the other hand, SCI_LINEUP preserves the value of
* SCI_CHOOSECARETX which we cannot read directly from Scintilla and
which
@scresto09 commented on this pull request.
> return;
- /* see cmd_goto_up() for explanation */
- one_above = p->line + num - 1;
- one_above = one_above < last_line ? one_above : last_line - 1;
- pos = SSM(p->sci, SCI_GETLINEENDPOSITION, one_above, 0);
-
@scresto09 commented on this pull request.
> /* Calling SCI_LINEUP/SCI_LINEDOWN in a loop for num lines leads to
> visible
* slow scrolling. On the other hand, SCI_LINEUP preserves the value of
* SCI_CHOOSECARETX which we cannot read directly from Scintilla and
which
@techee requested changes on this pull request.
Looks good except for the minor comments below.
I was actually thinking about not doing this at all because it doesn't cover
all fold/unfold situations like e.g. using Geany's keybindings for folding but
the patch is simple and better than
@techee commented on this pull request.
> @@ -40,42 +40,53 @@ void cmd_goto_right(CmdContext *c, CmdParams *p)
SET_POS(p->sci, pos, TRUE);
}
+static gint doc_line_from_visible_delta(CmdParams *p, gint line, gint delta,
gint *previous)
+{
+ gint step = delta < 0 ? -1 : 1;
+
> After read the https://sourceforge.net/p/scintilla/bugs/2438/ report, I think
> the best way to automatically set the cursor position on the visible line is
> surely to track the SCN_MARGINCLICK event. I did some modification to handle
> this with the commit
>
@scresto09 pushed 1 commit.
274ff97f51e65b02ae86579768ec8d41f5b5c611 try to fix some issues of the plugin
with folded lines
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1326/files/5608b74cba25b571428da9a055e696ddb053a247..274ff97f51e65b02ae86579768ec8d41f5b5c611
You are
In response to pull request
[#1338](https://github.com/geany/geany-plugins/pull/1338)
After read the
[https://sourceforge.net/p/scintilla/bugs/2438/](https://sourceforge.net/p/scintilla/bugs/2438/)
report, I think the best way to automatically set the cursor position on the
visible line is
@scresto09 pushed 1 commit.
5608b74cba25b571428da9a055e696ddb053a247 Automatically set the cursor position
on the visible line
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1326/files/be15445fa3fd4893f04945af6af94522db2e5e99..5608b74cba25b571428da9a055e696ddb053a247
You
I'm not sure this is the correct way to address the issue. I think we should
take the folds into account and perform the motion commands on top of the
visible lines instead of the document lines. I tried to replace this PR with
https://github.com/geany/geany-plugins/pull/1338
Please let me
15 matches
Mail list logo
