@xiota see #1361 which might help
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2171883257
You are receiving this because you are subscribed to this thread.
Message ID:
> This doesn't mean we can't still drop the plugin if people want, I still
> don't mind even if I spent some time on this
This type of plugin seems inherently dangerous... But up to people to install
and run what they want.
--
Reply to this email directly or view it on GitHub:
Merged, so we're one step closer to libsoup3 everywhere.
This doesn't mean we can't still drop the plugin if people want, I still don't
mind even if I spent some time on this :slightly_smiling_face:
--
Reply to this email directly or view it on GitHub:
Merged #1342 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#event-13174864827
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#pullrequestreview-2121257090
You are receiving this because you are subscribed to this thread.
Message ID:
Seeen it but didn't have time until now.
With the new installers pasting to geany.org works fine now.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2171266224
You are receiving this because you are subscribed to this thread.
@eht16 done (in case you didn't see the commit)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2170670511
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 1 commit.
7a2fa7c889b29f132f7f182eebd24e0fe515a754 fixup! Update CI for libsoup3
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1342/files/9c0e16f3b469501f8d69e476026755fb4d444e8d..7a2fa7c889b29f132f7f182eebd24e0fe515a754
You are receiving this because you are
We are getting closer :). "gsettings-desktop-schemas" is missing in the
dependency list in build/gtk-bundle-from-msys2.sh (sorry if I wasn't clear
about it before).
This package contains the GLib schemas files necessary for the
"glib-networking" package.
--
Reply to this email directly or
@eht16 sure, done.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2169452082
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 9 commits.
cbfa9112df4dec824cf6101907299a164d4006c2 geniuspaste: Port to libsoup3
31caf0bb044f94bb172fd57f06fa13a7fdc05200 geniuspaste: Remove use of deprecated
GTK API
0e9ac44e6612150caa89fddd6d7ef7be022d25d2 geniuspaste: Enable HTTPS for
paste.debian.net
@b4n do you mind rebasing on current master? Then we'll get easy to test
installers from the CI and could finally merge this one.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2169412511
You are receiving this because you are
> @eht16 paste configuration issue should be fixed. But indeed it's unrelated
> to this PR, just to you using a newer GLib
Yes, it is fixed. Thanks for fixing it!
> > Can't we "simply" run `glib-compile-schemas` during GP (and possibly Geany)
> > installation? it's e.g. what Linux distros
I was curious about the upper limit because of problems described as being
related to "newer GLib". But I guess the "invalid syntax" will or has been
fixed?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2122364199
You are
@xiota I don't know exactly the minimum version, but practically any should be
ok, why you ask?
The issue mentioned above is a change of behavior in glib 2.79. The plugin was
admittedly using invalid syntax in the configuration files, but it went
unnoticed because it worked fine.
--
Reply to
What's the range of glib versions this plugin is supposed to work with?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2121342610
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 paste configuration issue should be fixed. But indeed it's unrelated to
this PR, just to you using a newer GLib
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2121311153
You are receiving this because you are
@b4n pushed 1 commit.
0e2de9fae3f6c23a1a048da046279222b1118ce7 geniuspaste: Fix replace
configurations with GLib 2.79+
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1342/files/7a86376bf18109af37cd534ce9e97ff298ed1012..0e2de9fae3f6c23a1a048da046279222b1118ce7
You are
> Weird, here is Debian Testing but Geany is installed from GIT master.
Yeah I meant separate Git install, not from Debian.
But I got it, it's likely just you using a newer GLib than I am, and they made
a incompatible change: https://gitlab.gnome.org/GNOME/glib/-/issues/3098
--
Reply to this
> > No leftover configuration. I could reproduce this with pastebin.geany.org
> > on Linux and Windows.
> > After removing the keys from the `[parse]` section in
> > `geniuspaste/data/pastebin.geany.org.conf` so that the section remains
> > empty in the config, it works.
>
> What does the
@b4n pushed 2 commits.
4abbf8f4bc4095abf0bde1a97c11c5e7fc5301a9 fixup! Update CI for libsoup3
7a86376bf18109af37cd534ce9e97ff298ed1012 geniuspaste: Update TODO
--
View it on GitHub:
> No leftover configuration. I could reproduce this with pastebin.geany.org on
> Linux and Windows.
> After removing the keys from the `[parse]` section in
> `geniuspaste/data/pastebin.geany.org.conf` so that the section remains empty
> in the config, it works.
What does the section contain??
> > When trying to paste some file, Geany crashes for me when it is executed
> > natively. I don't know yet why this happens and I didn't manage it yet to
> > debug it with gdb. This might be related to my system where I use some
> > firewall rules to block unwanted internet access from Windows
I rebased against master to have a fixed CI, plus added @eht16 Windows bundle
fixes -- hopefully this will help testing and finding out what's wrong :)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2113570447
You are
@b4n pushed 7 commits.
e7f19b79f4b9e200b3e23d645e3cf62c8a7ca7c9 geniuspaste: Port to libsoup3
bb4513ca7e2a7540461d07acbd4a365ce14be802 geniuspaste: Remove use of deprecated
GTK API
80607621e5b1569737f3d2da8f3de6d830c9f706 geniuspaste: Enable HTTPS for
paste.debian.net
> Then, I got a compiler warning which might or might not be new but still
> worth to look at:
>
> […]
It's actually not an issue (the buffer is taken the line before), but probably
worth silencing.
> When trying to paste some file, Geany crashes for me when it is executed
> natively. I
I tried to test it on Windows but got mixed results :(.
First, we need more dependencies on Windows:
```
diff --git a/build/gtk-bundle-from-msys2.sh b/build/gtk-bundle-from-msys2.sh
index 408d727f..529fa24a 100644
--- a/build/gtk-bundle-from-msys2.sh
+++ b/build/gtk-bundle-from-msys2.sh
@@ -21,7
@eht16 commented on this pull request.
> @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE],
GP_ARG_DISABLE([GeniusPaste], [auto])
GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE,
- [libsoup-2.4 >= 2.4.0])
+ [gtk+-3.0 >= 3.16
No. It
@b4n pushed 1 commit.
d336856411f9b8897b62c705da5944c29205647b Update CI for libsoup3
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1342/files/0e025a780b403c083c1d3dcfede8c42a3c26d865..d336856411f9b8897b62c705da5944c29205647b
You are receiving this because you are
@b4n commented on this pull request.
> @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE],
GP_ARG_DISABLE([GeniusPaste], [auto])
GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE,
- [libsoup-2.4 >= 2.4.0])
+ [gtk+-3.0 >= 3.16
@eht16 Seems
@b4n pushed 4 commits.
125fe5376e806fb26612d6af1505b639efe8f0df geniuspaste: Port to libsoup3
bb27723f0bea02016036573524570001f1b7a443 geniuspaste: Remove use of deprecated
GTK API
1c3ca837f59d98f1b4d26ef69a102049fe6eb391 geniuspaste: Enable HTTPS for
paste.debian.net
@b4n pushed 1 commit.
7758920773f9918f1a672064434122ea674e5a79 Update CI for libsoup3
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1342/files/ab31775cbaa1fc401d5c7c0aa8231726d0729f4e..7758920773f9918f1a672064434122ea674e5a79
You are receiving this because you are
@b4n commented on this pull request.
> @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE],
GP_ARG_DISABLE([GeniusPaste], [auto])
GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE,
- [libsoup-2.4 >= 2.4.0])
+ [gtk+-3.0 >= 3.16
Indeed,
@b4n pushed 2 commits.
bdd4db94934400b447c8a7d5de2a7c5cd3740bf0 geniuspaste: Enable HTTPS for
paste.debian.net
ab31775cbaa1fc401d5c7c0aa8231726d0729f4e Update CI for libsoup3
--
View it on GitHub:
@eht16 commented on this pull request.
> @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE],
GP_ARG_DISABLE([GeniusPaste], [auto])
GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE,
- [libsoup-2.4 >= 2.4.0])
+ [gtk+-3.0 >= 3.16
We also
> It didn't appear to do either. No popup or message in status or msgwin on
> success. I don't recall seeing anything but some usual gtk errors in terminal.
Weird… unless you have a libsoup2 plugin loaded? IIUC nothing will stop you
from doing so, but things will just perform bizarrely (or
> it uses Geany's own `utils_open_browser()`, so that suggests this doesn't
> work for you either?
I had seen the browser setting, but don't know what actually uses it. Same
with the terminal command. What actually uses it? I also often have ... "send
selection to" not working until I
> Do Debian and Ubuntu even bother rebuilding packages for old releases?
No, the dependency only matter for users of older releases that would like to
build a newer Geany by themselves. And Debian was just an example, sometimes
we check what even more slow-paced distro do, like RHEL or so.
> After testing the plugin, I think it should be dropped. Most of the pastebins
> don't work.
Indeed only 3 did in my tests (Geany's, Debian's and Sprunge)
> There's no confirmation of what it's sending. […] Once data is sent, there's
> no way to delete it, which is a security risk if
> Do Debian and Ubuntu even bother rebuilding packages for old releases?
Bugfixes, security fixes and those sorts of things, but rarely new versions.
To be honest @xiota has a point, if the plugin causes constraints on others we
need to look at what value it adds, and if it only works for one
> not available in Debian before Bookworm (12, current stable)
Do Debian and Ubuntu even bother rebuilding packages for old releases?
After testing the plugin, I think it should be dropped. Most of the pastebins
don't work. There's no confirmation of what it's sending. Half the time,
Thanks for review & testing!
BTW, a few things things to note:
* libsoup3 is fairly recent (2021-09-18), and e.g. not available in Debian
before Bookworm (12, current stable)
* I probably won't make it possible to support both libsoup2 and libsoup3,
because the changes are too complex which
Tested... Seems to work.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2080360294
You are receiving this because you are subscribed to this thread.
Message ID:
@elextr approved this pull request.
Bearing in mind my lack of knowledge of libsoup it looks ok.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#pullrequestreview-2026126069
You are receiving this because you are subscribed to this
44 matches
Mail list logo
