Re: [Github-comments] [geany/geany] Keep the current tab when closing documents to the right of another tab (#1579)

2017-09-18 Thread Colomban Wendling
Merged #1579. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1579#event-1254173622

Re: [Github-comments] [geany/geany] Keep the current tab when closing documents to the right of another tab (#1579)

2017-09-18 Thread Matthew Brush
codebrainz approved this pull request. Seems reasonable to me. I haven't tested yet. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1579#pullrequestreview-63411159

Re: [Github-comments] [geany/geany] Keep the current tab when closing documents to the right of another tab (#1579)

2017-09-18 Thread Matthew Brush
codebrainz commented on this pull request. > gint doc_page = document_get_notebook_page(doc); for (gint i = doc_page + 1; i < gtk_notebook_get_n_pages(nb); ) { if (! document_close(document_get_from_page(i))) i++; // only increment

Re: [Github-comments] [geany/geany] Keep the current tab when closing documents to the right of another tab (#1579)

2017-09-18 Thread Thomas Martitz
LGBI, I support this change as it implements the expected behaviour -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1579#issuecomment-330136787

Re: [Github-comments] [geany/geany] Keep the current tab when closing documents to the right of another tab (#1579)

2017-08-19 Thread Colomban Wendling
1. Open 3 files 2. Make the far left (1st) one current 3. Right click on the middle (2nd) tab 4. Choose *Close Documents to the Right* Expected behavior: * far left document (1st) is current (no change) Actual behavior: * middle document (2nd) is current (changed from far left (1st) one) --

Re: [Github-comments] [geany/geany] Keep the current tab when closing documents to the right of another tab (#1579)

2017-08-19 Thread Matthew Brush
What does this accomplish? I'm using this feature for a long time and no problems. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1579#issuecomment-323557724