Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2021-03-27 Thread Carlos
I will leave it here in case it helps someone. I am using the following style in my _geany.css_: ```css #geany-compiler-error { color: #FF7987; } #geany-compiler-message { color: #DFDBFF; } #geany-compiler-context { color: #FEC0E0; } ``` It has been easy to read the compiler

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-12-23 Thread Matthew Brush
Real CSS has a property like this: ```css filter: invert(1) hue-rotate(180deg); ``` But since GTK+ CSS is not real/complete CSS, I doubt it works. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-09 Thread carlos157oliveira
> I guess that still has the problem that we have no idea what GTK+ theme the > user will choose, so it's not really possible to pick properly contrasting > colours. Its true, but we can pick bright colours instead of the dark ones currently implemented. Its very likely that it will give a

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-09 Thread Matthew Brush
> My solution would be to add comments to the CSS file so that the users of > dark themes only have to uncomment to have a functional contrast. I guess that still has the problem that we have no idea what GTK+ theme the user will choose, so it's not really possible to pick properly contrasting

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-09 Thread carlos157oliveira
I thought of something. I guess people in this community are really geek and like to tweak a CSS file. But I believe most users of dark themes don't really want to think of colours to customize _geany.css_ so the contrast between the letters and background is reasonable. My solution would be to

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread elextr
@b4n, ok, so long as whatever mechanism is simple for users to override if the theme is inappropriate, not all themes are done well, and when it comes to colours peoples vision differs markedly. And the override is documented in the Geany manual!!! [getting in ahead of time] -- You are

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread Colomban Wendling
@elextr well, yes and no; in theory you can't really get any color from CSS, as there might not be any -- could be image, gradient or whatnot, although it's less true for text. What you would normally do is use the appropriate CSS class and it'd be styled the right way whatever that is. In

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread elextr
> I wonder if it's possible to access the colours based on GtkMessageType like > GtkInfoBar does, so they come from the theme? This is sort of like web CSS > frameworks that provide basic colours for ex. warning, danger, primary, etc. Good idea for the default if not user custom colour is

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread Colomban Wendling
I think there are style classes for that yes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723493984

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread Matthew Brush
I wonder if it's possible to access the colours based on `GtkMessageType` like `GtkInfoBar` does, so they come from the theme? This is sort of like web CSS frameworks that provide basic colours for ex. warning, danger, primary, etc. -- You are receiving this because you are subscribed to this

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread carlos157oliveira
I had a idea. It would involve a little bit code. As my original idea, we would do some basic calculations to detect light and dark themes through _GtkStyleContext_, then load _geany.css_ or _geany-dark.css_ accordingly. I think this solution is more maintainable than caring for every theme. It

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-07 Thread Colomban Wendling
One workaround that has been implemented in e.g. MATE's file manager Caja is the ability to load custom CSS based on theme name. E.g., we could imagine try and load geany-$THEME.css, if it exists. That would clearly not be perfect, but could allows us (or the user) to provide support for some

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-06 Thread Matthew Brush
Duplicate of at least #1376, #1737, #2293, etc. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723363552

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-06 Thread elextr
Thanks for the offer, I guess advanced GTK versions can be required so long as the CSS is properly guarded so olde versions ignore it and don't give errors. I'm no expert on GTK CSS and I don't know if it can determine if a theme is "dark" to only apply in that case, but perhaps its possible.

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-06 Thread carlos157oliveira
Even when I use stable dark themes, the colors aren't that good to be read for me. I have looked some other mechanisms, but it would involve advanced GTK versions and a little bit of code tweak. I thought i would be able to contribute to Geany project, but it may have to be a next time. --

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-06 Thread elextr
Yes, you need to check what your particular GTK version supports. The basic premise is that (apart from the editor window) all theming should use the normal GTK mechanism, so having code play with colours is a "bad idea"™. Anything that doesn't is a bug. Of course that leaves Geany users at

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-06 Thread carlos157oliveira
I have tried to use **@media (prefers-color-scheme: dark)**, but it says ``` (geany:17276): Geany-WARNING **: 18:47:50.165: Failed to load custom CSS: geany.css:1:0unknown @ rule ``` Maybe it is a gtk version thing. Since it must be configured through CSS, i don't think it is a good idea change

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-06 Thread carlos157oliveira
Wouldn't it be nice to implement an functional default for dark themes? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2644#issuecomment-723298249

Re: [Github-comments] [geany/geany] Message Window colors aren't contrasting in dark themes (#2644)

2020-11-06 Thread elextr
Colours are configurable, see [the manual](https://www.geany.org/manual/current/index.html#customizing-geany-s-appearance-using-gtk-3-css) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: