> + GtkWidget *sortdesc_item;
> +
> + main_menu_item = gtk_menu_item_new_with_mnemonic(_("_Line Operations"));
> + gtk_widget_show(main_menu_item);
> +
> + submenu = gtk_menu_new();
> + gtk_widget_show(submenu);
> + sep1 = gtk_separator_menu_item_new();
> + sep2 =
Reviewed the diff and it looks fine however I did not test it in detail. Or as
Lex would say: LGBI :)
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/547#issuecomment-172359245
LGTM
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/324#issuecomment-172360003
> +static void
> +lo_cleanup(GeanyPlugin *plugin, gpointer pdata)
> +{
> + if(main_menu_item) gtk_widget_destroy(main_menu_item);
> +}
> +
> +
> +G_MODULE_EXPORT
> +void geany_load_module(GeanyPlugin *plugin)
> +{
> + main_locale_init(LOCALEDIR, GETTEXT_PACKAGE);
> +
> +
@kugel- Adwaita is pulled in as you can see in my pastebin.
http://pastebin.geany.org/WQNB6/ this is a diff to "bring back" the fixed
package list, extended by libepoxy for GTK3 and pixman/pixbuf dependencies for
both GTK versions.
This is just my suggestion, no idea what's the best way to go.
> Regarding adwaita, I don't think it's pulled in for GTK2
Just as a note/reminder, IMO I don't think we should ship official GTK+ 3
Windows release until we find an theme that at least makes an attempt to look
"native". The Adwaita theme is completely intolerable in Windows, IMO. For
icons, I
@codebrainz do you intent to continue on this? As I already said, I think we
should re-use the existing NSI script when possible. It seems #560 is a subset
of what you have done. Maybe we should finish the clean bundle creation first
before stepping into building releases, IMHO.
---
Reply to
This however raises a more important concern: if the API changes again having
the macro bundled doesn't help at least on Debian if the system has it too. I
didn't yet investigate this part of the issue, but it might be something to
worry about as apparently they sometimes change API.
BTW,
Closed #842 via f3a5dd609a51cbb0921d020b32a3778e24bf52e4.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/842#event-517481944
Closed #830 via 9365110c4c0fa23c99cb9b79149f68f4049e342e.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/830#event-517481932
Merged #826.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/826#event-517481912
Closed #848 via 46ed77bf195c6bc08601b0e5a2055de2fc4b9cff.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/848#event-517481933
Merged #852.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/852#event-517481930
Squashed the commits together and committed as
f3a5dd609a51cbb0921d020b32a3778e24bf52e4, thanks.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/842#issuecomment-172412886
> + gtk_menu_shell_append(GTK_MENU_SHELL(submenu), sep2);
> + gtk_menu_shell_append(GTK_MENU_SHELL(submenu), sortasc_item);
> + gtk_menu_shell_append(GTK_MENU_SHELL(submenu), sortdesc_item);
> +
> + gtk_menu_item_set_submenu(GTK_MENU_ITEM(main_menu_item), submenu);
> +
> +
> + gtk_menu_shell_append(GTK_MENU_SHELL(submenu), rmemtyln_item);
> + gtk_menu_shell_append(GTK_MENU_SHELL(submenu), rmwhspln_item);
> + gtk_menu_shell_append(GTK_MENU_SHELL(submenu), sep2);
> + gtk_menu_shell_append(GTK_MENU_SHELL(submenu), sortasc_item);
> +
> +
> + sci_end_undo_action(doc->editor->sci);
> +}
> +
> +
> +/* Sort Lines Ascending and Descending */
> +void sortlines(GeanyDocument *doc, gboolean asc) {
> + gint total_num_chars; /* number of characters in the document */
> + gint total_num_lines; /* number of lines in the
> +
> + sci_end_undo_action(doc->editor->sci);
> +}
> +
> +
> +/* Sort Lines Ascending and Descending */
> +void sortlines(GeanyDocument *doc, gboolean asc) {
> + gint total_num_chars; /* number of characters in the document */
> + gint total_num_lines; /* number of lines in the
> + GtkWidget *sortdesc_item;
> +
> + main_menu_item = gtk_menu_item_new_with_mnemonic(_("_Line Operations"));
> + gtk_widget_show(main_menu_item);
> +
> + submenu = gtk_menu_new();
> + gtk_widget_show(submenu);
> + sep1 = gtk_separator_menu_item_new();
> + sep2 =
> + gtk_menu_shell_append(GTK_MENU_SHELL(submenu), rmemtyln_item);
> + gtk_menu_shell_append(GTK_MENU_SHELL(submenu), rmwhspln_item);
> + gtk_menu_shell_append(GTK_MENU_SHELL(submenu), sep2);
> + gtk_menu_shell_append(GTK_MENU_SHELL(submenu), sortasc_item);
> +
> + GtkWidget *sortdesc_item;
> +
> + main_menu_item = gtk_menu_item_new_with_mnemonic(_("_Line Operations"));
> + gtk_widget_show(main_menu_item);
> +
> + submenu = gtk_menu_new();
> + gtk_widget_show(submenu);
> + sep1 = gtk_separator_menu_item_new();
> + sep2 =
Unfortunately Gtk3 dropped the support for flipping through notebook pages for
'usability reasons' without making it available again with some kind of
options. So applications like gnome-terminal started to re-implement this
feature.
For maintaining feature parity with the Gtk2 backend, geany
So I found one more problem: we now substitute the anon_* names in the sidebar
with the corresponding typedef name if it's something like typedef struct {}
Foo; The problem is that the sorting in the tree is still done according to the
anon_* name instead of the typedef name. I started working
Well, that would make the stripping just more complex.
I don't see so many problems with the manual dependency list, especially as you
already created it.
I guess we will detect new dependencies which were missing by a fixed list
quite quickly when testing the created bundle.
And we would save
To wake this one up: regarding the question how to get an up2date version of
Geany into the build environment: I'd prefer the nightly builds way.
In the meantime, Travis offers Ubuntu 14.04 as beta environment
(https://docs.travis-ci.com/user/ci-environment). Maybe we can check this, it
might
You want to strip either way so I don't see the point. Anyway, feel free to
compile the list of packages a ignore my script. Regarding adwaita, I don't
think it's pulled in for GTK2.
I'll try to have a look at the other issues this week.
---
Reply to this email directly or view it on GitHub:
26 matches
Mail list logo
