Re: [Github-comments] [geany/geany-plugins] Fix cppcheck warnings (#644)

2017-11-10 Thread Enrico Tröger
If there is nothing else, I'd like to merge this soon as the nightly builds are broken for days due to cppcheck issues. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Please reconsider your use of the word "sexy" in your domain and on your site (#1672)

2017-11-10 Thread Enrico Tröger
Closed #1672. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1672#event-1335971482

Re: [Github-comments] [geany/geany] Add cast to `GtkWidget*` to match previous behaviour (#1607)

2017-11-10 Thread Thomas Martitz
kugel- approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1607#pullrequestreview-75786729

Re: [Github-comments] [geany/geany] Added Context Action Patterns. (#1643)

2017-11-10 Thread Thomas Martitz
Seems really useful, will give it a test. Maybe there ought to be an UI for configuration? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1643#issuecomment-343505964

Re: [Github-comments] [geany/geany] Add cast to `GtkWidget*` to match previous behaviour (#1607)

2017-11-10 Thread Thomas Martitz
LGTM. I'd merge this in the near future unless anyone complains. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1607#issuecomment-343499476

Re: [Github-comments] [geany/geany-plugins] Fix cppcheck warnings (#644)

2017-11-10 Thread Matthew Brush
LGBI -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/644#issuecomment-343499159

Re: [Github-comments] [geany/geany] Follow up fixes for PR#1456 (#1578)

2017-11-10 Thread Thomas Martitz
@codebrainz I think it would be good if this was merged before the release. Please do. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1578#issuecomment-343500581

Re: [Github-comments] [geany/geany] Handle continuous G_IO_IN-s without any data (#1461)

2017-11-10 Thread LarsGit223
Is there a chance that this could be added to the next release? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1461#issuecomment-343523772

Re: [Github-comments] [geany/geany] Added Context Action Patterns. (#1643)

2017-11-10 Thread LarsGit223
Well, honestly I did not plan one cause I thought it would be quite an effort to implement the UI fields for a varying number of values. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] Fix cppcheck warnings (#644)

2017-11-10 Thread Frank Lanitz
Merged #644. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/644#event-1336955545

Re: [Github-comments] [geany/geany] Added Context Action Patterns. (#1643)

2017-11-10 Thread elextr
@LarsGit223 I havn't had a chance to look at this in detail, but is it only per-filetype, or do you have a set that is filetype independent? Or are filetype independent context actions still limited to one puny no pattern command? AFAIK nothing in the filetype files has a GUI, so its probably

[Github-comments] [geany/geany-plugins] Ported 'Debugger' plugin to GTK+3. (#645)

2017-11-10 Thread pmjobin
Tested on Fedora 27 using stock Geany available from repo. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/645 -- Commit Summary -- * Ported 'Debugger' plugin to GTK+3. -- File Changes -- M build/debugger.m4 (4) M

Re: [Github-comments] [geany/geany] Follow up fixes for PR#1456 (#1578)

2017-11-10 Thread Matthew Brush
Looks OK to me, feel free to merge, else I'll try and find some time to test and merge "soon". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1578#issuecomment-343628647

Re: [Github-comments] [geany/geany-plugins] Markdown: Remove embedded Discount lib and other stuff (#89)

2017-11-10 Thread GrantM11235
Since version 2.1.6, Discount has been released under the 3-Clause BSD License which [is GPL compatible](https://www.gnu.org/licenses/license-list.en.html#ModifiedBSD) [2.1.6 release notes](http://www.pell.portland.or.us/~orc/Code/discount/#v2.1.6) [Current Discount COPYRIGHT

Re: [Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

2017-11-10 Thread Thomas Martitz
kugel- requested changes on this pull request. Let's back out b9982368889354cfa010e5906cd5f477f7b90f35 and merge the rest, until we agree on a placeholder. > @@ -2394,7 +2394,7 @@ typedef struct } SelectionRange; -#define CURSOR_PLACEHOLDER "_" /* Would rather use … but not all docs are

Re: [Github-comments] [geany/geany] Added Context Action Patterns. (#1643)

2017-11-10 Thread LarsGit223
> I havn't had a chance to look at this in detail, but is it only per-filetype, > or do you have a set that is filetype independent? No, it only works per filetype. > AFAIK nothing in the filetype files has a GUI, ... The context action can be configured in the tools section of the

Re: [Github-comments] [geany/geany] Remove "-I" and "-F" opts from the default options for grep options (#1684)

2017-11-10 Thread Colomban Wendling
`-F` is only added if *use regular expressions* is not checked (or at least it should, I didn't test right now), so it should be preserved (or adapted to work everywhere). More generally, I agree with @elextr: we should have something configurable, but not drop current features or make them

Re: [Github-comments] [geany/geany] Remove "-I" and "-F" opts from the default options for grep options (#1684)

2017-11-10 Thread elextr
To answer my own question above, since `-F` is applied by the regex selection, clearly those are not all compatible, so while the `-I` can go in the extra options as default, the `-F` can't. I suggest a single configuration file option that has a list of values separated by `;` so `g_key_file`