I don't think copying the spawn module is a good idea, it was actually moved
from the plugin because subprocess communication is a tricky (esp. when you
want it to be portable, but even otherwise there's a gazillion ways to shoot
yourself in the food without even realizing it) and important
BTW, if I knew a way to let GitHub think a PR is merged when manually squasing
it, I could fix those nitpickings myself when merging… anybody aware of such a
possibility?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
b4n requested changes on this pull request.
Sorry…
Otherwise looks good, just need updating the `@since`, squashing and we're good
to merge.
> @@ -488,6 +519,32 @@ void msgwin_status_add(const gchar *format, ...)
}
}
+/**
+ * Logs a formatted status message *without* setting the
As I just merged geany/geany#1461, this is not needed anymore. And as
mentioned there, I don't really like the idea of copying a 1600+ lines module
over.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Well, yeah I don't like inefficient code when it can easily be improved in that
aspect. OTOH, I prefer easy to read/maintain code.
And I'll have to check again, maybe I was tired, but I found your code oddly
hard to follow, and tricky to fix the issues I found. At the time I found that
b4n commented on this pull request.
small stuff I noticed first time I went over, if it can be useful.
Not a complete review.
> +{
+ gchar *prefix, **ptr;
+
+ if (!NZV(strv))
+ return NULL;
+
+ if (num == 0)
+ num = g_strv_length(strv);
+
+
Merged #720.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/720#event-1514502527
> Not beautiful because of the code duplication but maybe the only safe way to
> apply the workaround with a 100% guarantee for having no side effects to
> non-scope users.
The other way being to merge it so more people test it.
--
You are receiving this because you are subscribed to this
Closed #721.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/721#event-1514408405
I'll try and test on Window 7 and 10 this weekend once the nightlies update.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1461#issuecomment-371987945
b4n requested changes on this pull request.
Is `GEANY_WORDCHARS` actually useful to anyone? I think it's pretty much
useless in most situations, and wrong in many other (e.g. it's *not* a good
universal way to recognize a "word", not even for programming languages).
And it's fairly easy to
> FWIW, this check was more or less always obsolete, GIO is in GLib, and if GTK
> exposes API using its types it ought to be present…
But `libgio` is a separate library, maybe that was really what should have been
tested? Sure on Linux its in the glib package so it will allways be there, but
b4n commented on this pull request.
> @@ -208,7 +206,7 @@ utils_pixbuf_from_stock(const gchar *stock_id)
static GdkPixbuf *
utils_pixbuf_from_path(gchar *path)
{
-#if defined(HAVE_GIO) && GTK_CHECK_VERSION(2, 14, 0)
+#if GTK_CHECK_VERSION(2, 14, 0)
The GTK check is also mostly irrelevant
b4n approved this pull request.
LGBI
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/720#pullrequestreview-102834917
Closed #713 via dcc37957e917a2e8c2f3e5d483c9a832eceff1e0.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/713#event-1514503766
Merged #719.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/719#event-1514503631
Merged #715.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/715#event-1514503750
Merged #1461.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1461#event-1514404023
@b4n: thanks for the info. I also played around with the cursor a bit. I
managed to use it as a replacement but also noticed that it does not make any
difference. Setting selection mode to none also does not help.
> Obviously we can't filter anymore, but the selection/cursor doesn't jump
>
@LarsGit223 pushed 1 commit.
6891778 scope: added 'scope_spawn.c' to POTFILES.in
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@LarsGit223 pushed 1 commit.
e5bbde4 scope: fixed typo in POTFILES.in
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
> I think that first of all we should fix the code so that it doesn't only rely
> on the UI being insensitive not to crash.
Yes, both keybindings and preferences buttons don't seem to suffer the problem,
probably because of a similar test.
--
You are receiving this because you are subscribed
See geany PR 1461 (https://github.com/geany/geany/pull/1461). This copies the
workaround code from the PR to scope_spawn.c to be used by the scope plugin
only. The prefix 'scope_' has been added to all functions in scope_spawn.c.
Fixes #433.
You can view, comment on, or merge this pull request
> Maybe the solution is for a copy of the spawn code with the patch to be made
> in scope so it only applies to Scope.
Good idea. Not beautiful because of the code duplication but maybe the only
safe way to apply the workaround with a 100% guarantee for having no side
effects to non-scope
@LarsGit223 pushed 1 commit.
9e49575 plugin-manager: protect call to help function with NULL pointer check
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
> Also, we really should be using the treeview's cursor rather than the
> selection, but well.
I haven't used cursors yet. How should it be used? Somewhat like this:
- on clicking a checkbox in the pluing manager set the cursor to the path given
to ```pm_plugin_toggled()```
- in
26 matches
Mail list logo
