@LarsGit223 other solution is just show me the commit and I add it :)
But @elextr and @codebrainz are right, you can easily just pull my changes into
your Geany clone repo: you add my remote, and you fetch suff from it.
--
You are receiving this because you are subscribed to this thread.
Reply
I don't really like the idea that we're installing certificates that aren't
even ours, but I guess that if we really have to installing the ones form MSYS
is probably simpler and safer indeed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
Merged #787 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/787#event-1988745172
Merged #793 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/793#event-1988745184
b4n approved this pull request.
LGTM and it builds on Linux apparently
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/793#pullrequestreview-178625809
bxgaillard commented on this pull request.
> @@ -458,21 +493,36 @@ void config_init(void)
g_free(data);
}
+#if GTK_CHECK_VERSION(3, 0, 0)
+ g_mutex_init(_config_mutex);
+ g_cond_init();
+ saving_thread = g_thread_new(NULL, saving_thread_func, NULL);
bxgaillard commented on this pull request.
> @@ -320,7 +324,11 @@ static void on_watch_dragged_callback(GtkWidget *wgt,
> GdkDragContext *context, i
gpointer userdata)
{
/* string that is dragged */
+#if GTK_CHECK_VERSION(3, 0, 0)
+ gchar *expression =
bxgaillard commented on this pull request.
> @@ -308,11 +318,20 @@ static gpointer saving_thread_func(gpointer data)
debug_config_changed = FALSE;
}
+#if GTK_CHECK_VERSION(3, 0, 0)
+ interval = g_get_monotonic_time() + SAVING_INTERVAL;
bxgaillard commented on this pull request.
> @@ -136,21 +152,37 @@ static void
> cell_renderer_frame_icon_get_size(GtkCellRenderer *cell, GtkWidget *
pixbuf_height = MAX (pixbuf_height, gdk_pixbuf_get_height
(cellframe->pixbuf_highlighted));
}
+#if
bxgaillard commented on this pull request.
> @@ -82,17 +82,28 @@ static void on_execute_until(GtkButton *button, gpointer
> user_data)
*/
GtkWidget* btnpanel_create(on_toggle cb)
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+ GtkWidget *vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL,
bxgaillard commented on this pull request.
> @@ -269,8 +274,13 @@ static void save_to_keyfile(GKeyFile *keyfile)
*/
static gpointer saving_thread_func(gpointer data)
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+ gint64 interval;
+ g_mutex_lock(_config_mutex);
+#else
I agree. I replaced
bxgaillard commented on this pull request.
> @@ -287,8 +288,13 @@ void dpaned_init(void)
/* setup notebooks */
gtk_notebook_set_scrollable(GTK_NOTEBOOK(debug_notebook_left), TRUE);
gtk_notebook_set_scrollable(GTK_NOTEBOOK(debug_notebook_right), TRUE);
+#if
bxgaillard commented on this pull request.
> @@ -1066,7 +1105,13 @@ void debug_init(void)
configfile = g_strconcat(geany_data->app->configdir, G_DIR_SEPARATOR_S,
"geany.conf", NULL);
g_key_file_load_from_file(config, configfile, G_KEY_FILE_NONE, NULL);
font =
bxgaillard commented on this pull request.
> @@ -197,7 +197,11 @@ static void on_render_line(GtkTreeViewColumn
> *tree_column, GtkCellRenderer *cell
g_object_set(cell, "text", "", NULL);
else
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+ GValue value =
bxgaillard commented on this pull request.
>
cell_renderer_break_icon_get_size (cell, widget, cell_area,
_rect.x,
_rect.y,
_rect.width,
_rect.height);
+#if GTK_CHECK_VERSION(3, 0, 0)
+
@bxgaillard pushed 1 commit.
5eec7fd Factorize some code between GTK2 and GTK3.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
This uses a menu and is thus subject to the menu icons visibility setting, but
here it should reflect the view from the symbols list, and thus show the icon
in all cases.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1997
-- Commit
bxgaillard commented on this pull request.
> calc_width = (gint) cell->xpad * 2 + pixbuf_width;
calc_height = (gint) cell->ypad * 2 + pixbuf_height;
+#endif
I agree. Fixed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
bxgaillard commented on this pull request.
>
cell_renderer_frame_icon_get_size (cell, widget, cell_area,
_rect.x,
_rect.y,
_rect.width,
_rect.height);
+#if GTK_CHECK_VERSION(3, 0, 0)
+
bxgaillard commented on this pull request.
> @@ -67,8 +67,13 @@ static GKeyFile *keyfile_project = NULL;
static gboolean debug_config_loading = FALSE;
/* saving thread staff */
+#if GTK_CHECK_VERSION(3, 0, 0)
+static GMutex change_config_mutex;
+static GCond cond;
+#else
I agree. I
bxgaillard commented on this pull request.
> gtk_box_pack_start(GTK_BOX(root), hbox, FALSE, FALSE, 0);
gtk_box_pack_start(GTK_BOX(hbox), target_label, FALSE, FALSE,
0);
gtk_box_pack_start(GTK_BOX(hbox), target_name, TRUE, TRUE, 0);
bxgaillard commented on this pull request.
> }
+#if GTK_CHECK_VERSION(3, 0, 0)
+ while (!g_cond_wait_until(, _config_mutex, interval));
+ g_mutex_unlock(_config_mutex);
Fixed: the old code has been replaced with the new one.
--
You are receiving this because you are
LGTM
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1997#issuecomment-441676366
bxgaillard commented on this pull request.
> modules = debug_get_modules();
for (iter = modules; iter; iter = iter->next)
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+
gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(debugger_cmb),
(gchar*)iter->data);
I agree.
bxgaillard commented on this pull request.
> @@ -366,7 +442,11 @@ int tpage_get_debug_module_index(void)
*/
gchar* tpage_get_debugger(void)
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+ return
gtk_combo_box_text_get_active_text(GTK_COMBO_BOX_TEXT(debugger_cmb));
I agree. Fixed.
--
You are
Thank you @LarsGit223 for the thorough PR review! I'm not a GTK+ expert at all,
that's why I didn'y dive in the documentation and just applied the changes from
#645 with preprocessing conditionals. As indicated in my replies I've applied
your suggestions and pushed a new commit which should be
bxgaillard commented on this pull request.
> gtk_widget_set_size_request(target_button_browse, BROWSE_BUTTON_WIDTH,
> 0);
g_signal_connect(G_OBJECT(target_button_browse), "clicked", G_CALLBACK
(on_target_browse_clicked), NULL);
/* debugger */
debugger_label =
LarsGit223 commented on this pull request.
> @@ -196,27 +223,45 @@ void tpage_pack_widgets(gboolean tabbed)
{
GtkWidget *lbox, *rbox, *hbox;
+#if GTK_CHECK_VERSION(3, 0, 0)
+ root = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, SPACING);
+
LarsGit223 commented on this pull request.
> gtk_box_pack_start(GTK_BOX(root), hbox, FALSE, FALSE, 0);
gtk_box_pack_start(GTK_BOX(hbox), target_label, FALSE, FALSE,
0);
gtk_box_pack_start(GTK_BOX(hbox), target_name, TRUE, TRUE, 0);
> I'm not a GTK+ expert at all, that's why I didn'y dive in the documentation
> and just applied the changes from #645 with preprocessing conditionals.
Therefore thanks for putting time in it even though it wasn't your PR
originally :+1: Once the others agree to merge it, the only thing left to
LarsGit223 approved this pull request.
This looks much better now because of all the code that is now shared between
gtk2 and 3. Also, the deprecation warnings I mentioned when compiling for gtk2
seem to be gone.
Compiled/installed/tested debugging shortly on gtk2 and 3 again, still works.
So
LarsGit223 approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#pullrequestreview-178477829
As discussed in PR #787.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/793
-- Commit Summary --
* scope: removed unnecessary includes of 'vte/vte.h'
-- File Changes --
M scope/src/prefs.c (4)
M scope/src/scope.c (2)
--
@b4n, @elextr, @codebrainz: ok, I took the simplest way and just created a PR
for the changes of the includes as the change is not depending on b4n's changes
(see #793).
@b4n, @codebrainz: sorry. I tried fetching b4n's repo but it seems to fetch
everything out of it. Merging into one of my
Two consecutive "go to matching brace" commands have to return us to the
original position. After we moved to the matching brace, we still should see
the same brace pair highlighted. All Scintilla-based editors have the problem.
Scintilla doesn't necessarily return us to the initial position
An issue with italian translation:
When you are editing a file and someone else changes it on disk, you are
presented a question: "Ricaricare il file?" ("Do you want to reload the
file?"). The question is correct and the italian translation too.
But the 3 buttons on the right say:
already resolved
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1999#issuecomment-441819225
Closed #1999.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1999#event-1988042534
As you have identified that the issue is common to all Scintilla based editors
did you raise it as an issue with Scintilla?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
39 matches
Mail list logo
