Re: [Github-comments] [geany/geany] Add option to "Open files on read-only mode" (#1987)
Closed #1987. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1987#event-2006736619
Re: [Github-comments] [geany/geany] Add option to "Open files on read-only mode" (#1987)
I guess I saw situations where defaulting to read-only would be useful, not just cats :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1987#issuecomment-00326
Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)
bxgaillard commented on this pull request. > cell_renderer->mode = GTK_CELL_RENDERER_MODE_ACTIVATABLE; +#endif Fixed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/791#discussion_r239031640
Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)
bxgaillard commented on this pull request. > - GdkPixbuf *GSEAL (pixbuf_enabled); - GdkPixbuf *GSEAL (pixbuf_disabled); - GdkPixbuf *GSEAL (pixbuf_conditional); - GdkPixbuf *GSEAL (pixbuf_file); + GdkPixbuf *pixbuf_enabled; + GdkPixbuf *pixbuf_disabled; + GdkPixbuf *pixbuf_conditional; + GdkPixbuf *pixbuf_file; Yes I didn't understand the reason to use GSEAL() in the first place in the GTK+2 code. It just broke the GTK+3 version. As a more elegant solution to the private nature of these members, I moved the structure definitions out of the .h into the .c. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/791#discussion_r239032254
Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)
bxgaillard commented on this pull request. > - GdkPixbuf *GSEAL (pixbuf_active); - GdkPixbuf *GSEAL (pixbuf_highlighted); + GdkPixbuf *pixbuf_active; + GdkPixbuf *pixbuf_highlighted; Same answer as above. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/791#discussion_r239032343
Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)
bxgaillard commented on this pull request.
> }
g_list_free(modules);
gtk_combo_box_set_active(GTK_COMBO_BOX(debugger_cmb), 0);
/* arguments */
args_frame = gtk_frame_new(_("Command Line Arguments"));
+#if GTK_CHECK_VERSION(3, 0, 0)
+ hbox = gtk_scrolled_window_new(
+ gtk_scrollable_get_hadjustment(GTK_SCROLLABLE(args_textview)),
+ gtk_scrollable_get_vadjustment(GTK_SCROLLABLE(args_textview)));
+ gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(hbox),
GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
The code can't be the same between GTK+2 and GTK+3 because the GtkTextView (and
the GtkTreeView) don't implement the GtkScrollable interface in GTK+2 whereas
they do in GTK+3 and shall seemingly be handled with a GtkScrolledWindow to add
the scrolling functionality from what I can understand.
However you're absolutely right about the use before assignment, this is fixed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#discussion_r239033661
Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)
bxgaillard commented on this pull request.
> @@ -279,8 +336,15 @@ static void tpage_create_widgets(void)
/* environment */
env_frame = gtk_frame_new(_("Environment Variables"));
+#if GTK_CHECK_VERSION(3, 0, 0)
+ hbox = gtk_scrolled_window_new(
+ gtk_scrollable_get_hadjustment(GTK_SCROLLABLE(args_textview)),
+ gtk_scrollable_get_vadjustment(GTK_SCROLLABLE(args_textview)));
+ gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(hbox),
GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
Same as above. And the correct variable is effectively tree, this is fixed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#discussion_r239033859
Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)
bxgaillard commented on this pull request. > @@ -1048,12 +1068,24 @@ void debug_init(void) NULL); grantpt(pty_master); unlockpt(pty_master); +#if GTK_CHECK_VERSION(3, 0, 0) + pty = vte_pty_new_foreign_sync(pty_master, NULL, NULL); + vte_terminal_set_pty(VTE_TERMINAL(terminal), pty); + g_object_unref(pty); + scrollbar = gtk_scrollbar_new(GTK_ORIENTATION_VERTICAL, gtk_scrollable_get_vadjustment(GTK_SCROLLABLE(terminal))); + gtk_widget_set_can_focus(GTK_WIDGET(scrollbar), FALSE); +#else vte_terminal_set_pty(VTE_TERMINAL(terminal), pty_master); scrollbar = gtk_vscrollbar_new(GTK_ADJUSTMENT(VTE_TERMINAL(terminal)->adjustment)); GTK_WIDGET_UNSET_FLAGS(scrollbar, GTK_CAN_FOCUS); If you're talking about the use of `gtk_widget_set_can_focus()`, that's right and it's fixed. The remaining code about PTY initialization seemingly has to be different though. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/791#discussion_r239034448
Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)
Thank you @b4n for your review. I applied your proposals, squashed the commits and pushed it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/791#issuecomment-61148
Re: [Github-comments] [geany/geany] Add Scheme (*.scm) syntax highlighting to Geany (#982)
Maybe add ```filetypes.Scheme.conf``` to page [https://wiki.geany.org/config/start](https://wiki.geany.org/config/start)? [filetypes.Scheme.conf](https://pastebin.com/1jDKBjZ5) and ```filetype_extensions.conf```: ```ini [Extensions] ... Scheme=*.scm;*.ss; ... [Groups] ... Script=Scheme; ``` P.S. I know about PR [#1922 Add parsers and built-in filetypes for Lisp dialects](https://github.com/geany/geany/pull/1922), but I don't know what will be done (and when). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/982#issuecomment-444524417
Re: [Github-comments] [geany/geany] Update da.po to 1.34 (#2006)
Merged #2006 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2006#event-2007535085
Re: [Github-comments] [geany/geany] Sync ctags main part (#1263)
As this has gone nowhere in two years, available resources are less than back then, and is holding up other ctags related stuff, I suggest it be rejected in its current form. Instead a progressive approach should be developed to re-arrange the directories to match ctags (using git-mv so as not to lose history), then the ctags parsers can be updated one at a time. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1263#issuecomment-444685801
Re: [Github-comments] [geany/geany-plugins] cannot install markdown plugin (#792)
@elextr I wasn't able to install libwebkitgtk2. I installed libwebkitgtk-1.0 via apt-get but couldn't do the same with v2, downloaded the tar.gz but the build commands were not working so I'm giving up on this mission. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/792#issuecomment-444683758
Re: [Github-comments] [geany/geany] Add translations for Windows installer (NSIS) (#2008)
Basically yes. IIRC we discussed this a couple of years ago and abandoned the idea. My concerns: - more overhead in maintaining Windows builds (none of the Geany developers actively use Windows) - more work for the translators for a rather small target user group - the installer is pretty basic and most of the texts are very common and so probably can be read/understood even by non-English speaking people or at least the installer can be used successfully Adding the NSI translations only would be an easy task, of course. One could argue so we have at least most of the texts translated. I would argue it would result in a half-translated installer with mixed languages. This is in my experience much more annoying than a complete English localized software. Anyway, if you think we should add it, feel free to open a PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2008#issuecomment-444666937
[Github-comments] [geany/geany] Update of Traditional Chinese translation (#2009)
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2009 -- Commit Summary -- * Update of Traditional Chinese translation -- File Changes -- M po/zh_TW.po (29) -- Patch Links -- https://github.com/geany/geany/pull/2009.patch https://github.com/geany/geany/pull/2009.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2009
Re: [Github-comments] [geany/geany] Sync ctags main part (#1263)
@elextr for example all the Python parser issues would be fixed by using the UCTags parser, but it relies on quite a few features we don't currently have. And maintaining a version that don't use those would create a difference gap again, with all the maintenance effort that go with it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1263#issuecomment-444773597
Re: [Github-comments] [geany/geany] Sync ctags main part (#1263)
@b4n Well, I didn't get a sense that you were making progress, will hassle you immediately after 1.34 release so it can be committed ASAP to allow for some time to mature before 1.35. [PS am only accepting it so I can have the new C++ added after the infrastructure is fixed :grin: ] -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1263#issuecomment-444775665
Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)
b4n commented on this pull request.
> }
g_list_free(modules);
gtk_combo_box_set_active(GTK_COMBO_BOX(debugger_cmb), 0);
/* arguments */
args_frame = gtk_frame_new(_("Command Line Arguments"));
+#if GTK_CHECK_VERSION(3, 0, 0)
+ hbox = gtk_scrolled_window_new(
+ gtk_scrollable_get_hadjustment(GTK_SCROLLABLE(args_textview)),
+ gtk_scrollable_get_vadjustment(GTK_SCROLLABLE(args_textview)));
+ gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(hbox),
GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
Be it in GTK2 or GTK3, to actually be scrollable you need to put most widgets
in a GtkScrolledWindow. The widgets "supporting scrolling" like GtkTreeView
and GtkTextView know how to communicate with the ScrolledWindow. On GTK3 it's
a proper interface; on GTK2 it was signals only.
Basically, what you usually would do is simply create a ScrolledWindow with
passing `NULL` as the adjustments, and let GTK do it's thing when you add the
child widget.
So, basically you could just use `gtk_scrolled_window_new(NULL, NULL)` followed
by `gtk_container_add()` in bot GTK2 and GTK3.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#discussion_r239191008
Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)
b4n commented on this pull request. > @@ -1048,12 +1068,24 @@ void debug_init(void) NULL); grantpt(pty_master); unlockpt(pty_master); +#if GTK_CHECK_VERSION(3, 0, 0) + pty = vte_pty_new_foreign_sync(pty_master, NULL, NULL); + vte_terminal_set_pty(VTE_TERMINAL(terminal), pty); + g_object_unref(pty); + scrollbar = gtk_scrollbar_new(GTK_ORIENTATION_VERTICAL, gtk_scrollable_get_vadjustment(GTK_SCROLLABLE(terminal))); + gtk_widget_set_can_focus(GTK_WIDGET(scrollbar), FALSE); +#else vte_terminal_set_pty(VTE_TERMINAL(terminal), pty_master); scrollbar = gtk_vscrollbar_new(GTK_ADJUSTMENT(VTE_TERMINAL(terminal)->adjustment)); GTK_WIDGET_UNSET_FLAGS(scrollbar, GTK_CAN_FOCUS); Yes I'm talking about `gtk_widget_set_can_focus()` I don't really know about the PTY stuff, but it seem that it has indeed to be different with VTE2.91. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/791#discussion_r239192027
