Re: [Github-comments] [geany/geany-plugins] scope: moved some initializations behind parameter checks in 'scptreestore.c' (#827)

2019-02-20 Thread Colomban Wendling
This is not really the right fix, `g_return_*if_fail()` is supposed to catch programming error, to check the contract between the caller and the callee. Admittedly here the values are accessed before the contract is checked, which is probably worth fixing, but the bug itself is that these

Re: [Github-comments] [geany/geany-plugins] scope: Improved evaluation on-hover (#823)

2019-02-20 Thread Colomban Wendling
Just from the top of my head, wouldn't it be better to evaluate `structa` when over `structa`, and `structa->item1` when over `item1`? I think it's reasonably useful to be able to get the evaluation of a part of the expression, here the parent. Also if you wanted to be thorough, the C and C++

Re: [Github-comments] [geany/geany-plugins] scope: moved some initializations behind parameter checks in 'scptreestore.c' (#827)

2019-02-20 Thread LarsGit223
I will try to find the trouble source. Anyway I would like to keep the existing changes for better stability in case of an error. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] scope: Improved evaluation on-hover (#823)

2019-02-20 Thread LarsGit223
> Just from the top of my head, wouldn't it be better to evaluate `structa` > when over `structa`, and `structa->item1` when over `item1`? Yes, good idea. I'll try to implement that. > Also if you wanted to be thorough, the C and C++ syntax allows for any kind > of spaces between `structa`,

Re: [Github-comments] [geany/geany-plugins] scope: prevent usage of invalid iters (GtkTreeeIter) (#827)

2019-02-20 Thread LarsGit223
Done. The wrong call came from ```stack_entry()``` because of not checking the result of ```gtk_tree_selection_get_selected()```. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Fix for #1764: Brace highlighting if virtual spaces are enabled (#1767)

2019-02-20 Thread van-de-bugger
Closed #1767. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1767#event-2153510009

Re: [Github-comments] [geany/geany] Fix for #1764: Brace highlighting if virtual spaces are enabled (#1767)

2019-02-20 Thread van-de-bugger
@van-de-bugger pushed 1 commit. 0ded9a34031b46acf5148ee97ec53f170d889e91 Field width in statusbar template -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] find and replace broken (#2091)

2019-02-20 Thread terauck21
Version is Geany 1.34. Accepting to wrap search results in the string NOT being found although there are many instances in the document. No, I didn't check _Search backwards_. Somehow _Match only a whole word_ **was** checked; unchecking it led to a correct result. The report is in error.