@b4n pushed 1 commit.
37647e32ca6861f7d06000d8acf8f8f8e079a405 Distribute new documentation image
--
View it on GitHub:
https://github.com/geany/geany/pull/3593/files/d2186cccddf8a885eae0ccb7c894564f1ac669a0..37647e32ca6861f7d06000d8acf8f8f8e079a405
You are receiving this because you are
@b4n commented on this pull request.
On doc/images/edit_change_history.png:
@eht16 I took the liberty to push to this PR with the fix above.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#discussion_r1364648967
You are receiving this because
Thanks Neil, that could explain the difference between GTK2 (Scintilla 3.5)
Geany and GTK3 current git (Scintilla 5.3.7) Geany.
As I said above, the images posted by the OP show the current aliasing to be
more correct than the GTK2 version which never seems to alias both sides of the
@eht16 Thank you, I have checked, this is exactly the place where font starts
to be blurry. I tried SciTE with `scite "-font.base=font:Monospace
Regular,size:12"` and compared Geany, SciTE, Gedit.
![geany22](https://github.com/geany/geany/assets/4203047/1619e246-41f9-4fbc-a403-5642f50d8442)
> Let's just cross fingers and hope Debian does something about it, and nobody
> else is shipping a broken Adwaita icon theme… or that none of our user
> actually use the broken ones.
No chance unless Murphy goes on holidays :smiling_imp:
--
Reply to this email directly or view it on GitHub:
@smostertdev @frlan This makes translations actually work in several places
(prefs dialog, keybindings list, Nth line dialog)
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1286
-- Commit Summary --
* lineoperations: Fix
Agreed, it grew way too out of hand to be merged less than 24 hours before the
deadline.
And I agree with @elextr that it likely requires more testing than just hoping
every other distro is shipping a well-behaving theme (better behaving than
Debian's Adwaita 43) by default, although @techee
Closed #3610 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3610#event-10700778434
You are receiving this because you are subscribed to this thread.
Message ID:
@poluyan just to remind you, "Monospace" is not a font, it is an alias for one.
Use `fc-match monospace` to find out which one so you can avoid it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3610#issuecomment-1769561652
You are receiving this
@hieeupomalrf pushed 1 commit.
6104d0007a6df4ed3f601e55080475d3066a add R execution command
--
View it on GitHub:
https://github.com/geany/geany/pull/3607/files/480e17ae6aa08b23b034ab4e9255259c4669c0f7..6104d0007a6df4ed3f601e55080475d3066a
You are receiving this because you are
I'm gonna postpone that as discussed in #3614, although it might come back to
bite us.
Or we mention it somewhere in the announcement email? @eht16 :laughing:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3613#issuecomment-1769501953
You are
Postponing as it's a bit late now. Should probably be merged soon after
release though.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3396#issuecomment-1769503371
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n requested changes on this pull request.
New image is missing from the build system. Otherwise I didn't check all PR
and issue references, but looks good! :+1:
On doc/images/edit_change_history.png:
This is not installed!
```diff
diff --git a/doc/Makefile.am b/doc/Makefile.am
index
@b4n approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#pullrequestreview-1686329485
You are receiving this because you are subscribed to this thread.
Message ID:
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1287
-- Commit Summary --
* Small update of the French translation
-- File Changes --
M po/fr.po (232)
-- Patch Links --
@frlan Ideally this could make it to 2.0 as it would extend translation and is
fairly trivial, but if it doesn't because it's way too late for this nothing
new breaks.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1286#issuecomment-1769587343
@smostertdev approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1286#pullrequestreview-1686433659
You are receiving this because you are subscribed to this thread.
Message ID:
The whole value 9 doesnt fit into the entry which looks ugly and, to
me, somehow a rounded value like 1000 (which is still sufficient in terms of
unlimited number of characters in a tab) looks more pleasing.
Im adding this nit-picky change for consideration for 2.0 since it should
be
@eht16 commented on this pull request.
On doc/images/main_window.png:
Ok, so it's just getting bigger again. I pushed a variant with similar
dimensions as @b4n's demo.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#discussion_r1363460371
You
Although I might have chosen , 1000 is fine, and after all its the default,
not the maximum the user can set. So LGBI.
An aside:
@eht16 congrats the Windows CI is working again. Interesting to see the
relative speeds, meson/ninja vs Autotools/gmake vs Autotools in a container.
--
Reply
@eht16 commented on this pull request.
> +.. image:: ./images/edit_change_history.png
+
+The image shows the default visuals:
+
+* inserted characters appear with coloured underlines
+* points where characters were deleted are shown with small triangles
+* the margin shows a block indicating
> I don't use the plugin's sidebar BTW - I haven't even noticed that there is
> one till now.
Just curious - what are you using the plugin for then?
> I'd also be fine with an option to disable to plugin/directory traversal on a
> per project basis
I can do that - IMO that makes more sense
> Perhaps after the first screenshot add "Screenshots in the document are the
> default GTK Adwaita theme, but Geany will adapt to the desktop GTK theme that
> is set."
Done.
--
Reply to this email directly or view it on GitHub:
@eht16 pushed 2 commits.
86754ddaf839503681e6f3939424883ed3e1d97d Update main window screenshot
50f76291b2e9b3ff55fe655109d532ed221f46a1 Add note about screenshots GTK theme
--
View it on GitHub:
That looks like Gtk2 vs Gtk3 difference
Geany / Gtk2
![geany-gtk2](https://github.com/geany/geany/assets/15620168/85ce8d60-5d55-40af-ba27-5fcded9db83e)
Geany / Gtk3
![geany-gtk3](https://github.com/geany/geany/assets/15620168/186a4a91-2228-4a85-8a23-12963f0052a7)
--
Reply to this email
BTW, what's the unit of the setting? pixels, chars, apples?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3612#issuecomment-1768237069
You are receiving this because you are subscribed to this thread.
Message ID:
Subset of a possible fix:
```diff
diff --git a/src/build.c b/src/build.c
index 56ec9d613..3d94a683f 100644
--- a/src/build.c
+++ b/src/build.c
@@ -1898,7 +1898,7 @@ static RowWidgets *build_add_dialog_row(GeanyDocument
*doc, GtkTable *table, gui
GTK_FILL | GTK_EXPAND,
> otherwise we might get flooded with bug reports regarding this problem and we
> might have to make a new release because of it anyway.
Yeah that's kind of my point, whomever fault it is, some of it will land on us.
And it still might, as if you install Geany from Debian under GNOME in
Regardless of whether it is an Adwaita icon theme bug (I just tried with other
icon themes and apart from the Adwaita one, all work well), I think if the
patch is as simple as you propose (possibly covering more instances), we should
do it - otherwise we might get flooded with bug reports
@techee approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#pullrequestreview-1685192114
You are receiving this because you are subscribed to this thread.
Message ID:
Following up https://github.com/geany/geany/pull/3593#issuecomment-1757592993,
should we do something about it on our end? Basically the solution is to use
`edit-clear-symbolic` icon-name instead of `GTK_STOCK_CLEAR`, which is for most
of it easy, for some a bit more involved.
* is it our
> Looks good to me based on the code itself and I think it could go to 2.0. I
> just haven't tested it yet (which I'm going to do now).
I just tested it and, yes, it is fixed, and, yes, the re-arrangement is really
annoying without this patch so I think it should go to 2.0. (Somehow, I didn't
> I can do that - IMO that makes more sense than ignoring the whole project
> based on the ignored directory patterns.
But using patterns allows the plugin to autoselect which projects to disable
since it can distinguish between `project1_dir/remote` (which is the slow
remote mount) and
> BTW, what's the unit of the setting? pixels, chars, apples?
The tooltip of the entry says "Characters to be visible on the tab label of the
file". While it's a bit inaccurate wrt international text as @b4n noted, it's
probably fine for "normal" projects and files.
--
Reply to this email
Merged #3612 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3612#event-10692845087
You are receiving this because you are subscribed to this thread.
Message ID:
> @eht16 @techee @elextr I added that to %2.0, but if it's not new since 1.38
> and you don't feel it's simple enough, we can postpone. It's actually not a
> problem with the default settings, so it's less bad -- although any sane
> person would have enabled the problematic option
Looks good
@b4n approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3612#pullrequestreview-1684973051
You are receiving this because you are subscribed to this thread.
Message ID:
Comparing GTK2 and GTK3 was not your initial issue.
Possibilities:
1. GTK2 and GTK3 do not render the same, quite likely, they are different and
likely have different versions of Pango and harfbuzz the two libraries that
actually convert font info to pixels.
2. The fonts are not the same, or
@eht16 @techee @elextr I added that to %2.0, but if it's not new since 1.38 and
you don't feel it's simple enough, we can postpone. It's actually not a
problem with the default settings, so it's less bad -- although any sane person
would have enabled the problematic option :grin:
--
Reply
> But using patterns allows the plugin to autoselect which projects to disable
> since it can distinguish between project1_dir/remote (which is the slow
> remote mount) and project2_dir/local (which is fast local storage).
But I think the problem (if I understand it correctly) is, that when you
@kugel- @techee looks like it's code points if cursory reading is to be trusted
(looks like it's based on `g_utf8_strlen()`).
Anyway, LGBI and agree that it's not pretty in the prefs dialog as is.
--
Reply to this email directly or view it on GitHub:
@b4n commented on this pull request.
On doc/images/main_window.png:
@eht16 yeah… is it a problem in the generated file?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#discussion_r1363823645
You are receiving this because you are subscribed to
> BTW, what's the unit of the setting? pixels, chars, apples?
Good question, probably glyphs if its done by GTK, or bytes if its done by
Geany :-)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3612#issuecomment-1768271762
You are receiving this
@b4n commented on this pull request.
> +Screenshots in the document are the default GTK Adwaita theme,
+but Geany will adapt to the desktop GTK theme that is set.
```suggestion
Screenshots in this document are taken with the default GTK Adwaita
theme, but Geany will adapt to
@eht16 approved this pull request.
Tested and works cleanly.
I'm all in for merge.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#pullrequestreview-1685997547
You are receiving this because you are subscribed to this thread.
Message ID:
@kugel- commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
@b4n commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
+
> And having added the feature back then, I can tell you I didn't plan for this
> :)
Alright, I am convinced it's a bug now :-)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#issuecomment-1769240269
You are receiving this because you are
@kugel- commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
Great, that you have it reported on Debian.
And good to know that newer versions of the theme do not expose this bug.
Debian users could probably even install the Sid package (judged from the
direct dependencies which should be possible).
Back to Geany: I fully agree with what @techee said.
@frlan commented on this pull request.
> +Addons:
+* Bookmarks: Prevent duplicating bookmarks when editing line (PR #1040)
+* Delay updating of tasks list until document has been colorised
+ (Issue #1254, PR #1257)
+
+GeanyLua:
+* Update documentation for
@eht16 commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
@eht16 pushed 1 commit.
0167607f2f7124dd285cf088ad0f6e0182b2c4b2 fixup! Add NEWS for Geany-Plugins 2.0
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1285/files/436e514c1139b6738f617b8441f990c39ed7aa12..0167607f2f7124dd285cf088ad0f6e0182b2c4b2
You are receiving this because
This needs to be tested on a wide range of distros, not just Debian, and not
just Gnome, Cinnamon, XFCE, etc and Windows.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3614#issuecomment-1769312752
You are receiving this because you are subscribed to
@eht16 looks like there has been a rebase mishap, and you grabbed some
unrelated things in there :confused:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#issuecomment-1769322566
You are receiving this because you are subscribed to this thread.
GP is less concerning, plugins can be disabled, code in Geany can't.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#issuecomment-1769334983
You are receiving this because you are subscribed to this thread.
Message ID:
> @eht16 looks like there has been a rebase mishap, and you grabbed some
> unrelated things in there
Oops, thanks for notifying. Should be fixed.
I started a first round of squashing the incremental changes and then came
#3611 :).
> You can add #3611 now ;)
Done.
--
Reply to this email
@eht16 pushed 6 commits.
641a09159a047d5df5adaf4b7675aa242e72a101 Add NEWS for Geany 2.0
dbf3c8e0141da0e14a619787c2d14a2aa47130c7 Add documentation for new Scintilla
feature "Change history"
35a208aa24e78887109fa3d1993548492abc516d Update documentation screenshots
@eht16 commented on this pull request.
> +* Update Python filetype config (PR#3039).
+* Add AutoIt filetype (Skif-off, PR#1752).
+* Add GDScript filetype (David Yang, PR#3012).
+* Remove Ferite filetype (PR#3075).
+* Enable local variables and improve autocompletion for
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#issuecomment-176945
You are receiving this because you are subscribed to this thread.
Message ID:
Actually if it's like this in 1.38 already (and possibly earlier) I see no
compelling reason to rush this into 2.0, considering that tomorrow is release.
It's not even clear to me if this is even a bug (as on "not working as
intended"). I surely never used that pref.
--
Reply to this email
@kugel-
> It's not even clear to me if this is even a bug (as in "not working as
> intended"). I surely never used that pref.
Well, to me it's definitely a bug as the session is *not* restored as it was
saved. Both documents order and current document are lost (well, current
document is OK
@kugel- commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
@eht16 pushed 1 commit.
8ac78832fb7e758784ed65dc50eb7ad766ba9eaf Update doc/geany.txt
--
View it on GitHub:
https://github.com/geany/geany/pull/3593/files/143f8e399684624dbf3b5f0147209ce9f1bd628d..8ac78832fb7e758784ed65dc50eb7ad766ba9eaf
You are receiving this because you are subscribed to
You guys like to have me updating screenshots I guess...
The screenshot for the prefs dialog with the changed default for the tab label
length is updated for 1000 chars, pixels, apples, Euros :smile:.
--
Reply to this email directly or view it on GitHub:
> An aside: @eht16 congrats the Windows CI is working again. Interesting to see
> the relative speeds, meson/ninja vs Autotools/gmake vs Autotools in a
> container.
Comparing Meson vs Autotools was already possible before. The Windows CI builds
should be excluded from such comparisons because
@eht16 pushed 2 commits.
1e9296bee0715464482b0784e0e68cd2f8fc768f Updated translations
436e514c1139b6738f617b8441f990c39ed7aa12 Merge pull request #1 from
frlan/release_2_0_documentation
--
View it on GitHub:
@b4n commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
+
@techee commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
@eht16 approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#pullrequestreview-1686111258
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 commented on this pull request.
> +Addons:
+* Bookmarks: Prevent duplicating bookmarks when editing line (PR #1040)
+* Delay updating of tasks list until document has been colorised
+ (Issue #1254, PR #1257)
+
+GeanyLua:
+* Update documentation for
Thanks everyone for the detailed answers! I just tested geany 1.38 (2022-05-01)
from the official arch repo. The font there looks "sharp" as I wanted. It uses
GTK+ v3.24.38, the same one I used building latest commit version from source.
I tested geany with gtk2 too, font is sharp. I have to do
@b4n pushed 1 commit.
4246298dd8b3c70528cdad0554000f5d54f39765 Fix startup files order when placing
tabs next to the current one
--
View it on GitHub:
https://github.com/geany/geany/pull/3611/files/0e0b33b5b8f2e858c06ea91128331f7d2252c15b..4246298dd8b3c70528cdad0554000f5d54f39765
You are
I didn't understand the issue completely yet but anyway maybe it's worth to try
SciTE (https://archlinux.org/packages/extra/x86_64/scite/) to check whether it
has the same problem.
If so, it is very likely related to Scintilla. If not, it may or may not be
related to Scintilla.
@poluyan when
Try the merges that change Scintilla versions first.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3610#issuecomment-1769315440
You are receiving this because you are subscribed to this thread.
Message ID:
(I just squashed the commits and rebased on master, will now merge)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#issuecomment-1769315976
You are receiving this because you are subscribed to this thread.
Message ID:
Heh, overlapping comments
Great minds think alike :-)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3610#issuecomment-1769315999
You are receiving this because you are subscribed to this thread.
Message ID:
At least GTK seems to have a test for these icon names so I think their
presence is kind of required:
https://gitlab.gnome.org/GNOME/gtk/-/blob/main/testsuite/gtk/check-icon-names.c
--
Reply to this email directly or view it on GitHub:
Merged #3611 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#event-10699097461
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3609 as completed via 4246298dd8b3c70528cdad0554000f5d54f39765.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3609#event-10699097436
You are receiving this because you are subscribed to this thread.
Message ID:
What bad things should happen? @b4n committed (this is without any irony!).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#issuecomment-1769324008
You are receiving this because you are subscribed to this thread.
Message ID:
@techee Ah yeah those names are common indeed. And cool, if they are required
by GTK itself, it's indeed very likely to be present, or at least work fine if
not (e.g. falling back on the non-symbolic version) :+1:
--
Reply to this email directly or view it on GitHub:
@eht16 pushed 4 commits.
b73b29b90cc1e1526ea77096d59953610777d2d6 Add NEWS for Geany 2.0
6a61051feccacb0698308d256d29f787bff4705c Add documentation for new Scintilla
feature "Change history"
f90c81347d9542c85bc6aeddbabc6becc7b4311c Update documentation screenshots
@eht16 pushed 1 commit.
85febd1e301506e8a22cedcc4eb177dd919719c5 Document Change History is disabled
by default
--
View it on GitHub:
https://github.com/geany/geany/pull/3593/files/e35069844226d60456eb397e6095116b099eb74a..85febd1e301506e8a22cedcc4eb177dd919719c5
You are receiving this
@eht16 commented on this pull request.
> +.. image:: ./images/edit_change_history.png
+
+The image shows the default visuals:
+
+* inserted characters appear with coloured underlines
+* points where characters were deleted are shown with small triangles
+* the margin shows a block indicating
@elextr commented on this pull request.
> +* Update Python filetype config (PR#3039).
+* Add AutoIt filetype (Skif-off, PR#1752).
+* Add GDScript filetype (David Yang, PR#3012).
+* Remove Ferite filetype (PR#3075).
+* Enable local variables and improve autocompletion for
I just did a quick rescan, raised one question, not critical just ignore if
stupid :-)
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3593#issuecomment-1769368276
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 pushed 1 commit.
143f8e399684624dbf3b5f0147209ce9f1bd628d Update screenshots
--
View it on GitHub:
https://github.com/geany/geany/pull/3593/files/50f76291b2e9b3ff55fe655109d532ed221f46a1..143f8e399684624dbf3b5f0147209ce9f1bd628d
You are receiving this because you are subscribed to this
> although any sane person would have enabled the problematic option
@b4n Hah, it seems you have proven me as crazy again, my config says
`tab_order_beside=false` :)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#issuecomment-1769221517
You are
> It's not even clear to me if this is even a bug (as in "not working as
> intended"). I surely never used that pref.
I hardly can imagine this could be intended behaviour. After start, the
previous code opened the tabs in some random (maybe not really random but in
some for the user
> You guys like to have me updating screenshots I guess...
Nah, it could have totally stayed the way it was.
> The screenshot for the prefs dialog with the changed default for the tab
> label length is updated for 1000 chars, pixels, apples, Euros .
We are aiming for 1000 screenshot updates
@b4n pushed 1 commit.
0e0b33b5b8f2e858c06ea91128331f7d2252c15b fixup! Fix startup files order when
placing tabs next to the current one
--
View it on GitHub:
https://github.com/geany/geany/pull/3611/files/7ff00f56af24fe1ea9013c9d3b64e14d6dce5f76..0e0b33b5b8f2e858c06ea91128331f7d2252c15b
You
@b4n commented on this pull request.
>
/* necessary to set it to TRUE for project session support */
main_status.opening_session_files++;
- i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1);
- while (TRUE)
+ file_prefs.tab_order_beside = FALSE;
+
> Might there be any risk that other themes may not work well with the changed
> icon references? I guess this is hard to answer; the icon loading mechanism
> are big mystique to me and so I'm just wondering how much we could break with
> this change.
Well, I'm not 100% sure, but I think yes,
> Might there be any risk that other themes may not work well with the changed
> icon references? I guess this is hard to answer; the icon loading mechanism
> are big mystique to me and so I'm just wondering how much we could break with
> this change.
Just speculating but
@techee symbolic icons has nothing to do with using icon names rather than
stock items, apart that stock items don't use symbolic icons.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3613#issuecomment-1769305818
You are receiving this because you
See #3613.
Some of the changes here make sense, some dont really but are still needed
not to look terrible with Adwaita 43. See each commit for details.
@techee @eht16 thats kind of how it looks to dodge the Adwaita 43 issues I
could see.
You can view, comment on, or merge this pull request
See #3614
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3613#issuecomment-1769309119
You are receiving this because you are subscribed to this thread.
Message ID:
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1285#issuecomment-1769317238
You are receiving this because you are subscribed to this thread.
Message ID:
FFS STOP THE LAST MINUTE MERGING!!
The CI ddin't even finish here.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3611#issuecomment-1769320995
You are receiving this because you are subscribed to this thread.
1 - 100 of 111 matches
Mail list logo