For the information of people who read this issue in the future.
It is mentioned above that some developers won't use Geany as root because of
the risks. But it was not explained what the risk is.
The risk is because, as Geany is an IDE, it has the capability to run random
commands, and as it
codebrainz commented on this pull request.
> @@ -554,6 +554,24 @@ void plugin_builder_connect_signals(GeanyPlugin *plugin,
}
+/** Get the additional data that corresponds to the plugin.
+ *
+ * @param plugin The plugin provided by Geany
+ * @return The data corresponding to the plugin or
elextr commented on this pull request.
> @@ -554,6 +554,24 @@ void plugin_builder_connect_signals(GeanyPlugin *plugin,
}
+/** Get the additional data that corresponds to the plugin.
+ *
+ * @param plugin The plugin provided by Geany
+ * @return The data corresponding to the plugin or @c
codebrainz commented on this pull request.
> @@ -554,6 +554,24 @@ void plugin_builder_connect_signals(GeanyPlugin *plugin,
}
+/** Get the additional data that corresponds to the plugin.
+ *
+ * @param plugin The plugin provided by Geany
+ * @return The data corresponding to the plugin or
elextr commented on this pull request.
Guess its reasonable to get the data you set :)
> @@ -554,6 +554,24 @@ void plugin_builder_connect_signals(GeanyPlugin *plugin,
}
+/** Get the additional data that corresponds to the plugin.
+ *
+ * @param plugin The plugin provided by Geany
+ *
Ammended to add `@see geany_plugin_set_data()` reference.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1234#issuecomment-247819073
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/1234
-- Commit Summary --
* Allow plugins to get the data they set
-- File Changes --
M src/plugindata.h (1)
M src/pluginutils.c (16)
-- Patch Links --
elextr commented on this pull request.
LGBI
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1224#pullrequestreview-466340
elextr approved this pull request.
LGTM
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223#pullrequestreview-466296
If there are no objections, I will merge this "soon".
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1223#issuecomment-247817103
If there are no objections, I will merge this "soon".
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1222#issuecomment-247817083
If there are no objections, I will merge this "soon".
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1224#issuecomment-247817059
Properly restore the BOM in the document buffer before diffing it against the
Git buffer, not to diff the missing BOM.
Fixes #482.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/483
-- Commit Summary --
* git-changebar: Fix
If a UTF-8 file starts with a BOM character, the changebar plugin always shows
the first line as changed even if there is no change.
To reproduce this, create a file with some lines of text, set encoding to UTF-8
and set "Document -> Write Unicode BOM"; save the file and git add and commit.
14 matches
Mail list logo
