Re: [Github-comments] [geany/geany] Proxy Plugins Filename Pattern Matching (#1236)

[Matthew Brush]

I would be useful to have it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1236#issuecomment-330416075

Re: [Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

[Matthew Brush]

codebrainz commented on this pull request.



> @@ -2394,7 +2394,7 @@ typedef struct
 } SelectionRange;
 
 
-#define CURSOR_PLACEHOLDER "_" /* Would rather use … but not all docs are 
unicode */
+#define CURSOR_PLACEHOLDER "..." /* Would rather use … but not all docs are 
unicode */

> What do other editors insert when you save a file containing the placeholder?

IIRC XCode and QtCreator enter some kind of special placeholder-filling mode 
where you can tab between them and fill them out, and then you commit them.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#discussion_r139588478

Re: [Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

[Matthew Brush]

codebrainz commented on this pull request.



> @@ -2394,7 +2394,7 @@ typedef struct
 } SelectionRange;
 
 
-#define CURSOR_PLACEHOLDER "_" /* Would rather use … but not all docs are 
unicode */
+#define CURSOR_PLACEHOLDER "..." /* Would rather use … but not all docs are 
unicode */

> I guess yeah ideally the placeholder wouldn't be any actual character but 
> simply a display thing, but I'm not sure Scintilla allows for this, does it?

Since the placeholders are marked with a (presumably) unique indicator, there's 
no reason they couldn't be removed from the saved contents (mere matter of 
programming).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#discussion_r139588429

Re: [Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

[elextr]

If the placeholder is a string that will get saved it has to be something that 
will save in all encodings since the user can select that at save time, hence 
@kugel- used ASCII.

But actually adding ANY characters to the buffer may result in illegal syntax.  
It would be better if the placeholder was not inserted at all.  

What about using the `INDIC_POINT` indicator at the relevant positions?  That 
seems to be the only one that marks a position not a character.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#issuecomment-330404890

Re: [Github-comments] [geany/geany] Allow plugins to get the data they set (#1234)

[elextr]

Closed #1234.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1234#event-1254568007

Re: [Github-comments] [geany/geany] Colors (#1604)

[elextr]

> 'xed' has its' own configurationsI was able to edit the XML for that to get 
> it to do what I wanted.
'm
For me on Linux Mint Cinnamon both GTK2 Geany and GTK3 Geany and Xed follow the 
selected desktop theme.  A majority of developers seem to think this is the 
"right thing" to do.

If you don't want an application to follow the theme you can have your own 
settings for the application in your personal GTK settings.

For GTK2 Geany the widget colours can be customised for specific apps using the 
selectors that are noted in the Geany manual in `~/.config/gtk2.0/.gtkrc`.

For GTK3 Geany colours can be customised for specific applications using the 
CSS based syntax in `~/.config/gtk3.0/gtk.css`

There is lots of guidance on how to use the GTK theming available on the web.

But desktop themes don't have settings for programming language syntactic 
elements, thats why Geany has its own filetype specific theming just for the 
editing window.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1604#issuecomment-330402361

Re: [Github-comments] [geany/geany] Allow plugins to get the data they set (#1234)

[Thomas Martitz]

@codebrainz @elextr this can be closed (was commited to master as 
7261742f8169b19fd5ac7f10a0845a684287e2d9)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1234#issuecomment-330367446

Re: [Github-comments] [geany/geany] Proxy Plugins Filename Pattern Matching (#1236)

[Thomas Martitz]

@codebrainz are you still interested in this? Otherwise we can close this, 
right?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1236#issuecomment-330366690

Re: [Github-comments] [geany/geany] Keep the current tab when closing documents to the right of another tab (#1579)

[Colomban Wendling]

Merged #1579.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1579#event-1254173622

Re: [Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

[Colomban Wendling]

b4n commented on this pull request.



> @@ -2394,7 +2394,7 @@ typedef struct
 } SelectionRange;
 
 
-#define CURSOR_PLACEHOLDER "_" /* Would rather use … but not all docs are 
unicode */
+#define CURSOR_PLACEHOLDER "..." /* Would rather use … but not all docs are 
unicode */

I guess yeah ideally the placeholder wouldn't be any actual character but 
simply a display thing, but I'm not sure Scintilla allows for this, does it?  
It would need be able to have an indicator that takes more room than the range 
it's on, which doesn't sounds likely, but I might miss an existing feature.

Otherwise for what the placeholder is I don't care that much; I just didn't 
feel like `_` looked straightforward to me when using the thing, but I don't 
have a string opinion either.  I still feel like 
https://github.com/geany/geany/commit/957b49b868214a4aea81641dedeabb98a497e4c1#commitcomment-23346900,
 but if the consensus is to keep `_` I won't argue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#discussion_r139496331

Re: [Github-comments] [geany/geany] Colors (#1604)

[caltrop-3]

Linux Mint Mate edition.

'xed' has its' own configurationsI was able to edit the XML for that to get it 
to do what I wanted.
'mate-terminal' is customizable from the preferences, though the colors are not 
labeled and take some experimentation.



I like a dark background, uses less poser too, and it has always been an issue 
getting the colours right no matter the Operating System. I quit Micro$oft and 
am totally Linux now and liking it better every day.
I have been enjoying your IDE. I have not done any 'C' programming for many 
years since I was at University. Nothing but Java Script and VBA for M$ Office 
for the last 15 years.


  From: Matthew Brush 
 To: geany/geany  
Cc: caltrop-3 ; Mention 
 Sent: Monday, September 18, 2017 12:35 PM
 Subject: Re: [geany/geany] Colors (#1604)
   

Many apps allow changing the default theme colours which is what my question is 
about.
Can you give some examples of this, preferably GTK+ apps so we can steal their 
code :)—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.  

   

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1604#issuecomment-330283725

Re: [Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

[Thomas Martitz]

kugel- commented on this pull request.



> @@ -2394,7 +2394,7 @@ typedef struct
 } SelectionRange;
 
 
-#define CURSOR_PLACEHOLDER "_" /* Would rather use … but not all docs are 
unicode */
+#define CURSOR_PLACEHOLDER "..." /* Would rather use … but not all docs are 
unicode */

They are, in fact, inserted literally into the buffer. This is required for 
Scintilla markers. Since we don't currently filter the document upon save, they 
are also saved to the file.

What do other editors insert when you save a file containing the placeholder?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#discussion_r139477387

Re: [Github-comments] [geany/geany] Colors (#1604)

[Matthew Brush]

> Many apps allow changing the default theme colours which is what my question 
> is about.

Can you give some examples of this, preferably GTK+ apps so we can steal their 
code :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1604#issuecomment-330279918

Re: [Github-comments] [geany/geany] Keep the current tab when closing documents to the right of another tab (#1579)

[Matthew Brush]

codebrainz approved this pull request.

Seems reasonable to me. I haven't tested yet.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1579#pullrequestreview-63411159

Re: [Github-comments] [geany/geany] Keep the current tab when closing documents to the right of another tab (#1579)

[Matthew Brush]

codebrainz commented on this pull request.



>   gint doc_page = document_get_notebook_page(doc);
for (gint i = doc_page + 1; i < gtk_notebook_get_n_pages(nb); )
{
if (! document_close(document_get_from_page(i)))
i++; // only increment if tab wasn't closed
}
-   gtk_notebook_set_current_page(nb, doc_page);
+   gtk_notebook_set_current_page(nb, MIN(current_page, doc_page));

Would've saved me a couple minutes of head-scratching if there was a comment 
that said "keep the current tab unless it was closed, in which case use the 
activated tab" or something. Maybe I'm just stupid.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1579#pullrequestreview-63410944

Re: [Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

[Matthew Brush]

codebrainz commented on this pull request.



> @@ -2394,7 +2394,7 @@ typedef struct
 } SelectionRange;
 
 
-#define CURSOR_PLACEHOLDER "_" /* Would rather use … but not all docs are 
unicode */
+#define CURSOR_PLACEHOLDER "..." /* Would rather use … but not all docs are 
unicode */

Shouldn't the placeholders not be saved since they aren't meant to be literally 
inserted into the document? IIRC other editors I've tried that do this (namely 
XCode and QtCreator) don't treat placeholders as text in the document, but 
rather just as a graphical cue for where you'll bounce when tabbing to the next 
placeholder in the edit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#discussion_r139470658

Re: [Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

[Thomas Martitz]

kugel- commented on this pull request.



> @@ -2394,7 +2394,7 @@ typedef struct
 } SelectionRange;
 
 
-#define CURSOR_PLACEHOLDER "_" /* Would rather use … but not all docs are 
unicode */
+#define CURSOR_PLACEHOLDER "..." /* Would rather use … but not all docs are 
unicode */

I had that before. Since nothing prevents you from saving a doc containing the 
placeholders, I didn't want to enforce utf8 for saved files.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#discussion_r139469259

Re: [Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

[Matthew Brush]

codebrainz commented on this pull request.



> @@ -2394,7 +2394,7 @@ typedef struct
 } SelectionRange;
 
 
-#define CURSOR_PLACEHOLDER "_" /* Would rather use … but not all docs are 
unicode */
+#define CURSOR_PLACEHOLDER "..." /* Would rather use … but not all docs are 
unicode */

Why not use Unicode ellipsis? All documents are UTF-8 in memory and since 
placeholders markers shouldn't ever be saved (they aren't actual contents of 
the document), it seems like it would work fine.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#discussion_r139468869

Re: [Github-comments] [geany/geany] Colors (#1604)

[caltrop-3]

Probably going to have to dig into the Desktop Theme to get the colours to 
change.
Many apps allow changing the default theme colours which is what my question is 
about.Horrid trying to view some of the default Geany colours in the side panes 
with the default theme colour.

This has nothing to do with Plug-Ins but Geany itself.


  From: elextr 
 To: geany/geany  
Cc: caltrop-3 ; Mention 
 Sent: Thursday, September 14, 2017 9:28 PM
 Subject: Re: [geany/geany] Colors (#1604)
   
The "project" tabs in the sidebar are created by plugins, they are not part of 
base Geany. Try disabling all the project plugins and see if they go away. Note 
I don't think that the various project plugins are made to work together, just 
choose one. The project plugins are part of the geany-plugins project so any 
suggestions or problems with them should be reported there.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.  

   

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1604#issuecomment-330268887

Re: [Github-comments] [geany/geany] Feature/reload all (#1471)

[attila-v]

It is working like the simple reload function: if the focus is on the unsaved 
document, then both functions reload it (and send message to the status); but 
if the focus is on the other document, then does not happen anything with 
unsaved document. When unsaved document reloaded, you can undo it to the 
unsaved status of course (if the 'keep_edit_history_on_reload' box is checked 
in the Preferences).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1471#issuecomment-330220418

Re: [Github-comments] [geany/geany] Feature/reload all (#1471)

[Thomas Martitz]

I agree it should nit reload unsaved files, at least by default. Is this 
implemented?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1471#issuecomment-330137359

Re: [Github-comments] [geany/geany] Keep the current tab when closing documents to the right of another tab (#1579)

[Thomas Martitz]

LGBI, I support this change as it implements the expected behaviour 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1579#issuecomment-330136787

Re: [Github-comments] [geany/geany] Follow up fixes for PR#1456 (#1578)

[elextr]

LGTM, @codebrainz?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1578#issuecomment-330136383

Re: [Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

[Thomas Martitz]

kugel- commented on this pull request.



> @@ -2394,7 +2394,7 @@ typedef struct
 } SelectionRange;
 
 
-#define CURSOR_PLACEHOLDER "_" /* Would rather use … but not all docs are 
unicode */
+#define CURSOR_PLACEHOLDER "..." /* Would rather use … but not all docs are 
unicode */

What's the resolution on this? Still not a fan.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#discussion_r139340694

Re: [Github-comments] [geany/geany] Fixes & changes for #1470 (#1554)

[Thomas Martitz]

I still don't really like b9982368 but otherwise looks good.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1554#issuecomment-330135100