[Github-comments] [geany/geany-plugins] travis: Run distcheck as well (#798)

2018-12-03 Thread Colomban Wendling
Here again, I'll let it kick in, fix the issue (as there's one with distcheck 
right now) and then only should it be merged.  The goal is to make sure 
everything's working as it should.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/798

-- Commit Summary --

  * travis: Run distcheck as well

-- File Changes --

M .travis.yml (1)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/798.patch
https://github.com/geany/geany-plugins/pull/798.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/798


Re: [Github-comments] [geany/geany] Add relations between label widgets and labelled widgets (51385f2)

2018-12-03 Thread Colomban Wendling
@codebrainz Yes.  The only trick is that Glade won't let you set a mnemonic 
widget if the label doesn't use underline, so for some of them I had to 
temporarily enable it to be able to set one.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/51385f2a735135eba2e1e0f6243619471e3ccfef#commitcomment-31547214

Re: [Github-comments] [geany/geany] GTK3 Nightly Builds (#2003)

2018-12-03 Thread Colomban Wendling
If we want it should also be possible to build older GTK versions on Travis 
just the same, and with its support for caches, it'd also only have to be built 
once.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2003#issuecomment-443998294

Re: [Github-comments] [geany/geany-plugins] cannot install markdown plugin (#792)

2018-12-03 Thread RuinChristmas
> @RuinChristmas did installing the libwebkit2gtk and development packages work 
> for you?

No, sorry I have not tried that yet but I will.  I installed libwebkitgtk-1.0-0 
and then didn't see your suggestion about the other.  I will give it a shot 
tomorrow.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/792#issuecomment-443956172

Re: [Github-comments] [geany/geany-plugins] cannot install markdown plugin (#792)

2018-12-03 Thread Skif-off
@arielsbecker

Sorry, I use Geany with some patches and I am not sure that it will make you 
happy. But I returned default patches of Debian/Ubuntu packages: [try to 
compile](https://www.upload.ee/files/9263226/geany-133-with-gtk2.zip.html).

P.S. If you will have an error with GeanyLua then try 
[this](https://github.com/geany/geany-plugins/pull/778).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/792#issuecomment-443921016

Re: [Github-comments] [geany/geany] GTK3 Nightly Builds (#2003)

2018-12-03 Thread Matthew Brush
I believe people actually use the Windows nightly binaries, but probably not 
much on other OS.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2003#issuecomment-443916997

Re: [Github-comments] [geany/geany] Add relations between label widgets and labelled widgets (51385f2)

2018-12-03 Thread Matthew Brush
Just to confirm, this was done with Glade 3.8 and not manually or some newer 
version?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/commit/51385f2a735135eba2e1e0f6243619471e3ccfef#commitcomment-31544426

Re: [Github-comments] [geany/geany-plugins] cannot install markdown plugin (#792)

2018-12-03 Thread Ariel S. Becker
> Under Ubuntu 18.04 (Linux Mint 19 is based on 18.04) package 
> `libwebkitgtk-1.0-0` is available (under 18.10 too). I builded and use 
> GTK2-version of Geany + plugins (1.33, I made deb-files) and plugin 
> `geany-plugin-markdown` works fine.

Hi! Do you still have those deb packages? I tried everything to compile, but it 
seems I'm out of luck.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/792#issuecomment-443897922

Re: [Github-comments] [geany/geany] GTK3 Nightly Builds (#2003)

2018-12-03 Thread Enrico Tröger
Hence the proposal to drop the GTK2 builds instead of adding new ones.

OTOH, compiling the whole stack for GTK 2.24 and GTK 3.0 probably isn't the 
hardest thing ever, it just needs to be done. And it needs to be done only once 
we change the minimum required versions or a new Debian version is released 
(because of dist-upgrade and binary incompatibilities). The rebuilding can 
probably be solved easily scripted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2003#issuecomment-443895373

Re: [Github-comments] [geany/geany-plugins] Scope breaks nightly with cppcheck 1.85 (#794)

2018-12-03 Thread Enrico Tröger
> @eht16 how did those builds work before then? Did you update the Debian?

"The Debian" is updated before each build as the Debian nightly builds are 
created in a pbuilder environment which is some sort of a chroot environment 
where all build dependencies are installed into a sane, clean Debian system 
before each build. The build dependencies are read from the `control` file, so 
it's as clean as possible.
What's not exactly clean is our `control` file, it is out-of-sync with Debian 
upstream. I think I will refresh the Debian packaging files after the 1.34 
release.
This could also bring back the Webkit2 GTK3 ready plugins but I would wait for 
this until Debian upstream (upstream is used here regarding the Debian 
packaging files) switches to GTK3.

Or anyone else would provide the Debian packaging files for GTK3 (for Geany and 
G-P). I won't do it myself.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/794#issuecomment-443893674

Re: [Github-comments] [geany/geany] GTK3 Nightly Builds (#2003)

2018-12-03 Thread elextr
Yeah, I saw the benefit of the nightlys that they could use different versions 
of GTK from Travis, but compiling the whole stack seems a bit OTT.

But otherwise they don't add a lot any more.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2003#issuecomment-443892953

Re: [Github-comments] [geany/geany] GTK3 Nightly Builds (#2003)

2018-12-03 Thread Enrico Tröger
Alternatively, we could even remove the GTK2 nightly builds as they are pretty 
much obsoleted by the Travis builds which are run more often and even against 
PRs.
In contrary to the Debian nightly builds, the build results are of no further 
use and so are no better than the Travis builds, IMO.

I see only one advantage over Travis: if we would build the nightlies against 
the minimum required versions of GTK2 and GTK3 to ensure compatibility. But 
this would require compiling the whole GTK2 and GTK3 stack manually to compile 
against (the current GTK2 nightlies are built against the GTK2 stack provided 
by Debian Stable).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2003#issuecomment-443891531

Re: [Github-comments] [geany/geany-plugins] Scope breaks nightly with cppcheck 1.85 (#794)

2018-12-03 Thread elextr
> > I'm going to remove the Webkit related plugins from the Debian builds.

> @eht16 the Markdown plugin should be ok: 4039a13

@codebrainz IIUC the problem is that Debian no longer ships _any_ GTK2 version 
of webkit, so the nightly GTK2 builds using recent Debians fail due to no 
webkit available.

Of course markdown and other webkit based plugins should work when the nightlys 
are built against GTK#

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/794#issuecomment-443891277

Re: [Github-comments] [geany/geany-plugins] Scope breaks nightly with cppcheck 1.85 (#794)

2018-12-03 Thread Matthew Brush
> I'm going to remove the Webkit related plugins from the Debian builds.

@eht16 the Markdown plugin should be ok: 
4039a13882f4b9e2127f6e7b018bdbdffe36e2a2

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/794#issuecomment-443861549

Re: [Github-comments] [geany/geany-plugins] [pair tag highlighter] Pressing the space key selects the whole tag instead of inserting space (#788)

2018-12-03 Thread mad-doctor
I'm closing this issue, the problem was on my side - the space key was assigned 
to "Move cursor in snippet" keyboard shortcut and was causing this behavior.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/788#issuecomment-443693790

Re: [Github-comments] [geany/geany-plugins] [pair tag highlighter] Pressing the space key selects the whole tag instead of inserting space (#788)

2018-12-03 Thread mad-doctor
Closed #788.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/788#event-2001274946

Re: [Github-comments] [geany/geany] Fix 'changed' flag being altered when all documents are closing. (#1857)

2018-12-03 Thread elextr
> They do affect our internal changed flag, as they require saving to take 
> effect; 

Ok, if you set them with the `Document` menu they do set `changed`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1857#issuecomment-443622882

Re: [Github-comments] [geany/geany] Fix 'changed' flag being altered when all documents are closing. (#1857)

2018-12-03 Thread Colomban Wendling
> Those don't affect the buffer, so they shouldn't affect the `changed` flag 
> should they?

They do affect our internal `changed` flag, as they require saving to take 
effect; but they aren't reported by Scintilla's "modified" query because as you 
say they don't affect the buffer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1857#issuecomment-443621243

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

2018-12-03 Thread elextr
> Also, keeping fold state when changing mode is something the app will likely 
> have to do

Especially so in the cases where a buffer close changes the visible hierarchy 
in one of the "smart" modes, thats really something that only Geany can do, not 
GTK.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1813#issuecomment-443621031

Re: [Github-comments] [geany/geany-plugins] Review string "translator_credits" (#587)

2018-12-03 Thread Colomban Wendling
@frlan it's from the bundled Devhelp, but yes, usually these strings are meant 
to be translated, or rather replaced with the credits for that translation: 
it's a mean to show credit for the currently used translation, maintained 
directly inside that translation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/587#issuecomment-443620568