> opening session files takes from 100ms to 300ms per file. IIRC he had similar
> times on Linux und MacOS.
Local files on a normal disk or what? What filetypes? One file, many files?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it
@frlan reported also slowiness on startup. His debug message log indicated the
startup itself is as fast as expected but opening session files takes from
100ms to 300ms per file. IIRC he had similar times on Linux und MacOS.
Besides that, I agree with @elextr: this either needs some detailed
Information from the OPs of those comments/mails about how slow (numbers,
"seems" isn't a measure) and how to reproduce might be useful.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Seems to not be an issue on Linux.
References:
https://github.com/geany/geany/issues/2639#issuecomment-723489800
https://github.com/geany/geany/issues/2639#issuecomment-723494612
https://github.com/geany/geany-osx/issues/20
https://www.mail-archive.com/users@lists.geany.org/msg02989.html
--
You
Merged #1024 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1024#event-3971178480
@ndroock1, @Rasbats and all who still had problems: we've just releases Geany
1.37 (https://github.com/geany/geany/releases/tag/1.37.1) with a fix for the
startup crash.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #2639 via 847a758c054dd1006e53fe2cfbf4c6c5a720d9a6.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2639#event-3971015836
## Windows
* Fix crash on first startup
([Issue#2639](https://github.com/geany/geany/issues/2639),
[PR#2645](https://github.com/geany/geany/pull/2645)).
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/releases/tag/1.37.1
@b4n approved this pull request.
LGTM
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1024#pullrequestreview-525827142
@frlan pushed 1 commit.
2a8969f0f69ba5dba96298a314004d3adfff6300 PrettyPrinter: Fix declaration of
input_buffer
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@b4n True. Will update it
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1024#issuecomment-723589309
@b4n requested changes on this pull request.
The problem is not freeing `input_buffer` which *should* be freed, but that the
`input_buffer` variable shouldn't be `const` (since
3fad1285599766a7932667688871c04610bd8651). The change you propose would lead
to leaking quite a lot of memory.
--
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1024
-- Commit Summary --
* PrettyPrinter: Dont try to free const gchar* input_buffer
-- File Changes --
M pretty-printer/src/PluginEntry.c (4)
-- Patch Links --
I'm on Debian Buster :) I'm not totally sure which dialog you're showing, but
for me e.g. the dialog examples and a couple other that display this kind of
dialogs all come without an image at all.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly
What OS are you using? If it Debian or any non Ubuntu-based distribution then
maybe this problem was born here
https://salsa.debian.org/gnome-team/gtk3/-/tree/ubuntu/focal/debian/patches ?
Rebuilding for all GTK 3 packages only with patchs from Debian will stay last
way of checking :)
--
You
> Maybe problem
> [here](https://github.com/geany/geany-plugins/blob/master/geanylua/glspi_dlg.c#L14):
> `GTK_MESSAGE_OTHER` (without icon) replaced by `GTK_MESSAGE_INFO` (with
> icon)?
Well, IIUC that just aliases `GTK_MESSAGE_OTHER` to `GTK_MESSAGE_INFO` on GTK <
2.10 (presumably because
@elextr The only set thing is, "one meeting per year" No date. It can be
either at Jan, 1st or December, 31th --Only having a combined one at new years
eve will not work unless you are sending out to invitations :D
--
You are receiving this because you are subscribed to this thread.
Reply to
@b4n , thanks, looks better:
> However, I don't understand why you see a "missing image" image under GTK3.
Maybe problem
> And in any case, relying on the marker not creating conflicts is IMO too
> optimistic for anything but user calling the feature and having a chance to
> see if it's wrong.
Yes, I noticed that there is only one toggle comment marker, not one per
filetype as I first thought. Given the
Agreed. My point was that it's perfectly OK to have whatever marker one on
wants, and it shouldn't break the feature here. If it's not convenient for the
user is not our problem, it's the user's; but if we let the user select a
marker, it should not break anything (or we should forbid it).
> Well, IMO that's one possible usage of it (admittedly, the expected one), but
> it doesn't strike me as "wrong" to use it some other way.
Well, its the usage for which the feature is designed, if it is used in
unintended ways and doesn't work that is not a bug. And since the feature
expects
> > How so?
>
> You basically said it in the following sentence, the feature is for toggling
> blocks of code on/off during development without worrying about internal
> comments, its not for setting/unsetting comments for permanent use, which is
> why I made the note about users
> How so?
You basically said it in the following sentence, the feature is for toggling
blocks of code on/off during development without worrying about internal
comments, its not for setting/unsetting comments for permanent use, which is
why I made the note about users misunderstanding the
@rezso Could you give some information on your setup? System version, maybe
libxml2 and Geany-Plugins version?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> But basically if the toggle comment character is set to space the whole
> toggle comment feature is broken everywhere, not just here.
How so? It works fine when triggered, and leads to inserting what looks like a
regular comment.
Using a marker that is not usually used allows to use the
Well the toggle comment feature will only toggle comments with the comment
marker in them, hence so long as its not space (as you identified) it will
leave existing comments alone and simply comment all the uncommented lines,
which is what we want.
IIRC the discussions at the time, toggle
26 matches
Mail list logo
