[Github-comments] [geany] Doxygen fixes2 (#826)

2015-12-17 Thread Thomas Martitz
Separated fixes from https://github.com/geany/geany/pull/744 I made more changes this time around as a result of the discussion there (and I found some more minor issues). You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/826 -- Commit

Re: [Github-comments] [geany] doxygen: various doxygen-related fixes in preparation for gtkdoc generation (302b40e)

2015-12-17 Thread Thomas Martitz
I disagree that member of public structs are private just because there's no doc comment. They are just as public, as they can't be hidden to the compiler or anything else using the struct. The type can't be hidden inside GEANY_PRIVATE or a private header because it must be fully visible in

Re: [Github-comments] [geany] doxygen: various doxygen-related fixes in preparation for gtkdoc generation (302b40e)

2015-12-17 Thread Thomas Martitz
GeanyAutoIndent is not at the end of the parent struct btw. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/commit/302b40e9778ff49407902f3ef9f272ed202f4547#commitcomment-15037063

Re: [Github-comments] [geany] doxygen: various doxygen-related fixes in preparation for gtkdoc generation (302b40e)

2015-12-17 Thread Thomas Martitz
Same reason as for GeanyAutoIndent. IMO any member of a documented struct should be documented itself. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/commit/302b40e9778ff49407902f3ef9f272ed202f4547#commitcomment-15037104

Re: [Github-comments] [geany] Doxygen fixes (#744)

2015-12-15 Thread Thomas Martitz
The changes are various enough, I think it would be preferable to make one PR each. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/744#issuecomment-164734561

Re: [Github-comments] [geany] doxygen: various doxygen-related fixes in preparation for gtkdoc generation (302b40e)

2015-12-17 Thread Thomas Martitz
So, how to proceed? If they are not documented I need to find another way to get them into the gir. I don't think there's going to be a solution that allows the GIR generation to be fully automated. Up to now I wasn't even aware we had a notion of private member fields. I think this stresses

Re: [Github-comments] [geany] doxygen: various doxygen-related fixes in preparation for gtkdoc generation (302b40e)

2015-12-17 Thread Thomas Martitz
I'll have a look, thanks --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/commit/302b40e9778ff49407902f3ef9f272ed202f4547#commitcomment-15045157

Re: [Github-comments] [geany] Geany hangs on saving a certain file (reproducible) (#815)

2015-12-18 Thread Thomas Martitz
Could it be that windows wants to focus Geany's main window but GTK wants to prevent that (because of the modality of the error dialog) but is unable to achieve that without spurious focus-in and focus-out events? --- Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany] Geany hangs on saving a certain file (reproducible) (#815)

2015-12-17 Thread Thomas Martitz
Actually, I've looked at this. I don't understand the bug (and I can't reproduce it). Given that the focus out event is used, it shouldn't be able to enter a loop. The pop up of the dialog doesn't itself cause a new (2nd) focus-out, because the widget is not focused again since the 1st

Re: [Github-comments] [geany] Geany hangs on saving a certain file (reproducible) (#815)

2015-12-15 Thread Thomas Martitz
Agreed with @codebrainz --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/815#issuecomment-165013896

Re: [Github-comments] [geany] Rewrite scope completion 2 (#505)

2016-01-09 Thread Thomas Martitz
Fwiw, I've been using this patch for a while and haven't noticed any problem so far --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/505#issuecomment-170306048

Re: [Github-comments] [geany] Keybindings for custom commands 4-9 and support for passing the document file name as an argument (#792)

2016-01-07 Thread Thomas Martitz
@tsahlin the changes itself are good, but please split them up into two commits --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/792#issuecomment-169829244

Re: [Github-comments] [geany] Doxygen fixes2 (#826)

2015-12-21 Thread Thomas Martitz
Cool, please merge :-) Feel free to squash before merging --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/826#issuecomment-166462056

Re: [Github-comments] [geany] Doxygen fixes2 (#826)

2015-12-22 Thread Thomas Martitz
What's holding this back? --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/826#issuecomment-166763611

[Github-comments] [geany] Gboxed types (#839)

2015-12-22 Thread Thomas Martitz
Allocation functions that are exported need to be GBoxed-based (if not GObject-based). This PR implements this for two cases. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/839 -- Commit Summary -- * plugin api: convert TMSourceFile to

Re: [Github-comments] [geany] cannot compile with shared object (#837)

2015-12-22 Thread Thomas Martitz
This doesn't look like a Geany bug so I suggest closing. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/837#issuecomment-166693461

Re: [Github-comments] [geany] Geany Freezes when unable to safe an edited file to it's FTP dir, no timeout on atempt saving file (#828)

2015-12-22 Thread Thomas Martitz
Is there anything we can do about it? Perhaps move to a poll-based file saving? --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/828#issuecomment-166694032

Re: [Github-comments] [geany] doxygen: various doxygen-related fixes in preparation for gtkdoc generation (302b40e)

2015-12-18 Thread Thomas Martitz
In fact I did it in this instance, but @codebrainz commented to the doc-comments of the type. Member documentation is not strictly necessary for gir, so the below hunk could be removed. It's just that all public struct types must be complete. --- Reply to this email directly or view it on

Re: [Github-comments] [geany] doxygen: various doxygen-related fixes in preparation for gtkdoc generation (302b40e)

2015-12-18 Thread Thomas Martitz
Am 17.12.2015 um 13:46 schrieb Colomban Wendling: > > I agree with @codebrainz (as I already > mentioned earlier). > Sure, there is a gray area on what's public and private inside > publicly accessible structures, as we (currently) don't have any way > to enforce

Re: [Github-comments] [geany] doxygen: various doxygen-related fixes in preparation for gtkdoc generation (302b40e)

2015-12-18 Thread Thomas Martitz
Besides, I don't know what's the fuzz about. I didn't actually start to document the members, their status is unchanged. I merely documented the *type* of these (as required for gir generation). So at the end of the day things are pretty much the same --- Reply to this email directly or view

Re: [Github-comments] [geany] doxygen: various doxygen-related fixes in preparation for gtkdoc generation (302b40e)

2015-12-18 Thread Thomas Martitz
Am 18. Dezember 2015 16:49:17 MEZ, schrieb Matthew Brush : >> That doesn't automatically make everything else strictly private, >though. [...]. So these "private" members are in fact part of the ABI >and in practice public. > >You keep confusing compiler with convention.

Re: [Github-comments] [geany-plugins] Automake (#277)

2015-11-30 Thread Thomas Martitz
Am 1. Dezember 2015 02:19:10 MEZ, schrieb Matthew Brush : >> depenencies are globally known to make; for G-P this means that >plugins don't need to be build in a specific order, but simply as soon >as possible > >Is that really a thing even for GP? I have not much clue

Re: [Github-comments] [geany] msys2 bundle script: Rework for less typo fragility, and add more pac… (#560)

2016-01-12 Thread Thomas Martitz
@eht16 I didn't ignore your change. However, I added var to the directories added to the bundle so it's moved out of the temp directory. I didn't notice .BUILDINFO yet, sorry. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/560#issuecomment-171198513

Re: [Github-comments] [geany] Splitwindow refactoring (#724)

2016-01-11 Thread Thomas Martitz
FWIW, my splitwindow2 (which implements true dual view) work is still available at https://github.com/kugel-/geany/tree/splitwindow2. I only closed the PR here because I'm not focusing in and thus isn't meant to be reviewed immediately. --- Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany] msys2 bundle script: Rework for less typo fragility, and add more pac… (#560)

2016-01-12 Thread Thomas Martitz
> Why does it crash though? This sounds more like a bug in MSYS/Pacman. > > Some gsettings schema is missing which created by the post_install command. It works after running the post_install step. Pretty sure gtk is buggy here. But even if it wouldn't crash, I expect gtk or other libraries

Re: [Github-comments] [geany/geany] Gi signals (#1038)

2016-06-05 Thread Thomas Martitz
Normally a plugin would connect using its own plugin object, this is what I expect for peasy based ones at least: ``` def on_document_new(self, doc): pass def do_enable(self): self.geany_plugin.geany_data.object.connect("document-new", self.on_document_new) ``` In this case the signal

Re: [Github-comments] [geany/geany] Gi signals (#1038)

2016-06-05 Thread Thomas Martitz
I tried the above use case without explicitly disconnecting. The scintilla case works differently, since the emitting object is destroyed. Here all signal connections are automatically unlinked, regardless of how/what you connect --- You are receiving this because you are subscribed to this

Re: [Github-comments] [geany/geany] Gi signals (#1038)

2016-06-07 Thread Thomas Martitz
> @@ -74,14 +74,11 @@ AS_IF([test "x$enable_gtk3" = xyes], > AM_CONDITIONAL([GTK3], [test "x$gtk_package" = "xgtk+-3.0"]) > > # GTK/GLib/GIO checks > -gtk_modules="$gtk_package >= $gtk_min_version glib-2.0 >= 2.28" > -gtk_modules_private="gio-2.0 >= 2.28 gmodule-no-export-2.0" >

Re: [Github-comments] [geany/geany] Gi signals (#1038)

2016-06-07 Thread Thomas Martitz
> @@ -32,6 +32,10 @@ > * Emitted just after loading main keyfile settings. > */ > > +/** > + * @file geanyobject.h > + * Definition of the global GeanyObject */ > + Am 06.06.2016 um 03:27 schrieb Matthew Brush: > In src/geanyobject.c >

[Github-comments] [geany/geany] Use our generated GTK bundle for travis (#1072)

2016-06-14 Thread Thomas Martitz
This enables travis to download and use the gtk bundles which we also use for the win32 installer images. The last commit is just for testing. Do not merge. I expect we want to put the bundle on geany.org You can view, comment on, or merge this pull request online at:

Re: [Github-comments] [geany/geany] Gi signals (#1038)

2016-06-08 Thread Thomas Martitz
> @@ -74,14 +74,11 @@ AS_IF([test "x$enable_gtk3" = xyes], > AM_CONDITIONAL([GTK3], [test "x$gtk_package" = "xgtk+-3.0"]) > > # GTK/GLib/GIO checks > -gtk_modules="$gtk_package >= $gtk_min_version glib-2.0 >= 2.28" > -gtk_modules_private="gio-2.0 >= 2.28 gmodule-no-export-2.0" >

Re: [Github-comments] [geany/geany] Use our generated GTK bundle for travis (#1072)

2016-06-14 Thread Thomas Martitz
Can you please check if the binary works with the updated cross build script if you say you did so in the past? I got some linker error when trying to run it under wine. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Gi signals (#1038)

2016-06-22 Thread Thomas Martitz
> @@ -70,6 +70,9 @@ typedef struct GeanyFilePrefs > GeanyFilePrefs; > > > +#define GEANY_TYPE_DOCUMENT (document_get_type()) > +GType document_get_type (void); Am 22.06.2016 um 17:31 schrieb Colomban Wendling: > In src/document.h >

Re: [Github-comments] [geany/geany] Use our generated GTK bundle for travis (#1072)

2016-06-16 Thread Thomas Martitz
Am 17. Juni 2016 00:25:00 MESZ, schrieb "Enrico Tröger" : >With what toolchain then? I doubt ABI compability can be kept if a >different toolchain would be used, especially MSVC. > >--- >You are receiving this because you authored the thread. >Reply to this email

Re: [Github-comments] [geany/geany] Use our generated GTK bundle for travis (#1072)

2016-06-17 Thread Thomas Martitz
@b4n Can we just use your combined bundle that works with cross toolchains and close this? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1072#issuecomment-226759883

Re: [Github-comments] [geany/geany] Gi signals (#1038)

2016-06-19 Thread Thomas Martitz
@kugel- pushed 3 commits. 11c32f6 api: remove @file command from geanyobject 61fd88d api: don't set GBoxed in stone via API doc d586ca2 scripts/cross-build-mingw.sh: Use newer support libraries with GTK2 --- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] Gi signals (#1038)

2016-06-23 Thread Thomas Martitz
> @@ -3250,6 +3250,7 @@ void scintilla_release_resources(void) { > static void *copy_(void *src) { return src; } > static void free_(void *doc) { } > > +GEANY_API_SYMBOL > GType scnotification_get_type(void) { > static gsize type_id = 0; Am 23. Juni 2016 05:07:10 MESZ, schrieb Matthew

Re: [Github-comments] [geany/geany] Gi signals (#1038)

2016-06-20 Thread Thomas Martitz
> @@ -3813,3 +3813,14 @@ void document_grab_focus(GeanyDocument *doc) > > gtk_widget_grab_focus(GTK_WIDGET(doc->editor->sci)); > } > + > +static void*copy_(void *src) { return src; } > +static void free_(void *doc) { } > + > +/** Gets the GType of GeanyDocument > + * > + *

Re: [Github-comments] [geany/geany-plugins] Resign Maintainership (#435)

2016-06-20 Thread Thomas Martitz
I can take over maintainership. I can push to upstream too if needed to keep the sync. But I won't be working on new features myself. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Use our generated GTK bundle for travis (#1072)

2016-06-15 Thread Thomas Martitz
You need to include headers, pkg-config files and some *.dll.a files for linking. The .dll.a files are small each. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Gi signals (#1038)

2016-06-23 Thread Thomas Martitz
> G_TYPE_BOOLEAN, 2, > - G_TYPE_POINTER, G_TYPE_POINTER); > + GEANY_TYPE_EDITOR, G_TYPE_POINTER); Yes, absolutely. Fixed that. Good catch. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on

Re: [Github-comments] [geany] Make it possible to define default symbol_list_sort_mode (#581)

2016-01-10 Thread Thomas Martitz
@b4n your screenshot looks good. not sure what a drop-down would look like so not sure. What's the current version? --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/581#issuecomment-170371130

Re: [Github-comments] [geany] Make it possible to define default symbol_list_sort_mode (#581)

2016-01-10 Thread Thomas Martitz
I prefer @b4n screen shot. And I too think the drop down is overkill (bad UI choice for just 2 options, IMO) --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/581#issuecomment-170406268

Re: [Github-comments] [geany] msys2 bundle script: Rework for less typo fragility, and add more pac… (#560)

2016-01-17 Thread Thomas Martitz
You want to strip either way so I don't see the point. Anyway, feel free to compile the list of packages a ignore my script. Regarding adwaita, I don't think it's pulled in for GTK2. I'll try to have a look at the other issues this week. --- Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany] Gboxed types (#839)

2016-01-19 Thread Thomas Martitz
> */ > GEANY_API_SYMBOL > void tm_source_file_free(TMSourceFile *source_file) > { > - if (NULL != source_file) I generally agree with you. IMO for API funtions, erroneous calls should be catched by something that isn't easily compiled out like g_return_*. I just did that here because we

Re: [Github-comments] [geany/geany] api: rename document_new_file to _file_new (and girskip the older one) (#1094)

2016-06-27 Thread Thomas Martitz
No, when that annotation is applied the function is already determined to be a constructor. In addition, the target function must exist. The primary use case is renaming a _full function to the non-_full one, perhaps because the non-_full one is incompatible (e.g if the _full one adds a destroy

Re: [Github-comments] [geany/geany] Api tmtag (#1093)

2016-06-27 Thread Thomas Martitz
I'd like to write a plugin that requires it too so I need TMTag for myself too. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1093#issuecomment-228875141

Re: [Github-comments] [geany/geany] Api tmtag (#1093)

2016-06-27 Thread Thomas Martitz
Not sure actually. I don't know what pointerOrder is for, but the lang member could be useful, although Geany overrules the file type doesn't it? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany] Api tmtag (#1093)

2016-06-27 Thread Thomas Martitz
Officially export TMTag which already contains documented members, and is in fact used by at least one plugin. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/1093 -- Commit Summary -- * api: formally put struct TMTag into the API *

[Github-comments] [geany/geany] api: rename document_new_file to _file_new (and girskip the older one) (#1094)

2016-06-27 Thread Thomas Martitz
g-ir-scanner detects document_new_file as constructor which is conceptually wrong. Unfortunately there is no way to override g-ir-scanner on this one so last resort is to rename the function. Old one is kept for backward compatibility. You can view, comment on, or merge this pull request online

Re: [Github-comments] [geany] Keybindings for custom commands 4-9 and support for passing the document file name as an argument (#792)

2016-02-10 Thread Thomas Martitz
Uh you added merge commits. Can you please cleanup the history? --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/792#issuecomment-182470514

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-11 Thread Thomas Martitz
> @@ -247,7 +247,18 @@ ALIASES= "signal=- @ref " \ > "endsignalproto=@endcode " \ > "signaldesc=" \ > "signals=@b Signals: " \ > - "endsignals= " > +

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-11 Thread Thomas Martitz
> > -all-local: Doxyfile.stamp > +Doxyfile.stamp: Doxyfile Doxyfile-gi $(doxygen_sources) > + $(AM_V_GEN)$(DOXYGEN) Doxyfile-gi && $(DOXYGEN) Doxyfile && echo "" > $@ > + > +ALL_TARGETS = Doxyfile.stamp > + > +if WITH_PYTHON > + > +geany-scintilla-gtkdoc.h: geany-gtkdoc.h > + >

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-11 Thread Thomas Martitz
> @@ -70,3 +70,16 @@ AC_DEFUN([GEANY_CHECK_DOCUTILS_PDF], > AM_CONDITIONAL([WITH_RST2PDF], [test "x$geany_enable_pdf_docs" != > "xno"]) > GEANY_STATUS_ADD([Build PDF documentation], [$geany_enable_pdf_docs]) > ]) > + > +dnl > +dnl GEANY_CHECK_PYTHON > +dnl For gtkdoc header

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-11 Thread Thomas Martitz
> @@ -1955,11 +1955,12 @@ static gboolean str_in_array(const gchar **haystack, > const gchar *needle) > * > * The argument list must be @c NULL-terminated. > * > + * ok --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/890/files#r52673261

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-11 Thread Thomas Martitz
> @@ -113,6 +113,9 @@ GeanyFiletypeID; > > #define filetype_id GeanyFiletypeID /* compat define - should be removed in > the future */ > > +/** Filetype categories > + * > + * These are used to provide submenus for each category in the GUI */ Yes (this was made before the other decision I

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-11 Thread Thomas Martitz
> > -all-local: Doxyfile.stamp > +Doxyfile.stamp: Doxyfile Doxyfile-gi $(doxygen_sources) > + $(AM_V_GEN)$(DOXYGEN) Doxyfile-gi && $(DOXYGEN) Doxyfile && echo "" > $@ > should rather be 3 lines in the rule, I don't see we need shell here and it's > less clear It was a single line before

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-11 Thread Thomas Martitz
> +(opts,args) = parser.parse_args() > + > +xml_dir = args[0] > +if (opts.outfile): > + outfile = open(opts.outfile, "w+") > +else: > + outfile=sys.stdout > + > +if (opts.scioutfile): > + scioutfile = open(opts.scioutfile, "w+") > +else: > + scioutfile = outfile > + > +if (outfile

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-11 Thread Thomas Martitz
> @@ -247,7 +247,18 @@ ALIASES= "signal=- @ref " \ > "endsignalproto=@endcode " \ > "signaldesc=" \ > "signals=@b Signals: " \ > - "endsignals= " > +

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-11 Thread Thomas Martitz
> +outfile.write("typedef struct _ScintillaObject ScintillaObject;\n") > +outfile.write("typedef struct TMSourceFile TMSourceFile;\n") > +outfile.write("typedef struct TMWorkspace TMWorkspace;\n") > + > +# write typedefs first, they are possibly undocumented but still required > (even > +# if

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-11 Thread Thomas Martitz
> > -all-local: Doxyfile.stamp > +Doxyfile.stamp: Doxyfile Doxyfile-gi $(doxygen_sources) > + $(AM_V_GEN)$(DOXYGEN) Doxyfile-gi && $(DOXYGEN) Doxyfile && echo "" > $@ > + > +ALL_TARGETS = Doxyfile.stamp > + > +if WITH_PYTHON > + > +geany-scintilla-gtkdoc.h: geany-gtkdoc.h > + >

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-11 Thread Thomas Martitz
Am 11.02.2016 um 20:19 schrieb Colomban Wendling: > > Apart all that, looks like it does as advertized. Yet, what's this > about this scintilla header? OK, I get it's nice if those are method > on ScintillaObject, but the symbols doesn't exist so…? > > Actually, it seems I messed up rebasing.

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-11 Thread Thomas Martitz
> > -all-local: Doxyfile.stamp > +Doxyfile.stamp: Doxyfile Doxyfile-gi $(doxygen_sources) > + $(AM_V_GEN)$(DOXYGEN) Doxyfile-gi && $(DOXYGEN) Doxyfile && echo "" > $@ Am 11.02.2016 um 23:00 schrieb Colomban Wendling: > > In doc/Makefile.am >

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-01-26 Thread Thomas Martitz
Am 27.01.2016 um 07:28 schrieb Matthew Brush: > > There are already two ruby scripts in the tree, so I'm surprised > this one is a problem given its optional. > > Are you sure your not grepping into the CTags test dir? None of the > ones we maintain in the |scripts| dir are in Ruby,

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-01-26 Thread Thomas Martitz
BTW, There are already two ruby scripts in the tree, so I'm surprised this one is a problem given its optional. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/890#issuecomment-175424878

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-24 Thread Thomas Martitz
Okay. I'm just afraid I cannot use much of the api for a full cycle because of missing comments (bytes accident). Anyway, just merge it as-is if you like --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/890#issuecomment-188398273

Re: [Github-comments] [geany] plugin api: export editor_set_indent_width() (#903)

2016-02-24 Thread Thomas Martitz
Done --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/903#issuecomment-188400500

Re: [Github-comments] [geany] plugin api: export editor_set_indent_width() (#903)

2016-02-22 Thread Thomas Martitz
@b4n @elextr @codebrainz can this be merged? --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/903#issuecomment-187202400

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-22 Thread Thomas Martitz
@b4n perhaps your last commit should be post-poned, e.g. GeanyEditorPrefs (the struct) is exported via GeanyData but no member is accessible. This points to an accident. (to me it shows once more that "undocumented members" != "private members", or that this definition is recently come up

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-28 Thread Thomas Martitz
Happy with your commits, thank you! (IMO this PR could use some squashing but meh) --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/890#issuecomment-189963990

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-28 Thread Thomas Martitz
- [x] I'm fine --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/890#issuecomment-190076225

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-25 Thread Thomas Martitz
Am 25.02.2016 um 00:07 schrieb Colomban Wendling: > Anyway, just merge it as-is if you like > > I don't, there are still open points :) > Fixed some of them. Hopefully mergeable now. The stray @ are unproblematic as far as .gir generation is concerned. They are caused by the extra \a

Re: [Github-comments] [geany] Gboxed types (#839)

2016-01-25 Thread Thomas Martitz
> } > } > > +/** Gets the GBoxed-derived GType for TMSourceFile > + * > + * @return TMSourceFile type . */ > +GEANY_API_SYMBOL > +GType tm_source_file_get_type(void); Am 25. Januar 2016 22:41:41 MEZ, schrieb Colomban Wendling : >> } >> } >> >> +/** Gets

[Github-comments] [geany] Gtkdoc hdr (#890)

2016-01-26 Thread Thomas Martitz
This is probably not ready yet, but open for review. The new script probably needs some more cleanup but since I'm not sure anyone is interested in reviewing ruby code I decided to PR'ify. Description: This PR does some prep work, then enables generating xml output from doxygen, and lastly

[Github-comments] [geany] scintilla: add scintilla_object_* to the plugin api (#874)

2016-01-19 Thread Thomas Martitz
Analogous to their legacy counterparts. Also required for gir-bindings generated via g-ir-scanner. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/874 -- Commit Summary -- * scintilla: add scintilla_object_* to the plugin api -- File

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-01-27 Thread Thomas Martitz
As with python, ruby libraries can be installed with a ruby-specific package manager: gem install doxyparser. doxyparser in turn requires nokogiri, which can be installed the same way (but is also available as a debian package). So whether or not being available as a debian is not an issue IMO.

Re: [Github-comments] [geany] Keybindings for custom commands 4-9 and support for passing the document file name as an argument (#792)

2016-02-18 Thread Thomas Martitz
Restricting the user's user cases / abilities just because one can make up awkward file names like this sounds out of proportion to me. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/792#issuecomment-185733288

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-19 Thread Thomas Martitz
> +proc = DoxygenProcess() > +self.brief = proc.process_element(xml) > +self.extra += proc.get_extra() > + > +def add_detail(self, xml): > +proc = DoxygenProcess() > +self.detail = proc.process_element(xml) > +self.extra += proc.get_extra() > +

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-19 Thread Thomas Martitz
> +proc = DoxygenProcess() > +self.brief = proc.process_element(xml) > +self.extra += proc.get_extra() > + > +def add_detail(self, xml): > +proc = DoxygenProcess() > +self.detail = proc.process_element(xml) > +self.extra += proc.get_extra() > +

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-20 Thread Thomas Martitz
@b4n I fixed the build and also added your commit. The idea is nice, well done :-) Although now some structs are all-private (e..g GeanyEditorPrefs). This doesn't look intended but not sure what to do about it (doesn't seem to be a problem for my peasy plugin yet). --- Reply to this email

Re: [Github-comments] [geany] Gtkdoc hdr (#890)

2016-02-11 Thread Thomas Martitz
> > -all-local: Doxyfile.stamp > +Doxyfile.stamp: Doxyfile Doxyfile-gi $(doxygen_sources) > + $(AM_V_GEN)$(DOXYGEN) Doxyfile-gi && $(DOXYGEN) Doxyfile && echo "" > $@ Am 11. Februar 2016 18:38:18 MEZ, schrieb Colomban Wendling : >> >> -all-local: Doxyfile.stamp

[Github-comments] [geany] Add and use enum _GeanyFiletypeID for filetype_id typedef. (#952)

2016-03-09 Thread Thomas Martitz
This repairs geany-gtkdoc.h output which otherwise contains an invalid typedef. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/952 -- Commit Summary -- * Add and use enum _GeanyFiletypeID for filetype_id typedef. -- File Changes --

Re: [Github-comments] [geany] msys2 bundle script: Rework for less typo fragility, and add more pac… (#560)

2016-03-10 Thread Thomas Martitz
I thought we're going to compile grep. The script download the binary, unless I'm missing something? --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/560#issuecomment-194875622

Re: [Github-comments] [geany-plugins] Geanypy proxy and keybindings (#384)

2016-03-10 Thread Thomas Martitz
@sagarchalise it never did that. It thinkpad you have to Do it manually (for extra modules). Or are you saying your main plugins file can't be loaded? --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/384#issuecomment-194887771

[Github-comments] [geany-plugins] geanypy: fix loading plugins from user config directory. (#400)

2016-03-11 Thread Thomas Martitz
Have to add ~/.config/geany/plugins to Python's path otherwise loading plugins from there fails. Tested with a relatively complex plugin which also ships extra modules in subdirectory: https://github.com/sagarchalise/geanypy-reStructured-preview You can view, comment on, or merge this pull

Re: [Github-comments] [geany-plugins] geanypy: fix loading plugins from user config directory. (#400)

2016-03-11 Thread Thomas Martitz
@frlan @elextr important bug fix for 1.27 --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/400#issuecomment-195242971

Re: [Github-comments] [geany] doxygen: various doxygen-related fixes in preparation for gtkdoc generation (302b40e)

2016-03-15 Thread Thomas Martitz
Err. right. There is geany_data->filetypes_array as an alternative --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/commit/302b40e9778ff49407902f3ef9f272ed202f4547#commitcomment-16700061

Re: [Github-comments] [geany] Fix forward reference to enumeration types in GtkDoc header (#955)

2016-03-09 Thread Thomas Martitz
I agree. I didn't yet test but the change is a good one. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/955#issuecomment-194492808

Re: [Github-comments] [geany] Gi sci methods v2 (#948)

2016-03-09 Thread Thomas Martitz
> try: > outfile.write("/*\n * Automatically generated file - do not edit\n > */\n\n") > -outfile.write("#include \n") > -outfile.write("#include \n\n") > -outfile.write("typedef struct _ScintillaObject ScintillaObject;\n") > +outfile.write("#include

Re: [Github-comments] [geany] Gi sci methods v2 (#948)

2016-03-09 Thread Thomas Martitz
> try: > outfile.write("/*\n * Automatically generated file - do not edit\n > */\n\n") > -outfile.write("#include \n") > -outfile.write("#include \n\n") > -outfile.write("typedef struct _ScintillaObject ScintillaObject;\n") > +outfile.write("#include

[Github-comments] [geany] tagmanager: make doxygen comments and typedefs gtkdoc generation frie… (#956)

2016-03-09 Thread Thomas Martitz
…ndly Because of the missing "typedef struct TMFoo" it was missing from the gtkdoc header (the struct listings are always without typedef). This is also consistent with the rest of geany. @gironly for TMParserType so it's picked up as well. @b4n You can view, comment on, or merge this pull

Re: [Github-comments] [geany] Gi sci methods (#935)

2016-03-08 Thread Thomas Martitz
Closed #935. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/935#event-582490677

Re: [Github-comments] [geany] Gi sci methods v2 (#948)

2016-03-08 Thread Thomas Martitz
BTW, this supersedes #935 --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/948#issuecomment-194011432

[Github-comments] [geany] Gi sci methods v2 (#948)

2016-03-08 Thread Thomas Martitz
This generates a separate geany-scintilla-gtkdoc.h. It contains basically just the sci_* functions of geany-gtkdoc.h (which are still there also) to make it easier to implement a separate namespace for scintilla. Also fixes to gen-api-gtkdoc You can view, comment on, or merge this pull request

Re: [Github-comments] [geany] tagmanager: make doxygen comments and typedefs gtkdoc generation frie… (#956)

2016-03-09 Thread Thomas Martitz
Closed #956. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/956#event-583888919

Re: [Github-comments] [geany] tagmanager: make doxygen comments and typedefs gtkdoc generation frie… (#956)

2016-03-09 Thread Thomas Martitz
Oops, this is actually mixed up with #948. including sciwrappers.h makes the manual typedef unecessary. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/956#issuecomment-194495605

Re: [Github-comments] [geany] Add and use enum _GeanyFiletypeID for filetype_id typedef. (#952)

2016-03-09 Thread Thomas Martitz
abandoned in favor of #955 --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/952#issuecomment-194501203

Re: [Github-comments] [geany] Add and use enum _GeanyFiletypeID for filetype_id typedef. (#952)

2016-03-09 Thread Thomas Martitz
Closed #952. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/952#event-583905135

Re: [Github-comments] [geany] tagmanager: make doxygen comments and typedefs gtkdoc generation frie… (#956)

2016-03-09 Thread Thomas Martitz
Reopened #956. --- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/956#event-583889066

Re: [Github-comments] [geany] Gi sci methods v2 (#948)

2016-03-09 Thread Thomas Martitz
> try: > outfile.write("/*\n * Automatically generated file - do not edit\n > */\n\n") > -outfile.write("#include \n") > -outfile.write("#include \n\n") > -outfile.write("typedef struct _ScintillaObject ScintillaObject;\n") > +outfile.write("#include

  1   2   3   4   5   6   7   8   9   10   >