> I "think" it will work.
> In detail this is, when querying https://geany.org/ I get an error: `GET
> request failed: WinHttp error: SECURE_CHANNEL_ERROR`. […]
>
> If I change the URL to query to https://httpbin.org/anything/version, the
> HTTP request works fine and I get the expected
Try adding this in *filetypes.sh* (you can open it from *Tools → Configuration
files → Filetypes configuration files → Scripting languages*):
```ini
[lexer_properties]
lexer.bash.styling.inside.string=1
lexer.bash.styling.inside.backticks=1
lexer.bash.styling.inside.parameter=1
@elextr you never know what the future of the web holds, but I highly doubt a
security issue would ruin the current API. A new feature maybe, but well.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081379570
You are
That's not how things work here, the identifier id either recognized as such
anf given a separate style (which we might or might not draw the same as a
string), or it's not recognized and thus is considered a string.
Which language do you have issue with?
--
Reply to this email directly or
I'll look into this Soon™, but the JS changes might have an issue (might be
what you see, might be something else), see
[this](https://github.com/universal-ctags/ctags/commit/6d85089456ed215ce6b6a673744ae42ccc5e0e99#diff-eb186936271438240da764e7ccf36ffa04ba8f0a6e1eabd1c69400164ae9f608R1)
which
@b4n approved this pull request.
LGBI, makes sense.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1339#pullrequestreview-2026699270
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #1295 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#event-12632694851
You are receiving this because you are subscribed to this thread.
Message ID:
> Yeah, but then its back to four plugins to synchronise on
> libsoup3/webkit2gtk-4.1.
Yet, does it currently matter? I mean, the code is ready (but for more testing
maybe) for all four now, porting isn't what is holding back anymore. Sure the
question might arise again for a future libsoup4
> It didn't appear to do either. No popup or message in status or msgwin on
> success. I don't recall seeing anything but some usual gtk errors in terminal.
Weird… unless you have a libsoup2 plugin loaded? IIUC nothing will stop you
from doing so, but things will just perform bizarrely (or
@b4n requested changes on this pull request.
LGTM, see inline comments.
Apart from that, I was kind of disappointed that the "goto file" only lists
Geany open documents rather than the project's documents -- maybe you'd like to
add that?
Also, I hoped to be able to go to a specific file's
@elextr hence checking if it does :) But if it's a concern, just keep using
the libsoup implementation, it *ought* to work with HTTP as that's the whole
point of that library :smiley:
--
Reply to this email directly or view it on GitHub:
> Do Debian and Ubuntu even bother rebuilding packages for old releases?
No, the dependency only matter for users of older releases that would like to
build a newer Geany by themselves. And Debian was just an example, sometimes
we check what even more slow-paced distro do, like RHEL or so.
> After testing the plugin, I think it should be dropped. Most of the pastebins
> don't work.
Indeed only 3 did in my tests (Geany's, Debian's and Sprunge)
> There's no confirmation of what it's sending. […] Once data is sent, there's
> no way to delete it, which is a security risk if
@techee any chance you could check whether gvfs works with HTTP(S) under macos?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2080478237
You are receiving this because you are subscribed to this thread.
Message ID:
Thanks for review & testing!
BTW, a few things things to note:
* libsoup3 is fairly recent (2021-09-18), and e.g. not available in Debian
before Bookworm (12, current stable)
* I probably won't make it possible to support both libsoup2 and libsoup3,
because the changes are too complex which
Many pastebins dont work, but its not new to the changes here…
CC @xiota @jbicha
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1342
-- Commit Summary --
* geniuspaste: Port to libsoup3
* geniuspaste: Remove use of deprecated
@xiota I don't think we need to explore a *different* additional HTTP library;
either we only use what's already part of the general GTK stack, or using
libsoup which is also a direct or indirect dependency of 3 other plugins is
fine.
--
Reply to this email directly or view it on GitHub:
See #1340 if wanted.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079550087
You are receiving this because you are subscribed to this thread.
Message ID:
Same as #1336 but using GIO instead of libsoup.
If wanted? CC @elextr @xiota @frlan.
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1340
-- Commit Summary --
* updatechecker: Port to libsoup3
* updatechecker: Dont leak the
Note that writing an async version of the feature, while reasonably easy, is a
little bit more work.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079476011
You are receiving this because you are subscribed to this thread.
hum… @elextr @xiota so what's your conclusion? Depend on libsoup3 as this PR
because it's HTTP, or depend on a GVFS backend for HTTP?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079474204
You are receiving this because
@b4n commented on this pull request.
> @@ -950,6 +1005,23 @@ gwh_browser_set_uri (GwhBrowser *self,
g_free (real_uri);
}
+gboolean
+gwh_browser_set_uri_from_document (GwhBrowser*self,
+ GeanyDocument *doc)
+{
+ gchar *uri;
+
+ /* document must
The main issue with native dialogs/portals, is that they have reduced feature
set, see e.g.
[GtkFileChooserNative](https://docs.gtk.org/gtk3/class.FileChooserNative.html).
And some might be a problematic trade-off for our use cases.
Also note that I can't read anything in the link above about
Yeah I guess using GIO directly for this kind of super simple GET would make
sense Indeed. I also think that gvfs will indeed be part of all reasonable GIO
installations, but I could be wrong.
--
Reply to this email directly or view it on GitHub:
And voila, I got plagued with another round of cleanups :)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#issuecomment-2078136827
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. If you intend to build it yourself,
@b4n pushed 5 commits.
52ab3ebefc8fdf805b081bac74efaec442c82529 webhelper: Use modern GObject private
data
9f420e09447cc2f8a57e4880dfa99bebc67734e7 webhelper: Replace use of deprecated
GtkVBox with GtkBox
3edea3f891cdbe241d63d2b4b37ef4c5eea035c4 webhelper: Remove use of deprecated
Merged #1335 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1335#event-12612366928
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. If you intend to build it yourself,
Merged #1232 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1232#event-12607573353
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #936 as completed via #1232.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/936#event-12607573756
You are receiving this because you are subscribed to this thread.
Message ID:
Oopsie, I didn't check the OP, only the commit message :confused:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1232#issuecomment-2077050321
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. If you intend to build it yourself,
@b4n approved this pull request.
I extracted the old and new code an tested a bit, and that also works great.
FWIW, if somebody didn't catch what the issue was (as in fact it's not
mentioned anywhere but "infinite loop"): if the replacement contains the search
term, it'll be replaced
@b4n commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. If you intend to build it yourself,
@b4n approved this pull request.
LGTM and seems to work fine here.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1335#pullrequestreview-2022078950
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> @@ -185,15 +191,30 @@ version_compare(const gchar *current_version)
}
-static void update_check_result_cb(SoupSession *session,
-SoupMessage *msg, gpointer user_data)
+static gchar *bytes_to_string(GBytes *bytes)
+{
+gsize bytes_size =
@b4n commented on this pull request.
Looks good, works fine, but the 2 first commits don't really work one without
the other, so they should be merged: the first one actually make it use
webkit2gtk only, but by removes the conditional that enables the code to use it
(and it probably also
@elextr I just did the bare minimum, see update
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#issuecomment-2075710224
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 1 commit.
8ee8a92a9eb7276ae210e376e0b80d271f885162 webhelper: Update dependencies in
README
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1295/files/d19aee697472477c0e53c12a75303121e47f5b64..8ee8a92a9eb7276ae210e376e0b80d271f885162
You are receiving this
> Alternatively, it could simply switch to the last open tab (emulating the
> behavior of Ctrl-Tab).
*Preferences → Interface → Notebook tabs → Editor tabs → Switch to lasted used
document after closing a tab* :wink:
--
Reply to this email directly or view it on GitHub:
Port to libsoup3 (see
https://github.com/geany/geany-plugins/pull/1295#issuecomment-1906999722
@jbicha) plus a couple other fixes I just couldnt leave there after seeing
them :slightly_smiling_face:
**:warning: DISCLAIMER:** I dont know neither libsoup2.4 nor libsoup3.
This is a uneducated
@xiota if you'd like to try, just look at the PR's commit messages. Basically,
try building against WebKit2GTK 4.1, enable the plugin and try loading pages,
editing an HTML displayed there, etc. But all should be good in theory
:crossed_fingers:
--
Reply to this email directly or view it
@jbicha could you make a PR with your Markdown changes, assuming they are not
too Ubunut/Debian-specific?
@elextr @jbicha I'll merge this (which at least *allows* building webhelper
with 4.1, although not forcing it), and try to update the rest to match, as
indeed it will cause issues if
> I don't understand your image:
>
> 1. it does not use `var`
There is on line 3 :wink:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3854#issuecomment-2074328625
You are receiving this because you are subscribed to this thread.
Message ID:
@elextr not sure where you found the info, all I can find myself is that it'd
be a "contextual keyword":
https://docs.oracle.com/javase/specs/jls/se21/html/jls-3.html#jls-3.9
--
Reply to this email directly or view it on GitHub:
@b4n commented on this pull request.
> @@ -241,6 +241,29 @@ void tm_ctags_clear_ignore_symbols(void)
}
+static void replace_str(gchar **where, const gchar *what, guint what_len,
+ const gchar *replacement, guint replacement_len)
+{
+ if (where && *where)
+ {
+
@b4n approved this pull request.
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3785#pullrequestreview-2018411095
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> @@ -241,6 +241,33 @@ void tm_ctags_clear_ignore_symbols(void)
}
+static gboolean replace_str(gchar **where, const gchar *what, gsize what_len,
+ const gchar *replacement, gsize replacement_len)
+{
+ if (where && *where)
+ {
+
@b4n commented on this pull request.
> @@ -241,6 +241,33 @@ void tm_ctags_clear_ignore_symbols(void)
}
+static gboolean replace_str(gchar **where, const gchar *what, gsize what_len,
+ const gchar *replacement, gsize replacement_len)
+{
+ if (where && *where)
+ {
+
@b4n commented on this pull request.
> @@ -241,6 +241,33 @@ void tm_ctags_clear_ignore_symbols(void)
}
+static gboolean replace_str(gchar **where, const gchar *what, gsize what_len,
+ const gchar *replacement, gsize replacement_len)
+{
+ if (where && *where)
+ {
+
@b4n commented on this pull request.
> @@ -241,6 +241,33 @@ void tm_ctags_clear_ignore_symbols(void)
}
+static gboolean replace_str(gchar **where, const gchar *what, gsize what_len,
+ const gchar *replacement, gsize replacement_len)
+{
+ if (where && *where)
+ {
+
Merged #3853 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3853#event-12581690186
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> @@ -241,6 +241,33 @@ void tm_ctags_clear_ignore_symbols(void)
}
+static gboolean replace_str(gchar **where, const gchar *what, gsize what_len,
+ const gchar *replacement, gsize replacement_len)
+{
+ if (where && *where)
+ {
+
@b4n commented on this pull request.
> @@ -241,6 +241,33 @@ void tm_ctags_clear_ignore_symbols(void)
}
+static gboolean replace_str(gchar **where, const gchar *what, gsize what_len,
+ const gchar *replacement, gsize replacement_len)
+{
+ if (where && *where)
+ {
+
They are gonna be the same in practice, but its not how target
is supposed to be used[^1][^2].
Streamline this to use host, which also makes things match our
Autotools closer.
[^1]: https://mesonbuild.com/Cross-compilation.html
[^2]:
> Is there anything wrong with merging this?
>
> Even if it would be cooler to not have to set the flag, as it is done by
> Autotools as well, it might be ok.
>
> And if uctags is updated next time, we could try to remove it again.
I don't see any reason not to merge this indeed, if it fixes
@b4n approved this pull request.
LGTM as far as 0-testing goes
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3660#pullrequestreview-2015727530
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> @@ -185,6 +185,10 @@ if python_command == '' or python_command == 'auto'
endif
cdata.set('PYTHON_COMMAND', python_command)
+if host_machine.system() == 'windows'
This is [fine](https://mesonbuild.com/Cross-compilation.html), but we probably
should
@b4n approved this pull request.
Looks good and works fine.
Could you please just squash the commits together? (or I can do it if you
prefer)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3759#pullrequestreview-2015703603
You are receiving this
Closed #3777 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3777#event-12565004868
You are receiving this because you are subscribed to this thread.
Message ID:
Fixed in #3716 (b23201c01390e6ed6d631cf232e404691ffe91ec)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3777#issuecomment-2070843882
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3779.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3779#event-12564994926
You are receiving this because you are subscribed to this thread.
Message ID:
This is a good fix, but was actually already part of #3716
(b23201c01390e6ed6d631cf232e404691ffe91ec), which is now merged.
Good work though!
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3779#issuecomment-2070840982
You are receiving this because you
The [README](https://github.com/geany/geany?tab=readme-ov-file#using-autotools)
should be a good start I believe.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3852#issuecomment-2070815483
You are receiving this because you are subscribed to this
We already have deprecation warnings in 0.56, so if we want to support earlier
jus use the older option I mentioned
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#issuecomment-2068837991
You are receiving this because you are subscribed to this
didn't you have a fresh install before already? Not sure, but maybe your
hardware (hard drive maybe) is faulty?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3843#issuecomment-2068206133
You are receiving this because you are subscribed to this
Closed #3843 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3843#event-12552031399
You are receiving this because you are subscribed to this thread.
Message ID:
@frlan do you plan on making a point-release, given the above-mentioned reasons?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1294#issuecomment-2068187873
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n requested changes on this pull request.
```console
../meson.build:887: WARNING: Project targets '>= 0.53' but uses feature
introduced in '0.56.0': win_subsystem arg in executable.
[…]
WARNING: Project specifies a minimum meson_version '>= 0.53' but uses features
which were added in newer
@eht16 This doesn't seem to have any impact on Linux, so looks fine on that end.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#issuecomment-2068186588
You are receiving this because you are subscribed to this thread.
Message ID:
>From looking at the backtrace and the relevant GTK source code, this seems
>entirely unrelated to Geany itself (apart for Geany using GTK3, that is). It
>looks like either there is a bug in your `XVisualIDFromVisual()` (which could
>come from a driver bug maybe?), or a bug in GTK on how it
@elextr Tell me if there are still strings to be updated or better error to
report, I can make another follow-up :wink:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3716#issuecomment-2068175821
You are receiving this because you are subscribed to
Merged #3720 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3720#event-12551819882
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3716 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3716#event-12551817780
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3163 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3163#event-12551564071
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n commented on this pull request.
> geany_debug("Couldn't convert from %s to UTF-8.",
> charset);
+ g_set_error(error, G_CONVERT_ERROR,
G_CONVERT_ERROR_ILLEGAL_SEQUENCE,
+ _("Data contains NULs"));
Yes, if
`symbols_find_typenames_as_string()` uses `symbols_find_typenames_as_string()`,
which itself uses `tm_workspace::typename_array`. This is filled *only* with
what is deemed a "typename", which currently has to match `TM_GLOBAL_TYPE_MASK`
(which is any of `tm_tag_class_t`, `tm_tag_enum_t`,
Merged #3846 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3846#event-12548053851
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3844 via #3846.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3844#event-12548053879
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 1 commit.
53a42c6de7875b0f112b4ed22eb3f3e1c9cf967c Fix invalid memory access and Unicode
support in utils_get_initials()
--
View it on GitHub:
https://github.com/geany/geany/pull/3846/files/346ef35a59857f63e249419e95c5ca66e54301f4..53a42c6de7875b0f112b4ed22eb3f3e1c9cf967c
You are
> Well the NFKC normalization should handle a lot of cases by itself.
Yeah it should. And so you think I should use NFKC rather than NFC? I'm
really not sure what makes more sense here.
> Yes, its hardly worth the effort to complicate a capability that appears to
> be little used, just being
> Its not perfect (eg Indic combining chars have class 0)
How should this be identified then? Just by ranges or something?
> but at least it should not result in invalid strings
If that's all we're after, I can keep the normalization step and remove the
manual (incomplete?) combining character
@b4n commented on this pull request.
> gchar *utils_get_initials(const gchar *name)
{
- gint i = 1, j = 1;
- gchar *initials = g_malloc0(5);
+ GString *initials;
+ gchar *composed;
+ gboolean at_bound = TRUE;
+ gboolean prev_matched = FALSE;
+
+
@b4n commented on this pull request.
> @@ -766,21 +766,47 @@ gchar *utils_get_date_time(const gchar *format, time_t
> *time_to_use)
}
+/* Extracts initials from @p name, with some Unicode support */
+GEANY_EXPORT_SYMBOL
No, it's only exported for tests, not `GEANY_API_SYMBOL`.
--
Reply
> the current behaviour of re-indenting the first line only is likely to be
> wrong most of the time and probably should be changed for multi-line pastes.
The current behavior does not indent anything, it just insert whatever there is
in the clipboard wherever the caret is at. If the caret was
> Even if this doesn't get implemented, I'd love to hear why this is not a
> desired behavior :)
I think it's an interesting (and probably useful) behavior, but it probably
also cannot be the default. Here are a couple of reasons why from the top of
my head:
* What currently happens is that
Good find! But I believe the fix, although not bad (despite me not liking the
`strlen()` use here, but that hardly matters) is not nearly enough. This
function is also *terrible* with non-ASCII handling, to the point where it does
more harm than good.
I propose an alternate (yet a bit
Fix utils_get_initials() reading past the end of the input string if that
string was empty.
Also fix support for non-ASCII initials for which the UTF-8 character
representation would have been truncated to the first byte only, leading to an
invalid value.
The implementation here also tries to
@fbrau OK, thanks for testing. I'm merging this for now because it improves
the situation a fair bit, but we can still discuss the details.
For whether the module should be shown or not, it's probably a bit of taste,
and a bit of meaning, for example:
* can *anything* in an Erlang file
Merged #3837 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3837#event-12530469240
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #2650 as completed via #3837.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2650#event-12530469384
You are receiving this because you are subscribed to this thread.
Message ID:
@eht16 I merged this anyway, but feel free to still check whether the
shenanigans are still useful :wink:
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3838#issuecomment-2065494154
You are receiving this because you are subscribed to this thread.
Merged #3838 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3838#event-12530458077
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3831 as completed via #3838.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3831#event-12530458173
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n requested changes on this pull request.
Looks good, but impl can possibly be improved a tad (see nitpicks & useful
comments inline).
Suggested changes (don't trust it blindly, esp. the part around L406):
```diff
diff --git a/src/tagmanager/tm_ctags.c b/src/tagmanager/tm_ctags.c
index
> I don't remember the initial problems from 12 years ago, maybe it was GTK2
> releated or a bug in early GTK3 versions or so.
Any chance you could try removing the guard and see if anything weird happens?
Not that I remember any details about that though, only Git does remember
anything :)
@b4n commented on this pull request.
> sci_scroll_columns(editor->sci, amount);
return TRUE;
}
+ else if (!event->state || (editor_prefs.scrollwheel_zoom_disable &&
(event->state & GDK_CONTROL_MASK)))
It's also to filter out uninteresting modifiers
> The mouse wheel would look broken if scrolling stopped when control is
> accidentally pressed.
I'd argue that it's just as true with any incorrect usage that doesn't do what
you wanted. For a more unreasonable example, if I hit Del when I
meant to write "hello", I wouldn't blame the software
@b4n commented on this pull request.
> +void sci_scroll_lines(ScintillaObject *sci, gint lines)
+{
+ SSM(sci, SCI_LINESCROLL, 0, (uptr_t) lines);
+}
+
+
@elextr I'm not concerned by any speed issues, just that although it looks
"clean", it also makes the code somewhat more complex,
1 - 100 of 3024 matches
Mail list logo
