[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)
@b4n commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32 +#ifdef _WIN32 @elextr they changed the bundled implementation (from an old glibc copy to a newer gnulib one), that's all. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3878#discussion_r1609354067 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] I have just solved the socket problem in my computer. (Issue #3880)
Closed #3880 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3880#event-12885446945 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] I have just solved the socket problem in my computer. (Issue #3880)
Short answer is "no". If this "solved" the issue you mentioned in #3871 it is probably just that you started Geany with sudo, and quit it cleanly. It thus removed the problematic socket file, allowing subsequent non-sudo runs to work properly. The issue you had was a leftover file *not owned by your user in your user's homedir*, and generalizing this behavior is just gonna widen the amount of files that might end up root-owned in your homedir. The real solution would be to have a sudo configuration that doesn't lead to root writing files in your homedir. I believe Ubuntu has had this issue for basically forever, which I don't understand; but I guess they have their reasons. Then, we can't do this for several reasons: * `sudo` is likely to ask for a password, which it's not gonna get if run outside a terminal. * `sudo` exists for a reason: * if you just want to always be root, just use the root account to start with. **:warning: I wouldn't recommend it though.** * on the contrary, if you want to modify a root-owned file from your sudo-enabled user, just prefix the command with `sudo` so you're explicit with yourself what you're doing. * lastly, the Geany team does **not** endorse running Geany as root. Of course you can do this, but consider it unsupported and dangerous. --- A pretty interesting solution to editing files as root is gvfsd-admin: basically you can use the URI `admin:///path/to/file` and the system asks for permission to edit this file from a non-root app. This works with e.g. GEdit and Pluma. It doesn't in Geany (yet?) for technical reasons we might or might not want to change, but it possibly could if really editing root files with an IDE-like app seem useful enough to enough people. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3880#issuecomment-2123435142 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
FWIW, it *is* enough to change the output of `glxinfo`. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2122562997 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix crash by protecting tm_ctags_*() functions against TM_PARSER_NONE (PR #3865)
@b4n commented on this pull request. LGTM, apart possibly the inline comments. Sad we have to do that in several functions, but makes sense. > + kindDefinition *def; + + if (lang == TM_PARSER_NONE) + return "unknown"; + + def = getLanguageKindForLetter(lang, kind); Maybe something like this to avoid repeating the fallback value? ```suggestion kindDefinition *def = NULL; if (lang != TM_PARSER_NONE) def = getLanguageKindForLetter(lang, kind); ``` > + kindDefinition *def; + + if (lang == TM_PARSER_NONE) + return '-'; + + def = getLanguageKindForName(lang, name); Ditto here, maybe: ```suggestion kindDefinition *def = NULL; if (lang != TM_PARSER_NONE) def = getLanguageKindForName(lang, name); ``` -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3865#pullrequestreview-2068531076 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
…and no crashes either with 1.39 at a random commit with Compiz under Debian Buster. So either those don't reproduce the issue, or simply setting `XLIB_SKIP_ARGB_VISUALS=1` for the Geany process isn't enough to cause the issue. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2122547710 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
Possibly, but I just tried enabling Metacity's compositor (xrender) with no crashes either. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2122542648 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
FWIW I just tested, I can't reproduce the crash simply by setting `XLIB_SKIP_ARGB_VISUALS=1` on my machine (Debian Bookworm, non-composited Metacity WM under MATE -- weird setup you say? bah :grin:) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2122523900 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)
@b4n commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32 +#ifdef _WIN32 @elextr because the *used* to use it, but replaced it with a different implementation (gnulib's IIUC) and we didn't sync this. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3878#discussion_r1607786955 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
@elextr I wouldn't trust X11R6 release notes on this :). It possibly was not useful back then, but it seems useful for transparency in apps. Then again I might lack knowledge on this, but it seems to be the generally accepted idea. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2121940052 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@xiota I don't know exactly the minimum version, but practically any should be ok, why you ask? The issue mentioned above is a change of behavior in glib 2.79. The plugin was admittedly using invalid syntax in the configuration files, but it went unnoticed because it worked fine. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2121933700 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@eht16 paste configuration issue should be fixed. But indeed it's unrelated to this PR, just to you using a newer GLib -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2121311153 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@b4n pushed 1 commit. 0e2de9fae3f6c23a1a048da046279222b1118ce7 geniuspaste: Fix replace configurations with GLib 2.79+ -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1342/files/7a86376bf18109af37cd534ce9e97ff298ed1012..0e2de9fae3f6c23a1a048da046279222b1118ce7 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
> Weird, here is Debian Testing but Geany is installed from GIT master. Yeah I meant separate Git install, not from Debian. But I got it, it's likely just you using a newer GLib than I am, and they made a incompatible change: https://gitlab.gnome.org/GNOME/glib/-/issues/3098 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2121295556 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)
@eht16 no, it's ctags, or rather glibc 2.10. Apparently though upstream ctags switched to gnulib's in universal-ctags/ctags#3054, so we might want to follow that… which might or might not solve this. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3660#issuecomment-2121229911 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Remove custom WIN32 compiler macro in favor of _WIN32 (PR #3878)
@b4n commented on this pull request. > @@ -418,7 +418,7 @@ static unsigned int re_string_context_at (const > re_string_t *input, int idx, #define re_string_skip_bytes(pstr,idx) ((pstr)->cur_idx += (idx)) #define re_string_set_index(pstr,idx) ((pstr)->cur_idx = (idx)) -#ifdef WIN32 +#ifdef _WIN32 Do we *really* want to modify this upstream-upstream dependency? I guess we'd at least need a patch or a special case in the copy script, because this looks overly fragile to me. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3878#pullrequestreview-2067028848 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@b4n pushed 2 commits. 4abbf8f4bc4095abf0bde1a97c11c5e7fc5301a9 fixup! Update CI for libsoup3 7a86376bf18109af37cd534ce9e97ff298ed1012 geniuspaste: Update TODO -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1342/files/17af2ad0706d7e092a130e6d7f0c091c831c5969..7a86376bf18109af37cd534ce9e97ff298ed1012 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
> No leftover configuration. I could reproduce this with pastebin.geany.org on > Linux and Windows. > After removing the keys from the `[parse]` section in > `geniuspaste/data/pastebin.geany.org.conf` so that the section remains empty > in the config, it works. What does the section contain?? because here (Debian) it works with the shipped configuration, even in a fresh separate install and configuration directory. > @b4n what do you think about the schemas compile problem? Can't we "simply" run `glib-compile-schemas` during GP (and possibly Geany) installation? it's e.g. what Linux distros would do (e.g. Debian has a trigger or whatever for whenever you install a new schema in the system directory so the compiled schemas are rebuilt) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2121184845 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-themes] Metallic Bottle: use a slightly darker background color for selections (PR #71)
Better, but what about `#ebdfd8`?  Still not great for readability, but a tad better and the whole theme doesn't focus on contrast it seems. Not that I care, it's indeed better to get input from actual theme users :slightly_smiling_face: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/pull/71#issuecomment-2121167791 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
> Sounds like its GTK thats misusing the visuals since its not just Geany thats > affected. Well, it could be that several apps don't properly check the presence of RGBA visuals and just assume they work. But indeed in Geany and Scintilla I don't see any obvious match. In GTK there are a few, but they all seem to handle the case the visual isn't found, and none seem related to selection, so I wouldn't think it's the issue. Maybe another library like VTE? Or indeed a bug in any of the component that is more subtle than just not checking the visual is NULL, I didn't check the actual code looking up the visual, and I probably wouldn't see the issue just looking at it anyway. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2120724784 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
@felixzng cool, that's also instructive and might allow to actually fix it. No guarantee, but at least we've got an idea where to look (unchecked usage of ARGB visuals) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2120427383 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Please just add a -i in the geany.desktop for not stuck in "other use socket" improperly. (Issue #3871)
Realistically the only thing we could do is add a button "Start a new instance anyway" kind of button to that dialog that would work as `-i`, or **maybe** offer to delete the problematic socket file as well, but that's not guaranteed to work either (depending on permissions). But that's adding support for a *fundamentally broken* use case. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3871#issuecomment-2120152925 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Please just add a -i in the geany.desktop for not stuck in "other use socket" improperly. (Issue #3871)
BTW, I want to point out that having other-user-owned files in your homedir is not a problem specific to Geany, and is gonna cause more trouble (and possibly more subtle) than just this message. Think impossibility to save (or possibly even read) configuration or plain files, etc. Check your homedir with e.g. `find ~ '!' -user "$USER"` (untested right now, but should be close enough): if you get any result, you might have issues with those files. You can limit that to `~/.config/` first if you have a lot of things in your homedir as s first indicator. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3871#issuecomment-211868 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)
> Just thinking, in #3859 I mapped matlab variables to `tm_tag_variable_t` so > they are displayed in the sidebar but maybe the result is a little too > verbose. Especially since it generates a tag for every variable assignment - > I just tried it with some random code from github and it displays lots of > identical variables in the sidebar, just every time the variable gets > assigned. > > So shouldn't we rather map it to `tm_tag_undef_t`? Hum yeah if it's gonna tag every variable assignment in the file regardless of scope, it's probably better to disable indeed, otherwise the more useful tags are likely gonna be hard to find. Maybe `tm_local_var_t` if we want, to still have goto stuff? Not sure if it's really useful though. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3877#issuecomment-2119389405 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Update ctags to p6.1.20240519.0 (PR #3877)
@b4n commented on this pull request.
Wanna laugh? https://github.com/universal-ctags/ctags/pull/4008 :smile:
> @@ -951,6 +951,7 @@ static TMParserMapEntry map_POWERSHELL[] = {
{'c', tm_tag_class_t}, // class
{'i', tm_tag_function_t}, // filter
{'g', tm_tag_enum_t}, // enum
+ {'e', tm_tag_undef_t}, // enumlabel
Should be mapped to `tm_tag_enumerator_t`, shouldn't it? It's usually mapped
to `"Variables"` / `TM_ICON_VAR` apparently (but here enumerators are always
gonna have a parent).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3877#pullrequestreview-2065159996
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Please just add a -i in the geany.desktop for not stuck in "other use socket" improperly. (Issue #3871)
>I don't think this would be better. >Then every time a new instance would be started which works indepedent of the >existing one. This is especially unconvenient when opening files via the >.desktop items (task bar, app menus, file managers, ...). Agreed, we ain't gonna do that. > The socket file message probably means either Geany crashed Does it lead to this? I don't think so > Geany was run as root or `sudo` and that still owns the socket link in your > config directory. More likely. This is another example of a misconfigured sudo that wrecks dotfiles in the user's directory */me sighs*. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3871#issuecomment-2119386492 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)
@techee FWIW, the PRs I wanted merged now are, so it's whenever you like :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#issuecomment-2115065344 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
I rebased against master to have a fixed CI, plus added @eht16 Windows bundle fixes -- hopefully this will help testing and finding out what's wrong :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2113570447 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@b4n pushed 7 commits. e7f19b79f4b9e200b3e23d645e3cf62c8a7ca7c9 geniuspaste: Port to libsoup3 bb4513ca7e2a7540461d07acbd4a365ce14be802 geniuspaste: Remove use of deprecated GTK API 80607621e5b1569737f3d2da8f3de6d830c9f706 geniuspaste: Enable HTTPS for paste.debian.net 62e02fafb549f6a0be22b9bb78dcda46e49cd9a3 Update CI for libsoup3 b7d63a448e31669fc847fc32c0b8a2881b4e649e geniuspaste: Replace dead dpaste.de with dpaste.org 4e7d6278a906b9d051e242217087e55e460dbf99 geniuspaste: Add dpaste.com 17af2ad0706d7e092a130e6d7f0c091c831c5969 geniuspaste: Silence a harmless warning with GLib 2.76+ -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1342/files/d336856411f9b8897b62c705da5944c29205647b..17af2ad0706d7e092a130e6d7f0c091c831c5969 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
> Then, I got a compiler warning which might or might not be new but still > worth to look at: > > […] It's actually not an issue (the buffer is taken the line before), but probably worth silencing. > When trying to paste some file, Geany crashes for me when it is executed > natively. I don't know yet why this happens and I didn't manage it yet to > debug it with gdb. This might be related to my system where I use some > firewall rules to block unwanted internet access from Windows and also have > proxy connections configured and after all, it is Windows 7. That's pretty bad :) I'd be nice to have more info, and possibly whether it's new or not. > When I start Geany from within the MSYS2 environment, pasting some file works > to some extend, at least no crash :). But the response look weird: […] The > link below "\1" is actually also "\1". > > The `response_str` in `pastebin_parse_response` is > "https://www.geany.org/p/6vzVo; which is correct. So there seems to be a > problem with parsing the URL. I don't know if this related to these changes > or not. This is weird, don't you have old leftover configuration for the plugin? This should only happen if your configuration has a `[parse]` section with an incorrect `replace` (if there are none, it would then use the default `\1`), e.g. one referencing a missing group in the `search` pattern. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2113534651 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)
Once this is dealt with that'd be fine: * https://github.com/universal-ctags/ctags/pull/3993 * https://github.com/universal-ctags/ctags/pull/3998 (new feature, so quite optional) * https://github.com/universal-ctags/ctags/pull/3999 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#issuecomment-2110226280 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)
@b4n approved this pull request. I didn't review all parser's changes (sorry :sob:), but the Geany changes, tests and behavior look good :+1: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#pullrequestreview-2053777392 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)
@techee I just added 2 more commits -- feel free to comment and reject them :) Anyway, looks good to me now. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#issuecomment-2108753021 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)
@b4n pushed 2 commits. 77614bd228aaba187faaef3631d127f231fce1f4 Map PowerShell classes and enums ae75c73b48db70a5d59e2dc02a566f1ebfa2ef46 Fix a JavaScript test -- View it on GitHub: https://github.com/geany/geany/pull/3859/files/acb4678486110d90dd46eb6dea336f5907cafb14..ae75c73b48db70a5d59e2dc02a566f1ebfa2ef46 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Document Comments in Python (Discussion #3869)
Closed #3869 as resolved. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3869 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)
@b4n commented on this pull request.
> +static TMParserMapGroup group_LDSCRIPT[] = {
+};
BTW, it's not merely a warning, but I had an error. However, it's a [GCC
extension](https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3859#discussion_r1597271684
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)
> Can do that. Should it be part of this PR or a separate one after this one is > merged? Whichever you prefer. I'd have said this one given it'll introduce yet another set of changes that are probably best diffed from current master, but I don't really mind either way in practice, so if it's easier for you just do another one afterwards. > > Tags p* are NOT releases, but probably pre-versions, or even nightly > > snapshots. Releases are v*. > > It's probably fine, but noteworthy > > OK, I didn't notice the release tags. But since these are just about once a > year, I guess we want the latest thing and "risk" the consequences, right? Yeah, I think we can "risk it" :slightly_smiling_face: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#issuecomment-2105264206 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)
@b4n commented on this pull request.
> @@ -557,6 +562,7 @@ static TMParserMapEntry map_FREEBASIC[] = {
{'t', tm_tag_struct_t}, // type
{'v', tm_tag_variable_t}, // variable
{'g', tm_tag_externvar_t}, // enum
+ {'n', tm_tag_undef_t}, // namespace
No clue about freebasic, but wouldn't it be worth including? kinds are already
silly, so the fact `tm_tag_namespace_t` is already in use is not really a
reason not to add it, is it?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3859#pullrequestreview-2050866317
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)
@b4n commented on this pull request. On tests/ctags/matlab_test.m.tags: that's a bit sad… I'll see if I can get those fixed upstream (it's easy enough to patch actually -- yet, I don't have a clue about matlab :grin: ) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#pullrequestreview-2050861477 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)
@b4n commented on this pull request.
> +static TMParserMapGroup group_LDSCRIPT[] = {
+};
This gives me:
```
src/tagmanager/tm_parser.c:1165:44: warning: ISO C forbids empty initializer
braces [-Wpedantic]
1165 | static TMParserMapGroup group_LDSCRIPT[] = {
|^
src/tagmanager/tm_parser.c:1165:25: error: zero or negative size array
'group_LDSCRIPT'
1165 | static TMParserMapGroup group_LDSCRIPT[] = {
```
Might be related to my pedantic flags, but that's a bit problematic.
What about having actual groups, even if unused?
```suggestion
static TMParserMapGroup group_LDSCRIPT[] = {
{N_("Section"), TM_ICON_STRUCT, tm_tag_struct_t},
{N_("Symbol"), TM_ICON_METHOD, tm_tag_method_t | tm_tag_function_t},
{N_("Version"), TM_ICON_OTHER, tm_tag_other_t},
{N_("Input Section"), TM_ICON_NAMESPACE, tm_tag_namespace_t},
};
```
Or just a dummy one?
```suggestion
static TMParserMapGroup group_LDSCRIPT[] = {
{"unused", TM_ICON_NONE, tm_tag_undef_t},
};
```
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3859#pullrequestreview-2050853725
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)
As nobody seemed horrified by this, I merged it so we can get CI working again. If there's any issue with this, we can always fix or revert. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1346#issuecomment-2105222322 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)
Merged #1346 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1346#event-12773739990 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)
Merged #3759 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3759#event-12773542349 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Document Comments in Python (Discussion #3869)
I don't think there is a way to get two different comment colors without modifying the lexer code and Geany's styling. However, the "pythonic" way is using triple-quoted strings (or well, I guess any string will do, but usually documentation is longer than that) as the first statement in e.g. a function. You can then access this in the `__doc__` property of the associated symbol. ```python def foo(): """This fooes around""" return 0xf00 print(foo.__doc__) ``` -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3869#discussioncomment-9389051 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)
BTW: > Sync our ctags to the latest tag version (p6.1.20240421.0) Tags `p*` are NOT releases, but probably pre-versions, or even nightly snapshots. Releases are `v*`. It's probably fine, but noteworthy :slightly_smiling_face: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#issuecomment-2104285016 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)
Regarding JS: > The only unexpected thing is the behavior of the javascript parser - this is > from the javascript commit message: > > There are lots of differences because of > > [universal-ctags/ctags@6d85089](https://github.com/universal-ctags/ctags/commit/6d85089456ed215ce6b6a673744ae42ccc5e0e99) Yeah, all this look OK. Some can be viewed as implementor's choice, but it's fair so I'm fine with it. > Also > > [universal-ctags/ctags@b1870b8](https://github.com/universal-ctags/ctags/commit/b1870b826a384c35671937743720464947af3b7e) > > seems to confuse the parser in simple.js so it doesn't generate > `my_global_var2`. Despite what's in the test file, this is *not* valid JS (AFAICT, or as far as SpiderMonkey tells me), so it's understandable the parser doesn't get along very well with it. If you add a semicolon after it it fixes it, as it then consider it the end of the construct and "resets" itself. > Finally, Geany reports > > ``` > (geany:820768): Tagmanager-WARNING **: 20:38:28.755: ignoring null tag in > /home/parallels/projects/geany/doc/reference/jquery.js(line: 2, language: > JavaScript) > ``` Is this actually anything new? I just fixed a few upstream in https://github.com/universal-ctags/ctags/pull/3993, but I believe we already had this before. Also, there's one instance in that jQuery code where it's somewhat expected, as there is indeed a zero-length property. For that remaining one, I'm not sure what the parser should do, as it can't really emit an empty name (format would probably not accept it, and anyway consumers are unlikely to like it), yet there *is* one in the input… > @b4n Does the PR in general and the javascript parser in particular look good > to you? I didn't investigate the javascript parser differences much as I'm > not a javascript user myself. At least the NULL warning should be fixed > though. Yeah, the JS changes look (almost) fine. I raised a couple issues upstream, but it's nothing serious nor that actually affect us much (see e.g. https://github.com/universal-ctags/ctags/issues/3995 and https://github.com/universal-ctags/ctags/issues/3997). Two things: * we should probabmy use a newer snapshot (some parser changes, e.g. related to class vs. object vs. variable are gonna lead to additional test result changes, which are admittedly better in the newer version, and I'm not sure it's worth having an intermediary step here) * we should probably rather fix *simple.js* test to remove the invalid syntax that confuses the parser. I'll try and do that Soon™. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#issuecomment-2104282900 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Unable to "Build" using Geany (Issue #3863)
> ```shell > gcc -Wall -o "%e" "%f“ `pkg-config --cflags gtk+-3.0` > -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_0 `pkg-config --libs gtk+-3.0` > ``` The issue you have is that the 4th quote (after the `%f`) is not an ASCII quote, but U+201C *Left Double Quotation Mark*. Just replace the command with: ```shell gcc -Wall -o "%e" "%f" $(pkg-config --cflags gtk+-3.0) -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_0 $(pkg-config --libs gtk+-3.0) ``` and you'll be on your way (I also replaced the `\`\` with `$()` because it can be nested, and generally creates less problem when you modify the command -- but functionally it's the same here). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3863#issuecomment-2092822069 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)
(just updated d0192a3621e2505f2fcf6bc1c390278b2396749e to use a more precise cppcheck suppression) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1346#issuecomment-2091810652 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)
If there's an option for it, sure (I didn't understand that was something you would be happy about). And I don't mind the default on non-Linux either, whatever people like best on those platforms. It would be nice to have this available on Linux as well (**but off by default**) for the sandboxing caps -- although I'm not really sure whether "sandboxing" an editor/IDE really makes much sense, but well, it has been mentioned quite a few times. > File filters work both on Windows and macOS That's nice. And indeed, the [documentation](https://docs.gtk.org/gtk3/class.FileChooserNative.html#win32-details-gtkfilechooserdialognative-win32) lead me to think it wouldn't work with out patterns, but [custom filters](https://docs.gtk.org/gtk3/method.FileFilter.add_custom.html) are actually something else. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3861#issuecomment-2089817883 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
This PR won (IMO), so it's the one to review @frlan -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2089096951 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
Closed #1340. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#event-12673653995 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
Yeah I agree, better stick with libsoup then, although relying on an existing component was an interesting idea. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2088925494 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)
Thanks for the replies So unless I made a huge mistake (maybe cppcheck my code fixes ), I suggest merging this and seeing where it leads us — at the very least it makes the checks green again, and it did reveal a few leaks. It finished in 10 minutes which is not so bad I'd say. If it's a problem, maybe we could see if there's a cppcheck GH action or so to parallelize it and some goodies maybe. And if some code is really too poorly maintained and cppcheck starts showing it, maybe the sane approach is getting rid of it rather than distributing a time bomb. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1346#issuecomment-2088860391 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)
> > not using --library=gtk > > See #1197 for why its needed I'm on my phone so can't ask git for details, but l just added it here, so either I bluntly missed it somehow, or it got removed in the meantime, which would be concerning for re-adding it here… > ... should we switch to C++ where its all built into the compiler and doesn't > need another tool to apply spurious checks. I'm serious, That's just the C++ grumpy old guy talking, because it's simply not true Sure C++ has more memory management goodies, but you have to use them in the first place, building the current codebase with a C++ compiler won't magically fix things -- well, it likely won't build without some patching, so in a sense it would avoid all issues… > > I'm not sure it has any value… does it? > > Oh how tempting . nah, I'll be nice. That's clearly quote misuse… but I laughed, so I give it a pass > My 2c is that most plugins are so poorly maintained that if you add > cppchecking that actually checks much, you will be the one making the > patches. You are just adding to your workload. Hopefully it won't find many more issues in the existing code, but could on new one. Though, it's like with all those imperfect tools, the user has to be able to tell whether a warning is meaningful or not, and how to handle it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1346#issuecomment-2088128774 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)
> * Use a version that doesn't require the exhaustive checking (@eht16 why do > we use latest version in the first place? I see > [1562ca0](https://github.com/geany/geany-plugins/commit/1562ca07500505ab396fe99ce19cb211d1c2c8fa) > but no rationale… and if it's that the version in Ubuntu 20.04 is too old > for something, maybe using 22.04 would be enough?) OK, I see #1310 now. Well, maybe we could either be OK with this, use a version that doesn't require this (and hope for a fix), or see if playing with other options has a significant impact without drastic check quality reduction (that last option I'm no hopeful about, because I already did play with it a bit). > * we could avoid running cppcheck in the distcheck phase, I'm not sure it has > any value… does it? I tried disabling this in the last commit above, we'll see what it changes -- but I can still revert that if you think it's a bad idea. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1346#issuecomment-2087576237 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)
@b4n pushed 1 commit. a34f3a35f92598242888982014e3d8b36c763b4f ci: Disable cppcheck on distcheck -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1346/files/119676eabff36ec59f1bbcac5889a0e1cf66cc13..a34f3a35f92598242888982014e3d8b36c763b4f You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)
21 minutes might be a tad long… 2 things we could to: * Use a version that doesn't require the exhaustive checking (@eht16 why do we use latest version in the first place? I see 1562ca07500505ab396fe99ce19cb211d1c2c8fa but no rationale… and if it's that the version in Ubuntu 20.04 is too old for something, maybe using 22.04 would be enough?) * we could avoid running cppcheck in the distcheck phase, I'm not sure it has any value… does it? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1346#issuecomment-2087550340 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)
@b4n pushed 10 commits. 3d1a5aa72b4e3905e0da108ec1c3a5033bc7961c ci: Enable exhaustive cppcheck checking e3f2816ceb5ec08bd16597c045b130c3d18e43ea cppcheck: Enable inline suppression hints 98fc4fb79834e19bca025626f3d6c53aed3038c2 addons: Fix memory leak detected by cppcheck 1e5d1581a296404276af7a4326d2cf48e8ec9d07 geanyprj: Fix memory leak detected by cppcheck 60a0cce2c2421132006af3a0c658e2b91499 workbench: Fix memory leak detected by cppcheck bdf27a12e48124975a735814518f8ba2eba11ee5 geniuspaste: Fix memory leak detected by cppcheck 697ece0ee4949582c3ece8f0c368357d04532181 markdown: Slightly rewrite two tests for cppcheck's sake 8ca610c273b8780cd9083b0ab7cc41e4fdfb6446 cppcheck: Add inline suppressions for false-positives 0ac49b67b38fb82da9751032620249da526229e2 Remove obsolete cppcheck suppressions 119676eabff36ec59f1bbcac5889a0e1cf66cc13 treebrowser: Move cppcheck suppressions inline -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1346/files/7190ef3b4e9382625ba0cd11fa022b9eb9e81a16..119676eabff36ec59f1bbcac5889a0e1cf66cc13 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)
Lets try to make cppcheck work again, and even report useful stuff. During the journey it found a few actual issues, which is good. It also found some false-positives, which isnt so good. We probably could reduce the false positives by not using `--library=gtk`, but that also would reduce the actual issues it can find. There are a few issues that should be reported upstream, but its harder than it looks… if I could only remember my password on their tracker :confused: Anyway, what do you guys think? Is it good? Are there too many false-positives? Should the suppressions be moved back to `AM_CPPCHECKFLAG`s not to alter the code, although it makes it harder to maintain? You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1346 -- Commit Summary -- * cppcheck: Enable parallelism to match Make call * cppcheck: Properly define GETTEXT_PACKAGE globally * cppcheck: Undefine GEANY_PRIVATE * cppcheck: Use cppchecks own gtk support * cppcheck: Define the common plugin defines to their actual values * ci: Enable exhaustive cppcheck checking * cppcheck: Enable inline suppression hints * addons: Fix memory leak detected by cppcheck * geanyprj: Fix memory leak detected by cppcheck * workbench: Fix memory leak detected by cppcheck * geniuspaste: Fix memory leak detected by cppcheck * markdown: Slightly rewrite two tests for cppchecks sake * cppcheck: Add inline suppressions for false-positives * Remove obsolete cppcheck suppressions * treebrowser: Move cppcheck suppressions inline -- File Changes -- M .github/workflows/build.yml (2) M addons/src/ao_tasks.c (11) M build/cppcheck-geany-plugins.cfg (4) M build/cppcheck.mk (6) M geanyctags/src/geanyctags.c (2) M geanygendoc/src/ggd-options.c (1) M geanyprj/src/Makefile.am (3) M geanyprj/src/utils.c (3) M geniuspaste/src/geniuspaste.c (5) M git-changebar/src/gcb-plugin.c (1) M markdown/src/conf.c (4) M scope/src/Makefile.am (2) M scope/src/debug.c (4) M treebrowser/src/Makefile.am (3) M treebrowser/src/treebrowser.c (2) M vimode/src/cmd-runner.c (2) M workbench/src/sidebar.c (6) M workbench/src/wb_project.c (4) M workbench/src/workbench.c (4) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1346.patch https://github.com/geany/geany-plugins/pull/1346.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1346 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@b4n pushed 1 commit. d336856411f9b8897b62c705da5944c29205647b Update CI for libsoup3 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1342/files/0e025a780b403c083c1d3dcfede8c42a3c26d865..d336856411f9b8897b62c705da5944c29205647b You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@b4n commented on this pull request. > @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE], GP_ARG_DISABLE([GeniusPaste], [auto]) GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE, - [libsoup-2.4 >= 2.4.0]) + [gtk+-3.0 >= 3.16 @eht16 Seems to work, but that hit the cppcheck issue again, do you know anything about that? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#discussion_r1582356142 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@b4n pushed 4 commits. 125fe5376e806fb26612d6af1505b639efe8f0df geniuspaste: Port to libsoup3 bb27723f0bea02016036573524570001f1b7a443 geniuspaste: Remove use of deprecated GTK API 1c3ca837f59d98f1b4d26ef69a102049fe6eb391 geniuspaste: Enable HTTPS for paste.debian.net 0e025a780b403c083c1d3dcfede8c42a3c26d865 Update CI for libsoup3 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1342/files/7758920773f9918f1a672064434122ea674e5a79..0e025a780b403c083c1d3dcfede8c42a3c26d865 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@b4n pushed 1 commit. 7758920773f9918f1a672064434122ea674e5a79 Update CI for libsoup3 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1342/files/ab31775cbaa1fc401d5c7c0aa8231726d0729f4e..7758920773f9918f1a672064434122ea674e5a79 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@b4n commented on this pull request. > @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE], GP_ARG_DISABLE([GeniusPaste], [auto]) GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE, - [libsoup-2.4 >= 2.4.0]) + [gtk+-3.0 >= 3.16 Indeed, trying it now -- but that also requires bumping the Ubuntu version because 20.04 doesn't have it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#discussion_r1582327000 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
@b4n pushed 2 commits. bdd4db94934400b447c8a7d5de2a7c5cd3740bf0 geniuspaste: Enable HTTPS for paste.debian.net ab31775cbaa1fc401d5c7c0aa8231726d0729f4e Update CI for libsoup3 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1342/files/4ea2725da6e3a26e8ff6fb178f3b0125f04b24bd..ab31775cbaa1fc401d5c7c0aa8231726d0729f4e You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)
@b4n commented on this pull request. LGTM, indeed the ABOUTs don't seem useful, and for numberedbookmarks it's an old version of README including typos that have been corrected. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1343#pullrequestreview-2027207516 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] latex: improve readme (PR #1343)
@b4n commented on this pull request.
> +* Wizard to create new LaTeX documents in a fast and easy way
+ with a bunch of templates available
+
+* A front end for add labels ``\label{}`` and references ``\ref{}`` and
+ ``\pageref{}`` with getting suggestion from aux file of document
+
+* Inserting special characters through menu
+
+* Help entering the right fields for BibTeX entries by
+ providing templates
+
+* Easy inserting format patterns like ``\texttt{}`` through menu
+
+* Support on inserting environments by offering an dialog and
+ recognising selections
+
+* Shortcuts for inserting ``\item`` and ``\newline``
+
+* Toolbar with often used format options
I'd remove blank lines between the items (but it works like that)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1343#pullrequestreview-2027207317
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)
> The bad news is that it doesn't work too. > I have added it, closed geany, reopen and all is the same. WFM, looks like that: Default:  Adding `lexer.bash.styling.inside.string=1`  Adding `lexer.bash.styling.inside.backticks=1`  Adding `lexer.bash.styling.inside.heredoc=1`  > One question: what is the correct: altering via Geany Tools, ... or editing > directly in the file /usr/share/geany/file... Because opening in Tools, all lines appear commented and is is different from the same file in /usr/share/geany/file... What is actually used ? Both are used together. If something is not defined in the user's configuration, the value is looked up in the /usr/share one (or whatever the Geany installation path is). All you need to do is go through Tools… and replace the whole content with literally what I mentioned above. Or add it (uncommented) somewhere. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3860#issuecomment-2081489596 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
> I "think" it will work. > In detail this is, when querying https://geany.org/ I get an error: `GET > request failed: WinHttp error: SECURE_CHANNEL_ERROR`. […] > > If I change the URL to query to https://httpbin.org/anything/version, the > HTTP request works fine and I get the expected response. > > So it probably works provided one uses an up to date operating system. OK, might be either TLS versions or certificates not installed I guess. Does the libsoup version work any better? (I doubt it, but who knows) > The thing is that I didn't even manage to get tls running correctly (it > compiled but https didn't work afterwards, probably some configuration issue) > so the updatechecker plugin isn't part of the macOS release. What do you mean, with GIO, with libsoup, with anything? If it doesn't work neither on macos not Windows, it starts to feel like nobody is gonna be using it :laughing: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081484303 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)
Try adding this in *filetypes.sh* (you can open it from *Tools → Configuration files → Filetypes configuration files → Scripting languages*): ```ini [lexer_properties] lexer.bash.styling.inside.string=1 lexer.bash.styling.inside.backticks=1 lexer.bash.styling.inside.parameter=1 lexer.bash.styling.inside.heredoc=1 ``` We probably should use all or some by default, we'd just need to check what defaults make more sense, and what the limitations might be. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3860#issuecomment-2081476762 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
@elextr you never know what the future of the web holds, but I highly doubt a security issue would ruin the current API. A new feature maybe, but well. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081379570 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] color priority/precedence (Issue #3860)
That's not how things work here, the identifier id either recognized as such anf given a separate style (which we might or might not draw the same as a string), or it's not recognized and thus is considered a string. Which language do you have issue with? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3860#issuecomment-2081376204 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Sync our ctags to the latest tag version (p6.1.20240421.0) (PR #3859)
I'll look into this Soon™, but the JS changes might have an issue (might be what you see, might be something else), see [this](https://github.com/universal-ctags/ctags/commit/6d85089456ed215ce6b6a673744ae42ccc5e0e99#diff-eb186936271438240da764e7ccf36ffa04ba8f0a6e1eabd1c69400164ae9f608R1) which doesn't look right to me. In any case, thanks for doing this :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3859#issuecomment-2081175172 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] codenav/goto_file: Fix use-after-free crash (PR #1339)
@b4n approved this pull request. LGBI, makes sense. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1339#pullrequestreview-2026699270 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
Merged #1295 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#event-12632694851 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
> Yeah, but then its back to four plugins to synchronise on > libsoup3/webkit2gtk-4.1. Yet, does it currently matter? I mean, the code is ready (but for more testing maybe) for all four now, porting isn't what is holding back anymore. Sure the question might arise again for a future libsoup4 (if they don't make it possible for those to coexist in a process), but that doesn't seem to be around the corner just yet. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2080756552 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
> It didn't appear to do either. No popup or message in status or msgwin on > success. I don't recall seeing anything but some usual gtk errors in terminal. Weird… unless you have a libsoup2 plugin loaded? IIUC nothing will stop you from doing so, but things will just perform bizarrely (or crashingly). Or maybe the plugin has more issues than I can see myself. > > ... by default the pastes are deleted after a while, and it just means that > > nobody had made a forever-paste since then. > > I don't see how to use the geany pastebin service without the plugin. There's > no web form I can find. Ah, indeed, it was removed due to spam… quoting @eht16 from an internal mail: > I removed the form to create new snippets and related code [due to recurring > spam]. > Only the API endpoint is still available for the GeniusPaste plugin. So indeed, only the plugin (or another API-based tool, like an ld pastebinit configuration I have laying around). Anyway, that doesn't change much on whether this says anything to whether the plugin is in use or not, as the snippets expire anyway. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2080748702 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] projectorganizer: Add popup panel for navigation (PR #1341)
@b4n requested changes on this pull request.
LGTM, see inline comments.
Apart from that, I was kind of disappointed that the "goto file" only lists
Geany open documents rather than the project's documents -- maybe you'd like to
add that?
Also, I hoped to be able to go to a specific file's line, not only in the
current file -- but that's probably less useful in practice.
> + GPtrArray *arr = g_ptr_array_new_full(0,
> (GDestroyNotify)prjorg_goto_symbol_free);
+ gint lineno = atoi(line_str);
+ gint linenum = sci_get_line_count(doc->editor->sci);
+ guint i;
+
+ for (i = 0; i < 4; i++)
+ {
+ PrjorgGotoSymbol *sym = g_new0(PrjorgGotoSymbol, 1);
+
+ sym->file_name = utils_get_utf8_from_locale(doc->real_path);
+ sym->icon = _ICON_OTHER;
+
+ switch (i)
+ {
+ case 0:
+ sym->name = g_strdup(_("line typed above"));
This string and the ones below are probably worth a translator comment, and
possibly even a translation context.
> + }
+ pos = new_pos;
+ }
+ end_pos = pos;
+
+ if (start_pos == end_pos)
+ return NULL;
+
+ return sci_get_contents_range(sci, start_pos, end_pos);
+}
+
+
+static void goto_panel_query(const gchar *query_type, gboolean prefill)
+{
+ GeanyDocument *doc = document_get_current();
+ gint pos = sci_get_current_position(doc->editor->sci);
:warning: dereferencing `doc` which is tested against `NULL` further down. And
the `NULL` check makes sense in the (unlikely) case no document is open.
> + * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301,
USA.
+ */
+
+/* This file contains mostly stolen code from the Colomban Wendling's Commander
You're welcome :laughing:
> + gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, , );
+ }
+ return gtk_icon_theme_load_icon(icon_theme, icon_name, x, 0, NULL);
+}
+
+
+static GdkPixbuf *get_icon_pixbuf(gint icon)
+{
+ if (!geany_icons[_ICON_CLASS].pixbuf)
+ {
+ guint i;
+ for (i = 0; i < G_N_ELEMENTS(geany_icons); i++)
+ geany_icons[i].pixbuf =
get_tag_icon(geany_icons[i].icon_name);
+ }
+
+ if (icon < _N_ICONS)
```suggestion
if (icon < G_N_ELEMENTS(geany_icons))
```
maybe?
> +
+ case GDK_KEY_Return:
+ case GDK_KEY_KP_Enter:
+ case GDK_KEY_ISO_Enter:
+
tree_view_activate_focused_row(GTK_TREE_VIEW(panel_data.tree_view));
+ return TRUE;
+
+ case GDK_KEY_Page_Up:
+ case GDK_KEY_Page_Down:
+ case GDK_KEY_KP_Page_Up:
+ case GDK_KEY_KP_Page_Down:
+ {
+ gboolean up = event->keyval == GDK_KEY_Page_Up ||
event->keyval == GDK_KEY_KP_Page_Up;
+
tree_view_move_focus(GTK_TREE_VIEW(panel_data.tree_view),
+ GTK_MOVEMENT_PAGES, up ? -1 : 1);
+ return TRUE;
```suggestion
return TRUE;
```
> +
+ if (!symbols)
+ return ret;
+
+ tf_strv = g_strsplit_set(filter, " ", -1);
+
+ for (i = 0; i < symbols->len && j < 100; i++)
+ {
+ PrjorgGotoSymbol *symbol = symbols->pdata[i];
+ gchar *normalized_name = g_utf8_normalize(symbol->name, -1,
G_NORMALIZE_ALL);
+ gboolean filtered = FALSE;
+ gchar **val;
+
+ foreach_strv(val, tf_strv)
+ {
+ gchar *normalized_val = g_utf8_normalize(*val, -1,
G_NORMALIZE_ALL);
Maybe you could normalize the filter before splitting it?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1341#pullrequestreview-2026639258
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
@elextr hence checking if it does :) But if it's a concern, just keep using the libsoup implementation, it *ought* to work with HTTP as that's the whole point of that library :smiley: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2080630460 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
> Do Debian and Ubuntu even bother rebuilding packages for old releases? No, the dependency only matter for users of older releases that would like to build a newer Geany by themselves. And Debian was just an example, sometimes we check what even more slow-paced distro do, like RHEL or so. Anyway, I don't think this should be a reason to go one direction or another myself, as staying with libsoup2 is causing issues on current and future distros, and again I won't add support for selecting the one to use myself. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2080624014 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
> After testing the plugin, I think it should be dropped. Most of the pastebins > don't work. Indeed only 3 did in my tests (Geany's, Debian's and Sprunge) > There's no confirmation of what it's sending. […] Once data is sent, there's > no way to delete it, which is a security risk if accidentally (or > maliciously) triggered. It's indeed unfortunate that it doesn't report deletion URL for pastebins that support it. > Half the time, there's no way to view the pastebin after it's sent because > plugin failed to open browser on my computer, and didn't print any message > indicating issue, or where to get pastebin, etc. (The other half, were error > popups.) Failing to open the browser is odd, because it uses Geany's own `utils_open_browser()`, so that suggests this doesn't work for you either? Though, note that the default behavior is to show the URL, not open it. > The pastebin that did work (https://pastebin.geany.org/) hadn't been used > since Dec 2022. So the plugin probably isn't being used. That part is not true: it's just that by default the pastes are deleted after a while, and it just means that nobody had made a forever-paste since then. Also, https://paste.debian.net works, albeit not for single-line pastes (but indeed the plugin fails to report the error). It's not to say that the plugin *is* used though, it might not be. --- Anyway, as @elextr said this has been abandoned by it's author, and I've been surprised of the amount of work I did put in it myself over the years (not that I really mind, but I don't think of myself as the maintainer). I think that this plugin has some occasional use (although I don't myself, and it lacks support for some popular ones like gists), but I won't weep over its coffin if that should be its fate. Also, there are some competent tools around that might be a worthy replacement, like [pastebinit](https://github.com/pastebinit/pastebinit) that could probably be wrapped to offer a similar featureset. Pastebin service support might however be easy enough to improve; it's configuration files that need to be added/removed/adapted to pastebin service changes. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2080606715 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
@techee any chance you could check whether gvfs works with HTTP(S) under macos? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2080478237 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
Thanks for review & testing! BTW, a few things things to note: * libsoup3 is fairly recent (2021-09-18), and e.g. not available in Debian before Bookworm (12, current stable) * I probably won't make it possible to support both libsoup2 and libsoup3, because the changes are too complex which would make the code somewhat of a nightmare. * This means that other plugins *have* to be compiled against e.g. webkit2gtk 4.1, not 4.0. Is that OK with everybody? @elextr @frlan It is with me, I feel it's OK for the plugin to live in the present, and with the webkit question we don't really have a choice (apart from process isolation). Also, maybe this means we want to drop support for webkit2gtk 4.0 in the other plugins, or have a fancy check in the build system to try and avoid the case where different plugins use incompatible libraries -- but that's gonna be non-trivial, and probably not worth it. Also a subsequent improvement would be to use the asynchronous libsoup API, because now it blocks the UI. Before this PR, it *looked* a bit better because IIUC (not verified) one of the libsoup calls spun the main loop manually, but this likely had some unexpected side effects of its own. I will try *not* to include this here. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342#issuecomment-2080472478 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)
Many pastebins dont work, but its not new to the changes here… CC @xiota @jbicha You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1342 -- Commit Summary -- * geniuspaste: Port to libsoup3 * geniuspaste: Remove use of deprecated GTK API -- File Changes -- M build/geniuspaste.m4 (3) M geniuspaste/README (4) M geniuspaste/src/geniuspaste.c (95) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1342.patch https://github.com/geany/geany-plugins/pull/1342.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1342 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
@xiota I don't think we need to explore a *different* additional HTTP library; either we only use what's already part of the general GTK stack, or using libsoup which is also a direct or indirect dependency of 3 other plugins is fine. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2079813014 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
See #1340 if wanted. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079550087 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)
Same as #1336 but using GIO instead of libsoup. If wanted? CC @elextr @xiota @frlan. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1340 -- Commit Summary -- * updatechecker: Port to libsoup3 * updatechecker: Dont leak the libsoup session * updatechecker: Avoid a deprecated call * updatechecker: Remove weird German quotes * updatechecker: Port from libsoup to plain GIO -- File Changes -- M build/updatechecker.m4 (2) M updatechecker/README (6) M updatechecker/src/updatechecker.c (145) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1340.patch https://github.com/geany/geany-plugins/pull/1340.diff -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340 You are receiving this because you are subscribed to this thread. Message ID: geany/geany-plugins/pull/1...@github.com
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
Note that writing an async version of the feature, while reasonably easy, is a little bit more work. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079476011 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
hum… @elextr @xiota so what's your conclusion? Depend on libsoup3 as this PR because it's HTTP, or depend on a GVFS backend for HTTP? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079474204 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
@b4n commented on this pull request.
> @@ -950,6 +1005,23 @@ gwh_browser_set_uri (GwhBrowser *self,
g_free (real_uri);
}
+gboolean
+gwh_browser_set_uri_from_document (GwhBrowser*self,
+ GeanyDocument *doc)
+{
+ gchar *uri;
+
+ /* document must exist on disk */
+ if (! doc || ! doc->real_path)
+return FALSE;
+
+ uri = g_strconcat ("file://", doc->file_name, NULL);
No, `doc->real_path` is used to verify the document is actually saved to a
file, but it's in locale encoding, whereas `doc->file_name` is the expected
UTF-8. Admittedly, it might not behave properly if the locale is non-UTF-8 and
the file path contains non-ASCII characters; but at least the worse that would
happen would be the file not being found.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#discussion_r1581062630
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] [FR] Use XDG desktop portal filechooser instead GTK on Linux/BSD (Issue #3458)
The main issue with native dialogs/portals, is that they have reduced feature set, see e.g. [GtkFileChooserNative](https://docs.gtk.org/gtk3/class.FileChooserNative.html). And some might be a problematic trade-off for our use cases. Also note that I can't read anything in the link above about the portals being used outside of a sandboxed app, so I'm not sure if it would happen. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3458#issuecomment-2079420019 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to libsoup3 and small other fixes (PR #1336)
Yeah I guess using GIO directly for this kind of super simple GET would make sense Indeed. I also think that gvfs will indeed be part of all reasonable GIO installations, but I could be wrong. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1336#issuecomment-2079187953 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
And voila, I got plagued with another round of cleanups :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#issuecomment-2078136827 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
@b4n commented on this pull request. > @@ -26,9 +26,9 @@ Prominent features Requirements -This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18), -GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to -work. If you intend to build it yourself, you will need to get the development +This plugin requires GTK3, GLib (>= 2.22), GIO (>= 2.18), GdkPixbuf (>= 2.0), +WebKit2GTK (either API 4.0 or 4.1), and obviously Geany (>= 0.20) to work. Probably -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#discussion_r1580097533 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
@b4n pushed 5 commits. 52ab3ebefc8fdf805b081bac74efaec442c82529 webhelper: Use modern GObject private data 9f420e09447cc2f8a57e4880dfa99bebc67734e7 webhelper: Replace use of deprecated GtkVBox with GtkBox 3edea3f891cdbe241d63d2b4b37ef4c5eea035c4 webhelper: Remove use of deprecated g_thread_init() 9eb5d4630a1449d8c4ea13926631f23f447f85fe webhelper: Replace deprecated g_value_set_char() 8b17184e6a2eecfd598367d9f9783e9abbcd984f webhelper: Update minimal requirements -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1295/files/8ee8a92a9eb7276ae210e376e0b80d271f885162..8b17184e6a2eecfd598367d9f9783e9abbcd984f You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)
Merged #1335 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1335#event-12612366928 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
@b4n commented on this pull request. > @@ -26,9 +26,9 @@ Prominent features Requirements -This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18), -GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to -work. If you intend to build it yourself, you will need to get the development +This plugin requires GTK3, GLib (>= 2.22), GIO (>= 2.18), GdkPixbuf (>= 2.0), +WebKit2GTK (either API 4.0 or 4.1), and obviously Geany (>= 0.20) to work. Damned :smile: Simple to add, yes, but simple to figure out, not so much. I sometimes wish there was a generic tool that can *reliably* scan the code an tell me "ok, you need libfoo >= 1.2.3 (because of $reason), libbar 42.0 (because of $othereason), …", but well. I had a script that did something like that ad-hoc grepping GTK documentation and the code to try and get an idea, but not sure if it still works, and it never was truly reliable. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#discussion_r1579574079 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1232)
Merged #1232 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1232#event-12607573353 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] When the "Markdown" plug-in is enabled, opening a markdown file containing "@@markdown@@" always freezes. (#936)
Closed #936 as completed via #1232. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/936#event-12607573756 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1232)
Oopsie, I didn't check the OP, only the commit message :confused: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1232#issuecomment-2077050321 You are receiving this because you are subscribed to this thread. Message ID:
