[Github-comments] Re: [geany/geany-themes] Flatpak directory location (Issue #47)

[Enrico Tröger via Github-comments]

> @eht16 be polite. I did the groundwork beforehand. The archive sure does look 
> official - https://flathub.org/apps/org.geany.Geany

My post wasn't meant to sound that rude, sorry for that. But I guess you got my 
point.

Probably not necessary to say after your last post 
(https://github.com/geany/geany-themes/issues/47#issuecomment-2094799789) but 
apart from the political issues, there is probably less to no benefit from a 
technical point of view to use Geany as Flatpak for most users.

So, as long as there is no real indication or reason to use a Flatpak, I'd say 
you are better and easier when using Geany as a normal, native application.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/issues/47#issuecomment-2094812166
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

[Enrico Tröger via Github-comments]

Nice.

I think we could add this new filetype and then update the wiki page to have it 
only a seperate docker-compose filetype and a reference to the GIT version of 
this Docker filetype. I'm happy to do this after merge.

Regarding the `extension=` setting: what do you think about using lower case? 
So that new files will be named "untitled.dockerfile". I don't know if there is 
a correct answer at all but IIRC what I've seen when there are mutliple 
dockerfiles is rather something like "Dockerfile.dev" or 
"Dockerfile.production" but we don't support this ordering in Geany.
So, when using extensions, they are usually written in lowercase in my 
experience.

For the reasons outlined above, I would add to the filetype extension list the 
pattern "Dockerfile.*" as this is more common than the others in my experience.

Do we need to adjust anything for the Meson build system?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3757#issuecomment-2094212685
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



> @@ -0,0 +1,14 @@
+[styling=Sh]
+
+[keywords]
+primary=ADD ARG CMD COPY ENTRYPOINT ENV EXPOSE FROM HEALTHCHECK LABEL 
MAINTAINER ONBUILD RUN SHELL STOPSIGNAL USER VOLUME WORKDIR
+
+[lexer_properties=C]

```suggestion
[lexer_properties=Sh]
```
Or am I missing something?
It won't make much difference as the lexer properties for the C lexer will be 
probably ignored by the Sh lexer. But to be less confusing, I think it inherit 
from "Sh".

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3757#pullrequestreview-2039357473
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

[Enrico Tröger via Github-comments]

> Maybe one more question - should the open dialog show hidden files by 
> default? [...]
> I'm not sure if it's possible on Windows too though (on the other hand 
> Windows hidden files aren't so important I think because it's not those 
> beginning with `.` like `.gitignore` that typical developer needs to edit).

I don't think it's necessary because as you said, hidden files on Windows are 
usually less relevant and have stronger means than on Linux.
The dialog in the current configuration shows files like `.gitignore` and this 
is good, I think.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2094125442
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-themes] Flatpak directory location (Issue #47)

[Enrico Tröger via Github-comments]

Closed #47 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/issues/47#event-12704196950
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-themes] Flatpak directory location (Issue #47)

[Enrico Tröger via Github-comments]

Why do you use Geany as Flatpak at all?
I don't understand why users go this way and then wonder why things won't work.

This issue is clearly caused by the Flatpak package and should be reported to 
the maintainers of this package - whoever this is, it is very well hidden on 
FlatHub and falsely marked as "by Geany Team".

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/issues/47#issuecomment-2094123941
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

[Enrico Tröger via Github-comments]

I tried to test it on Windows but got mixed results :(.

First, we need more dependencies on Windows:
```
diff --git a/build/gtk-bundle-from-msys2.sh b/build/gtk-bundle-from-msys2.sh
index 408d727f..529fa24a 100644
--- a/build/gtk-bundle-from-msys2.sh
+++ b/build/gtk-bundle-from-msys2.sh
@@ -21,7 +21,7 @@ EXE_WRAPPER_64="mingw-w64-x86_64-wine"
 # enchant, hunspell - for SpellCheck plugin
 # lua51 - for GeanyLua plugin
 # gnupg, gpgme - for GeanyPG plugin
-# libsoup - for UpdateChecker plugin
+# libsoup3 - for UpdateChecker & GeniusPaste plugins
 # libgit2 - for GitChangeBar plugin
 # gtkspell3 - for GeanyVC plugin
 # the rest is dependency-dependency
@@ -30,6 +30,7 @@ ca-certificates
 ctags
 ctpl-git
 enchant
+glib-networking
 gnupg
 gpgme
 http-parser
@@ -39,8 +40,9 @@ libgcrypt
 libgit2
 libgpg-error
 libidn2
+libproxy
 libpsl
-libsoup
+libsoup3
 libssh2
 libsystre
 libunistring
```
(The diff probably won't apply cleanly against this PR but should be easy 
enough to adopt, sorry.)
It is important to remove "libsoup" as it cannot be installed together with 
"libsoup3". There is a runtime warning when both libraries are loaded.
This obviously has a direct impact on the UpdateChecker plugin, so we probably 
need to merge them in order and rebase the latter one after the first one is 
merged.

Then, I got a compiler warning which might or might not be new but still worth 
to look at:
```
In file included from C:/msys64/mingw64/include/glib-2.0/glib/giochannel.h:36,
 from C:/msys64/mingw64/include/glib-2.0/glib.h:56,
 from C:/msys64/mingw64/include/glib-2.0/gobject/gbinding.h:30,
 from C:/msys64/mingw64/include/glib-2.0/glib-object.h:24,
 from C:/msys64/mingw64/include/glib-2.0/gio/gioenums.h:30,
 from C:/msys64/mingw64/include/glib-2.0/gio/giotypes.h:30,
 from C:/msys64/mingw64/include/glib-2.0/gio/gio.h:28,
 from 
C:/msys64/mingw64/include/libsoup-3.0/libsoup/soup-types.h:9,
 from 
C:/msys64/mingw64/include/libsoup-3.0/libsoup/soup-auth.h:8,
 from C:/msys64/mingw64/include/libsoup-3.0/libsoup/soup.h:11,
 from geniuspaste.c:22:
geniuspaste.c: In function 'json_request_new':
C:/msys64/mingw64/include/glib-2.0/glib/gstring.h:74:5: warning: ignoring 
return value of 'g_string_free_and_steal' declared with attribute 
'warn_unused_result' [-Wunused-result]
   70 |   (__builtin_constant_p (free_segment) ?\
  |   ~~~
   71 | ((free_segment) ?   \
  | ~
   72 |   (g_string_free) ((str), (free_segment)) : \
  |   ~~~
   73 |   g_string_free_and_steal (str))\
  |   ~~~
   74 | :   \
  | ^
   75 | (g_string_free) ((str), (free_segment)))
  | 
geniuspaste.c:612:5: note: in expansion of macro 'g_string_free'
  612 | g_string_free(str, FALSE);
  | ^
```

When trying to paste some file, Geany crashes for me when it is executed 
natively. I don't know yet why this happens and I didn't manage it yet to debug 
it with gdb. This might be related to my system where I use some firewall rules 
to block unwanted internet access from Windows and also have proxy connections 
configured and after all, it is Windows 7.

When I start Geany from within the MSYS2 environment, pasting some file works 
to some extend, at least no crash :).
But the response look weird:
![Screenshot_2024-05-04_12-48-33](https://github.com/geany/geany-plugins/assets/617017/d45c72e8-ed90-48cf-a45a-8296a437890a)
The link below "\1" is actually also "\1".

The `response_str` in `pastebin_parse_response` is 
"https://www.geany.org/p/6vzVo; which is correct. So there seems to be a 
problem with parsing the URL. I don't know if this related to these changes or 
not.

Anyway, with the bundle changes above, we should get usable installers from the 
CI and so others could test it as well with a less weird Windows setup :).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#issuecomment-2094122392
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

[Enrico Tröger via Github-comments]

> So it probably works provided one uses an up to date operating system. If 
> anyone has access to a Windows 10/11 system, the artifacts of the CI build 
> https://github.com/geany/geany-plugins/actions/runs/8850165013 contain the 
> Geany and G-P installers for easy testing.

I was about to ask @techee or @rdipardo whether they could test this build but 
then thought maybe it is not worth the work at all if GeniusPaste still depends 
on libsoup and so especially for the macOS and Windows bundles, it makes no 
difference whether UpdateChecker uses GIO or libsoup.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2088839584
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

[Enrico Tröger via Github-comments]

The native file dialog on Windows 7 works very well after some testing.
Non-ASCII path and file names seem to work well, too.
![Screenshot_2024-05-01_19-35-32](https://github.com/geany/geany/assets/617017/3aaca2a3-9213-4435-89ab-864a9460c383)

I don't know how to set up "automounted remote servers", so can't test it.
But what the native dialog offers is access to network drives, I tested it with 
a file on a network drive added via the RDP client (I think this uses SMB under 
the hood) and this works fine while the GTK dialog does not see those drives.

To me it seems fine to use those dialogs since it seems to work well and if it 
goes the same for "Save As" and maybe "Open Folder". Making it configurable is 
a good idea, I don't mind about the default.
Most of the infrastructure for the setting we already had (see #3219 and #3791) 
which could be revived.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2088829584
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Enhance cppcheck usage, fix CI and fix reported errors (PR #1346)

[Enrico Tröger via Github-comments]

> Anyway, what do you guys think? Is it good? Are there too many 
> false-positives?

> Should the suppressions be moved back to `AM_CPPCHECKFLAG`s not to alter the 
> code, although it makes it harder to maintain?

I'm fine with having the suppressions inline. I don't remember if it was me 
starting to put them into `AM_CPPCHECKFLAG` or suggested by someone. In any 
way, usually in Python code, I put them inline.

> * Use a version that doesn't require the exhaustive checking (@eht16 why do 
> we use latest version in the first place?  I see 
> [1562ca0](https://github.com/geany/geany-plugins/commit/1562ca07500505ab396fe99ce19cb211d1c2c8fa)
>  but no rationale… and if it's that the version in Ubuntu 20.04 is too old 
> for something, maybe using 22.04 would be enough?)

In the CI we used the cppcheck version available in the Ubuntu release the 
runner is using. This version tends to be a bit outdated.
The nightly builds for Debian Sid use rather new versions (by the design of 
Sid) and those caused various new findings or other problems which caused the 
nightly builds to fail. This probably bothers only me but it does. And so I try 
to fix or workaround the issues or find a hack to make cppcheck happy.
This is how #1197, #1310 and maybe more cppcheck related changes emerged.

In general I think for static code checkers it is fine to use recent versions 
and not rely on versions provided by the distribution to benefit from improved 
and new checks more quickly than the CI runner images are updated.

> * we could avoid running cppcheck in the distcheck phase, I'm not sure it has 
> any value… does it?

Good idea, I don't think it gives any value on distcheck.

> Or it got removed in the version of #1197 that was eventually merged. Not 
> sure but I think when @eht16 upped the version of cppcheck in CI the 
> `--library=gtk` got built in or something, so it wasn't included in what got 
> merged. Might mean it won't work for older versions of `cppcheck` though.

I don't mind at all if we use `--library=gtk` or not. AFAIR this was one way to 
make recent cppcheck versions happy. If there is a better alternative, this is 
fine.


So, after all, whatever makes the CI, the builds on Debian Sid and @b4n happy, 
is fine for me :D.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1346#issuecomment-2088790813
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

[Enrico Tröger via Github-comments]

>Somebody who has Windows 11 and can build Geany with this needs to
>test as well.

No need to build yourself, a full installer with the changes can be
downloaded from
the CI builds: https://github.com/geany/geany/actions/runs/8869590862

Windows 10/11 feedback would be great, I can only test on Windows 7
which is unsupported and not representative.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2081961546
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

[Enrico Tröger via Github-comments]

I'm curious though as I only use Linux, it won't change anything for me :D.
But I'll give it a try on Windows, this will take a few days though.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2081658681
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



> @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE],
 GP_ARG_DISABLE([GeniusPaste], [auto])
 
 GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE,
- [libsoup-2.4 >= 2.4.0])
+ [gtk+-3.0 >= 3.16

No. It breaks also the nightly builds and so I merged #1310 today to unhide 
this problem.
Unfortunately, now it is not hidden any longer.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#discussion_r1582394729
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Fix CPP CMake option capitalization (PR #1344)

[Enrico Tröger via Github-comments]

Merged #1344 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1344#event-12635099051
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany-plugins] Fix CPP CMake option capitalization (PR #1344)

[Enrico Tröger via Github-comments]

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1344

-- Commit Summary --

  * Fix CPP CMake option capitalization

-- File Changes --

M .github/workflows/build.yml (2)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1344.patch
https://github.com/geany/geany-plugins/pull/1344.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1344
You are receiving this because you are subscribed to this thread.

Message ID: geany/geany-plugins/pull/1...@github.com

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

[Enrico Tröger via Github-comments]

> > I "think" it will work.
> > In detail this is, when querying https://geany.org/ I get an error: `GET 
> > request failed: WinHttp error: SECURE_CHANNEL_ERROR`. […]
> > If I change the URL to query to https://httpbin.org/anything/version, the 
> > HTTP request works fine and I get the expected response.
> > So it probably works provided one uses an up to date operating system.
> 
> OK, might be either TLS versions or certificates not installed I guess. Does 
> the libsoup version work any better? (I doubt it, but who knows)

I cannot say for sure, with the libsoup version I get a different error 
message. Might be the same reason though.

Even if we are not sure whether it runs on Windows and we know it does not work 
on MacOS, there is still another use case for this plugin we tend to forget 
about:
Linux users who install Geany from sources and not via the distro package 
manager. I don't know if there are any and if so how many and I won't make any 
attempts to analyse any log files. But we should keep this in mind before 
dropping the plugin.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081503771
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] CI: Download, compile and use latest cppcheck version (PR #1310)

[Enrico Tröger via Github-comments]

Merged #1310 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1310#event-12634889055
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

[Enrico Tröger via Github-comments]

@eht16 approved this pull request.





-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#pullrequestreview-2027099072
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



> @@ -60,6 +60,8 @@ typedef struct GeanySearchPrefs
gbooleanuse_current_file_dir;   /* find in files directory to 
use on showing dialog */
gbooleanhide_find_dialog;   /* hide the find dialog 
on next or previous */
gbooleanreplace_and_find_by_default;/* enter in replace 
window performs Replace & Find instead of Replace */
+   gbooleanskip_confirmation_for_replace_in_session;   /* do 
*not* ask for confirmation

Ok, I reverted the API version bump.

I was referring to that the new field is technically part of the plugin API as 
I can access and use it from a plugin, no matter whether it is doxgened.
Anyway, using the documented API as source is also fine.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3851#discussion_r1582151054
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

[Enrico Tröger via Github-comments]

@eht16 pushed 1 commit.

bb15a702a9a0ae9eb4e2f805e391f30c6a9f06ad  fixup: do not increase plugin API 
version

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3851/files/c0cd092a49a3162f57691099f115fc2689515774..bb15a702a9a0ae9eb4e2f805e391f30c6a9f06ad
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

[Enrico Tröger via Github-comments]

Looks good now.

As said before, I cannot judge whether the result of the snippets is as 
desired. To me it feels a little confusing that the element in the "itemize" 
environment is indented while for the other ones the cursor position is not 
indented.
Maybe it's ok.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#issuecomment-2081474610
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] geniuspaste: Port to libsoup3 (and avoid GTK3 deprecations) (PR #1342)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



> @@ -3,7 +3,8 @@ AC_DEFUN([GP_CHECK_GENIUSPASTE],
 GP_ARG_DISABLE([GeniusPaste], [auto])
 
 GP_CHECK_PLUGIN_DEPS([GeniusPaste], GENIUSPASTE,
- [libsoup-2.4 >= 2.4.0])
+ [gtk+-3.0 >= 3.16

We also need to adjust the CI workflow config to install libsoup3. Currently 
the plugin will not be built in the CI due to the missing dependency.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#pullrequestreview-2027082303
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

[Enrico Tröger via Github-comments]

> Guys, be a bit patient :D. I'll test this on Windows/MSYS2 later or in the 
> next days.

I "think" it will work.
In detail this is, when querying https://geany.org I get an error: `GET request 
failed: WinHttp error: SECURE_CHANNEL_ERROR`. But I guess this is not related 
to the changes but rather to the combination of how GIO handles TLS, the 
outdated Windows 7 I'm using and the fact that geany.org offers only TLS 1.2 or 
newer. This doesn't seem to be too good for Windows 7.

If I change the URL to query to https://httpbin.org/anything/version, the HTTP 
request works fine and I get the expected response.

So it probably works provided one uses an up to date operating system.
If anyone has access to a Windows 10/11 system, the artifacts of the CI build 
https://github.com/geany/geany-plugins/actions/runs/8850165013 contain the 
Geany and G-P installers for easy testing.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2081471114
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

[Enrico Tröger via Github-comments]

Guys, be a bit patient :D. I'll test this on Windows/MSYS2 later or in the next 
days.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2079741003
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

[Enrico Tröger via Github-comments]

> > For "table" and "itemize" there is a trailing space after the cursor 
> > marker. Is this intended?
> > "block" uses no indentation at all, "itemize" uses a tab resp. spaces and 
> > "table" uses a single space only.
> 
> This is fixed. I tried to re-sync the indentions

I cannot verify as I do not know what is the purposed variant. To me it looks 
inconsistent:
![Screenshot_2024-04-26_18-38-28](https://github.com/geany/geany-plugins/assets/617017/47d46203-5f95-4454-a03b-0e412bd6e747)
 
More importantly, the rubbisch after the "block" environment is because 
`g_strconcat()` must always be NULL-terminated which it is not in the newly 
added code.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#issuecomment-2079738972
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



> - tmp = g_strdup_printf("\n\\end{%s}", environment);
-   glatex_insert_string(tmp, FALSE);
-   g_free(tmp);
-
-   indention_prefs = editor_get_indent_prefs(doc->editor);
-   if (type == GLATEX_ENVIRONMENT_TYPE_LIST)
-   {
-   sci_set_line_indentation(doc->editor->sci,
-   sci_get_current_line(doc->editor->sci),
-   indent + indention_prefs->width);
+   if (type == GLATEX_ENVIRONMENT_TYPE_LIST)
+   {
+   tmpstring = g_strconcat(
+   "\\begin{",
+   environment,
+   "}\n\t\\item %cursor% \n\\end{",

There is still a trailing space.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#pullrequestreview-2025456762
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



>  **``search`` group**
-find_selection_type   See `Find selection`_.   
0   immediately
-replace_and_find_by_default   Set ``Replace & Find`` button as default so  
trueimmediately
-  it will be activated when the Enter key is
-  pressed while one of the text fields has
-  focus.
+find_selection_type  See `Find selection`_.
   0immediately
+replace_and_find_by_default  Set ``Replace & Find`` button as 
default so  true immediately
+ it will be activated when the Enter 
key is
+ pressed while one of the text fields 
has
+ focus.
+skip_confirmation_for_replace_in_session If set, do *not* show the 
   falseimmediately

Yeah, I don't like cryptic names anymore. I've chosen too many in the past and 
got annoyed myself even more often by them :).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3851#discussion_r1576877918
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



> @@ -60,6 +60,8 @@ typedef struct GeanySearchPrefs
gbooleanuse_current_file_dir;   /* find in files directory to 
use on showing dialog */
gbooleanhide_find_dialog;   /* hide the find dialog 
on next or previous */
gbooleanreplace_and_find_by_default;/* enter in replace 
window performs Replace & Find instead of Replace */
+   gbooleanskip_confirmation_for_replace_in_session;   /* do 
*not* ask for confirmation

Thanks, fixed.

Isn't it part of the API by 
https://github.com/geany/geany/blob/master/src/plugindata.h#L202?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3851#discussion_r1576876210
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)

[Enrico Tröger via Github-comments]

@eht16 pushed 1 commit.

c0cd092a49a3162f57691099f115fc2689515774  fixup: move new search pref to the 
end of struct

-- 
View it on GitHub:
https://github.com/geany/geany/pull/3851/files/8c9818eb861065ca48854e0d7aed5b2daf52310a..c0cd092a49a3162f57691099f115fc2689515774
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: Use host instead of target (PR #3853)

[Enrico Tröger via Github-comments]

@eht16 approved this pull request.

Tested and works on Windows.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3853#pullrequestreview-2018263666
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add Ocaml ctags parser (PR #3163)

[Enrico Tröger via Github-comments]

I tested this last week and forgot to comment :).

It works fine and parses the random Ocaml code I found on the net properly. 
Though I don't know the language at all :D.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3163#issuecomment-2068120694
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Error: Most Plugins not binary compatible with this release of geany. Therefore not available in Plugin Manager Dialog (Issue #1292)

[Enrico Tröger via Github-comments]

@masla84 if this still persists, please check Help->Debug Messages in Geany, at 
the beginning loading of plugins is logged and also if there any errors 
occurred.

Alternatively, uninstall all of your Geanys, remove the config folder (or at 
least clean the plugin paths manually) and try again.

Re-open if it still does not work.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1292#issuecomment-2068116724
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Error: Most Plugins not binary compatible with this release of geany. Therefore not available in Plugin Manager Dialog (Issue #1292)

[Enrico Tröger via Github-comments]

Closed #1292 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1292#event-12551239724
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Allow to disable: Are you sure to replace in the whole session? (Issue #3702)

[Enrico Tröger via Github-comments]

A new various pref to disable the confirmation dialog is added in #3851.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3702#issuecomment-2068108109
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Allow to disable: Are you sure to replace in the whole session? (Issue #3702)

[Enrico Tröger via Github-comments]

Reopened #3702.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3702#event-12551227374
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany] Add various pref replace in session (PR #3851)

[Enrico Tröger via Github-comments]

Allow brave users to disable the confirmation dialog when replacing text in the 
whole session.

While modifying the docs, I noticed a missing various pref in the table and 
added it.
Because of the long names of the other and the new setting, the table grew and 
needed reformatting. I put this into a separate commit for easier review but we 
can probably squash them together afterwards.

Closes #3702.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3851

-- Commit Summary --

  * Add a various pref to skip replace in session confirmation dialog
  * Add missing various pref docs
  * Reformat various prefs table in docs

-- File Changes --

M doc/geany.txt (264)
M src/keyfile.c (2)
M src/plugindata.h (2)
M src/search.c (3)
M src/search.h (2)

-- Patch Links --

https://github.com/geany/geany/pull/3851.patch
https://github.com/geany/geany/pull/3851.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3851
You are receiving this because you are subscribed to this thread.

Message ID: geany/geany/pull/3...@github.com

[Github-comments] Re: [geany/geany] update fortran keywords (PR #3656)

[Enrico Tröger via Github-comments]

Merged #3656 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3656#event-12551171089
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fortran function random_init not highlighted (Issue #3362)

[Enrico Tröger via Github-comments]

Closed #3362 as completed via #3656.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3362#event-12551171193
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Bazel build config files are based on Python (#2088)

[Enrico Tröger via Github-comments]

Closed #2088.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2088#event-12551166960
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



>   if (utils_str_equal(environment, "block") == TRUE)
{
-   g_string_append(tmpstring, "}{}");
+   tmpstring = 
g_strdup_printf("\\begin{%s}{}\n%%cursor%%\n\\end{%s}", environment, 
environment);

It might be more readable using "g_strconcat" like above in 
https://github.com/geany/geany-plugins/pull/1330/files#diff-44b2e13e0c1bd7750fc7aa3324ce230dd2ed0192c37d03208846a549509206bbR82?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#pullrequestreview-2013463978
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] LaTeX: Switch handling of insert (list) environments over to snippets workflow (PR #1330)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.

Looks good.

As you know I'm not LaTeX expert and so I'm wondering if it is on purpose that 
different environments produce quite different stylings:

```
\begin{block}{}
_
\end{block}

\begin{itemize}
\item _ 
\end{itemize}

\begin{table}
 _ 
\end{table}
```

For "table" and "itemize" there is a trailing space after the cursor marker. Is 
this intended?

"block" uses no indentation at all, "itemize" uses a tab resp. spaces and 
"table" uses a single space only.

> @@ -103,6 +114,7 @@ glatex_insert_string(const gchar *string, gboolean 
> reset_position)
 
doc = document_get_current();
 
+

Was this on purpose?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1330#pullrequestreview-2013452584
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Bazel build config files are based on Python (#2088)

[Enrico Tröger via Github-comments]

@StephenWassell is this still relevant or can we close this?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2088#issuecomment-2068040167
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix search entry after editing the toolbar (PR #3838)

[Enrico Tröger via Github-comments]

It seems to work without the guard as well.
The connect_proxy function is called four times here, but it's the same on 
Linux and Windows and in either way, the search toolbar item still works after 
re-ordering.

Since we cannot reproduce this anymore and the "fix" is so long ago, maybe it 
was really related to some Windows-GTK2 bugginess.

 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3838#issuecomment-2068038479
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Help command should check browser tool's return value (Issue #3468)

[Enrico Tröger via Github-comments]

Closed #3468 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3468#event-12550837837
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Encodings UI improvements (PR #3720)

[Enrico Tröger via Github-comments]

Looks and works great, tested on Linux and Windows!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3720#issuecomment-2068035433
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



>   geany_debug("Couldn't convert from %s to UTF-8.", 
> charset);
+   g_set_error(error, G_CONVERT_ERROR, 
G_CONVERT_ERROR_ILLEGAL_SEQUENCE,
+   _("Data contains NULs"));

Do we always know for sure the error here is exclusively NUL bytes?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3716#pullrequestreview-2013391366
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)

[Enrico Tröger via Github-comments]

There are actually some encodings which seem not support on Windows:
```
15:31:32.356445: Geany INFO : Encoding ISO-8859-10 is not supported 
by the system
15:31:32.356445: Geany INFO : Encoding ISO-8859-14 is not supported 
by the system
15:31:32.356445: Geany INFO : Encoding ISO-8859-16 is not supported 
by the system
15:31:32.356445: Geany INFO : Encoding UTF-7 is not supported by 
the system
15:31:32.356445: Geany INFO : Encoding ARMSCII-8 is not supported 
by the system
15:31:32.356445: Geany INFO : Encoding EUC-TW is not supported by 
the system
15:31:32.356445: Geany INFO : Encoding GEORGIAN-ACADEMY is not 
supported by the system
15:31:32.356445: Geany INFO : Encoding HZ is not supported by the 
system
15:31:32.356445: Geany INFO : Encoding ISO-IR-111 is not supported 
by the system
15:31:32.356445: Geany INFO : Encoding TCVN is not supported by the 
system
15:31:32.356445: Geany INFO : Encoding TIS-620 is not supported by 
the system
15:31:32.356445: Geany INFO : Encoding VISCII is not supported by 
the syste
```

For the rest, I did some basic testing on Linux and works as expected and by 
inspection it looks (almost) fine.
Even if there might be subtile bugs on edge cases, I would merge this in master 
already to get broader testing of the changes.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3716#issuecomment-2068028879
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] lineoperations: Removed debug code (fixes #1322) (PR #1323)

[Enrico Tröger via Github-comments]

Thanks!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1323#issuecomment-2068027676
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Line Operations plugin outputs "Value: 0" to terminal when Geany launches (Issue #1322)

[Enrico Tröger via Github-comments]

Closed #1322 as completed via #1323.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1322#event-12550784189
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] lineoperations: Removed debug code (fixes #1322) (PR #1323)

[Enrico Tröger via Github-comments]

Merged #1323 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1323#event-12550784154
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] update fortran keywords (PR #3656)

[Enrico Tröger via Github-comments]

Don't we want to merge this anyway? Maybe the performance impact is tolerable 
and then it is still an improvement for Fortran users.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3656#issuecomment-2068027071
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

[Enrico Tröger via Github-comments]

Well, the CI just builds the code and runs some simple tests. This is already a 
good indicator, yes. Still, it is different from executing the full application 
with full loading of GTK and such.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#issuecomment-2054114331
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

[Enrico Tröger via Github-comments]

Could anyone who uses Meson on Linux check if this is fine and properly 
ignored? @b4n or @kugel- maybe?

I tested it on Windows and it does what it should.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#issuecomment-2054064747
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: Add icon with geany program (PR #3812)

[Enrico Tröger via Github-comments]

@Biswa96 thanks!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3812#issuecomment-2054062719
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: Add icon with geany program (PR #3812)

[Enrico Tröger via Github-comments]

Merged #3812 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3812#event-12460442729
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: Add icon with geany program (PR #3812)

[Enrico Tröger via Github-comments]

Looks fine and works on Windows, the icon and the other meta information on the 
executable are set properly.

> We lack a Meson Windows job to tell

We could add it. I might work on this at some point (days, weeks, months, who 
knows :smile: ).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3812#issuecomment-2054062487
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)

[Enrico Tröger via Github-comments]

Is there anything wrong with merging this?

Even if it would be cooler to not have to set the flag, as it is done by 
Autotools as well, it might be ok.

And if uctags is updated next time, we could try to remove it again.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3660#issuecomment-2054055869
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)

[Enrico Tröger via Github-comments]

> > Is `_WIN32` set for cross builds?
> 
> `_WIN32` is set in compiler which targets Windows platform - no header or IDE 
> is required. You can verify that using `cc -dM -E - < /dev/null | grep WIN32` 
> command.

Yep, looks good.
This is in a Docker container running the image we use in CI for 
cross-compilation:
```
root@470e6364089b:/build# x86_64-w64-mingw32-gcc -dM -E - < /dev/null | grep 
WIN32
#define __WIN32__ 1
#define _WIN32 1
#define WIN32 1
#define __WIN32 1
```

And natively in MSYS2 on Windows:
```
$ cc -dM -E - < /dev/null | grep WIN32
137:#define __WIN32__ 1
183:#define _WIN32 1
301:#define WIN32 1
325:#define __WIN32 1
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3660#issuecomment-2054054773
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)

[Enrico Tröger via Github-comments]

> > I would suggest to provide Windows installer. Most of the users will still 
> > use official installer who are not familiar with msys2 and its packaging 
> > system.
> 
> But as I said above, none of the major contributors use Geany on Windows, 
> even the nice guy who makes the build (and yes with installer) so its 
> virtually untested.

Hmm, I first thought: this probably won't work as it would require users to 
install MSYS2 in order to install Geany within.

On the other hand: maybe there is a way to use MSYS2 packages directly without 
installing a full Linux like environment. And it would save me from moaning 
about Windows build and installer issues :smile:.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3811#issuecomment-2054050951
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Default plugins folder incorrect / not found (Issue #1321)

[Enrico Tröger via Github-comments]

@socal-nerdtastic if you are curious and brave enough, you could try the Geany 
and Geany-Plugins installers from:
https://github.com/geany/geany-plugins/actions/runs/8679662809/artifacts/1412215267

They should work now.
But aware, these installers are created from GIT master, the current 
development state. Though usually this works pretty stable.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1321#issuecomment-2054045147
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] [RFC] Enable keyboard searching for Compiler and Messages tree views (PR #3823)

[Enrico Tröger via Github-comments]

`git blame` tells that it was me disabling it, in 2006. Unfortunately, I didn't 
comment why I did this and I don't remember.

Maybe there were problems with interactions or I just did it for no specific 
reason.

I'm fine to enable it again and see if it works as expected.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3823#issuecomment-2054036459
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] lineoperations: Commented out debug code to fix #1322 (PR #1323)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



> @@ -117,7 +117,7 @@ lo_init_prefs(GeanyPlugin *plugin)
lo_info->use_collation_compare = utils_get_setting_boolean(config,
"general", "use_collation_compare", FALSE);
 
-   printf("VALUE: %d\n", lo_info->use_collation_compare);
+   /* printf("VALUE: %d\n", lo_info->use_collation_compare); */

I would drop it completely. There is no point in having commented debug flying 
around. If needed, it can be restored from the GIT history.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1323#pullrequestreview-1999565351
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Python print() doesn't work well. (Issue #3798)

[Enrico Tröger via Github-comments]

Closed #3798 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3798#event-12460279098
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Python print() doesn't work well. (Issue #3798)

[Enrico Tröger via Github-comments]

I cannot reproduce this (similar to #3772).

Either it is related to Windows 11 vs my Windows 7 or some settings. But as 
@elextr said, Geany just starts the configured command.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3798#issuecomment-2054032021
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Windows: Geany does not update the UI text to be white on dark background/dark gtk-theme (Issue #3827)

[Enrico Tröger via Github-comments]

I tested the Orchis theme and it looks good, I think:
![geany_windows_orchis](https://github.com/geany/geany/assets/617017/0a43ca17-41f1-45e3-b9f3-682f740c2c8e)

Since you said you installed the theme into `AppData/Local/gtk-3.0`, this might 
cause the problems. Usually, themes are to be put into `AppData/Local/themes` 
and then configured in `AppData/Local/gtk-3.0/settings.ini`, e.g.:
```ini
[Settings]
gtk-theme-name=Orchis
gtk-application-prefer-dark-theme=1
```

This worked for me. See also 
https://www.geany.org/documentation/faq/#on-windows_1.

Feel free to re-open if I'm wrong.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3827#issuecomment-2054031144
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Windows: Geany does not update the UI text to be white on dark background/dark gtk-theme (Issue #3827)

[Enrico Tröger via Github-comments]

Closed #3827 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3827#event-12460274679
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] [plugins/filebrowser] Change external open default to `xdg-open` (PR #3815)

[Enrico Tröger via Github-comments]

I think this is OK even if when called for a file the file will be opened and 
not the file manager. Since the whole command can be configured and by the same 
default `%d` is used, the behavior should not be changed, just the default will 
work probably for more users.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3815#issuecomment-2054029288
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix search entry after editing the toolbar (PR #3838)

[Enrico Tröger via Github-comments]

Tested on Linux and Windows, works perfectly.

I don't remember the initial problems from 12 years ago, maybe it was GTK2 
releated or a bug in early GTK3 versions or so.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3838#issuecomment-2054027526
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Fix search entry after editing the toolbar (PR #3838)

[Enrico Tröger via Github-comments]

@eht16 approved this pull request.





-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3838#pullrequestreview-1999562116
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Windows installer: Prefer Geany installation directory over user's HOME (PR #1324)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



> @@ -401,6 +398,12 @@ Function .onInit
StrCpy $INSTDIR "$GEANY_INSTDIR"
${EndIf}
 
+   ; if $INSTDIR has not been set yet above, set it to the profile 
directory for non-admin users
+   ${If} $INSTDIR == ""

The diff is a bit cluttered because of the variable rename (I don't know what 
was wrong with me naming it "Answer" :( ), the relevant part is here: we set 
`$INSTDIR` only to the user's profile directory if we didn't find a Geany 
installation before. Before the Geany installation was ignored if the installer 
was executed without administrative privileges.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1324#pullrequestreview-1999560372
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany-plugins] Windows installer: Prefer Geany installation directory over user's HOME (PR #1324)

[Enrico Tröger via Github-comments]

If no explicit installation directory was specified and an existing, Geany 
installation was found, then use its installation directory.

Closes #1321.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/1324

-- Commit Summary --

  * Windows installer: Prefer Geany installation directory over users HOME

-- File Changes --

M build/geany-plugins.nsi (25)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/1324.patch
https://github.com/geany/geany-plugins/pull/1324.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1324
You are receiving this because you are subscribed to this thread.

Message ID: geany/geany-plugins/pull/1...@github.com

[Github-comments] Re: [geany/geany] Geany buffer strangeness: is the buffer shared between tabs? (Issue #3805)

[Enrico Tröger via Github-comments]

Closed #3805 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3805#event-12278355411
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Geany buffer strangeness: is the buffer shared between tabs? (Issue #3805)

[Enrico Tröger via Github-comments]

@rubyFeedback please note that you can attach images also directly to the 
issue. This saves us from opening thrird party websites just to see a small 
image. Thank you.

I agree with @elextr, the described completion behavior is caused by the 
`Preferences->Editor->Completions->Autocomplete all words` option and because 
the completed text is also present in the very same document. This is how this 
feature is intended to work.

I will close the issue.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3805#issuecomment-2024736451
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] `Use Windows native dialogs` is broken (Issue #3627)

[Enrico Tröger via Github-comments]

Closed #3627 as completed via #3791.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3627#event-12278089629
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Remove "Use Windows native dialogs" GUI setting (PR #3791)

[Enrico Tröger via Github-comments]

Merged #3791 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3791#event-12278089411
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] CI: Download, compile and use latest cppcheck version (PR #1310)

[Enrico Tröger via Github-comments]

If there are no objections or improvement suggestions, I would like to merge to 
this in a week.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1310#issuecomment-2024696264
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-themes] Metallic Bottle: use a slightly darker background color for selections (PR #71)

[Enrico Tröger via Github-comments]

If there are no objections or improvement suggestions, I would like to merge to 
this in a week.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/pull/71#issuecomment-2024695254
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add a 1px black border around the tab-switcher (Issue #3797)

[Enrico Tröger via Github-comments]

> @eht16 The popup is a dynamically created menu, can you invoke the inspector 
> while it remains visible?

No :(. This is what I meant with "I failed to pick the mentioned menu" above.
But maybe it is possible and it is just me not getting it.

Maybe a search engine can help on this or some GTK expert.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3797#issuecomment-2024690516
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add a 1px black border around the tab-switcher (Issue #3797)

[Enrico Tröger via Github-comments]

Maybe the GTK Inspector can help, https://wiki.gnome.org/Projects/GTK/Inspector.

Basically, enable it by executing `gsettings set org.gtk.Settings.Debug 
enable-inspector-keybinding true` and then start it from within Geany with the 
keyboard shortcut `Control-Shift-D`.

The inspector allows to pick various GUI objects and show the CSS path. 
However, I failed to pick the mentioned menu. Surely there is some trick to get 
it.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3797#issuecomment-2016882890
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Feature request - extend plugin Save Actions - code fixers (Issue #1319)

[Enrico Tröger via Github-comments]

Closed #1319 as not planned.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1319#event-12227163281
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Feature request - extend plugin Save Actions - code fixers (Issue #1319)

[Enrico Tröger via Github-comments]

Duplicate of [#3295](https://github.com/geany/geany/issues/3295). There are 
some ideas on how to implement it but it still needs someone to do it :).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1319#issuecomment-2016881883
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

[Enrico Tröger via Github-comments]

>Surely he means Racket, its [lisp](https://xkcd.com/297/) (well
>Scheme, but similar) and it has its own portable native GUI library
>built in, no more GTK on windows issues .. hmm I just might convince
>myself at this rate :-)

Raku, R, Racket, Rust, Ruby, I'll leave the important questions to
@elextr.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3169#issuecomment-2007838787
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

[Enrico Tröger via Github-comments]

> I gave it some testing and it works fine. I want to repeat I'm
> really bad at Perl and saw Raku the first time now. Btw, I did not
> fell in love with it :D.
> 
> Good, I was worried we'd have to rewrite Geany in it :-)

Maybe I'll change my mind in two weeks, what about Reany?

:)

> The perl6.c parser is taken from uctags, I assume. If so, we
> probably should to rename it as it was done in
> universal-ctags/ctags#3777
> .
> 
> I'm aware of that, I was just thinking it could be done during the next 
> "ctags sync" if it's not a problem.

Alright, sounds good.

> Is anything else missing? If there are no other problems, I'd like to 
> merge this PR so we are finally done with it.

I'm fine with it and when @b4n is also, let's get it in.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3169#issuecomment-2005161122
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] `Use Windows native dialogs` is broken (Issue #3627)

[Enrico Tröger via Github-comments]

> If the setting is in `geany.glade` how come it doesn't show on Linux?

If you have a close look at the changes in #3791, your question will be 
answered :D.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3627#issuecomment-2002545082
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany] Remove "Use Windows native dialogs" GUI setting (PR #3791)

[Enrico Tröger via Github-comments]

This is a left-over from #3219 and should have been removed already.

Fixes #3627.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/3791

-- Commit Summary --

  * Remove Use Windows native dialogs GUI setting

-- File Changes --

M data/geany.glade (16)
M src/prefs.c (3)

-- Patch Links --

https://github.com/geany/geany/pull/3791.patch
https://github.com/geany/geany/pull/3791.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3791
You are receiving this because you are subscribed to this thread.

Message ID: geany/geany/pull/3...@github.com

[Github-comments] Re: [geany/geany-osx] Open dialog enter file path text (#14)

[Enrico Tröger via Github-comments]

> > I'll try to have a look at it if it would require many changes in Geany to 
> > migrate to this class.
> 
> It would need to be optional

Why would it need to be optional? If it works well on relevant platforms and do 
not introduce too much restrictions, why not use it completely?

> but I think the checkbox from the windows native dialogs is still in Glade 
> unless @eht16 got around to removing it ;-)

thanks for the reminder :D.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-osx/issues/14#issuecomment-2002542469
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] geanyctags: eliminate some warnings and update the readtags library (PR #1317)

[Enrico Tröger via Github-comments]

LGBI.

I didn't test the changes, @techee I guess you did. If so, I think we can merge 
this.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1317#issuecomment-2002538765
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] vimode: eliminate a warning (PR #1316)

[Enrico Tröger via Github-comments]

Merged #1316 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1316#event-12143453175
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

[Enrico Tröger via Github-comments]

> Agree with @techee and I could give it a bit of testing, though this might 
> takes a few weeks. 

s/few weeks/few years/ but we are all patient :).

I gave it some testing and it works fine. I want to repeat I'm really bad at 
Perl and saw Raku the first time now. Btw, I did not fell in love with it :D.

The perl6.c parser is taken from uctags, I assume. If so, we probably should to 
rename it as it was done in https://github.com/universal-ctags/ctags/pull/3777.

Geany detects 
https://github.com/Raku/examples/blob/master/categories/games/blackjack.p6 as 
Perl even the file extension tells Raku. This is because of the shebang in the 
file. The following change should solve it by first checking for "perl6" and 
only then "perl".

```diff
@@ -604,6 +605,7 @@ static GeanyFiletype *find_shebang(const gchar 
*utf8_filename, const gchar *line
{ "sh", GEANY_FILETYPES_SH },
{ "bash",   GEANY_FILETYPES_SH },
{ "dash",   GEANY_FILETYPES_SH },
+   { "perl6",  GEANY_FILETYPES_RAKU },
{ "perl",   GEANY_FILETYPES_PERL },
{ "python", GEANY_FILETYPES_PYTHON },
{ "php",GEANY_FILETYPES_PHP },
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3169#issuecomment-2002536714
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

[Enrico Tröger via Github-comments]

Merged #3769 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#event-12143071778
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

[Enrico Tröger via Github-comments]

> > > Adding ` workflow_dispatch:` might be a good idea to manually re-run the 
> > > workflow.
> > 
> > 
> > I would still recommend this simple change.
> > And it seems the configuration still has syntax errors: 
> > https://github.com/geany/geany/actions/runs/8135027731/workflow
> 
> That seems outdated. I added the workflow_dispatch and fixed the cron 
> syntax/indentation about a week ago.

Sorry, I guess I didn't properly refresh this page and so commented on the old 
code.

Looks good to me now.
Thanks.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#issuecomment-2002485389
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-plugins] Make updatechecker plugin for MacOS (Issue #1314)

[Enrico Tröger via Github-comments]

> The update checker for Linux works incorrectly, it checks the Geany 
> repository for a new version, not the repositories for the current distro. 
> Most distros don't update versions of software like Geany on LTS versions for 
> example. So it just feeds frustration for users of such 

I'd say it depends on the user. There is maybe a minority of users who compile 
Geany themselves from release tarballs and for those the plugin might be useful.

> Its really only useful for Windows, but maybe it could be made useful for 
> Macos if it looked at the right repository because it can get new bugfix 
> releases separate from Geany.

Isn't the plugin for Macos in the same way useful as for Windows as it checks 
geany.org for the latest version and this is where the Macos version is 
distributed.
AFAIK Geany is not mainly distributed via some sort of repository like "brew" 
or so but via downloadable installers from our website and so I thought the 
update checker plugin would do the same job on Macos as on Windows.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1314#issuecomment-1987320147
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

[Enrico Tröger via Github-comments]

> Adding ` workflow_dispatch:` might be a good idea to manually re-run the 
> workflow.

I would still recommend this simple change.

And it seems the configuration still has syntax errors: 
https://github.com/geany/geany/actions/runs/8135027731/workflow

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#issuecomment-1987318532
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



> @@ -8,6 +8,13 @@ on:
   push:
 branches:
   - master
+- '**'

I don't see why, at least for this case it seems a bit beyond the goal.

If we have use cases for excluding files from triggering a CI run, we
can add them but no excluding only two YAML files doesn't change much.

Without having checked it, I think about 95% of the commits will change files 
which should trigger the CI anyway, so don't waste resources maintaining an 
articial exclude list.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#discussion_r1518925242
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-themes] New DarkSpook color scheme (PR #68)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



On screenshots/dark-spook.png:

Do you mind to replace the screenshot as described above?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/pull/68#discussion_r1510333217
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany-themes] New DarkSpook color scheme (PR #68)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



> +description=Based on the InkPot theme of the same name.
+# incremented automatically, do not change manually
+version=1
+author=Vukić Srđan 
+url=https://hardcoder.xyz
+# list of each compatible Geany release version
+compat=1.22;1.23;1.23.1;1.24;1.25;1.26;1.27;1.28;1.29;1.33;1.38;2.0
+
+[named_styles]
+default=#626CAD;#15181D;false;false
+error=#542929;#121C2B;false;false
+
+# Editor styles
+#---
+
+selection=;#4e4e8f;false;false

```suggestion
selection=;#4e4e8f;false;true
```

This eliminates the warning and makes selected text look much better as the 
background color is used.

See https://geany.org/manual/#styling-section-1 for reference.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/pull/68#pullrequestreview-1913044168
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] [geany/geany-themes] Metallic Bottle: use a slightly darker background color for selections (PR #71)

[Enrico Tröger via Github-comments]

I just made the background color for selections a little darker so that it is 
different from the foreground color.

Closes #70.

![Screenshot](https://github.com/geany/geany-themes/assets/617017/472e0715-c1c1-4166-926e-b2260d160687)

You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-themes/pull/71

-- Commit Summary --

  * Metallic Bottle: use a slightly darker background color for selections

-- File Changes --

M colorschemes/metallic-bottle.conf (2)

-- Patch Links --

https://github.com/geany/geany-themes/pull/71.patch
https://github.com/geany/geany-themes/pull/71.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/pull/71
You are receiving this because you are subscribed to this thread.

Message ID: geany/geany-themes/pull/7...@github.com

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



> @@ -8,6 +8,13 @@ on:
   push:
 branches:
   - master
+- '**'

And it causes an error:
```
Invalid workflow file: .github/workflows/build.yml#L8
You have an error in your yaml syntax on line 8
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#discussion_r1510279256
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

[Enrico Tröger via Github-comments]

Thanks!

> Done. Some examples of this workflow include a cron schedule as well. Would 
> you like that added, and if so, how often should it be scheduled?

I would say once in a month is a good start.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#issuecomment-1975169850
You are receiving this because you are subscribed to this thread.

Message ID: 

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

[Enrico Tröger via Github-comments]

@eht16 commented on this pull request.



> @@ -8,6 +8,13 @@ on:
   push:
 branches:
   - master
+- '**'

Why did you change this, what's the intention?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3769#pullrequestreview-1912989734
You are receiving this because you are subscribed to this thread.

Message ID: