[Github-comments] Re: [geany/geany] Geany segfaults after clicking new document 3 or 4 times (#2736)
Not very helpful but it shows the problem is entirely within the GTK/GIO/GObject/Glib libraries, the only Geany code present is the initial call to GTK. So its something in the version of those libraries that doesn't like your X11. Is it actual Xorg X11 or XWayland? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2736#issuecomment-2075938944 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Geany segfaults after clicking new document 3 or 4 times (#2736)
https://sourceware.org/gdb/current/onlinedocs/gdb#Backtrace -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2736#issuecomment-2075917818 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Geany segfaults after clicking new document 3 or 4 times (#2736)
When it stops at "(gdb)" type "backtrace" and return. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2736#issuecomment-2075915174 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Geany segfaults after clicking new document 3 or 4 times (#2736)
Without a backtrace have no idea whats wrong. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2736#issuecomment-2075906669 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Geany segfaults after clicking new document 3 or 4 times (#2736)
Need the whole backtrace, and watch it might print some and ask if you want to continue. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2736#issuecomment-2075878844 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
@elextr commented on this pull request. > @@ -26,9 +26,9 @@ Prominent features Requirements -This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18), -GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to -work. If you intend to build it yourself, you will need to get the development +This plugin requires GTK3, GLib (>= 2.22), GIO (>= 2.18), GdkPixbuf (>= 2.0), +WebKit2GTK (either API 4.0 or 4.1), and obviously Geany (>= 0.20) to work. Geany 0.20 or 2.0? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#pullrequestreview-2020969159 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)
Needs to update README -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1335#issuecomment-2074723649 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
Maybe should update the requirements section of README as well. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#issuecomment-2074716996 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] How to change the UI font of Geany? (Discussion #3856)
If by UI font you mean everything except the editor pane then you need to set it in `geany.css` I think since Windows font settings won't be transferred to the GTK themes. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3856#discussioncomment-9211935 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] When closing the current tab, move to the tab on the left, not on the right (Issue #3855)
> Plus browsers are sort of crazy, so I don't think mimicking their behavior is > necessarily a good idea. +1, I just tried Chrome, sometimes it went to previous, sometimes to the one on the right, I can't tell what makes the decision. I think (without checking) in Geany it is simply that since notebook tabs are usually referenced by number counting from left, when the current tab is closed and the tab number isn't changed the tab that was on the right will now be that number and so the current one. So maybe there isn't any code for this, its simply what happens. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3855#issuecomment-2074683356 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)
LGBI, the removals look good but did not check thats all that needs removing. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1335#issuecomment-2074588921 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] When closing the current tab, move to the tab on the left, not on the right (Issue #3855)
IIRC someone commented somewhere that the behaviour mirrors what browsers do. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3855#issuecomment-2074551017 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Java var keyword not highlighted (Issue #3854)
@b4n, the highlighted text was copied from part way down
[this](https://docs.oracle.com/en/java/javase/22/language/local-variable-type-inference.html)
page (about para 4). Making it a predefined typename is how "contextuality"
is implemented I guess, as it is a typename it makes `var i = 10;` be a
declaration, and act like C++ `auto i = 10;` but where a typename is not
expected its a variable name eg `var var = "var";` :grin:
As the rest of the sentence I copied says `which means that existing code that
uses var as a variable, method, or package name is not affected.`
So with the contextless lexer implementation those cases can't be disambiguated
from `var` as a type, so both are correct, pick one for highlighting. [no right
answer]
> There is on line 3
Ooops, hidden by the { [end excuse]
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3854#issuecomment-2074519916
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1232)
There were already some mumblings about a point release due to fixes of potential crashes being merged IIUC, and hopefully the next release won't be as far away as 2.0 was from 1.38, but its hard to tell. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1232#issuecomment-2074131119 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1232)
IIUC any Ubuntu 20.04 LTS or derivative (eg Linux Mint 20) does not have webkit2gtk-4.1. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1232#issuecomment-2073939609 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Modify replace_all to avoid infinite loop (PR #1232)
LGBI but someone needs to test it. The problem is that the markdown plugin has been in and out of plugins due to its delayed GTK3 port so its not clear how many users there are, and its likely to go away again due to wekkit2gtk-4.1 (see https://github.com/geany/geany-plugins/pull/1295#issuecomment-2073809698) unless somebody makes necessary changes. @xiota It needs an active maintainer who can then make decisions like when to swap to new functions even if it makes the plugin not build on older systems, but since you have fixed it without that then yeah probably should wait. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1232#issuecomment-2073880145 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Java var keyword not highlighted (Issue #3854)
I don't understand your image: 1. it does not use `var` 2. the class `Var` is highlighted correctly Oracle says `var is a reserved type name, not a keyword` so not sure how its meant to be highlighted. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3854#issuecomment-2073843781 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)
@elextr commented on this pull request. > @@ -60,6 +60,8 @@ typedef struct GeanySearchPrefs gbooleanuse_current_file_dir; /* find in files directory to use on showing dialog */ gbooleanhide_find_dialog; /* hide the find dialog on next or previous */ gbooleanreplace_and_find_by_default;/* enter in replace window performs Replace & Find instead of Replace */ + gbooleanskip_confirmation_for_replace_in_session; /* do *not* ask for confirmation The struct is, but your new field is not doxygened so it won't appear in the API docs, in fact only `use_current_word` appears in the [API docs](https://www.geany.org/manual/reference/structGeanySearchPrefs.html) from the whole structure. If you want it in the API docs you need to use a `/**<` comment on the field but unless you are about to use it in a plugin its probably better to not doxygen it and no change needed in the API version. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3851#discussion_r1577102818 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Various small WebHelper improvements (PR #1295)
Which plugin did you mean? There are four listed in the previous two comments. Since I would think that it is not possible to load old and new versions of webkit2gtk and libsoup at the same time probably the version needs to be selected once and builds of all four need to disable them if the new version is found. Then they can be switched to re-enable as they are modified to use the new libraries, ping @b4n as the plugin build system expert. Webhelper is done here by itself and if the comments are correct will select webkit2gtk-4.1 if its available, so @xiota if you build it with this PR applied it should build with the new version if its on your system. Then just try it to see that it doesn't crash when you use it a bit. Then the other plugins need to be adapted to the new libraries by "somebody", since the maintainers seem to have departed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1295#issuecomment-2073809698 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Cannot install (Issue #3852)
@ineuw to be fair to us, you are not just installing, you are building and installing, and building is a development activity that assumes that you know enough to install the relevant tools, because its not the job of every project to teach the tools they use. You have not specified what operating system you are trying to build on, but the script by @rdipardo looks like it will work on Debian like distros (untested) when run from the top level of the clone tree. There was a PR to add the simplest build sequence to README, but it kept getting kibbitzed with "no it needs to do this", "should be out of tree", "its better to use the tools in this more complex way", etc etc so it was abandoned. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3852#issuecomment-2071264612 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Various encodings conversion fixes (PR #3716)
@b4n the only one that I would question is the one that @eht16 had questioned, so I was waiting until that was decided. :-P "Data contains NULs" is referring to the result of the conversion, but the user doesn't know that, they only have the input file and it may not contain NULs, eg it might have an overlong encoding of a nul. So "Result of conversion to UTF-8 buffer contains NULs" might be better. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3716#issuecomment-2068425388 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add various pref replace in session (PR #3851)
@elextr requested changes on this pull request. LGBI except the ABI thing. > @@ -60,6 +60,8 @@ typedef struct GeanySearchPrefs gbooleanuse_current_file_dir; /* find in files directory to use on showing dialog */ gbooleanhide_find_dialog; /* hide the find dialog on next or previous */ gbooleanreplace_and_find_by_default;/* enter in replace window performs Replace & Find instead of Replace */ + gbooleanskip_confirmation_for_replace_in_session; /* do *not* ask for confirmation Not last == ABI break as well as API And if its moved to the end its technically not an API break either since it isn't documented for plugin use. > **``search`` group** -find_selection_type See `Find selection`_. 0 immediately -replace_and_find_by_default Set ``Replace & Find`` button as default so trueimmediately - it will be activated when the Enter key is - pressed while one of the text fields has - focus. +find_selection_type See `Find selection`_. 0immediately +replace_and_find_by_default Set ``Replace & Find`` button as default so true immediately + it will be activated when the Enter key is + pressed while one of the text fields has + focus. +skip_confirmation_for_replace_in_session If set, do *not* show the falseimmediately If it was lazy me I would have chosen a more cryptic but shorter name to avoid indenting the whole table, but since its done might as well leave it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3851#pullrequestreview-2013691773 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
Well, Ubuntu LTS 20.04 has a year of support left (April 2025) and it has Meson 0.54, maybe it has to be `#ifdef`ed (or whatever the meson equivalent is) to change what it uses at 0.56 to get rid of the message. Kind of annoying that a Windows only feature causes a message on Linux, maybe the targeted version can be changed just for Windows? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2068394877 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] update fortran keywords (PR #3656)
@eht16 sure, doesn't break anything if nobody wants to fix it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3656#issuecomment-2068044244 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] in document.c symbols_find_typenames_as_string returns always empty string, if tag_parser=Pascal (Issue #3848)
The problem with loading all external tags into the wordlists is that the lexers only recognise syntactic elements, in this case "identifier" and not the semantics that it is a typename or a function name. Also they have no knowledge of scope and no way to pass that information to them. The lexers will select the style of an identifier as the first list it finds the name in, so in C++ for example if the standard library `set` type was loaded from global tags then the lexers would style all `set()` functions as types. And `set(...)` is a pretty common function and they would all show as types. Because of the lack of scoping this happens even if the `set` type is not visible at the point of the `set()` function call. If extra lists for function names were added the fact that the lexers do not have semantics or scope will mean identifiers (eg local variables) that happen to have the same name as a function in any loaded file or tags will be styled as a function name. Similar clashes will happen in any language with separate namespaces. There is no simple solution to this issue. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3848#issuecomment-2067960749 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] in document.c symbols_find_typenames_as_string returns always empty string, if tag_parser=Pascal (Issue #3848)
The Pascal parser only recognises functions and procedures, it would need extending (upstream in uctags) to recognise type declarations before anything can happen in Geany. And as @b4n says, only type names are passed to the lexer for highlighting. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3848#issuecomment-2067859263 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix invalid memory access and Unicode support in utils_get_initials() (PR #3846)
@elextr approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3846#pullrequestreview-2013080468 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix invalid memory access and Unicode support in utils_get_initials() (PR #3846)
> And so you think I should use NFKC rather than NFC? I had another look at UAX#15 and its not really clear that either is better, both are likely to get different things wrong/right, selecting initials isn't what they are made for, so `(rand() % 100) > 50 ? "yes" : "no"` :-) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3846#issuecomment-2067659398 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix invalid memory access and Unicode support in utils_get_initials() (PR #3846)
> How should this be identified then? Just by ranges or something? Its a while since I came across this, but IIRC there is a separate indic setting in the unicode standard that says something about how it combines, because the rules of indic languages are complex (see comments above ;-) > If that's all we're after, I can keep the normalization step and remove the > manual (incomplete?) combining character support, which should still do the > right thing™ in the vast majority of cases Well the NFKC[^1] normalization should handle a lot of cases by itself. The extra combining character support adds the case when there is no pre-combined code point, so it will handle some more cases, but what proportion of additional cases it gets correct I can't say. So better to be simple even if it misses a few cases. > not counting the fact that it's currently terribly broken yet nobody > complained before. Yes, its hardly worth the effort to complicate a capability that appears to be little used, just being safe (ie select proper code points) is enough since it can always be manually overridden if the simple answer is wrong. [^1]: Why did glib use different names? There is a standard, NFC, NFKC etc so why did they invent their own names? Its a guess what standard name the glib names relate to, as usual its not documented!!! [end rant] Thats why my suggestion of `G_NORMALIZE_ALL_COMPOSE` was so tentative. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3846#issuecomment-2067650306 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix invalid memory access and Unicode support in utils_get_initials() (PR #3846)
@elextr commented on this pull request.
> gchar *utils_get_initials(const gchar *name)
{
- gint i = 1, j = 1;
- gchar *initials = g_malloc0(5);
+ GString *initials;
+ gchar *composed;
+ gboolean at_bound = TRUE;
+ gboolean prev_matched = FALSE;
+
+ g_return_val_if_fail(name != NULL, NULL);
+
+ composed = g_utf8_normalize(name, -1, G_NORMALIZE_DEFAULT_COMPOSE);
Oooh, Æsop, there is a name with a ligature, so I guess its possible.
My rule is that if its inconvenient and annoying and inconsistent some natural
language will do it!!!
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3846#discussion_r1573251565
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Fix invalid memory access and Unicode support in utils_get_initials() (PR #3846)
@elextr commented on this pull request. > @@ -766,21 +766,47 @@ gchar *utils_get_date_time(const gchar *format, time_t > *time_to_use) } +/* Extracts initials from @p name, with some Unicode support */ +GEANY_EXPORT_SYMBOL Ok. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3846#discussion_r1573248774 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] FR: Allow setting default filetype (or at least default file extension) for new Geany tabs (Issue #3847)
Having the ability to set the filetype of new files is reasonable, just add a setting to `Edit->Preferences->Files->New Files` with a combo box to select the filetype. The semantics can simply be the same as `Files->New` then `Document->Set filetype->[what the setting says]`. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3847#issuecomment-2067629985 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Indentation on pasting of a multiline text (Issue #3845)
> The current behavior does not indent anything What I mean is that the usual use case is to type return to get a new line to paste on, but that indents with the usual settings for Python, so extra indent is added to the first line unless the user does return then backspaces to remove the indent to start of line and _then_ inserts. Perhaps "re-indent" is the wrong term but the default result is to add indent to the first line of the paste. > Again, IMO that s must still be available and likely default, because it's > the simplest thing to do, and is 100% predictable. Sure I am not suggesting remove it, its is likely the right thing for pastes anywhere besides first on line, just that it isn't the right thing for whole lines with usual settings for offside languages, so that makes more choice and its not really a setting, it will vary from one paste to the next so we need multiple paste options: 1. paste (do as I tell you and don't argue no matter how wrong I have it!!! :-) 2. language specific "Paste at current indent" 3. language specific "Paste indented from current" Options 2 and 3 should be added to the menu by the language specific plugin that controls behaviour ... what? ... No!!! There is a reason nearly all other IDEs are built from plugins, not built-in :grin: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3845#issuecomment-2067617672 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Indentation on pasting of a multiline text (Issue #3845)
And what about pasting Python (or other offside languages)? Are we pasting: 1. _at_ the levels indicated by the clipboard indentation, or 2. _at_ the level at the cursor, or 3. _into_ the level at the cursor? So just taking deltas into account is still not enough because of 2. vs 3. Too many choices, but the current behaviour of re-indenting the first line only is likely to be wrong most of the time and probably should be changed for multi-line pastes. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3845#issuecomment-2067502068 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix invalid memory access and Unicode support in utils_get_initials() (PR #3846)
@elextr requested changes on this pull request.
Neat.
Its not perfect (eg Indic combining chars have class 0), but at least it should
not result in invalid strings and the user can always override it with the
preference.
> @@ -766,21 +766,47 @@ gchar *utils_get_date_time(const gchar *format, time_t
> *time_to_use)
}
+/* Extracts initials from @p name, with some Unicode support */
+GEANY_EXPORT_SYMBOL
If its exported it should be documented ?
> gchar *utils_get_initials(const gchar *name)
{
- gint i = 1, j = 1;
- gchar *initials = g_malloc0(5);
+ GString *initials;
+ gchar *composed;
+ gboolean at_bound = TRUE;
+ gboolean prev_matched = FALSE;
+
+ g_return_val_if_fail(name != NULL, NULL);
+
+ composed = g_utf8_normalize(name, -1, G_NORMALIZE_DEFAULT_COMPOSE);
I suspect it should be `G_NORMALIZE_ALL_COMPOSE` so composite characters get
split and other compatibility transforms. (==NFKC?).
I am unsure if (for example) ligatures can occur as first letters of names, and
if they do is the "initial" the ligature or the first letter of it? Currently
it selects the ligature as the "initial". Anyway its not critical so long as
the user can override it with the "initials" preference.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3846#pullrequestreview-2012843161
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany-themes] Where is the Windows' Geany's color scheme saved (Issue #72)
The [manual](https://www.geany.org/manual/current/index.html#configuration-file-paths) tells you where Geany is looking. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-themes/issues/72#issuecomment-2066279241 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix read past end of string in utils_get_initials() (PR #3844)
> this is (for better or for worse) a util function Well only within Geany, its not available to plugins. Its just located in a file called `utils.c` but its not really a util, it seems unlikely that any other part of Geany will need a function that returns the _byte_ (not character) after ASCII space, I do hope Åsa Åkesson does not use Geany templates :grin: > But do note that this overflow read does actually occur, when Preferences -> > Templates -> Developer is empty (= \0). Damn users, fancy deleting their name!!! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3844#issuecomment-2060693881 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix read past end of string in utils_get_initials() (PR #3844)
This is a function that has only a single user but has been pulled out and put in another file to make life more complicated instead of doing it locally where the conditions of the parameters are visible [end rant]. The overflow is when name is `\0` and the use probably thinks it is never `\0` by using the user real name if it is, so the past the end won't happen, but I suppose its possible (though very very unlikely) for a user real name to be empty, so yeah why not be safe. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3844#issuecomment-2060076197 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
There are some reports of weirdnesses with XWayland and GTK, which have been fixed by running Geany as Wayland as I mentioned. But havn't had any reports that can be traced to real xorg and GTK (that my quick search on Geany issues found anyway), and it is just fine on my Linux Mint (which is based on Ubuntu). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2058962271 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
Sounds like something is wrong with your brand new Ubuntu. Are you running Wayland? If so try `GDK_BACKEND=wayland geany`. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2058899522 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] geany crashes on ubuntu/mate 22.04 when attempting to select text (Issue #3843)
Its hard to say anything except that the problem occurs inside the X11 library called from GDK called from GTK during the initialisation of the displays called from Geany at line `#11`. We don't even know the version of Geany. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3843#issuecomment-2058841903 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] How to sync geany setting of Windows to Linux one (Discussion #3842)
You can copy the whole configuration directory back and forwards but the experience might not be totally acceptable since: 1. session files, recent files, and other paths are likely to be in different locations 2. tools settings may not be the same between Windows and Linux 3. some settings may not exist in both, eg Windows does not have VTE. Perhaps explain why you think you want them synchronised? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3842#discussioncomment-9123778 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] color scheme: function color (Discussion #3840)
The Php lexer (part of the HTML lexer) sets the styling, but only has one word list (see [here](https://github.com/geany/geany/blob/32bbe106195f953e980bfa756b5a7ccad1ee209d/scintilla/lexilla/lexers/LexHTML.cxx#L724)) which is used as you noticed for the Php words. The lexer is purely syntactic, it does not recognise semantics like function definitions, the ctags parser does that, but because there is only one wordlist available for php there is no way to pass the function list to the lexer to style those names as functions, so any setting in the theme will be unused. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3840#discussioncomment-9118241 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] color scheme: function color (Discussion #3840)
Not knowing what language you are using its hard to help, does the lexer recognise style something as "function" ? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3840#discussioncomment-9117972 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [msgwin] Reset compiler/messages treeview width at start of build/search (PR #3816)
@ntrel You seem to have misunderstood the point of my objection. The problem was the process, merging a change before others had the chance to assess it, not that there was a technical problem with the PR. Since as I noted I had not had time to see its contents I could not be commenting on the content. > Taken together though, my points justify the merge IMO. This was not a crash problem or a sudden regression, it was an inconvenience that Geany users had been living with for a long time, there was no need to hurry a merge without giving others time to assess it. There is no release planned for tomorrow, so there is no rush to merge to enable distribution of the change to users. Therefore nothing justifies a quick merge. > There are no other cases. I thought we agreed that wrapping should not always > be on, and this does not conflict with wrapping. Again, I was not taking about the technical content of the PR, sorry if that was not clear. As I said above I was talking generally about the process, "cases" meant applying your sole judgement to the "obviousness" and complexity of the change to justify a quick merge for this and future PRs. Having had a chance to look at the changes, why not put `reset_msgwin` in `ui_utils` and call it from both `build` and `search`, or is there some technical reason that the order of the calls needs to be different in build? If there is it probably should be commented so someone doesn't reorder them in the future. > Reverting is not the end of the world. Agree totally, thats a very mature and sensible approach, reverting is not a criticism, it should be thought of in the same way as deleting a line of code if it needs to be changed, but some members of the Geany project seem to have a horror of it :-) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3816#issuecomment-2054522950 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Devhelp: Google Code Search removal (#93)
@frlan as devhelp has been removed just close it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/93#issuecomment-2054307272 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] reload dialog doesn't show up anymore (Issue #3839)
Does Filezilla set the file modified date/time of the file to the remote file date/time each upload? If so it won't change if the file on disk has not changed since the last upload (the scenario you describe above "... but haven't saved it"). As Geany uses the modified date/time of the file to drive the reload query it won't see any change if the file date/time does not change. But saving from another editor sets the modified date/time and triggers the query. Nothing in the scenario touches the buffer in Geany, it is not connected to the file on disk, your magnum opus of "//1234" is still there, just save it. In fact I would have thought the risk of losing it was increased if you get multiple reload queries, thats multiple chances to accidentally say "yes". Kate may use another metric to indicate "changed" or maybe it uses the OS `inotify` facility. But `inotify` (and therefore its Glib wrapper `g_file_monitor`) has limitations and bugs (described in `man inotify`) and although it was tried in Geany it was disabled because it missed changes, does not see files on remote filesystems, and doubled up reports of changes. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3839#issuecomment-2054294557 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [build] Improve custom command dialog (PR #3833)
LGBI. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3833#issuecomment-2054035862 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [plugins/filebrowser] Change external open default to `xdg-open` (PR #3815)
> (I did the cinnamon install and I don't have nautilus). Welcome to the light ;-) As the default `xdg-open %d` opens a file manager then thats safe, it won't open some random software on the users system. If they change the setting they are responsible for the consequences. So my opinion is that `xdg-open` looks to be a better more portable (among Linuxes) alternative to `nautilus` and its ok to merge, although give the weekend at least for others (with non LM distros) to look at it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3815#issuecomment-2054028934 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [msgwin] Reset compiler/messages treeview width at start of build/search (PR #3816)
> It was open for a week Availability of our contributors is limited, a week is nowhere near time that guarantees people have time to notice, and review it. Most only have weekends, but if they are busy one weekend they have missed your PR. > you didn't object to the change after seeing it I suggested an alternative approach and we are looking at that on another PR, that is clearly not approval of this change. > it's an obvious improvement. Because we are looking at an alternative I have not even looked at the implementation of this, so "obvious" is purely your own judgement. It may be right in this case, but it may not be in another. Having someone else review your changes is part of a cooperative project, not merging before they have a chance. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3816#issuecomment-2054023539 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
@elextr commented on this pull request.
> +void sci_scroll_lines(ScintillaObject *sci, gint lines)
+{
+ SSM(sci, SCI_LINESCROLL, 0, (uptr_t) lines);
+}
+
+
@b4n I am normally the one complaining about single use functions where a lump
of functionality is broken out for no good reason, and that case totally
matches your reasoning.
But for APIs wrapping is a useful way of getting encapsulation and hiding, and
the Geany plugin API should have been done that way, but well, that ship has
sailed, hit stormy seas, and sunk ;-D
Probably doesn't matter at this stage which this individual call uses but every
little drop of water erodes the stone [proverb].
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3835#discussion_r1564537916
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
> hum… sounds hacky, but might happen to work, I don't know. Totally hacky :-). But if it works it keeps the scrolling under Scintilla's control and IIUC Scintilla makes attempts to match the environment scrolling speed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3835#issuecomment-2053946683 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
> The mouse wheel would look broken if scrolling stopped when control is > accidentally pressed. Hmm, ok, in that case is it safe for us to simply edit the event to remove the control mask then let it go to Scintilla, maybe @b4n knows, or you could try it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3835#issuecomment-2053882168 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Wrapping Compiler and Messages lines (Issue #3834)
I had a short time to try things. Based on your status window code, set `wrap-mode` and `wrap-width` (which is pixels not characters). Testing with status window on the right so the width can be changed with the pane separator sees wrapping happen fine at the set `wrap-width` or the window width if it is _greater_ than `wrap-width`. So `wrap-width` sets the _minimum_ wrap width in pixels, if less space is available it simply hides part of the column like normal. But row heights are not recalculated, it is calculated when data is first added to the row and left at the height needed for `wrap-width` since this is big enough to contain the worst case. That is why various examples on the web show massive blank space when `wrap-width` was set small (like 50 in one example) and so the row height was calculated based on that value but he text wrapped based on the actual widget width. Your attempt to use the callback to reset `wrap-width` seemed a good idea, but for me it is never called with signal `check-resize` (printf debugging :-). Maybe another signal could work better? Alternatively given the uses it should be enough if we can calculate the right value for `wrap-width` based on the layout and just leave it since none of the message windows change their existing contents and new lines added (eg in status) get their height based on the `wrap-width`. This won't change the height if the window is resized after it has content, but that won't matter so much for compiler and messages which are reset regularly, so long as the new `wrap-width` is used when the new data is added. With this model status probably should be left unwrapped and of course its irrelevant to scribble and terminal. I have run out of time now, over to you. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3834#issuecomment-2053881145 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
@elextr commented on this pull request.
> +void sci_scroll_lines(ScintillaObject *sci, gint lines)
+{
+ SSM(sci, SCI_LINESCROLL, 0, (uptr_t) lines);
+}
+
+
Disagree with @b4n, all Scintilla interfacing should go through wrappers so
that changes Scintilla makes can be abstracted away, for example the recent
string length change.
The performance difference will be immaterial unless the Scintilla call is
being hammered in a loop (which it never is AFAICT). And if it _is_ a problem
anywhere, define the function `inline` in `sciwrappers.h` (C99).
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3835#discussion_r1564399845
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] [msgwin] Reset compiler/messages treeview width at start of build/search (PR #3816)
@ntrel, where does anybody say they have tested or reviewed this? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3816#issuecomment-2053823635 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add options to control scrollwheel behavior (zoom and scroll lines) (PR #3835)
Why is it transforming ctrl+scroll to scroll differently (as @b4n pointed out on the code) instead of doing nothing when `scrollwheel_zoom_disable` is set? On #2954 you say: > I have the editor font sent to a comfortable size. Many shortcuts consist of > combining the Control key with others. And of course, the touchpad is used > for moving the cursor. So very frequently (multiple times per day), I > accidentally engage the scrolling function of the touchpad while the control > key is pressed. This causes the editor view to zoom, which is disruptive. Simply disabling the ctrl+zoom will achieve your aim and won't unexpectedly scroll the view either. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3835#issuecomment-2053821224 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Wrapping Compiler and Messages lines (Issue #3834)
According to the GTK wrap-mode link in your OP the `wrap-width` property also needs to be set as well, its not in your WIP commit so unless its already set somewhere else in Geany it needs to be added. Note the Python code sets `wrap-width`. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3834#issuecomment-2053623074 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Backgroud color for selection (Discussion #3836)
The Scintilla editing widget Geany uses only recently added the capability with the new [element API](https://www.scintilla.org/ScintillaDoc.html#ElementColours), but Geany does not expose it, well written PRs that integrate it into colour schemes are welcome. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3836#discussioncomment-9103256 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [msgwin] Reset compiler/messages treeview width at start of build/search (PR #3816)
> all I was saying was that wrapping is not always an improvement. Ok, true, which suggests having a menu item to turn it on and off quickly and easily, not a preference. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3816#issuecomment-2052987288 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add option to disable zooming (via the scroll wheel) (PR #2954)
Probably cleaner to make a new one -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2954#issuecomment-2050941280 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add option to disable zooming (via the scroll wheel) (PR #2954)
Just thinking about it again, rather than waiting for Scintilla to get the ctrl+scroll and then resetting it, a better way would be to intercept the event in Geany [here](https://github.com/geany/geany/blob/dbaf99e3528a2f9007c4ab0ced416bdd87c22574/src/editor.c#L4778) and not propagate it to Scintilla in the first place. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2954#issuecomment-2050915144 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Can't define keyword who start with @ for syntax coloration (Issue #3830)
> who start by @, but I can't color them.
The Rust lexer does not detect them as identifiers, its identifier code is:
```c++
static bool IsIdentifierStart(int ch) {
return (IsASCII(ch) && (isalpha(ch) || ch == '_')) || !IsASCII(ch);
}
/* This isn't quite right for Unicode identifiers */
static bool IsIdentifierContinue(int ch) {
return (IsASCII(ch) && (isalnum(ch) || ch == '_')) || !IsASCII(ch);
}
```
That is because Rust doesn't allow identifiers to start with `@`
> And also, is it possible to define a coloration for every u or i followed by
> a number ?
That matches the definition of identifier above, so any that exist in one of
the keyword lists will be styled for that list, but not any u or i followed by
a random number.
> but with Rust lexer and tag parser, maybe a ctag problem ?
You are running into the problem with custom types, lexers and tag parsers are
intended for a specific language and will only work for a custom type to the
extent that your language is the same. Colouring is not a ctags problem, but
symbols in the sidebar will be.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3830#issuecomment-2050779659
You are receiving this because you are subscribed to this thread.
Message ID:
[Github-comments] Re: [geany/geany] Distinctness of white_space markers (Issue #3829)
The visible whitespace artefacts are drawn by Scintilla which only allows one foreground and one background setting to cover both spaces and tabs and it has no way of controlling the dot size. There is a setting to remove the head of the tab (so its just the horizontal line) which has not been exposed in Geany, and I'm not sure it would help you much. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3829#issuecomment-2049668984 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [msgwin] Reset compiler/messages treeview width at start of build/search (PR #3816)
> Often when doing Find in Files I'm not interested in any matches on long > lines (e.g. text files), I'm only interested in matches in code which are > almost always short lines. Wrapping would just add more vertical noise (in > this case). See your use-case and raise you a different use-case. But then if searching documentation where modern markups tend to use single line paragraphs edited with wrap on it would be very useful as most of the matching line would be off screen and the horizontal scrolling would be horrible :-) If you don't want to add wrap just don't do it, I am only asking, but don't try to justify it with easily refutable use-cases. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3816#issuecomment-2043985269 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add 'Open Terminal' and 'Open Directory' to right click menu (PR #3813)
> The difference with opening a terminal or file manager from the desktop, is > that this opens it inside the same directory as the file, saving a whole lot > of time compared to manually navigating to the same directory. I knew that the file manager opened in the current file directory, but I didn't think terminal did, which is why I asked. > I'm leaning towards creating a new plugin for this, one I'd also be willing > to contribute to geany-plugins. Would you say that this indeed sounds like > the best option? Yes, especially if it is fairly general to "Run Commands". ATM Geany can run commands: 1. custom commands that get the buffer/selection in their stdin and the buffer/selection is replaced by their stdout, can have 10 IIRC, or 2. run a grep compatible command and show results in the message window, or 3. build commands where the stdout is scanned for errors and shown in the compiler tab, or 4. execute comands that are run in a script in a terminal so their stdout is shown to the user. All of these wait for completion, AFAIR there is no way to just run commands and forget about them. So a plugin that allowed commands to be configured that would just be run and forgotten would be useful. If it had a fixed number like custom commands it should be possible to have a keybinding section for the plugin so you could have shortcuts for the commands, fixed because the keybinding GUI doesn't handle variable numbers of entries after loading which is why extra build commands can't have keybindings, only the fixed minimum entries. A single "Run Commands" menu item could be added to tools with the actual commands as a submenu. Gold star for configuration GUI to define the commands. Extra points for %c %d type substitutions in commands like build commands do. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3813#issuecomment-2043975022 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Fix Find in Files invalid directory error (PR #3818)
Agree, improving input validation is a better solution since the command return error does not actually identify the error. LGBI -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3818#issuecomment-2043949401 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [RFC] Enable keyboard searching for Compiler and Messages tree views (PR #3823)
Don't know why its disabled, perhaps there were problems on GTK2. But if it works ok why not, finding "required from here" in 3000 lines of C++ errors from one misplaced character could be very useful :grin:. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3823#issuecomment-2043943967 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Windows: Geany does not update the UI text to be white on dark background/dark gtk-theme (Issue #3827)
There is probably something wrong with the theme, note the text in the document tree is white. Customisations can be put in `Tools->Configuration Files->geany.css` but as this project isn't responsible for the theme we can't advise what you need to change, you will need to look at the theme and see what it sets for what elements. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3827#issuecomment-2043935489 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Change bar all green after reload (Issue #3824)
If I read the linked notepad issue correctly notepad can't undo the reload, so truncating there makes sense, but Geany can undo the reload (depending on the option but its default is true IIRC) like Scite. So as Neil says on the Scintilla issue, (thanks for finding, I thought I had seen it somewhere) its not clear how to handle it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3824#issuecomment-2043909108 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [Input Dialog refactor] Replace 5 function parameters with 2 (PR #3826)
@elextr approved this pull request. Agree its a better idea to put the common parts in the shared function and the different parts in the callers. Not tested but LGBI. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3826#pullrequestreview-1987842008 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [Make Custom Target] Always put a space between command and argument (PR #3825)
@elextr requested changes on this pull request. The space is currently only added to pre-0.19 formats, so adding it to all formats is an incompatible change. It assumes that the user is typing a full argument as they are required to do pre-0.19 but post 0.19 formats allow them to only have to type part of the argument. Currently if the user configured "my_build_script f" in the GUI for custom command and typed "oo" the command is "my_build_script foo" but this change will make it "my_build_script f oo" with no way to recover. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3825#pullrequestreview-1987816591 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Change bar all green after reload (Issue #3824)
What should happen on undo of the reload? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3824#issuecomment-2043777058 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Line Operations plugin outputs "Value: 0" to terminal when Geany launches (Issue #1322)
Looks like a debug print was left in [here](https://github.com/geany/geany-plugins/blob/a8f26ab20668206588aac8ffd3f56045575bebd6/lineoperations/src/lo_prefs.c#L120) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1322#issuecomment-2041817054 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Meaning of "Value: 0" in terminal seems to be undocumented (Issue #3822)
It not going to be harmful, just you will miss any other messages that come from libraries like GTK, although most of them should be stderr not stdout. And after all when Geany is run from the desktop menu stdout/stderr messages are usually lost, so its no worse. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3822#issuecomment-2041809662 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Meaning of "Value: 0" in terminal seems to be undocumented (Issue #3822)
Doesn't happen here. Try `geany -p` to see if its a plugin. If it is start with only one at a time enabled until you find which one then report on the geany-plugins repo. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3822#issuecomment-2041753901 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [msgwin] Reset compiler/messages treeview width at start of build/search (PR #3816)
I'm not so sure there is a "reason not to use wrap", you have made a speculation, but have you tried it? In Vscode wrapped error messages (G++) are still the crap the compiler gives, but at least there is no need to scroll side to side to try to figure out what its whinging about, its possible to read it all. Thats not to say this PR isn't an improvement, I just was looking to see if there might be more improvement available. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3816#issuecomment-2039601327 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Document *Go to line* offsets (PR #3817)
@elextr approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3817#pullrequestreview-1982761782 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [msgwin] Reset compiler/messages treeview width at start of build/search (PR #3816)
Or maybe [wrap](https://docs.gtk.org/gtk3/property.CellRendererText.wrap-mode.html) could be turned on. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3816#issuecomment-2039491302 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] [plugins/filebrowser] Change external open default to `xdg-open` (PR #3815)
The existing command "nautilus" is a Gnome file manager, so its not likely to be available on non-gnome distros, so "xdg-open" is likely to be more portable, but is it doing the same thing? The (expletive deleted useless) nautilus [man page](https://linux.die.net/man/1/nautilus) doesn't say what it does when run with a file path, does it open that file or open the file manager at the path with the file selected[^1]? In other words does xdg-open do the same thing? Does it matter since "nautilus" won't work for lots of people anyway but xdg-open probably will? [^1]: no I can't try nautilus, it isn't installed on my non-Gnome desktop and the file manager here when run with a file opens itself with the file selected, it does not open the file. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3815#issuecomment-2039460395 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add 'Open Terminal' and 'Open Directory' to right click menu (PR #3813)
> shall I place the entries in say the 'Tools' menu? Well thats a short menu so a good candidate, although plugins add stuff to it too. Which raises the question, did you check that none of the plugins already does either of these? Especially Add Ons which has become a bit of a catch all :-) Also personally I can't see the purpose for the Open terminal if its just going to open the same as if its from the desktop. Geany isn't trying to become a whole OS unlike Emacs ;-P As for Glade, yeah, the 3.8.5 isn't relevant any more, this sort of change noise used to be a problem and 3.8.5 did fix it, thats why it was mentioned, but as to current versions, somebody else will have to advise, I havn't used Glade for years and am not sure what the minimum and maximum version is or if it has settings for a target file version. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3813#issuecomment-2039411492 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)
> This underlying issue has been fixed in upstream ctags repository. Ok, will get included when the ctags is next updated from upstream. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3660#issuecomment-2038623056 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] visual design (Issue #3810)
[brace_good, brace_bad](https://github.com/geany/geany/blob/1735daeb2cff6022cf9f5da6b13d6f2340cca6e1/data/filedefs/filetypes.common#L112) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3810#issuecomment-2038619245 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Add 'Open Terminal' and 'Open Directory' to right click menu (PR #3813)
@elextr requested changes on this pull request. In principle the right click menu should be context related, like the `Open Selected File` entry[^1]. So it might be better to add these new items to a normal menu, and then they can be given a keyboard accelerator and even a shortcut as well. I suggest that adding a separate command for terminal would be better than using the existing command and substituting nothing for `%c`. There is no guarantee that will produce a valid command. There is plenty of space in the Tools Preferences page. Which version of glade did you use? there seems to be a lot of unrelated change noise. I have only had a quick look review so far. [^1]: Yes yes I know it has accumulated non-context related things over the years, but thats no excuse to continue the trend. > in the command are substituted with the run script name, see `Terminal emulators`_. +File Manager + The command to use to open a file manager. Occurences of %d + are substituted with a directory in which to open it. + Say _what_ is substituted for %d directory of current file or home dir if no files open, its up to the command to determine what to do with that. > @@ -73,37 +73,40 @@ /* some default settings which are used at the very first start of Geany to fill * the configuration file */ -#define GEANY_MAX_SYMBOLLIST_HEIGHT10 -#define GEANY_MIN_SYMBOLLIST_CHARS 4 -#define GEANY_MSGWIN_HEIGHT208 -#define GEANY_DISK_CHECK_TIMEOUT 30 -#define GEANY_DEFAULT_TOOLS_MAKE "make" +#define GEANY_MAX_SYMBOLLIST_HEIGHT10 +#define GEANY_MIN_SYMBOLLIST_CHARS 4 +#define GEANY_MSGWIN_HEIGHT208 +#define GEANY_DISK_CHECK_TIMEOUT 30 +#define GEANY_DEFAULT_TOOLS_MAKE "make" Why all these noise changes? > gchar *term_cmd; /**< > terminal emulator command */ + gchar *file_manager_cmd; /**< file manager command */ This struct is in the plugin API, so add new fields at the end to avoid breaking the ABI, increment the API, see HACKING. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3813#pullrequestreview-1981492918 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
> I would suggest to provide Windows installer. Most of the users will still > use official installer who are not familiar with msys2 and its packaging > system. But as I said above, none of the major contributors use Geany on Windows, even the nice guy who makes the build (and yes with installer) so its virtually untested. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2036208896 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
> geany 2.0 is built with meson in msys2 project Maybe we can stop making a build for Windows (hopeful). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2036200273 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: Prevent showing console after running geany in Windows (PR #3811)
Is that harmless on Linux builds? If not it needs to be conditioned appropriately the same as `win_src` and `vte_src` are, probably best if its done anyway, even if harmless at this point, since Meson has a habit of increasing strictness and creating errors of previously acceptable things. I am not sure that the meson build has been tested on Windows, the Windows builds for Geany are usually cross built from Linux. Basically there are no Windows users amongst the regular Geany contributors, so a Grumpy olde guy like me says drop the Windows build until somebody(s) using Windows support it, but the really nice guy who makes the builds keeps doing it even though he doesn't use it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3811#issuecomment-2035799889 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] RFE: markdown plugin - option to synchronize views (Issue #1267)
Plugins are submitted by and maintained by individuals named in the Maintainers file. Although Markdown is listed as "maintained" nothing has been heard from the maintainer for years, so requests may indeed be yelling into a void. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/1267#issuecomment-2035788200 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] meson: correctly set WIN32 in config.h (PR #3660)
Is `_WIN32` set for cross builds? For Geany Windows builds are usually cross built on Linux. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3660#issuecomment-2035767733 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Unable to load right_ptr from the cursor theme (Issue #3809)
> I really never knew how many folks were so passionate about cursors! I'm not sure its so much about cursors as it is G* folks going back on their word and breaking GTK3 applications _again_, just proves that we can't trust 'em, Leopards never change their spots etc etc. Oh well, my answer is "Don't use dead tortoises as themes, make a proper one you lazy " :grin: Basically a "default" theme is never going to be right for anyone, so it should be as lousy as possible (like default HTML) which Adwaita achieves IMNSHO so all distros should make their own and not be lazy [end rant] I don't know why Scintilla uses different cursors, possibly to match the behaviour of the initial Windows control it is based on. It tries to be consistent on all platforms. Perhaps Scintilla should switch to checking the return [here](https://github.com/geany/geany/blob/3a92129d61d4d8e96136e29d4709bb638527be40/scintilla/gtk/PlatGTK.cxx#L1297) and and falling back to default if fail. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3809#issuecomment-2030933161 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Unable to load right_ptr from the cursor theme (Issue #3809)
> > if it doesn't get in a release should not appear in stable distros. > No, that "compromise" > [merged](https://gitlab.gnome.org/GNOME/adwaita-icon-theme/-/merge_requests/65) > during the past dev cycle, and was included in the tagged release. All > rolling/current distros that default to Adwaita are missing right_ptr. Sorry, if the linking of the old names compromise was in the release why is right_ptr missing, or did they forget that one? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3809#issuecomment-2030860418 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] visual design (Issue #3810)
For alternative colour schemes see [geany-themes](https://github.com/geany/geany-themes) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3810#issuecomment-2029364646 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] changing cursor blinking rate or make it invisible (Issue #3410)
As I said, turning blinking off works on LM Cinnamon, sounds like you need to raise an issue with LM and maybe upstream XFCE rather than making a way for Geany to force overriding it. Scite is C++, Geany is C, Scite properties are handled very differently to how Geany settings are handled, so not much code is going to be directly reusable. Better to start from the Scintilla [API](https://www.scintilla.org/ScintillaDoc.html#SCI_SETCARETPERIOD). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3410#issuecomment-2029312187 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] changing cursor blinking rate or make it invisible (Issue #3410)
Turning off cursor blinking works here with Cinnamon, are you restarting Geany each time you change it? Scintilla only loads from the settings at startup. I don't see why you are playing with the Scintilla code, the Scintilla API provides a means of controlling it from the application, just that Geany does not do so. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3410#issuecomment-2029278087 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Unable to load right_ptr from the cursor theme (Issue #3809)
Yes, Scintilla can use the cursors [here](https://github.com/geany/geany/blob/3a92129d61d4d8e96136e29d4709bb638527be40/scintilla/gtk/PlatGTK.cxx#L1297) and it just asks GDK for them. It is [documented](https://www.scintilla.org/ScintillaDoc.html#SCI_SETMARGINCURSORN) that a right cursor is shown over margins and Geany does not set it, just leaves it as default. A PR making a setting to select a different cursor would probably be accepted so long as default was as is. Elsewhere Scintilla notes use of another cursor icon for clickable links, not used by Geany, but I think plugin(s) might use it. A quick look at the discussion the OP linked seems to suggest that the problem is being fixed by linking under the old names as well as the new names, so I doubt its worth it doing anything in Scintilla or Geany. The problem should only affect bleeding edge rolling distros for a short time, and if it doesn't get in a release should not appear in stable distros. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3809#issuecomment-2029044492 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] changing cursor blinking rate or make it invisible (Issue #3410)
Hmmm, Scintilla GTK has an undocumented feature[^1] where its initial blink and blink rate are set from GTK settings if available [here](https://github.com/geany/geany/blob/3a92129d61d4d8e96136e29d4709bb638527be40/scintilla/gtk/ScintillaGTK.cxx#L693) So that would work if you can set `gtk-cursor-blink` and `gtk-cursor-blink-time` (in ms) in GTK settings via your desktop or otherwise. Works on LM (XFCE from @oOosys and Cinnamon for me) which is a GTK focused distro. Others can test on their desktop, for example not sure if a KDE desktop will set GTK settings. [^1]: here I actually mean a _feature_ not a bug :grin: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3410#issuecomment-2029013815 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Unable to load right_ptr from the cursor theme (Issue #3809)
Well don't use dead tortoise as your theme is likely the only answer Geany can give, we don't don't ship or set icon themes. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3809#issuecomment-2028508721 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Geany v2 file open dialog (Windows) (Discussion #3808)
Its probable that other users of file servers have them mounted (or whatever the Windows word is) so they access by something like `//server/foo/file.blah`. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3808#discussioncomment-8962208 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] contents within () {} [] jump a little bit following non-ascii characters (Issue #3803)
Closed #3803 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3803#event-12299174547 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany] Remove all items of the tab-switcher except the tab-titles (Issue #3806)
We don't delete issues, and we try to encourage people to search open _and_ closed issues before posting, so all issues are kept because even this one answers a question. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3806#issuecomment-2026482175 You are receiving this because you are subscribed to this thread. Message ID:
