I'll stretch the last point from the future PR plan. Maybe we find another
solution for existing users or just leave them with their configuration.
WRT `gtk_show_uri()`: for it doesn't work with any local filesystem URL,
neither with `file://` prefix nor without nor escaped nor unescaped.
At
If `gtk_show_uri()` doesn't work, this should do fine to open the default
browser:
```c
system("start \"\" \"file:///C:/where/ever/foo.html#blah\"");
```
At least it works fine from the command line.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
> I'm going to test gtk_show_uri() (and the _on_window variant) on Windows,
> maybe it works for file:// and http:// URIs even without GVFS what should be
> well enough for opening URLs in the browser.
Great, don't forget to test URLs with `#foo` on them in case GTK just uses
`ShellExecute`
I'm going to test `gtk_show_uri()` (and the `_on_window` variant) on Windows,
maybe it works for file:// and http:// URIs even without GVFS what should be
well enough for opening URLs in the browser.
I would prepare a PR to do the following:
- remove the "firefox" default browser on Windows,
Yeah the GVFS is a problem, especially for windows. But the GVFS dependency is
only for the `_window` version IIUC.
If its only useful for local files its useless, since open browser is used for
lots of stuff. But we can use the basic`gtk_show_uri()` version (if it works),
until its removed
Yeah, `gtk_show_uri()` should be tested on windows, and tested that it handles
the `#foo` correctly for both `file://` and `http://` urls. If it works for
GTK2 and 3 then use it if no browser is configured, on all platforms, and on
windows don't configure a browser by default (we already have
> The reason we use ShellExecute("open", uri, ...) on Windows is that it's the
> easiest way to open the system's default browser without any hassle.
Probably before, but since GTK+ 2.14 I think the simplest and most robust way
should be
@eht16 `@lex` isn't actually my github name, but getting pinged serves them
right for using it before I did :)
(hope they are friendly)
> However, I don't want to open three new issues two weeks before the release.
Its ok to open them, just don't commit windows only fixes the week before
Windows support is annoying :(.
@Lex On Windows, we always strip the `file://` prefix in
https://github.com/geany/geany/blob/master/src/win32.c#L789.
This has been added to support the "builtin" Run command for HTML files, this
wouldn't work otherwise. Maybe this just masks another bug in
Same thing with Firefox as default browser. When I run it from the command line
with the forward slashes in the path it doesn't realize it's a path and
searches the web using the current search provider. With proper backslashes, it
tries to open the file, but the `#` for the anchor name gets
It uses `file:///` for windows, and the skip is only used to test if the file
is locally installed or if we have to go to the online `geany.org` copy. It
should call `win32_open_browser()` with the `file:///` intact AFAICT.
--
You are receiving this because you are subscribed to this thread.
Weird.
We explicitly strip the `file://` prefix from the URL when opening URLs on
Windows.
I don't remember why we did this. Though even when keeping the prefix, the URL
opens but the anchor is stripped and ignored.
I'll debug this further at the weekend.
--
You are receiving this because you
Specifically, with Geany-1.30.1 (default install) on Win7/32-bit, when
accessing help from within preferences, help fails to open and the following
error is reported in the status bar:
*Failed to open URI: "C:\Program
Files\Geany\share\doc\geany\html\index.html#editor-features-preferences":
13 matches
Mail list logo
