Merged #2566 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2566#event-3837051783
@codebrainz approved this pull request.
Works fine for me when commenting and uncommenting line(s), when I set
`comment_single` to nothing.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> P.S. "Uncomment code" works strange with block comment.
Hmm yeah, doesn't seem to work for any language (at least doesn't work for C
AFAICT), so its separate issue, not Lua. Not really sure what it is supposed
to do, but I suspect it favours single line comments if the setting exists, and
Hm... in this case `--]]` looks more useful.
P.S. "Uncomment code" works strange with block comment.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2566#issuecomment-699899446
@Skif-off the reference provided by the OP to the Lua manual explains the
reasoning behind the `--]]` idiom.
This setting is only used by the comment functions to comment/uncomment code,
which is exactly the situation the reference above talks about, its not used
anywhere it is actually
`]]--` or `--]]` don't make sense, because:
- `]]--`: comment will end with `]]` and `--` will be beginning of other
(single) comment, in C/C++ it would be::
```c
/*
Block comment
*/// Single comment
```
Such "coding style" looks like crap...
- `--]]`: comment will end with `]]` and `--` will
According to the link, end comment is `]]` not `]]--` so the original was wrong
anyway. The modification is what is touted by the Lua manual as idiomatic
usage rather than the actual end comment but its more correct than the original.
Will commit soon unless many Luaists object that it will
See: https://www.lua.org/pil/1.3.html
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/2566
-- Commit Summary --
* filetypes.lua: Change block comment
-- File Changes --
M data/filedefs/filetypes.lua (2)
-- Patch Links --
