@Yanpas pushed 1 commit.
2ca4fe13a3c2a9d9443442aec47202089f1ef921 warning, regex support
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@Yanpas pushed 1 commit.
59a71e0 Merge branch 'master' into warnings
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1649/files/e6af531ab210ca87bee7fde48d7d1735141e4621..59a71e09ca7f34c8e23dcbf72a968dea6ff7b05f
OK, will handle it
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1649#issuecomment-371067896
Well, nobody has suggested rejecting it, but it wasn't obvious that it was
ready for testing (hence my question), and then without the conflicts being
fixed nobody can test it either.
I expect the conflicts are due to the PR that made error colours configurable
by CSS, so you would need to
I do not working on it since there are no updates and tasks to do in this PR.
If geany's team is willing to merge it I will resolve the conflicts.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
What do you mean?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1649#issuecomment-371063465
@Yanpas ping, where is this up to?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1649#issuecomment-371061636
This will close/fix #447 when merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1649#issuecomment-357394261
I agree with @elextr, `compiler` would be too specific as we use the Build
infrastructure here also for many other tools than compilers.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Well, the indicators come from any build, not just compilers, so I would
suggest "Remove Build Indicators"
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1649#issuecomment-342008134
Menu item "Document" -> "Remove error indicators" shoud be renamed to "Remove
compiler indicators" I guess
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1649#issuecomment-341982993
Oh, its just your test file, I thought you were getting the error compiling
Geany :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1649#issuecomment-337443120
Yes, it's an exmaple of error. Fifth line 5 in "main.c" file. I've fixed the
code and now regexp form previous comment works. Only documentation left?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@Yanpas pushed 1 commit.
e6af531 fix named subpattern finding
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1649/files/efbb6f7bb31fef2f7890928d6c26b2b7f4a18642..e6af531ab210ca87bee7fde48d7d1735141e4621
> line: main.c:5:2: error: 'a' undeclared (first use in this function)
What is this error from? line 5 of "main.c" ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
It seems that glib isn't able to fetch named subpatterns inside groups
line: `main.c:5:2: error: 'a' undeclared (first use in this function)`
regex: `(?[^:]+):(?[0-9]+):([0-9]+):
((?error)|(?warning)).+`
`g_match_info_fetch_named_pos` returns false.
--
You are receiving this because you are
@Yanpas pushed 1 commit.
efbb6f7 regex support
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1649/files/9705be61c2cb480747c9a8ae12c1a4a7b581cf57..efbb6f7bb31fef2f7890928d6c26b2b7f4a18642
> BTW it seems that backreferences do not support named groups.
>From the glib regex syntax description:
```
Back references to named subpatterns use the Perl syntax \k or \k'name'
or the Python syntax (?P=name).
```
but I admit its not easy to find. And named back references are also numbered
Oh, didn't know about named subpatterns, I thought glib supports only
sequential subpatterns. BTW it seems that backreferences do not support named
groups.
I think I should document this convetions at least as a comment for
`filetypes_parse_error_message`. The problem with regexps is solved.
> Also I didn't find convetions for regexp. For example mapping of group
> number, type and meaning (e.g groupn:2; meaning:line number; type:integer). I
> don't think it's a good idea to hardcode such mapping.
The use of the regex is described in the [Geany
> Not sure what you mean, can you expand?
While I was implementing this issue I haven't traced any usage of regexp (I've
inserted printf's). It seems they are defined in filetype config files. Also I
didn't find convetions for regexp. For example mapping of group number, type
and meaning (e.g
An alternative to having separate error and warning regexes could be to use
separate named captures for error and warning.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> Note that I didn't workout regex since it seems to break group number
> conventions.
Not sure what you mean, can you expand?
> Also for this to work we must reset LANG envvar (maybe provide an option?)
> since gcc translates words "error", "warning", "note".
Well, the regex is there for
Fix #864
Note that I didn't workout regex since it seems to break group number
conventions.
Also for this to work we must reset LANG envvar (maybe provide an option?)
since gcc translates words "error", "warning", "note".
24 matches
Mail list logo
