[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)
Merged #1335 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1335#event-12612366928 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)
@b4n approved this pull request. LGTM and seems to work fine here. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1335#pullrequestreview-2022078950 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)
@b4n Thanks... I've squashed the commits. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1335#issuecomment-2076289869 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)
@b4n commented on this pull request. Looks good, works fine, but the 2 first commits don't really work one without the other, so they should be merged: the first one actually make it use webkit2gtk only, but by removes the conditional that enables the code to use it (and it probably also breaks the build system by having an undefined conditional). So fine by me once those 2 commits get squashed together. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1335#pullrequestreview-2020825180 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)
@xiota pushed 1 commit. c8d5d229d73c2ddcbcfcca3fd3557f77c74d3d94 Markdown: Update version numbers -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1335/files/4003ca4cd882cdfb44cd86749d1c4630b0c10c56..c8d5d229d73c2ddcbcfcca3fd3557f77c74d3d94 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)
Needs to update README -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1335#issuecomment-2074723649 You are receiving this because you are subscribed to this thread. Message ID:
[Github-comments] Re: [geany/geany-plugins] Markdown: Add support for webkit2gtk-4.1 (PR #1335)
LGBI, the removals look good but did not check thats all that needs removing. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1335#issuecomment-2074588921 You are receiving this because you are subscribed to this thread. Message ID:
