Re: [Github-comments] [geany/geany] Fix: Improve documentation on duplication (#1228)

2016-09-11 Thread elextr
> @@ -3357,6 +3357,10 @@ Delete to line startCtrl-Shift-BackSpace >Deletes from the begin >current caret > position. > > Duplicate line or selection Ctrl-DDuplicates the > current line or

[Github-comments] [geany/geany] Geany 1.28 "Find in files" doesn't work in Windows 7 64bit OS (#1229)

2016-09-11 Thread VS
Please check screenshot(attached ![screenshot - sep 12 2016 8 11 am](https://cloud.githubusercontent.com/assets/332841/18423289/78951344-78c1-11e6-8af5-bf7bfe32c28b.png) ) and let me know what could be issue responsible for this behaviour. Ask me if still not clear. -- You are receiving this

Re: [Github-comments] [geany/geany] Fix some typos in French translation (#1227)

2016-09-11 Thread Landrok
> @@ -4412,7 +4412,7 @@ msgid "" > msgstr "" > "Tester la correspondance des expressions régulières sur tout le tampon d'un > " > "coup plutôt que ligne à ligne, ce qui permet aux correspondances de " > -"recouvrir plusieurs lignes. Dans ce mode les caractères de fin de ligne " > +"recouvrir

[Github-comments] [geany/geany] Fix: Improve documentation on duplication (#1228)

2016-09-11 Thread Michael Gruben
Previously, the documentation on the duplication did not clearly delineate the behavior of the `duplication` keystroke. Specifically, it was possible to interpret this keystroke as performing selection-only `duplication`. However, `duplication` only duplicates the selection on the same line, or

Re: [Github-comments] [geany/geany] scrollbar steppers missing running as root (#1226)

2016-09-11 Thread elextr
What version of GTK is Geany using? (menu->help->debug messages near the top). If its gtk2 then the css is not going to have an effect, you will need to do it with gtkrc. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

2016-09-11 Thread elextr
Looks unnecessarily complex. Shouldn't need all the changes to the internals. Get any command is a good idea, yes. To do that I suggest you modify `build_get_menu_item()` which is not in the API and not used in Geany. Just add the field parameter, and the switch statement from

Re: [Github-comments] [geany/geany] Geany 1.28 "Find in files" doesn't work in Windows 7 64bit OS (#1229)

2016-09-11 Thread elextr
The messages are from the `grep` command shown in blue at the top of the window. Try running it at the command line after `cd`ing to the directory indicated. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany] Add utils_get_real_path() and use it (#1224)

2016-09-11 Thread Matthew Brush
This is a wrapper around `tm_get_real_path()` but is in a more suitable namespace/module. I think it makes more sense like this. I typically dislike adding general-purpose functions to the API, but since Glib doesn't provide any equivalent, it really is useful. You can view, comment on, or

[Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

2016-09-11 Thread Matthew Brush
So plugins can set the current command rather than only get it, as well as get a specific command rather than only set it. __Note:__ This needs real code review since I had a hard time following the code in `build.c`, I'm not 100% confident I implemented this correctly. Will be testing with a

Re: [Github-comments] [geany/geany] Fix some typos in French translation (#1227)

2016-09-11 Thread Colomban Wendling
Apart a small remark, LGTM -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1227#issuecomment-246194486

Re: [Github-comments] [geany/geany] Fix some typos in French translation (#1227)

2016-09-11 Thread Colomban Wendling
> @@ -4412,7 +4412,7 @@ msgid "" > msgstr "" > "Tester la correspondance des expressions régulières sur tout le tampon d'un > " > "coup plutôt que ligne à ligne, ce qui permet aux correspondances de " > -"recouvrir plusieurs lignes. Dans ce mode les caractères de fin de ligne " > +"recouvrir

Re: [Github-comments] [geany/geany] Add utils_get_real_path() and use it (#1224)

2016-09-11 Thread Matthew Brush
@codebrainz pushed 1 commit. 0370112 Mark tm_get_real_path with G_DEPRECATED_FOR -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Github-comments] [geany/geany] Fix some typos in French translation (#1227)

2016-09-11 Thread Colomban Wendling
> @@ -2202,7 +2202,7 @@ msgid "" > "Space separated list of file patterns used for the find in files dialog (e." > "g. *.c *.h)" > msgstr "" > -"Liste de motifs de fichier, séparés par une espace, à utiliser dans le " > +"Liste de motifs de fichier, séparés par un espace, à utiliser dans le "

Re: [Github-comments] [geany/geany] Fix some typos in French translation (#1227)

2016-09-11 Thread Landrok
> @@ -2202,7 +2202,7 @@ msgid "" > "Space separated list of file patterns used for the find in files dialog (e." > "g. *.c *.h)" > msgstr "" > -"Liste de motifs de fichier, séparés par une espace, à utiliser dans le " > +"Liste de motifs de fichier, séparés par un espace, à utiliser dans le "

[Github-comments] [geany/geany] Fix some typos in French translation (#1227)

2016-09-11 Thread Landrok
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/1227 -- Commit Summary -- * Fix some typos in French translation -- File Changes -- M po/fr.po (52) -- Patch Links -- https://github.com/geany/geany/pull/1227.patch

[Github-comments] [geany/geany] scrollbar steppers missing running as root (#1226)

2016-09-11 Thread nilands55s
I hate the overlay scrollbars as I find I have to hunt for them, so they are disabled. To over come the missing items that used to come with fallback/flashback Gnome desktop I use 2 sections of code to bring back functionality. 'gtk-widgets.css' usually in the Theme section of the current

Re: [Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

2016-09-11 Thread Matthew Brush
> You never want to set the current build command, thats the point, why do you > want to set a command in an unknown source? If you want to set the build command which is currently active, otherwise you have to figure out if a project is open, for example, and then set that build command

Re: [Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

2016-09-11 Thread Matthew Brush
> Looks unnecessarily complex. Believe it or not, the code is actually simplified since it removes an unused function and refactors an existing function to be in terms of another function instead of duplicating code. But yeah, the diff looks complex at a glance due to the way diffs work. --

Re: [Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

2016-09-11 Thread elextr
The complexity (or not) isn't the main point. That `set_current` functionality should not be added is the main point. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

2016-09-11 Thread elextr
You never want to set the current build command, thats the point, why do you want to set a command in an unknown source? "Current" is a state, not a thing, it may be different after the next user input. You then don't know what you set. On 12 September 2016 at 15:47, Matthew Brush

Re: [Github-comments] [geany/geany] Make build_get/set_(current_)menu_item functions symmetrical (#1225)

2016-09-11 Thread Matthew Brush
> That set_current functionality should not be added is the main point. It's the only way to set the current build command, that's the rationale :) An alternative would be a function like `build_get_current_source()` to get the current build source and then use that the set it. -- You are

Re: [Github-comments] [geany/geany] Add new API function to open a project file (#1222)

2016-09-11 Thread Matthew Brush
Ammended commit to change API 229 to 230 since 094737533609dff5a2ff101f97e8c156bcca4979. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1222#issuecomment-246174379

Re: [Github-comments] [geany/geany] Add "project-before-close" signal to API (#1223)

2016-09-11 Thread Matthew Brush
Ammended commit to change API 229 to 230 since 094737533609dff5a2ff101f97e8c156bcca4979. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1223#issuecomment-246174611

Re: [Github-comments] [geany/geany-plugins] Addons: Implement deselect with single click (#481)

2016-09-11 Thread Enrico Tröger
Merged #481. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/481#event-785147250

Re: [Github-comments] [geany/geany] Improve template command error message (#1166)

2016-09-11 Thread Enrico Tröger
Merged #1166. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1166#event-785147411