Re: [Github-comments] [geany/geany] Geany on Windows includes a grep.exe that cannot handle some unicode in filename (#1260)

2016-10-16 Thread Enrico Tröger
The `grep` binary shipped with Git for Windows is from MSYS2 and hence it requires the MSYS2 libraries: ```sh $ ls -lh /c/tmp/git-grep/ total 4.9M -rwxr-xr-x 1 enrico None 210K Mar 11 2016 grep.exe -rwxr-xr-x 1 enrico None 3.3M Sep 9 09:38 msys-2.0.dll -rwxr-xr-x 1 enrico None 108K Apr 1 2016

Re: [Github-comments] [geany/geany] Sync ctags main part (#1263)

2016-10-16 Thread Jiří Techet
> I pity anyone who tries to review the entire changeset :) This is why I'd suggest reviewing it as if it was a single commit "Take over upstream ctags and apply Geany changes on top" which is how it will appear when you take meld and compare upstream ctags/main with geany-ctags/main. The diff

Re: [Github-comments] [geany/geany] Sync ctags main part (#1263)

2016-10-16 Thread elextr
@techee thanks for the explanation, can you explain more what is "cork" and what it provides? This is more for understanding than directly relevant to the PR. You pointed out the concern, is there anything that is not needed in Geany, thats in that code because ctags needs it (like for

Re: [Github-comments] [geany/geany] Sync ctags main part (#1263)

2016-10-16 Thread Matthew Brush
> Binary-size wise libgeany.so size looks this way: > ``` 17942824 before 18533832 after ``` I guess that's with default `-O2` and `-g` without stripping symbols? Here's what I get with different options (always using `make install-strip`): ``` Master branch w/ '-O4': 2.8 MB This branch w/

Re: [Github-comments] [geany/geany] Geany on Windows includes a grep.exe that cannot handle some unicode in filename (#1260)

2016-10-16 Thread Matthew Brush
> I'm actually tempted to bundle the MSYS2 binary along with the necessary > libraries The only "problem" I see that we would may be including two separate copies of `libiconv`, `libpcre` and maybe `libintl` since GLib already embeds these. IIRC, Glib build system has compile-time options to

Re: [Github-comments] [geany/geany] Sync ctags main part (#1263)

2016-10-16 Thread Jiří Techet
@codebrainz Yeah, thanks, I didn't notice it was an order of magnitude bigger. So it's something like 7% increase then. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany] Provide utf-8 command line arguments on Windows (#1258)

2016-10-16 Thread cshu
This can be reproduced when filename character is not supported by system locale's encoding. E.g. When system locale is "English (United States)", double clicking `read我.txt` opens an empty tab in Geany with name `read?.txt`. The file is not really opened. -- You are receiving this because