The `grep` binary shipped with Git for Windows is from MSYS2 and hence it
requires the MSYS2 libraries:
$ ls -lh /c/tmp/git-grep/
-rwxr-xr-x 1 enrico None 210K Mar 11 2016 grep.exe
-rwxr-xr-x 1 enrico None 3.3M Sep 9 09:38 msys-2.0.dll
-rwxr-xr-x 1 enrico None 108K Apr 1 2016
> I pity anyone who tries to review the entire changeset :)
This is why I'd suggest reviewing it as if it was a single commit
"Take over upstream ctags and apply Geany changes on top"
which is how it will appear when you take meld and compare upstream ctags/main
with geany-ctags/main. The diff
> @codebrainz @techee but what does all that code actually DO? Why has it
> accumulated over 10 years (if thats the reason)? What benefit does it bring
> to include it in Geany?
In fact I think it has accumulated over something like 15 years - it was first
part of the tag manager (which is
@techee thanks for the explanation, can you explain more what is "cork" and
what it provides? This is more for understanding than directly relevant to the
You pointed out the concern, is there anything that is not needed in Geany,
thats in that code because ctags needs it (like for
[Apple Swift](https://swift.org/ "Official Website") is a new, but established
language, judging by the [activity](https://github.com/apple/swift/pulse
"GitHub Pulse") on its [GitHub repository](https://github.com/apple/swift
"Official Repository"). I believe that it deserves to be supported by
> @techee thanks for the explanation, can you explain more what is "cork" and
> what it provides? This is more for understanding than directly relevant to
> the PR.
The "cork" thing is something that helps constructing scope information by
referencing the parent tag. You write something like:
> Binary-size wise libgeany.so size looks this way:
I guess that's with default `-O2` and `-g` without stripping symbols?
Here's what I get with different options (always using `make install-strip`):
Master branch w/ '-O4': 2.8 MB
This branch w/
> I'm actually tempted to bundle the MSYS2 binary along with the necessary
The only "problem" I see that we would may be including two separate copies of
`libiconv`, `libpcre` and maybe `libintl` since GLib already embeds these.
IIRC, Glib build system has compile-time options to
@codebrainz Yeah, thanks, I didn't notice it was an order of magnitude bigger.
So it's something like 7% increase then.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
This can be reproduced when filename character is not supported by system
E.g. When system locale is "English (United States)", double clicking
`read我.txt` opens an empty tab in Geany with name `read?.txt`. The file is not
You are receiving this because
Mail list logo