Re: [Github-comments] [geany/geany] Add option to "Open files on read-only mode" (#1987)

2018-12-05 Thread Thomas Martitz
Closed #1987. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1987#event-2006736619

Re: [Github-comments] [geany/geany] Add option to "Open files on read-only mode" (#1987)

2018-12-05 Thread elextr
I guess I saw situations where defaulting to read-only would be useful, not just cats :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1987#issuecomment-00326

Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)

2018-12-05 Thread Benjamin Gaillard
bxgaillard commented on this pull request. > cell_renderer->mode = GTK_CELL_RENDERER_MODE_ACTIVATABLE; +#endif Fixed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)

2018-12-05 Thread Benjamin Gaillard
bxgaillard commented on this pull request. > - GdkPixbuf *GSEAL (pixbuf_enabled); - GdkPixbuf *GSEAL (pixbuf_disabled); - GdkPixbuf *GSEAL (pixbuf_conditional); - GdkPixbuf *GSEAL (pixbuf_file); + GdkPixbuf *pixbuf_enabled; + GdkPixbuf *pixbuf_disabled; + GdkPixbuf *pixbuf_conditional;

Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)

2018-12-05 Thread Benjamin Gaillard
bxgaillard commented on this pull request. > - GdkPixbuf *GSEAL (pixbuf_active); - GdkPixbuf *GSEAL (pixbuf_highlighted); + GdkPixbuf *pixbuf_active; + GdkPixbuf *pixbuf_highlighted; Same answer as above. -- You are receiving this because you are subscribed to this thread. Reply to

Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)

2018-12-05 Thread Benjamin Gaillard
bxgaillard commented on this pull request. > } g_list_free(modules); gtk_combo_box_set_active(GTK_COMBO_BOX(debugger_cmb), 0); /* arguments */ args_frame = gtk_frame_new(_("Command Line Arguments")); +#if GTK_CHECK_VERSION(3, 0, 0) + hbox =

Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)

2018-12-05 Thread Benjamin Gaillard
bxgaillard commented on this pull request. > @@ -279,8 +336,15 @@ static void tpage_create_widgets(void) /* environment */ env_frame = gtk_frame_new(_("Environment Variables")); +#if GTK_CHECK_VERSION(3, 0, 0) + hbox = gtk_scrolled_window_new( +

Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)

2018-12-05 Thread Benjamin Gaillard
bxgaillard commented on this pull request. > @@ -1048,12 +1068,24 @@ void debug_init(void) NULL); grantpt(pty_master); unlockpt(pty_master); +#if GTK_CHECK_VERSION(3, 0, 0) + pty = vte_pty_new_foreign_sync(pty_master, NULL, NULL); +

Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)

2018-12-05 Thread Benjamin Gaillard
Thank you @b4n for your review. I applied your proposals, squashed the commits and pushed it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/791#issuecomment-61148

Re: [Github-comments] [geany/geany] Add Scheme (*.scm) syntax highlighting to Geany (#982)

2018-12-05 Thread Skif-off
Maybe add ```filetypes.Scheme.conf``` to page [https://wiki.geany.org/config/start](https://wiki.geany.org/config/start)? [filetypes.Scheme.conf](https://pastebin.com/1jDKBjZ5) and ```filetype_extensions.conf```: ```ini [Extensions] ... Scheme=*.scm;*.ss; ... [Groups] ... Script=Scheme; ```

Re: [Github-comments] [geany/geany] Update da.po to 1.34 (#2006)

2018-12-05 Thread Frank Lanitz
Merged #2006 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2006#event-2007535085

Re: [Github-comments] [geany/geany] Sync ctags main part (#1263)

2018-12-05 Thread elextr
As this has gone nowhere in two years, available resources are less than back then, and is holding up other ctags related stuff, I suggest it be rejected in its current form. Instead a progressive approach should be developed to re-arrange the directories to match ctags (using git-mv so as not

Re: [Github-comments] [geany/geany-plugins] cannot install markdown plugin (#792)

2018-12-05 Thread burnlawson
@elextr I wasn't able to install libwebkitgtk2. I installed libwebkitgtk-1.0 via apt-get but couldn't do the same with v2, downloaded the tar.gz but the build commands were not working so I'm giving up on this mission. -- You are receiving this because you are subscribed to this thread. Reply

Re: [Github-comments] [geany/geany] Add translations for Windows installer (NSIS) (#2008)

2018-12-05 Thread Enrico Tröger
Basically yes. IIRC we discussed this a couple of years ago and abandoned the idea. My concerns: - more overhead in maintaining Windows builds (none of the Geany developers actively use Windows) - more work for the translators for a rather small target user group - the installer is pretty basic

[Github-comments] [geany/geany] Update of Traditional Chinese translation (#2009)

2018-12-05 Thread 張修銘
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/2009 -- Commit Summary -- * Update of Traditional Chinese translation -- File Changes -- M po/zh_TW.po (29) -- Patch Links -- https://github.com/geany/geany/pull/2009.patch

Re: [Github-comments] [geany/geany] Sync ctags main part (#1263)

2018-12-05 Thread Colomban Wendling
@elextr for example all the Python parser issues would be fixed by using the UCTags parser, but it relies on quite a few features we don't currently have. And maintaining a version that don't use those would create a difference gap again, with all the maintenance effort that go with it. --

Re: [Github-comments] [geany/geany] Sync ctags main part (#1263)

2018-12-05 Thread elextr
@b4n Well, I didn't get a sense that you were making progress, will hassle you immediately after 1.34 release so it can be committed ASAP to allow for some time to mature before 1.35. [PS am only accepting it so I can have the new C++ added after the infrastructure is fixed :grin: ] -- You

Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)

2018-12-05 Thread Colomban Wendling
b4n commented on this pull request. > } g_list_free(modules); gtk_combo_box_set_active(GTK_COMBO_BOX(debugger_cmb), 0); /* arguments */ args_frame = gtk_frame_new(_("Command Line Arguments")); +#if GTK_CHECK_VERSION(3, 0, 0) + hbox =

Re: [Github-comments] [geany/geany-plugins] 'Debugger' plugin port to GTK3 with GTK2 compatibility (#791)

2018-12-05 Thread Colomban Wendling
b4n commented on this pull request. > @@ -1048,12 +1068,24 @@ void debug_init(void) NULL); grantpt(pty_master); unlockpt(pty_master); +#if GTK_CHECK_VERSION(3, 0, 0) + pty = vte_pty_new_foreign_sync(pty_master, NULL, NULL); +