Hi @andy5995,
The problem you mention is with utilslib, which is part of geany-plugins and
now used by the debugger plugin (it contains some compatibility functions). Did
you activate it at configure time? It may need some other dependencies besides
libvte.
--
You are receiving this because
This is a PR waiting to be approved/merged regarding this issue: #791.
You can use that if you need the plugin.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
An IDE without a debugger, blocked in this state for the lifetime of the next
stable Debian release, that would be very sad.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
bxgaillard commented on this pull request.
> cell_renderer->mode = GTK_CELL_RENDERER_MODE_ACTIVATABLE;
+#endif
Fixed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
bxgaillard commented on this pull request.
>
- GdkPixbuf *GSEAL (pixbuf_enabled);
- GdkPixbuf *GSEAL (pixbuf_disabled);
- GdkPixbuf *GSEAL (pixbuf_conditional);
- GdkPixbuf *GSEAL (pixbuf_file);
+ GdkPixbuf *pixbuf_enabled;
+ GdkPixbuf *pixbuf_disabled;
+ GdkPixbuf *pixbuf_conditional;
bxgaillard commented on this pull request.
>
- GdkPixbuf *GSEAL (pixbuf_active);
- GdkPixbuf *GSEAL (pixbuf_highlighted);
+ GdkPixbuf *pixbuf_active;
+ GdkPixbuf *pixbuf_highlighted;
Same answer as above.
--
You are receiving this because you are subscribed to this thread.
Reply to
bxgaillard commented on this pull request.
> }
g_list_free(modules);
gtk_combo_box_set_active(GTK_COMBO_BOX(debugger_cmb), 0);
/* arguments */
args_frame = gtk_frame_new(_("Command Line Arguments"));
+#if GTK_CHECK_VERSION(3, 0, 0)
+ hbox =
bxgaillard commented on this pull request.
> @@ -279,8 +336,15 @@ static void tpage_create_widgets(void)
/* environment */
env_frame = gtk_frame_new(_("Environment Variables"));
+#if GTK_CHECK_VERSION(3, 0, 0)
+ hbox = gtk_scrolled_window_new(
+
bxgaillard commented on this pull request.
> @@ -1048,12 +1068,24 @@ void debug_init(void)
NULL);
grantpt(pty_master);
unlockpt(pty_master);
+#if GTK_CHECK_VERSION(3, 0, 0)
+ pty = vte_pty_new_foreign_sync(pty_master, NULL, NULL);
+
Thank you @b4n for your review. I applied your proposals, squashed the commits
and pushed it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/791#issuecomment-61148
bxgaillard commented on this pull request.
> }
g_list_free(modules);
gtk_combo_box_set_active(GTK_COMBO_BOX(debugger_cmb), 0);
/* arguments */
args_frame = gtk_frame_new(_("Command Line Arguments"));
+#if GTK_CHECK_VERSION(3, 0, 0)
+ hbox =
Yes I'm aware, buy I somehow managed to completely break my forked repository,
and it was then a mess to sort out, with tons of changes from the master
branch... Sorry for the inconvenience.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
This pull request is heavily based on #645 from which it borrows the majority
of the changes.
The main improvement is that this one doesn't break compatibility with GTK2
(there are macros which select the correct code path accordingly).
I also removed some cosmetic-only changes to maintain the
FYI I created a new pull request that doesn't break compatibility with GTK2:
#790.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/645#issuecomment-440274221
Closed #790.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/790#event-1977808005
This pull request is heavily based on #645 from which it borrows the majority
of the changes.
The main improvement is that this one doesn't break compatibility with GTK2
(there are macros which select the correct code path accordingly).
I also removed some cosmetic-only changes to maintain the
bxgaillard commented on this pull request.
> @@ -458,21 +493,36 @@ void config_init(void)
g_free(data);
}
+#if GTK_CHECK_VERSION(3, 0, 0)
+ g_mutex_init(_config_mutex);
+ g_cond_init();
+ saving_thread = g_thread_new(NULL, saving_thread_func, NULL);
bxgaillard commented on this pull request.
> @@ -320,7 +324,11 @@ static void on_watch_dragged_callback(GtkWidget *wgt,
> GdkDragContext *context, i
gpointer userdata)
{
/* string that is dragged */
+#if GTK_CHECK_VERSION(3, 0, 0)
+ gchar *expression =
bxgaillard commented on this pull request.
> @@ -308,11 +318,20 @@ static gpointer saving_thread_func(gpointer data)
debug_config_changed = FALSE;
}
+#if GTK_CHECK_VERSION(3, 0, 0)
+ interval = g_get_monotonic_time() + SAVING_INTERVAL;
bxgaillard commented on this pull request.
> @@ -136,21 +152,37 @@ static void
> cell_renderer_frame_icon_get_size(GtkCellRenderer *cell, GtkWidget *
pixbuf_height = MAX (pixbuf_height, gdk_pixbuf_get_height
(cellframe->pixbuf_highlighted));
}
+#if
bxgaillard commented on this pull request.
> @@ -82,17 +82,28 @@ static void on_execute_until(GtkButton *button, gpointer
> user_data)
*/
GtkWidget* btnpanel_create(on_toggle cb)
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+ GtkWidget *vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL,
bxgaillard commented on this pull request.
> @@ -269,8 +274,13 @@ static void save_to_keyfile(GKeyFile *keyfile)
*/
static gpointer saving_thread_func(gpointer data)
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+ gint64 interval;
+ g_mutex_lock(_config_mutex);
+#else
I agree. I replaced
bxgaillard commented on this pull request.
> @@ -287,8 +288,13 @@ void dpaned_init(void)
/* setup notebooks */
gtk_notebook_set_scrollable(GTK_NOTEBOOK(debug_notebook_left), TRUE);
gtk_notebook_set_scrollable(GTK_NOTEBOOK(debug_notebook_right), TRUE);
+#if
bxgaillard commented on this pull request.
> @@ -1066,7 +1105,13 @@ void debug_init(void)
configfile = g_strconcat(geany_data->app->configdir, G_DIR_SEPARATOR_S,
"geany.conf", NULL);
g_key_file_load_from_file(config, configfile, G_KEY_FILE_NONE, NULL);
font =
bxgaillard commented on this pull request.
> @@ -197,7 +197,11 @@ static void on_render_line(GtkTreeViewColumn
> *tree_column, GtkCellRenderer *cell
g_object_set(cell, "text", "", NULL);
else
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+ GValue value =
bxgaillard commented on this pull request.
>
cell_renderer_break_icon_get_size (cell, widget, cell_area,
_rect.x,
_rect.y,
_rect.width,
_rect.height);
+#if GTK_CHECK_VERSION(3, 0, 0)
+
@bxgaillard pushed 1 commit.
5eec7fd Factorize some code between GTK2 and GTK3.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
bxgaillard commented on this pull request.
> calc_width = (gint) cell->xpad * 2 + pixbuf_width;
calc_height = (gint) cell->ypad * 2 + pixbuf_height;
+#endif
I agree. Fixed.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or
bxgaillard commented on this pull request.
>
cell_renderer_frame_icon_get_size (cell, widget, cell_area,
_rect.x,
_rect.y,
_rect.width,
_rect.height);
+#if GTK_CHECK_VERSION(3, 0, 0)
+
bxgaillard commented on this pull request.
> @@ -67,8 +67,13 @@ static GKeyFile *keyfile_project = NULL;
static gboolean debug_config_loading = FALSE;
/* saving thread staff */
+#if GTK_CHECK_VERSION(3, 0, 0)
+static GMutex change_config_mutex;
+static GCond cond;
+#else
I agree. I
bxgaillard commented on this pull request.
> gtk_box_pack_start(GTK_BOX(root), hbox, FALSE, FALSE, 0);
gtk_box_pack_start(GTK_BOX(hbox), target_label, FALSE, FALSE,
0);
gtk_box_pack_start(GTK_BOX(hbox), target_name, TRUE, TRUE, 0);
bxgaillard commented on this pull request.
> }
+#if GTK_CHECK_VERSION(3, 0, 0)
+ while (!g_cond_wait_until(, _config_mutex, interval));
+ g_mutex_unlock(_config_mutex);
Fixed: the old code has been replaced with the new one.
--
You are receiving this because you are
bxgaillard commented on this pull request.
> modules = debug_get_modules();
for (iter = modules; iter; iter = iter->next)
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+
gtk_combo_box_text_append_text(GTK_COMBO_BOX_TEXT(debugger_cmb),
(gchar*)iter->data);
I agree.
bxgaillard commented on this pull request.
> @@ -366,7 +442,11 @@ int tpage_get_debug_module_index(void)
*/
gchar* tpage_get_debugger(void)
{
+#if GTK_CHECK_VERSION(3, 0, 0)
+ return
gtk_combo_box_text_get_active_text(GTK_COMBO_BOX_TEXT(debugger_cmb));
I agree. Fixed.
--
You are
Thank you @LarsGit223 for the thorough PR review! I'm not a GTK+ expert at all,
that's why I didn'y dive in the documentation and just applied the changes from
#645 with preprocessing conditionals. As indicated in my replies I've applied
your suggestions and pushed a new commit which should be
bxgaillard commented on this pull request.
> gtk_widget_set_size_request(target_button_browse, BROWSE_BUTTON_WIDTH,
> 0);
g_signal_connect(G_OBJECT(target_button_browse), "clicked", G_CALLBACK
(on_target_browse_clicked), NULL);
/* debugger */
debugger_label =
> Therefore thanks for putting time in it even though it wasn't your PR
> originally :+1:
My pleasure.
> Once the others agree to merge it, the only thing left to do would be to
> squash the commits into one.
Done.
--
You are receiving this because you are subscribed to this thread.
Reply
I've looked into it and from what I can tell this is normal behaviour.
The main Geany GUI uses GtkPaneds for side panels (document browser, symbols,
messages...), including the bottom one. When such a panel is too small to
display its contents, the latter is located in hidden overflow.
This
> @bxgaillard have you tried setting sizes and resize and shrink and stuff from
> CSS, setting minimum sizes in apps is not very portable.
I have made some research and CSS seems not to be appropriate for setting
dimensions. On the other hand the correct way to fix it seems to be the Glade
39 matches
Mail list logo
