[Github-comments] [geany/geany] Typo in german translation (#1219)

2016-09-09 Thread Heihon
Geany 1.28 Release (Windows and Linux) and also Geany 1.29 "Jowar" (Windows) "Document/Set Lineend/Set to CR/LF and convert" is in german translation "Dokument/Zeilenenden festlegen/Auf CR/LF setzen und umwandeln (Winows)" should be "Dokument/Zeilenenden festlegen/Auf CR/LF setzen und umwandeln (

[Github-comments] [geany/geany] Small inconsistency with property files (*.ini) (#1220)

2016-09-09 Thread Heihon
Geany 1.28 Release (Windows and Linux) and Geany 1.29 and I think also Geany 1.27 and before Lines that start with ';' are syntax highlighted as comment. Lines that start with '#' are syntax highlighted as comment. An entry "key=value" in a line starting with ';' is shown in the symbols list. An

[Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-09 Thread Heihon
Geany 1.29 "Jowar" compiled 2016-07-16 / Windows 7-64 Bit and also Geany 1.29 "Jowar" compiled 2016-09-08 / Windows 7-64 Bit If you select -> Lineend will be Set to CR -> 0x0d Set to LF -> 0x0d 0x0a Set to CR/LF-> 0x0d 0x0d 0x0a Except with "Set to CR" there is an additional 0x0

Re: [Github-comments] [geany/geany] Typo in german translation (#1219)

2016-09-13 Thread Heihon
Sorry for the noise. I did search in Issues but didn't search in Pull requests. I am not at all familiar with the Geany Nightly build process, but I assumed that merged Pull requests in branch master should be reflected in the Geany Nightly Build. I saw the fixed file po/de.po in branch master, b

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-13 Thread Heihon
Closed #1218. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1218#event-787546868

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-13 Thread Heihon
Additional information: With Geany 1.28 Release for all three file types as attached above the status bar shows the mode correctly (mode:CR / mode:CRLF / mode:LF). With Geany 1.29 Nightly the status bar shows mode:LF for test_crlf.txt. (Still Windows 7-64). -- You are receiving this because yo

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-13 Thread Heihon
Reopened #1218. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1218#event-787547065

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-13 Thread Heihon
Sorry, I closed by mistake. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1218#issuecomment-246682506

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-14 Thread Heihon
I tested with the latest nightly Geany 1.29 "Jowar" (kompiliert am 2016-09-12 oder später) I saw a lot of changes in read.c since 1.28. Perhaps the input file is not opened in "binary mode" under windows any more. AFAIK only windows has this binary mode, so this wouldn't happen under linux. --

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-14 Thread Heihon
...and with view/show line endings it shows only LF for the file with CRLF as line ending. ![geany_test_crlf](https://cloud.githubusercontent.com/assets/22057148/18514288/486c78ca-7a91-11e6-9a9a-ff383d9f5289.png) -- You are receiving this because you are subscribed to this thread. Reply to thi

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-14 Thread Heihon
It is still the file test_crlf.txt I attached above. ![hexeditor_test_crlf](https://cloud.githubusercontent.com/assets/22057148/18515188/c6df05da-7a94-11e6-95c5-a4ca0559a81c.jpg) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHu

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-14 Thread Heihon
AFAIK if you don't `fopen` with explicitely specifying binary mode, then windows will not `fread` all characters of the input file into your buffer. When the input file is not opened in binary mode, windows will modify the line endings (CRLF -> LF) and eat other characters too (I think 0x00 and

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-14 Thread Heihon
A quick search returned: fopen: [(https://msdn.microsoft.com/en-us/library/yeby3zcb.aspx)] text vs binary mode: [(https://msdn.microsoft.com/en-us/library/ktss1a9b.aspx)] fread (see section Remarks): [(https://msdn.microsoft.com/en-us/library/kt0etdcs.aspx)] Geany debug messages: 16:25:55: Geany

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-14 Thread Heihon
I did and the result is still the same. BTW if the setting for file saving changes how geany reads files then this would IMHO be an error. When geany inspects the input file buffer to find out, what kind of line ending was mostly used in the input file (your code snippet `utils_get_line_endings`

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-14 Thread Heihon
Geany 1.28 debug messages: 17:29:16: Geany INFO: Geany 1.28, German_Germany.1252 17:29:16: Geany INFO: GTK 2.24.28, GLib 2.48.1 17:29:16: Geany INFO: System data dir: D:\Programme\Geany\data 17:29:16: Geany INFO: User config dir: C:\Users\honrathxp\A

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-14 Thread Heihon
And also with atomic off: ![geany_1 28_test_crlf_atomic_off](https://cloud.githubusercontent.com/assets/22057148/18518910/21070528-7aa2-11e6-82f4-7676d3459543.jpg) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://git

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-15 Thread Heihon
Yes, I tried 1.29 from the nightly builds. There are some other small problems with the nightlies (under windows): a) the german translation is not included as of github master (I reported an issue #1219 which as I found out later has already been fixed in master but is still wrong in the nightly

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-16 Thread Heihon
> Regarding the original issue: I will try to create a new build soon of > current master natively compiled on Windows. It would be great if you could > test it then. Will test when I see a new nightly. > a) this is expected as the translation files are not included in the nightly > build ZIP

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-19 Thread Heihon
> http://download.geany.org/snapshots/geany-1.29nightly20160918_setup.exe Wow, I installed this and all problems are gone. All three types of lineends are shown and converted properly (with and without use_atomic_file_saving). No more "Error loading icon". No missing icon in the about box. And wi

Re: [Github-comments] [geany/geany] Error in "Document/Set Lineend/Set to xx and convert" (#1218)

2016-09-19 Thread Heihon
And the bundle with all plugins > http://download.geany.org/snapshots/geany-plugins-1.29nightly20160918_setup.exe works as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1218#iss