Fix cursor hang when we want to move cursor on top line and this line is folded
To reproduce the problem, when vimode plugin is enabled:
Fold a few lines by clicking the minus icon.
Move the cursor to the bottom of these lines and try to move back to the top.
The cursor doesnt go back and seem to
Closed #1326.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1326#event-12472026207
You are receiving this because you are subscribed to this thread.
Message ID:
Supported commands are:
za / zo / zc toggle / open / close fold on one level of folding
zA / zO / zCtoggle / open / close fold on all folding levels
zR / zM open / close all folds
You can view, comment on, or merge this pull request online at:
Trying to get more Vim-like behavior for cursor position after using undo (U
key)
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany-plugins/pull/1328
-- Commit Summary --
* fix cursor position after using undo (u key)
-- File Changes --
M
Reopened #1326.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1326#event-12486535931
You are receiving this because you are subscribed to this thread.
Message ID:
IncDec is a plugin for Geany that provides shortcuts to increment an decrement
number at the cursor, or to the right of the cursor (on the same line).
By default, typing Shift-+ will increment the next number, and typing Shift--
will decrement the next number.
You can also increment and
@scresto09 pushed 1 commit.
7615fdcdeae24739d65ddf42554fcaf48a380d82 Update README and geany-plugins.nsi
files
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1337/files/1a06f6b2c2336da69fbfa1a035d6f4640cfd6f4f..7615fdcdeae24739d65ddf42554fcaf48a380d82
You are receiving this
Sure, here's an example:
Open a 5 line file
Move the cursor to line 2
press "2dd" to delete 2 lines
press "u" to cancel
With a real VIM, the cursor stays on line 2
With Geany Vimode not patched, the cursor goes to the last line
--
Reply to this email directly or view it on GitHub:
@scresto09 pushed 1 commit.
327cdde2d506400ad6e05342c0d6095e9c254e0e use SC_MOD_BEFOREINSERT and
SC_PERFORMED_UNDO events to track cursor position to restore after undo
--
View it on GitHub:
You're right, my previous correction was not correct.
[327cdde](https://github.com/geany/geany-plugins/pull/1328/commits/327cdde2d506400ad6e05342c0d6095e9c254e0e)
is a new fix using the SC_MOD_BEFOREINSERT and SC_PERFORMED_UNDO events to
save the cursor position.
--
Reply to this email
@scresto09 commented on this pull request.
> /* Calling SCI_LINEUP/SCI_LINEDOWN in a loop for num lines leads to
> visible
* slow scrolling. On the other hand, SCI_LINEUP preserves the value of
* SCI_CHOOSECARETX which we cannot read directly from Scintilla and
which
@scresto09 pushed 1 commit.
274ff97f51e65b02ae86579768ec8d41f5b5c611 try to fix some issues of the plugin
with folded lines
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1326/files/5608b74cba25b571428da9a055e696ddb053a247..274ff97f51e65b02ae86579768ec8d41f5b5c611
You are
Hello,
After read the
[https://sourceforge.net/p/scintilla/bugs/2438/](https://sourceforge.net/p/scintilla/bugs/2438/)
report, I think the best way to automatically set the cursor position on the
visible line is surely to track the SCN_MARGINCLICK event.
I did some modification to handle this
It seems there are some issues with the changes in commit
[907b9bc](https://github.com/geany/geany-plugins/pull/1338/commits/907b9bc9830e601119e1d9df9d39848c3f697932),
for example the cursor can no longer go up to the first line, or when some
lines wrap.
I've made some changes to try and fix
@scresto09 commented on this pull request.
> return;
- /* see cmd_goto_up() for explanation */
- one_above = p->line + num - 1;
- one_above = one_above < last_line ? one_above : last_line - 1;
- pos = SSM(p->sci, SCI_GETLINEENDPOSITION, one_above, 0);
-
@scresto09 pushed 1 commit.
5608b74cba25b571428da9a055e696ddb053a247 Automatically set the cursor position
on the visible line
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1326/files/be15445fa3fd4893f04945af6af94522db2e5e99..5608b74cba25b571428da9a055e696ddb053a247
You
In response to pull request
[#1338](https://github.com/geany/geany-plugins/pull/1338)
After read the
[https://sourceforge.net/p/scintilla/bugs/2438/](https://sourceforge.net/p/scintilla/bugs/2438/)
report, I think the best way to automatically set the cursor position on the
visible line is
@scresto09 pushed 1 commit.
2b99b719de64166b3833280a5ba0c1fdf00c6a4c used goto_nonempty to go to the first
non-white character and some more changes
--
View it on GitHub:
@scresto09 commented on this pull request.
> @@ -162,14 +163,14 @@ void cmd_del_word_left(CmdContext *c, CmdParams *p)
void cmd_undo(CmdContext *c, CmdParams *p)
{
gint i;
- gint pos = SSM(p->sci, SCI_GETCURRENTPOS, 0, 0);
+ start_undo(c);
for (i = 0; i < p->num;
@scresto09 pushed 1 commit.
1be4e6adeb28c19ac35c9a9682d21c35f08532f3 added two empty lines
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1328/files/2b99b719de64166b3833280a5ba0c1fdf00c6a4c..1be4e6adeb28c19ac35c9a9682d21c35f08532f3
You are receiving this because you are
20 matches
Mail list logo