Re: [Github-comments] [geany/geany] HTML comments inserted in PHP files (#1758)

2018-02-02 Thread elextr 
@b4n thanks, I don't know any PHP so just tried to add comments to an empty PHP 
file and got HTML ones and said "Oh!! the OP on the ML is right".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1758#issuecomment-362738639

Re: [Github-comments] [geany/geany] HTML comments inserted in PHP files (#1758)

2018-02-02 Thread Colomban Wendling 
Agreed with @codebrainz it's not very clear, but I guess I got it:

When *filetypes.php* has an empty `comment_single`, it uses HTML comments 
(``) instead of multi-line PHP comments (`/* */`) for some reason.
To test:

1. Open Geany with a stock configuration (`geany -c /tmp/temp-config`)
2. Create a new PHP file from template
3. Insert a non-empty line in the PHP section (e.g. `echo "hello!";` on line 24)
 1. Try and comment line 24 with Ctrl+E: it inserts `//~ ` at 
the start of the line.  Good!  Try and the same on line 31: it inserts ``.  Good again!  Toggle both back to not commented.
4. Open *filetypes.php* (*Tools → Configuration files → Filetype configuration 
files → Scripting languages → filetypes.php*)
5. Change the value of `comment_single` to make it empty.  Save it.
6. Try commenting line 24: it inserts ``  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1758#issuecomment-362671288

Re: [Github-comments] [geany/geany] HTML comments inserted in PHP files (#1758)

2018-02-02 Thread Matthew Brush 
More information please.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1758#issuecomment-362619370

[Github-comments] [geany/geany] HTML comments inserted in PHP files (#1758)

2018-02-02 Thread elextr 
Reported on the ML.  Possibly due to 
[this](https://github.com/geany/geany/blob/16020ddc6cd32a3aa121b89edc8aeb6a45e78775/src/editor.c#L2815)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1758