Re: [Github-comments] [geany/geany] keyfile: Output unescaped filename if session file cannot be opened (#1803)
@J-Dunn: no, this PR only fixes the issue which #779 directly addresses. As @elextr wrote the path encoding in the config file is correct. It only would be a bug if you see such enocidng in an output. @elextr: no, only purely changed what PR #779 addresses and won't do anything else in this PR. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1803#issuecomment-372915393
Re: [Github-comments] [geany/geany] keyfile: Output unescaped filename if session file cannot be opened (#1803)
Well, except that I actually meant to say "escaped" not "encoded" on #779 no it only addresses the output to the screen/terminal, as I said, the stored filenames are __intended__ to be escaped so they do not contain characters that cause problems for keyfiles when they are part of a list of items. In the [project] section paths are by themselves in an entry and so in practice they probably don't actually need escaping. Which is why I only said technically all filenames should be escaped, it allows them to contain any Unicode character without caring what the encoding is. But since nobody seems to be doing that, its not broke, so don't fix it :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1803#issuecomment-372911406
Re: [Github-comments] [geany/geany] keyfile: Output unescaped filename if session file cannot be opened (#1803)
Does this address the secondary issue I raise here? https://github.com/geany/geany/issues/779#issuecomment-161904655 to which elextra replied: > "Technically all other filenames in config files probably should be encoded, > but thats another issue." -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1803#issuecomment-372908929
Re: [Github-comments] [geany/geany] keyfile: Output unescaped filename if session file cannot be opened (#1803)
Closed #1803. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1803#event-1519989515
Re: [Github-comments] [geany/geany] keyfile: Output unescaped filename if session file cannot be opened (#1803)
Closed in 7fd73a06a7aab8582af36891f7b2a19dbe08188b -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1803#issuecomment-372879025
Re: [Github-comments] [geany/geany] keyfile: Output unescaped filename if session file cannot be opened (#1803)
LGBI -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1803#issuecomment-372828352
[Github-comments] [geany/geany] keyfile: Output unescaped filename if session file cannot be opened (#1803)
Fixes #779. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/1803 -- Commit Summary -- * keyfile: Output unescaped filename if session file cannot be opened -- File Changes -- M src/keyfile.c (2) -- Patch Links -- https://github.com/geany/geany/pull/1803.patch https://github.com/geany/geany/pull/1803.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1803
