Re: [Github-comments] [geany/geany] Better highlighting for YAML keys (#1838)
@FMuro sorry for the delay simply missed your comment above, just ping if you don't get responses in a few weeks and you are still interested, there is such a thing as being _too_ patient waiting 6 months :grin: What I meant (and I presume @b4n meant) by "does the wrong thing" is that it mixes semantics by using "type" for "identifiers". The "proper" fix is for the Scintilla lexer to style keys as something else than "identifier", and the notebook++ lexer offered on the Scintilla issue from #1853 seems to do that, adding a new "key" semantic. But AFAICT that new lexer hasn't happened yet. On the other hand YAML does not have the concept of "type" so if it suits YAML users I guess it can't hurt to use "type" highlighting for "identifiers" which means keys IIUC. @b4n any comment, or will merge in a week or two. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1838#issuecomment-787608950
Re: [Github-comments] [geany/geany] Better highlighting for YAML keys (#1838)
It doesn't do the wrong thing. That complain was fixed and there hasn't been more complains. As two people, apart from myself, have already said, this patch could be merged and it would be an improvement. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1838#issuecomment-651614447
Re: [Github-comments] [geany/geany] Better highlighting for YAML keys (#1838)
As @b4n said, this actually does the wrong thing, it would be better to wait for #1853 to do the right thing. Note nothing stops you changing it in you own copy in the meantime, `Menu->Tools->Configuration files->Filetype Configuration->Miscellaneous->filetypes.yaml` will open the file, you make the one line change and save and it will be saved to your user configuration. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1838#issuecomment-651474422
Re: [Github-comments] [geany/geany] Better highlighting for YAML keys (#1838)
Hi! Will be this PR merged..??? 21st century in the yard, but Geany can't highlight YAML... :neutral_face:  My version is from Ubuntu's repo: 1.32 (built on or after 2018-08-01) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1838#issuecomment-651119625
Re: [Github-comments] [geany/geany] Better highlighting for YAML keys (#1838)
https://github.com/geany/geany/issues/1853 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1838#issuecomment-578437114
Re: [Github-comments] [geany/geany] Better highlighting for YAML keys (#1838)
https://github.com/geany/geany/issues/1853 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1838#issuecomment-576039384
Re: [Github-comments] [geany/geany] Better highlighting for YAML keys (#1838)
I guess waiting for the dissenter (@b4n) to look at it and see if they are happy with it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1838#issuecomment-475395202
Re: [Github-comments] [geany/geany] Better highlighting for YAML keys (#1838)
@FMuro pushed 1 commit. f9f9cda highlighting keys -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/1838/files/dfdde7c5a645c2928bb6bcf279175eed05f344fe..f9f9cda37977cf497c1505298bc0ba4ac897be3b
Re: [Github-comments] [geany/geany] Better highlighting for YAML keys (#1838)
> Should I close this and submit a new pull request with these two > modifications? Just add the changes to this PR please. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1838#issuecomment-383601200
Re: [Github-comments] [geany/geany] Better highlighting for YAML keys (#1838)
Ha! I didn't notice identifier in line 6, sorry. `type` works well, the other two options look worse in my opinion, but at least they would also be different from plain text. Should I close this and submit a new pull request with these two modifications? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1838#issuecomment-383500889
Re: [Github-comments] [geany/geany] Better highlighting for YAML keys (#1838)
I'm not sure I like it, because it seems to remove some semantics of the styles. Also, it'd style keywords (true, false, …) the same way now. I agree that the fact most color schemes style identifiers the same as "no style" is sad in the case of YAML, but I'm not sure this is the best solution. Would `type`, `function` or `label` work better? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1838#issuecomment-383414489
Re: [Github-comments] [geany/geany] Better highlighting for YAML keys (#1838)
b4n commented on this pull request. > @@ -11,6 +11,7 @@ document=preprocessor text=string_1 error=error operator=operator +identifier=keyword You should *replace* the existing value (L6), not add a new one to override it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1838#pullrequestreview-114215737
