Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2019-09-23 Thread Nick Treleaven
> Trouble is no symbol is an obvious "this is overridden" especially that new 
> users will understand automatically,

I've started working on a pull that puts an info icon next to the frame label 
with a tooltip, as well as disabling overridden pref widgets.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-534063065

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-05-30 Thread elextr
> The last change adds the text (using project settings) after the Saving Files 
> title if a project is open.

> In my opinion it makes it much more obvious why the settings are disabled

So obvious I missed it :wink:


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-393059846

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-05-30 Thread shiftee
The last change adds the text **(using project settings)** after the **Saving 
Files** title if a project is open.

In my opinion it makes it much more obvious why the settings are disabled

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-393054414

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-05-29 Thread elextr
@shiftee not sure what your last change did looking at the image? And if you 
need a Glade-spurt to comment, thats not me, anybody else?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-392954897

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-05-29 Thread Stefano
Any news on this? I think @shiftee changes would be really a helpful 
enhancement! :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-392926459

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-02-21 Thread shiftee
Small reminder about this

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-367313722

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-02-17 Thread shiftee
I've pushed a change which updates the frame-label instead of the tooltip.
I'm not very experienced with Glade so it may not be done the best way.

Thoughts?

![disabled](https://user-images.githubusercontent.com/1383407/36343749-190792f6-1408-11e8-8d3f-b54cdb329de4.png)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-366457225

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-02-17 Thread shiftee
@shiftee pushed 1 commit.

dfd5dea  Modify frame label to explain why it is disabled


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1750/files/4cfd91391869fde7034adc907f5a8b40b4b3181e..dfd5dea93b6ecee1ec7e4be1395248d74544a879


Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-02-02 Thread elextr
> appending a note like "this setting might be overridden by open projects" or 
> something like this.
I guess users know when they have a project opened.

Yeah, thats easier, but the tooltip doesn't show unless the user hovers for a 
period, so the insensitive is important too.

> Another solution could be to show some sort of symbol, like warning sign or 
> the like, 

Trouble is no symbol is an obvious "this is overridden" especially that new 
users will understand automatically, and its new users who need the warning the 
most.  Thats why setting insensitive is useful, it makes the user stop and 
think for a moment :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-362541635

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-02-02 Thread Enrico Tröger
I like the approach to tell the user that some global settings will be 
overridden by projects to reduce confusion.

When changing tooltips, it might be easier to change the original tooltips in 
the Glade file by simply appending a note like "this setting might be 
overridden by open projects" or something like this.
I guess users know when they have a project opened.

Another solution could be to show some sort of symbol, like warning sign or the 
like, next to those settings which can be overridden by projects in the 
preferences dialog. Those symbols could then have a generic tooltip.

Changing tooltips of all settings which can be overridden is probably a tedious 
work and might make the code less readable for little effect.


Just my 2cents.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-362538574

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-01-26 Thread elextr
> The individual setting tooltips are set in the glade file
so if I change them in the c code then I don't know if they can be reset to the 
default

They can be 
[read](https://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-get-tooltip-text),
 so they could be saved to be restored later

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-360781860

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-01-26 Thread shiftee
The individual setting tooltips are set in the glade file
so if I change them in the c code then I don't know if they can be reset to the 
default

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-360779710

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-01-26 Thread elextr
> Unfortunately it doesn't.

Sad

> I'm not very experienced with GTK, do you know if it's possible to make it do 
> that?

Don't know either (other than brute force of changing all the tooltips to the 
same thing), lets see what the experts say.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-360779173

Re: [Github-comments] [geany/geany] Disable Prefs/Files/Saving-files if project open (#1750)

2018-01-26 Thread shiftee
Unfortunately it doesn't.

I'm not very experienced with GTK, do you know if it's possible to make it do 
that?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1750#issuecomment-360778563