Re: [Github-comments] [geany/geany] Find in Files not search in symlink folders (#1364)

2017-01-16 Thread Mikhail
Linux version protected too from infinite loop

![screenshot from 2017-01-17 
01-23-11](https://cloud.githubusercontent.com/assets/200750/21997934/d0845808-dc53-11e6-82a3-10085a80e066.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1364#issuecomment-272955019

Re: [Github-comments] [geany/geany] Find in Files not search in symlink folders (#1364)

2017-01-15 Thread Mikhail
> There is some doubt if grep can stop itself from going into an infinite loop 
> if the symlinks make a cycle on windows. If it turned out to be safe then 
> pull request could be accepted.

Don't worry grep can stop itself

![16 01 2017 
11-55-48-338](https://cloud.githubusercontent.com/assets/200750/21973496/f08b56b8-dbe2-11e6-85ef-1e2e325af87f.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1364#issuecomment-272787026

Re: [Github-comments] [geany/geany] Find in Files not search in symlink folders (#1364)

2017-01-13 Thread elextr
There is some doubt if grep can stop itself from going into an infinite loop if 
the symlinks make a cycle on windows. If it turned out to be safe then pull 
request could be accepted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1364#issuecomment-272436402

Re: [Github-comments] [geany/geany] Find in Files not search in symlink folders (#1364)

2017-01-13 Thread Mikhail
Thanks, `-R` option solves this problem. So you can add additional option for 
search in symlink or use `-R` option by default.

![13 01 2017 
17-37-23-620](https://cloud.githubusercontent.com/assets/200750/21930318/38d4211c-d9b7-11e6-98ee-1f82eba1e1e1.png)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1364#issuecomment-272434861

Re: [Github-comments] [geany/geany] Find in Files not search in symlink folders (#1364)

2017-01-13 Thread elextr
Find in files runs the `grep` program.  If you select the `recursive` option 
the `-r` option is passed to grep.  The `-r` option does not follow symlinks 
(on Linux or Windows).  On Linux the `-R` option follows symlinks, and I 
presume it does on windows too.  So set the `recursive` option off (to remove 
the `-r` ) and add `-R` to the `extra options` and see if it works.  If it 
doesn't work check that your copy of grep works in the command line with that 
option.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/1364#issuecomment-272430522