Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2020-12-28 Thread Matthew Brush
This was finally fixed in master by 9f5b430458192388a7bf611943fc61b2a8b44246. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/758#issuecomment-751855942

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2020-12-28 Thread Matthew Brush
Closed #758. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/758#event-4153011522

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2019-03-20 Thread Mike MGarcia
ridiculous! uninstalled -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/758#issuecomment-474782221

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2019-01-29 Thread Haburaku
Using the fix from kenshail I got it working on my local copy as well, thanks! Reading through PR #588 (in which the update function of the search box is already mentioned) I decided not to go through the steps of making a new PR. -- You are receiving this because you are subscribed to this thr

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2019-01-26 Thread kenshail
No offence taken whatsover. I has assumed that he was using the patched function that I had posted here. Sent from my Samsung device Original message From: elextr Date: 26/01/2019 14:09 (GMT+07:00) To: geany/geany Cc: kenshail , Mention Subject: Re: [geany/geany

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2019-01-26 Thread elextr
@Haburaku as I said above, nobody has made a pull request with the code and the documentation of the modified behaviour. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/758#issuecomment-

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2019-01-25 Thread Haburaku
Ok, thanks for the clarification. I still think it is a usefull feature. Can the souce code be shared or pushed to git (or a branch if it can't be included in master). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https:

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2019-01-25 Thread elextr
@kenshail I definitely was not criticising you or implying that you should have done anything different, sorry if it sounded that way. Just intended to clarify for @Haburaku that the change has to be made locally, its not part of Geany. -- You are receiving this because you are subscribed to

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2019-01-25 Thread kenshail
I simply submitted it as a suggested patch because the discussion at that time seemed to suggest that some may not want search to work that way. On 2019-01-26 06:46, elextr wrote: > @Haburaku [1] to be clear, AFAIK nobody has made a pull request to add the > functionality to Geany, so it will n

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2019-01-25 Thread elextr
@Haburaku to be clear, AFAIK nobody has made a pull request to add the functionality to Geany, so it will not be in Geany git. @kenshail modified his own copy, not Geanys. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: htt

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2019-01-25 Thread kenshail
Did you recompile the modified source?  The change saves you having to close and re open the find dialog for a new find. You highlight the required text then click the search tab without closing the dialog. The required text will then appear in the dialog.This procedure  is similar to some

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2019-01-25 Thread Haburaku
@kenshail I have downloaded and installed version 1.34 (from your comment: "I have changed this on a local copy of 1.34 and it works fine") but the search item in the "Find" field is still not updated accordingly to the highlighted text. Do I have the right version or am I doing the wrong thing

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2019-01-25 Thread elextr
@kenshail about the crash on `help-> about` it should be fixed in git -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/758#issuecomment-457531514

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2019-01-25 Thread Haburaku
@kenshail I would really like to have this ctrl-f update function :-). Can you help me to get it working on Linux? In short, how (and where) do I change Search.c and compile it? Cheers, René -- You are receiving this because you are subscribed to this thread. Reply to this email directly o

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2018-04-08 Thread kenshail
I have changed this on a local copy of 1.34 and it works fine - just one function, search_show_find_dialog had to be changed in Search.c You can leave the search widget open and highlight the next text to find. It transfers to the widget when you click find again without having to close the wi

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2018-03-28 Thread elextr
@kenshail no, nobody contributed anything. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/758#issuecomment-377041313

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2018-03-28 Thread kenshail
Was anything ever implemented on this? I am still screaming every time that the open Find dialog does not update to the highlighted text when I click Find or Ctrl-F. Please someone call me a dumb-head for not finding the already implemented option. -- You are receiving this because you are su

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2016-10-24 Thread gmircea
Hi everyone, I'm also affected by this issue. Is anyone working on it ? @jgraley Do you have a status ? Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/758#issuecomment-25567

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2016-06-06 Thread elextr
@jgraley a well written pull request would be fine, so long as it has an option to continue the current behaviour there shouldn't be any problems. Don't forget to document it in the manual (unsubtle hint). --- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [Github-comments] [geany/geany] Find popup does not update with new highlighted text without closing and reopening it. (#758)

2016-06-06 Thread jgraley
Hi Guys This issue is affecting me too. consider the steps (from an earlier comment): 1. find something 2. do some editing, which may involve selecting Now at this point it's equally likely the user wants 3a. find again, still having the original find text available. or 3b. find the new thing jus