Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
Might be nice to review the [geany-themes](https://github.com/geany/geany-themes) to see if this could be useful. Maybe I'll do it some day... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-379135141
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
Updated for up-to-date-ness and to fix review comments. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-379072161
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
@mscdex IIUC all that would need is for the filetypes.common entry to refer to a name, so if this goes ahead that would be a minor later change. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-378504110
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
It'd be nice to be able to change the value from themes also. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-378489069
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
@b4n @codebrainz is this still happening and still wants a review, or is it abandoned? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-378486966
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
> @@ -4616,15 +4624,15 @@ marker_mark > *Example:* ``marker_mark=0x00;0xb8f4b8;false;false`` > > marker_translucency > -Translucency for the line marker (first argument) and the search marker > -(second argument). Values between 0 and 256 are accepted. > +Translucency for the line marker (first argument) and the mark marker the other documentation (on ^M, ^. and ^,) calls those "markers" only, and some other parts refers to them as "bookmarks". -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917/files/dcbbc2001c49d820ea871f9b686d985334dcdf93#r75585407
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
> @@ -4616,15 +4624,15 @@ marker_mark > *Example:* ``marker_mark=0x00;0xb8f4b8;false;false`` > > marker_translucency > -Translucency for the line marker (first argument) and the search marker > -(second argument). Values between 0 and 256 are accepted. > +Translucency for the line marker (first argument) and the mark marker it's `GCS_MARKER_MARK`, "user marker" may be slightly better? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917/files/dcbbc2001c49d820ea871f9b686d985334dcdf93#r75585353
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
Seems OK to me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-241224654
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
> > Only the first and second arguments are interpreted. > > -*Example:* ``marker_translucency=256;256;false;false`` > +*Example:* ``marker_translucency=255;255;false;false`` Same note here about showing needless `;false;false` in example. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917/files/dcbbc2001c49d820ea871f9b686d985334dcdf93#r75585035
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
> @@ -4616,15 +4624,15 @@ marker_mark > *Example:* ``marker_mark=0x00;0xb8f4b8;false;false`` > > marker_translucency > -Translucency for the line marker (first argument) and the search marker > -(second argument). Values between 0 and 256 are accepted. > +Translucency for the line marker (first argument) and the mark marker What's a "mark marker"? Is it the search indicator? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917/files/dcbbc2001c49d820ea871f9b686d985334dcdf93#r75585020
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
> > Only the first and second arguments are interpreted. > > -*Example:* ``translucency=256;256;false;false`` > +*Example:* ``translucency=255;255;false;false`` Maybe it could say "Only two arguments are interpreted" and then not show the `;false;false` in the example? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917/files/dcbbc2001c49d820ea871f9b686d985334dcdf93#r75584997
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
> > Note for Windows 95, 98 and ME users: > -keep this value at 256 to disable translucency otherwise Geany might > crash. > +keep this value at 255 to disable translucency otherwise Geany might > crash. We could probably remove this whole note since AFAIK we don't support anything older than Windows XP (if even that). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917/files/dcbbc2001c49d820ea871f9b686d985334dcdf93#r75584973
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
@codebrainz any objection to merging this? Ideally yeah all the key names should be improved, but well. Also, allowing themes to configure that would be nice too, but that also requires a little work. IMO this is good enough for the moment, and can be enhanced together with the existing stuff if someone cares enough. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-241213978
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
@mscdex How did you set the value? As said in the first message, this still isn't configurable in the theme AFAIK, but it works just fine though `filetypes.common`:  (using `marker_search_translucency=255;32` here) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-241213839
Re: [Github-comments] [geany/geany] Make search marker translucency configurable (#917)
Ok, so I got a chance to try this patch against v1.27.0. It seems like the problem still occurs and I've verified that my local install is using the correct libgeany (from `/usr/local/libgeany..` instead of `/usr/lib/libgeany...`). I've tried setting both `marker_search_translucency=0;0` and `marker_search_translucency=255;255` but the resulting translucency is the same after restarting geany. Changing other values in the theme like the `marker_search` color works just fine. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/917#issuecomment-215209374
