Re: [Github-comments] [geany/geany] Mark All - mistake (#1467)

2017-04-22 Thread bulkozavr
**@vfaronov** wow, I am don't know this feache too! Dude, thanks a lot! At this case nothing to fix, I agree. And I agree that documentation need to be more clear, at least for such users as me. Thank you all! The problem is solved. -- You are receiving this because you are subscribed to this t

Re: [Github-comments] [geany/geany] Mark All - mistake (#1467)

2017-04-22 Thread bulkozavr
Closed #1467. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1467#event-1053450071

Re: [Github-comments] [geany/geany] Mark All - mistake (#1467)

2017-04-20 Thread elextr
> Menu items should cover the most-used actions. Agree, but a function that does not exist in Geany is suddenly the "most used" ? :-S @vfaronov wow, didn't know that before!!! Indeed if NOTHING is selected when the keybinding is activated the word under the cursor and all occurrences of that

Re: [Github-comments] [geany/geany] Mark All - mistake (#1467)

2017-04-20 Thread Vasiliy Faronov
@bulkozavr and everyone: isn’t the problem solved simply by placing the cursor *on* `i` without *selecting* `i`? ![mark-word](https://cloud.githubusercontent.com/assets/300211/25223917/836ad5ae-25c5-11e7-9395-0474462911cc.png) I agree this behavior is not very obvious, and maybe it should be doc

Re: [Github-comments] [geany/geany] Mark All - mistake (#1467)

2017-04-20 Thread Thomas Martitz
What @codebrainz suggested, simply always match whole word. I.e. if a substring is selected, only mark whole words that match the substring. I disagree that yet another action is needed, since there is still the find dialog, that offers the current functionality as well. I don't want Geany's m

Re: [Github-comments] [geany/geany] Mark All - mistake (#1467)

2017-04-20 Thread elextr
@kugel- you mean if a whole word is not selected when the mark-all keybinding is selected it should expand the selection to a word and mark all occurrences of that? Does mean you can't use mark-all keybinding on anything but words. It should be an additional action, instead of removing the exis

Re: [Github-comments] [geany/geany] Mark All - mistake (#1467)

2017-04-20 Thread Thomas Martitz
> Yes, though that wouldn't be useful if a part of a word not a whole word had > not been selected. You could still use the find dialog if the default behavior of the keybinding doesn't fit. I don't think "Mark All" a with a non-word selection is major use case to justify more complexity, given

Re: [Github-comments] [geany/geany] Mark All - mistake (#1467)

2017-04-16 Thread elextr
> > Mark all activated from the keybinding ignores the settings in the find > > dialog. > If it ignores the settings from the dialog, it ought to do the most expected > thing, which would be to behave like similar feature in most editors (ie. > match whole word), IMO. Yes, though that wouldn't

Re: [Github-comments] [geany/geany] Mark All - mistake (#1467)

2017-04-16 Thread Matthew Brush
> Mark all activated from the keybinding ignores the settings in the find > dialog. If it ignores the settings from the dialog, it ought to do the most expected thing, which would be to behave like similar feature in most editors (ie. match whole word), IMO. -- You are receiving this because

Re: [Github-comments] [geany/geany] Mark All - mistake (#1467)

2017-04-16 Thread elextr
> > The "mark all" keybinding does not follow the options set in the find > > dialog box > but it makes the same as "Find -> Mark". Mark all activated from the find dialog obeys the options on the dialog, in particular "match whole word" and "match at start of word" which is what you want to h

Re: [Github-comments] [geany/geany] Mark All - mistake (#1467)

2017-04-16 Thread bulkozavr
I don't understand you at all. > The "mark all" keybinding does not follow the options set in the find dialog > box but it makes the same as "Find -> Mark". > The options for the "mark all" keybinding could be set in the preferences > dialog separate from the search dialog. Really? How to do

Re: [Github-comments] [geany/geany] Mark All - mistake (#1467)

2017-04-15 Thread elextr
This is not a bug. As @codebrainz said, the mark all function is a text match function, it operates the same as the equivalent functionality in applications such as firefox or chrome. This default behaviour should not change (at least without the user changing settings). The "mark all" keybin

Re: [Github-comments] [geany/geany] Mark All - mistake (#1467)

2017-04-15 Thread Matthew Brush
It definitively seems like a bug, but I don't think it is. "Mark All" is a search feature (see Search->Find->Mark All), it follows the given GUI search options, so I don't think we can really hardcode them, although for this particular case it does seem to make some sense. -- You are receiving