> Does Geany still support GTK2?
Yes
> If so should I use an #ifdef ?
Yes
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1762#issuecomment-364080543
The GTKFlowBox seems like a nice solution.
Does Geany still support GTK2?
If so should I use an #ifdef ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1762#issuecomment-364074490
@shiftee pushed 1 commit.
46cffb5 Restore setting transient parent for replace dialog
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/geany/geany/pull/1762/files/c9821fe6dcbd589bc1fc7f52000d886e922d6ea6..46cffb50cb138ea784294504fe1608b
The first change seems fine from the image. It seems good to not force a
minimum size unless truly needed (or something really small), and the default
size of the dialog needn't/shouldn't change.
For the other stuff, perhaps it could be made more responsive so that once the
dialog gets too smal
codebrainz commented on this pull request.
> GtkSizeGroup *label_size;
- replace_dlg.dialog = gtk_dialog_new_with_buttons(_("Replace"),
- GTK_WINDOW(main_widgets.window), GTK_DIALOG_DESTROY_WITH_PARENT,
- GTK_STOCK_CLOSE, GTK_RESPONSE_CANCEL, NULL);
+
Removing setting the entry widths to fixed numbers of characters seems ok
(commit 1).
But I do not like the look of the other two, having labels above the entry is
different to every other dialog in Geany and every other replace dialog in
editors I have on this machine. I also don't like the r
