Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

Thanks for the heads up and review! > To be honest if this works well I don't know why we need the other 2 options > besides Show Tree. Once I used "show tree" I never went back to the other methods. It's really great IMO, especially since it allows to easily close all files within a directory

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel- pushed 1 commit. f15336e0ef057947ba6d1d74d78d7d87952b8e06 typo and doc fixes -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/1813/files/1d28d2a7833c7a858ab4c00aed345d3d8c1abbb3..f15336e0ef057947ba6d1d74d78d7d87

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

ntrel commented on this pull request. Haven't tested, but the idea seems great. (To be honest if this works well I don't know why we need the other 2 options besides *Show Tree*). I've reviewed the doc changes and made suggestions, not a blocker. If I have time maybe I'll fix those. > @@ -530,

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

ntrel commented on this pull request. > + return i; +} + + +typedef struct TreeForeachData { + gchar *needle; + gsize best_len; + gsize needle_len; + GtkTreeIter best_iter; + enum { + TREE_CASE_NONE, + TREE_CASE_EQUALS, +

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@b4n your review is still pending. Please have a look again. I would like to merge this early in the cycle. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-538851090

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@b4n @elextr @codebrainz please test and/or review, thanks :-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-524747635

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@b4n @elextr please test and/or review, thanks :-) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-520862649

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel- I no longer use geany all day every day, so it might be a delay before I can test it, hopefully not too long. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-5185

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@elextr ping :-) @b4n hopefully I adressed the review comments and didn't forget one. Please test and review. PS: I merged 1.35 to be up-to-date. I plan to rebase and consolidate a bit before merging (but no complete squash). -- You are receiving this because you are subscribed to this thread.

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel- pushed 5 commits. 17d06db1ac63277581fdb71c17b66cd8e3aa799b Merge tag '1.35.0' into rpg-sidebar-tree-fixed ef6d6817e1214bd098d000850ed906ac3f41dcdf sidebar: resolve some review comments 15582e2a440220607e80449162e51b810fbf3252 sidebar: fix for new documents being added unfolded when tr

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel- good to see you get some time, ping when you think its testable. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-517636410

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

kugel- commented on this pull request. > @@ -1100,7 +1412,7 @@ void sidebar_init(void) StashGroup *group; group = stash_group_new(PACKAGE); - stash_group_add_boolean(group, &documents_show_paths, "documents_show_paths", TRUE); + stash_group_add_integer(group, (gint

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

kugel- commented on this pull request. > + } + case TREE_CASE_PARENT_OF: + { + /* More complicated logic. This dir should be a parent +* of existing, so reparent existing dir. */ + has_pa

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

kugel- commented on this pull request. > +/* + * Recursively copy all nodes from old parent to new parent + * */ +static void tree_copy_recursive(GtkTreeIter *parent_old, GtkTreeIter *parent_new) +{ + gint i; + GtkTreeIter child; + GtkTreeIter parent; + GtkTreePath *path

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

kugel- commented on this pull request. > + break; + } + case TREE_CASE_CHLID_OF: + { + /* This dir is longer than existing so just add child */ + tree_add_new_dir(parent, &data.best_iter, pa

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

kugel- commented on this pull request. > + break; + } + case TREE_CASE_CHLID_OF: + { + /* This dir is longer than existing so just add child */ + tree_add_new_dir(parent, &data.best_iter, pa

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

Trying to finish this up...I could locate and fix the unfold bug and I'm currently work through the other review comments. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

kugel- commented on this pull request. > +} + + +/* + * Recursively copy all nodes from old parent to new parent + * */ +static void tree_copy_recursive(GtkTreeIter *parent_old, GtkTreeIter *parent_new) +{ + gint i; + GtkTreeIter child; + GtkTreeIter parent; + GtkTreePat

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

kugel- commented on this pull request. > + tree_copy_recursive(&data.best_iter, &parent_buf); + unfold_iter(&parent_buf); + gtk_tree_store_remove(store_openfiles, &data.best_iter); + tree_add_new_dir(parent, &p

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

kugel- commented on this pull request. > + GtkTreePath *path; + GtkTreeModel *model = GTK_TREE_MODEL(store_openfiles); + + path = gtk_tree_model_get_path(model, parent_old); + gtk_tree_path_free(path); + tree_copy_item(&parent, parent_old, parent_new); + i = gtk

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

> Also, keeping fold state when changing mode is something the app will likely > have to do Especially so in the cases where a buffer close changes the visible hierarchy in one of the "smart" modes, thats really something that only Geany can do, not GTK. -- You are receiving this because you

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@scriptum Yes, GTK doesn't maintain tree view fold state below folded elements for you. However, that doesn't mean elements get folded seemingly randomly :) The issue I mentioned is not that folding an element and unfolding it doesn't restore children's fold state, but that for some reason when

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

> @scriptum did you give it a try? I tested forked Geany 4 or 3 years ago with this patch. But I didn't tested it on latest Geany versions. I remember a fold state issue but it is probably common for all GTK applications - GTK doesn't remember children fold state unlike Qt. This feature was pl

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

For some reason I wasn't notified about your updates. I was still thinking review is ongoing. Given the bugs that appeared I agree to post-pone. Thanks for finally testing this -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

I also get all the tree folding up when right clicking. To be clear, this is unacceptable, I can't close a file without losing my fold state. This should be merged as is. This PR has a history of more bugs being found each time its "ready" probably because @kugel- has only had the chance to

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

Bug: when I open Geany after this change, so with the default setting: if I right-click on the documents sidebar, every element gets folded. Yeah, even before I click on any action. More generally fold state seems pretty random when switching between modes. -- You are receiving this because yo

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

b4n requested changes on this pull request. First pass looking at the code. Not tested yet, but the feature looks pretty cool indeed :) > - if (!documents_show_paths) - return NULL; + path = gtk_tree_model_get_path(GTK_TREE_MODEL(store_openfiles), iter); + gtk_

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel- I'm in the process of reviewing the code, but I might not have a lot of time before Friday. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-440438760

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@elextr @b4n I really want this in the release so please give it a last look / test or an OK for me to merge it. String freeze is soon. Please! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/p

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@scriptum did you give it a try? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-439165856

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

Has anyone (apart from @kugel-) tested this yet? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-438177747

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@elextr ping -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-422041192

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@elextr I'm sorry. I found that I have forgotten to publish one more commit I made. Please review this one, though I hope it's welcome one since it simplifies things. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel- pushed 1 commit. 7b10e1e sidebar: simplify code by handling projects and home directory equally -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/1813/files/61256572da06a5ca023a0b2f782e2ae8b7f8f830..7b10e1e06500a

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel- I'm fine for you to merge it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-407214891

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@elextr is your approval still valid even after my changes? I'd like to merge this finally. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-407131820

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

I amended the commit message of 7552d5f due to typos. There are no code changes, except the three new commits on top of @elextr change. @elextr Upon looking at the code handling the home directory, I think the intention was to match your first case, and it was a bit buggy. Since I think this i

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel- various daemons and databases run under other users and have their config files in that home dir as another use-case. But even if we can't think of a use-case, if its at all possible, _somebody_ __will__ do it :smile: -- You are receiving this because you are subscribed to this thread

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

I think the second. However, upon trying I found there is a crash (but only when there are open files of another user AND a file located in ~ itself). I'll dig into it. On a side note, having a file of another user open seems unlikely, as Geany is a poor program for pair programming :-) -- Yo

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

changed which @kugel- :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-380346281

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel, erm, ok, what happens if there are two directories open along the path to `~` eg if HOME is `/file_server/home/this_user` and I have the files `/file_server/home/this_user/my_file.cpp`, `/file_server/home/this_user/a_dir/also_mine.cpp` and `/file_servert/home/another_user/their_file.cpp

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@elextr Actually, the home directory is merely abbreviated (using ~), it doesn't get an individual root node unlike the project base path. See the doc/sidebar_show_tree.png -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: ht

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

I get the following warning when building the manual: ``` [WARNING] image.py:463 image /home/kugel/dev/geany.git/doc/./images/sidebar_documents_only.png is too tall for the frame, rescaling [WARNING] image.py:463 image /home/kugel/dev/geany.git/doc/./images/sidebar_documents_only.png is too tal

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

elextr approved this pull request. LGTM -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#pullrequestreview-110364788

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel- pushed 1 commit. 5c79661 improve manual text for the document listing methods in the sidebar -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/geany/geany/pull/1813/files/3ca8921a8b2b925a41c07a5541c6b36dd63491a0..5c796614e0149100

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

Works for me, thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-379639860

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel- I still can't do anything with github, so I have posted my suggested text below. ``` Document list views ^^^ There are three different ways to display documents on the sidebar if *Show documents list* is active. To switch between views press the right mouse button on docu

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

Correct -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-378513491

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

> This proves that I'm not good at documenting such things for end users :-) Thats ok, thats why I'm asking all these annoying questions :-) I think the confusion is that I understood that the difference between this option and the existing option was that all directories on the path to open f

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

This proves that I'm not good at documenting such things for end users :-) There is additional confusion since your example has two foo folders and the project is named foo as well. I'll rename to illustrate: ``` /data -- the raid array mount point foo bar -- the git tree and the pro

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

Yes, above I said: > But on looking at the above example again. > > No, all open files are tree'ified. > But in your additional example you have shown foo/dev_build as not being > expanded the way foo/src is? I had previously asked if only the project tree was expanded and you said no as quot

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@elextr do you need more information on how it's supposed to work? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-378340732

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

> Might be easier if you just try the patch and see yourself, Github/mail kind > of sucks for showing examples. Two things: 1. I said above I can't try it ATM 2. guessing how its meant to work from experiments is a poor way of getting an explanation for users -- You are receiving this becaus

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

> But in your additional example you have shown foo/dev_build as not being > expanded the way foo/src is? foo/dev_build is one tree node because no file in foo itself is open. foo->src is two tree nodes because foo represents the project (therefore always gets its own top-level node) and src is

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel- yep, will propose something as soon as I'm happy I understand :) But on looking at the above example again. > No, all open files are tree'ified. But in your additional example you have shown `foo/dev_build` as not being expanded the way `foo/src` is? -- You are receiving this because

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

Please suggest a better description, I'm not so good at this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-376485752

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

> all open files are tree'ified. Its just that once a project is open it is > ensured that its base path gets its own tree node (labeled after the project) Oh, ok, thats sort of unexpected, so it needs to be explained more clearly (if only so we can close issues and point people to the manual th

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

>Oh, ok, so if I read that right only the project base dir and below >shows as a tree? No, all open files are tree'ified. Its just that once a project is open it is ensured that its base path gets its own tree node (labeled after the project) > >Maybe the selection should be called "Show Proje

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

hehe its fine, i get these every once in a while, just wanted to make sure the real kugel gets your message, eve if he stole my nickname =D On Tue, Mar 27, 2018 at 2:19 AM, elextr wrote: > @Kugel sorry, I meant @kugel- > but your user comes

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel sorry, I meant @kugel- but your user comes up first on the autocomplete, and hey us humans make mistakes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-376410113

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

hey sorry to dissapoint, I dont know how my email got linked to this project but the Kugel you are looking for doesnt use this email (ive been getting random updates from github every once in a while for years), sorry =( but hey i hope you guys work out those bugs and keep plugging away at it! On

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

elextr commented on this pull request. > + +.. image:: ./images/sidebar_documents_only.png + +Show Paths +Show opened documents as two-level tree in which first level is a full +directory path to document and second level is a file name. + +.. image:: ./images/sidebar_show_paths.

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

kugel- commented on this pull request. > + +.. image:: ./images/sidebar_documents_only.png + +Show Paths +Show opened documents as two-level tree in which first level is a full +directory path to document and second level is a file name. + +.. image:: ./images/sidebar_show_paths.

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@kugel thanks for making a testable version of #259, reviewed but unfortunately I can't test ATM, maybe someone else will test in the meantime. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/p

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

elextr requested changes on this pull request. Code was reviewed too, but I couldn't find anything to complain about!!! :) > + +.. image:: ./images/sidebar_documents_only.png + +Show Paths +Show opened documents as two-level tree in which first level is a full +directory path to docum

Re: [Github-comments] [geany/geany] Rpg sidebar tree (see #259) (#1813)

@codebrainz too -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1813#issuecomment-374653014