Re: [Github-comments] [geany/geany] bash may not found in the system. replace to /bin/sh (#1574)

2017-08-07 Thread elextr
Merged #1574. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1574#event-1196534472

Re: [Github-comments] [geany/geany] bash may not found in the system. replace to /bin/sh (#1574)

2017-08-07 Thread Colomban Wendling
b4n approved this pull request. Looks reasonable and I can't see any bashisms in there indeed (makes me wonder why I made it a Bash script in the first place, I guess the script probably grew out of it). And anyway if Travis, you guys and me test it OK, it should be safe. -- You are

Re: [Github-comments] [geany/geany] bash may not found in the system. replace to /bin/sh (#1574)

2017-08-05 Thread Matthew Brush
Works for me in Ubuntu, and script runs with GNU bash with `--posix` too. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1574#issuecomment-320453362

Re: [Github-comments] [geany/geany] bash may not found in the system. replace to /bin/sh (#1574)

2017-08-05 Thread kloun
no bashisms. me@gentoo ~ $ checkbashisms runner.sh me@gentoo ~ $ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/1574#issuecomment-320452537

Re: [Github-comments] [geany/geany] bash may not found in the system. replace to /bin/sh (#1574)

2017-08-05 Thread Matthew Brush
@kloun would you be able to run the script through [checkbashisms](http://openports.se/sysutils/checkbashisms) to verify that it doesn't contain any Bash-specific features? I think on some Linuxes `/bin/sh` refers to Bash/Dash in some kind of POSIX compatibility mode, needs testing there too.